Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-16
20:27:45 aspiers oh, looks like I screwed it up
20:31:48 openstackgerrit James E. Blair proposed openstack/nova master: WIP: sphinx latex build tests https://review.opendev.org/677028
20:33:14 efried okay
20:44:04 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
20:44:21 efried dustinc, mordred: Okay, donnyd set up us the cloud, and I've got it configured to reproduce the failure
20:44:21 efried ...which afaict is, we're talking to ironic okay, but for some reason the node.list is coming back with 0 nodes.
20:44:34 efried so dustinc this might be where you need to jump in and debug.
20:49:17 openstackgerrit Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964
20:49:18 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
20:54:03 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
20:54:29 aspiers efried: what's the world record for the most patchsets in a nova review? :-o
20:54:40 aspiers am I even close yet?
20:54:58 aspiers seems like a very dubious achievement
20:55:16 efried you are nowhere close.
20:55:20 efried Well into three figures
20:55:22 aspiers hah, phew
20:55:24 aspiers wow
21:12:15 openstackgerrit Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964
21:12:15 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
21:14:36 aspiers Damn, I intended to not work at all today, and here I am still going ... time for late dinner
21:14:49 aspiers Just desperate to get this damn series all to +2
21:16:56 efried aspiers: https://review.opendev.org/#/c/676964/3/nova/tests/functional/libvirt/test_report_cpu_traits.py show me where STUB_INIT_HOST is being used?
21:19:36 aspiers efried: ah sorry, it *is* in the next patch
21:19:54 efried It's not worth respinning stuff for, just want to make sure I'm not blind.
21:19:59 aspiers yeah
21:20:07 efried (I got glasses day before yesterday, for the first time in my life)
21:20:09 aspiers I ran my grep with the wrong commit checked out
21:20:22 aspiers hah, welcome to nerd club
21:20:28 aspiers I've been in it since I was 14 :-(
21:20:42 aspiers well, since I was born I suppose
21:27:31 aspiers OK, dinner
21:27:37 aspiers thanks and catch you next week! o/
21:27:51 efried mordred, dustinc: I found the bug
21:28:20 efried It looks like you can only run through the generator returned by conn.baremetal.nodes() once.
21:29:41 efried which, now that I think about it, makes sense.
21:29:57 efried I mean, now that I've seen this thing in action and think about it.
21:30:21 efried Because having done that I learned 1) that it's a generator, and 2) that it doesn't actually do anything, like go out over the wire, until you start iterating over it.
21:31:25 efried dustinc: Ima fix that up in the node.list patch (and rebase the rest on top, cause they definitely won't work without that) and let's see where we get to.
21:31:36 efried (that will probably break UT; but I'll leave you to fix that :P )
21:33:39 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
21:33:40 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
21:33:40 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
21:33:41 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
21:33:41 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
21:33:51 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Test sdk Connection(strict_proxies) https://review.opendev.org/676926
21:34:38 efried I... don't actually know whether strict_proxies is gold here. But that last patch ^ ought to tell us.
21:42:49 efried Thanks for your help donnyd
22:04:49 donnyd glad I can be helpful efried
22:36:45 openstackgerrit Eric Fried proposed openstack/nova master: Limit get_sdk_adapter to requested service type https://review.opendev.org/674678
#openstack-nova - 2019-08-17
00:27:48 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
01:01:39 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
02:04:25 alex_xu efried: yea, I added that to my todo list, will try to reach it asap
08:16:57 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
09:57:16 openstackgerrit ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298
09:57:16 openstackgerrit ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299
09:57:17 openstackgerrit ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300
23:39:52 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
23:39:53 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
23:39:53 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
23:39:54 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
23:39:54 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
23:39:55 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
#openstack-nova - 2019-08-18
16:08:30 prometheanfire new version of websockify breaks nova, see my comment here https://review.opendev.org/677052
16:08:48 prometheanfire also lxml
#openstack-nova - 2019-08-19
01:56:16 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix wrong assertions in unit tests https://review.opendev.org/677102
03:00:41 openstackgerrit Boxiang Zhu proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/621646
03:01:01 openstackgerrit ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298
03:01:01 openstackgerrit ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299
03:01:02 openstackgerrit ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300
05:36:58 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
07:34:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix 'has_calls' method calls in unit tests https://review.opendev.org/676536
07:34:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix wrong assertions in unit tests https://review.opendev.org/677102
07:51:10 openstackgerrit Vieri proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908
08:22:57 openstackgerrit Ghanshyam Mann proposed openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes https://review.opendev.org/676275
09:17:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: Tests: autospecs all the mock.patch usages https://review.opendev.org/470775
09:36:44 aspiers o/
09:36:47 aspiers anyone around?
09:36:56 aspiers I just had an idea
09:37:59 aspiers Could write a script a bit like tools/flake8wrap.sh -HEAD, but specifically for running tests
09:38:29 aspiers Actually, I could just write a Guardfile
09:38:36 aspiers Can't quite believe I didn't think of that before
09:39:10 aspiers Ah, Python has watchdog
10:08:36 bhagyashris stephenfin: Hi, I saw you have send mail on mailing list #link http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008501.html ... So what will be the exact plan for upgrade ... actually I was working on functional test part
10:09:48 stephenfin bhagyashris: I'm still trying to decide
10:09:59 stephenfin But I _think_ I'm going to go with the global config option
10:10:23 stephenfin Something like 'pcpus_in_placement' that will default to False in Train and True in U
10:10:43 stephenfin That'll be set on both the compute node and controller
10:11:13 stephenfin Once you've upgraded everything to Train, you'll toggle the config option on the controller, followed by the config options on the compute node
10:13:35 bhagyashris Okay and then that will translate the flavor extra specs at controller node and will report the PCPU inventory at placement side .... Right?
10:13:44 stephenfin once toggled, yes
10:13:49 stephenfin and do the reshape
10:14:19 stephenfin Until it's toggled though, the compute nodes will not report PCPUs, the extra specs will not be translated, and the reshape will not occur
10:18:09 bhagyashris And if the global config option set is false that means not toggle and user defines the cpu_dedicated_set then in that case what will happen?
10:18:28 stephenfin We error out
10:19:42 bhagyashris stephenfin: means 'pcpus_in_placement' and the cpu config options should be set properly by operator
10:20:06 stephenfin Well, by the deployment tool they're using
10:20:24 stephenfin Actuallly
10:20:37 stephenfin We don't necessarily need to set 'pcpus_in_placement'
10:20:45 stephenfin ...on the compute nodes
10:21:23 stephenfin We could just say "set 'pcpus_in_placement'" on the controller, and then set 'cpu_dedicated_set' and 'cpu_shared_set' on the compute nodes

Earlier   Later