Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-15
14:44:33 tssurya that means we block the rest of the events in the queue no ?
14:44:42 tssurya because one volume-extend event broke ?
14:44:50 tssurya and you raise
14:45:02 mriedem we wouldn't get a volume-extended and power-update event in the same request
14:45:10 mriedem unless someone sends that manually
14:45:34 mriedem there might be a bug in the volume-extended event handling in compute that's not handling that properly, but that's a separate bug
14:45:50 tssurya mriedem: got it
14:46:51 mriedem tssurya: how much longer are you going to be around today?
14:46:54 tssurya mriedem: do you have a sample functional test that you have written for such races
14:46:56 tssurya ?
14:47:13 tssurya I couldn't find a way to hack the task_state in between my code
14:47:16 tssurya for the functional teste
14:47:35 tssurya mriedem: i'll be around only for 2 more hours
14:47:36 mriedem you'd have to stub/mock something in between to change the task_state after the compute manager sets it and the driver code gets it
14:47:50 mriedem i'm not sure we need the functional test to cover that though
14:48:04 mriedem that's pretty unit-y test level to me
14:48:10 tssurya but its ok, I'll be online and if you have comments will update them during vacation
14:48:45 tssurya mriedem: ok then I'll just do a unit test
14:49:16 dansmith yep, unit test makes sense to me
14:49:23 dansmith just to make sure we catch it and do the right thing
14:49:51 tssurya dansmith: yea I'll do that
14:51:19 mriedem tssurya: but i won't be around to review the updates until monday... and people are held up on this microversion, so i'll review it in detail now before you make another push
14:52:08 tssurya mriedem: ok sounds good
14:52:46 tssurya even if I am on vacation I do intend to work on this patch to get it in, so I hope to not block everyone
14:53:08 tssurya s/not block/unblock soon
14:55:36 atmark hello, I have mix setup of local disk computes and rbd backed computes. In nova.conf of local disk computes, I have images_type=raw and in the rbd backed compute image_type=rbd. I can spin up VMs fine in both setup however the when RESIZE a local disk VM, I get 'boot failed: not a bootable disk' from the VM's console
14:56:26 atmark resizing a RBD VM works. Resizing local disk VMs fails
15:12:56 mriedem tssurya: doesn't test_external_instance_event_power_update_unexpected_task_state already cover the race you were asking about testing?
15:13:15 tssurya mriedem: yes
15:13:23 tssurya that's the unit test I have
15:13:30 mriedem then we don't need a functional test wrinkle for that
15:13:37 tssurya I didn't have a functional test hence asked
15:13:39 tssurya ah ok
15:13:42 tssurya cool
15:14:57 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879
15:18:15 mriedem tssurya: dansmith: comments posted https://review.opendev.org/#/c/645611/
15:18:24 tssurya thanks
15:20:20 mriedem if you run out of time, post what you have and i'll fix the rest and +2
15:39:08 openstackgerrit Eric Fried proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
15:39:09 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
15:39:09 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
15:39:10 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
15:39:10 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
15:39:11 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
15:39:26 efried dustinc: Rebased and with requirements bump to sdk 0.34.0 ^
15:39:48 dustinc thanks
15:39:49 efried that should fix `fields`. I'm hoping it also fixes the remaining patches
15:40:00 dustinc 🤞
15:40:03 efried cause I also added a dep to the devstack patch
15:40:05 efried hmm
15:40:20 efried Will the second patch still observe the dep from the first?
15:42:09 mriedem yes
15:44:21 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Limit get_sdk_adapter to requested service type https://review.opendev.org/674678
15:45:09 efried cool
15:48:20 mriedem i guess forbidden aggregates is never getting out of a runway slot
15:51:17 mriedem sean-k-mooney: if you can get a new patch set for https://review.opendev.org/#/c/671338/ today it would be good as well, since it was pretty close
15:51:45 openstackgerrit Mohammed Naser proposed openstack/nova master: config: remove deprecated checksum options https://review.opendev.org/676539
15:51:46 openstackgerrit Mohammed Naser proposed openstack/nova master: Remove nova.image.download.modules extension point https://review.opendev.org/676540
15:51:46 openstackgerrit Mohammed Naser proposed openstack/nova master: requirements: move to using psycopg2-binary https://review.opendev.org/676684
15:52:05 sean-k-mooney ok i was doing som sriov testing but ill priorities that and get it updated today
15:52:27 sean-k-mooney mriedem: ill ping you when its done
15:53:51 openstackgerrit Mohammed Naser proposed openstack/nova master: constraints: bump psycopg2 to 2.8 https://review.opendev.org/676725
15:54:13 mriedem brinzhang: i'm going to move https://blueprints.launchpad.net/nova/+spec/support-specifying-az-when-restore-shelved-server into the open runway slot though you'll likely have to rebase it again once 2.76 is taken by the power-update change
15:59:30 melwitt tssurya: what do you think about multi-cell archive deleted rows skipping disabled cells? or would you rather expect it to try each cell and move on if can't connect instead
15:59:52 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Mock libvirt'y things globally https://review.opendev.org/676727
16:00:04 tssurya melwitt: you mean down cells ?
16:00:17 tssurya disabled cells should be archived without distinction
16:00:17 mriedem disabled
16:00:36 mriedem wouldn't one want to disable a cell if it's down?
16:00:44 mriedem so the scheduler doesn't try to pull computes from it and timeout?
16:01:04 tssurya yea but its only a workaround for scheduling right ?
16:01:14 tssurya people could also have disabled the cells since its new
16:01:19 melwitt tssurya: ok. that's kinda what I was thinking, not to assume because disabled to skip. because otherwise you (operator) would have to enable any disabled cells in order to archive and I thought maybe that would be annoying
16:01:21 tssurya not necessarily down
16:01:33 mriedem melwitt: well, you could just archive them directly
16:01:37 mriedem like you do today
16:01:46 mriedem anyway, it was a question - feel free to ignore it until it's a problem
16:01:49 tssurya melwitt: right yea
16:02:30 melwitt ok, just wanted to take the opportunity to ask tssurya since I saw her around
16:03:12 mriedem could add a --skip-disabled later if people want that
16:03:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
16:03:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Follow up for I491eb7abe1405b27c552cdef142c688a46e914f2 https://review.opendev.org/675589
16:03:15 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729
16:03:24 melwitt aye
16:03:57 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Add functional regression recreate test for bug 1839560 https://review.opendev.org/676507
16:03:57 openstack bug 1839560 in OpenStack Compute (nova) stein "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem)
16:03:57 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Restore soft-deleted compute node with same uuid https://review.opendev.org/676509
16:04:05 mriedem mnaser: ^ functional test should be fixed now
16:06:52 stephenfin mriedem, efried: When you've a chance, could you look at my two TODOs here to make sure I'm understanding what placement is doing correctly? (it's for the VCPU -> PCPU reshape) https://review.opendev.org/#/c/674895/8/nova/virt/libvirt/driver.py@7373 https://review.opendev.org/#/c/674895/8/nova/virt/libvirt/driver.py@7389
16:07:08 openstackgerrit Akihiro Motoki proposed openstack/nova master: DNM: WIP: PDF documentation build https://review.opendev.org/676730
16:09:37 openstackgerrit Merged openstack/nova stable/queens: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676291
16:11:24 efried stephenfin: It is true that *today* the compute node provider is the only provider of *CPU resources. So adding new code with that assumption ingrained is safe, but adds to the tech debt we have to pay off when we model NUMA nodes.
16:11:54 stephenfin efried: Is that a fair assumption for the reshape operation though
16:11:58 stephenfin ?
16:12:40 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.76: Add 'power-update' external event https://review.opendev.org/645611
16:12:42 stephenfin Given that in order to get a NUMA topology, we'd have to had reshaped first
16:13:09 efried stephenfin: What's the upgrade path? Would there be a way to FFU past Train and straight into U?
16:13:15 efried How are we enforcing the order of different reshapes?
16:13:21 efried Because that's what we're talking about here.
16:13:29 tssurya mriedem, dansmith: ^ thanks for all the help

Earlier   Later