Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-12
05:02:21 openstackgerrit Luyao Zhong proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398
05:02:21 openstackgerrit Luyao Zhong proposed openstack/nova master: Add functional tests for resize with VGPU https://review.opendev.org/675106
05:02:22 openstackgerrit Luyao Zhong proposed openstack/nova master: Indroduce new LibvirtConfigGuestPMEM https://review.opendev.org/672956
05:02:22 openstackgerrit Luyao Zhong proposed openstack/nova master: Populates existing pmems in libvirt device manager https://review.opendev.org/672957
05:02:23 openstackgerrit Luyao Zhong proposed openstack/nova master: Report pmem namespaces resources by provider tree https://review.opendev.org/634551
05:02:23 openstackgerrit Luyao Zhong proposed openstack/nova master: Support instance creation and resize with pmems https://review.opendev.org/672958
05:02:24 openstackgerrit Luyao Zhong proposed openstack/nova master: Add functional tests for persistent memory https://review.opendev.org/675592
07:17:35 lennyb stephenfin: Hi, please review #https://review.opendev.org/#/c/675776/ revert that broke MacVtap.
07:40:42 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support re-configure deleted_on_termination in server https://review.opendev.org/580336
10:38:55 sean-k-mooney /away
10:41:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
10:43:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
10:45:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
10:47:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
10:49:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113
10:51:16 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
11:13:51 sean-k-mooney stephenfin: im going to move the validate_trait function form https://review.opendev.org/#/c/665775/10 into the first patch https://review.opendev.org/#/c/666914/6 and cache it. once its cached i can then vaildate the traits more libarlly as i am creating them.
11:14:05 sean-k-mooney what should be the behavior for invalid traits
11:14:26 sean-k-mooney skip them and log a warning or something else
11:21:43 openstackgerrit Luyao Zhong proposed openstack/nova master: Add functional tests for persistent memory https://review.opendev.org/675592
11:37:23 cooldharma06 hi all is nova rebuild option support uerdata.?
11:40:24 sean-k-mooney cooldharma06: i cant recall if we added support for that or ssh keys recently but it support one fo the two
11:41:15 sean-k-mooney cooldharma06: it support both on master https://docs.openstack.org/api-ref/compute/?expanded=rebuild-server-rebuild-action-detail#rebuild-server-rebuild-action
11:41:37 sean-k-mooney New in version 2.57
11:45:26 cooldharma06 sean-k-mooney: https://review.opendev.org/#/c/431052/ in this commit they mentioned like it will be added later
11:46:18 cooldharma06 i need to add some extra routes during nova rebuild so i thought i can acheive using rebuild
11:46:20 sean-k-mooney that is a spec from pike i think we implemented it seperatly
11:48:26 cooldharma06 ok thank you. In nova rebuild cli is there any explicit parameter or i need to pass userdata in some other form.?
11:49:52 sean-k-mooney key pairs was added with https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/rebuild-keypair-reset.html in queens i dont see a spec for user data but sicne it was added in a later micro version it was added in or after queens
11:51:49 cooldharma06 sean-k-mooney oops i am using pike in my environment
11:52:16 sean-k-mooney on master you can do nova rebuild --os-compute-api-version '2.57' --user-data <data in base64>
11:52:31 sean-k-mooney pike does not have support for this sorry
11:52:53 sean-k-mooney cooldharma06: normally you would add routes via neutron
11:52:58 sean-k-mooney not via userdata
11:53:12 sean-k-mooney you would update teh subnet with addtional routes
11:53:22 sean-k-mooney and they will be served via dhcp
11:58:27 cooldharma06 actually i want to add route to only to that particular exiting machine
11:58:45 cooldharma06 so i thought to try with rebuild option with extra routes
11:59:37 sean-k-mooney a post boot ansible sricpt/ssh is proably a better option.
12:00:55 cooldharma06 post boot will work i think.. thank you i ll try this one
12:01:35 cooldharma06 thanks for your time and info.. :)
12:23:08 openstackgerrit Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110
12:25:05 openstackgerrit Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111
12:27:03 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
12:28:58 openstackgerrit Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
12:30:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
12:30:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
12:34:43 openstackgerrit Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
12:36:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113
12:36:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
12:50:52 openstackgerrit Eric Fried proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
12:55:47 openstackgerrit Merged openstack/nova master: Cache host to cell mapping in HostManager https://review.opendev.org/663388
12:55:55 openstackgerrit Merged openstack/nova master: Update comments in HostManager._get_instance_info https://review.opendev.org/674929
13:29:11 stephenfin sean-k-mooney:
13:29:20 stephenfin sean-k-mooney: I think we just skip them?
13:29:49 sean-k-mooney ok
13:29:59 stephenfin The alternative is to hardcode a mapping of vif types to traits, but maybe that's needlessly complex?
13:30:10 stephenfin Or we can just add a unit test to validate things
13:30:23 sean-k-mooney well i am validating them
13:30:26 sean-k-mooney just later
13:30:39 sean-k-mooney when i am doing the actual update
13:30:59 sean-k-mooney sorry im validating them in the filter
13:31:06 sean-k-mooney not in the dirver
13:31:26 stephenfin Oh, if they're already validated somewhere then it doesn't matter
13:31:27 sean-k-mooney anyway ill skip them and log a warning
13:31:40 sean-k-mooney i should filter them out in the driver
13:32:08 sean-k-mooney but i want to cache the validation function as its not that cheap and i dont want to pay the cost on every request/update
13:32:53 sean-k-mooney it would also be nice to be able to add new vif_models without needing ot update placement first
13:33:50 sean-k-mooney i should still poing out however the validation only ensure that the version of placemetn install in the nova compute node thinks its valid not that the plamcent service thinks its valid
13:35:11 sean-k-mooney we really dont want to be making restcall to placemetn to validate it direclty
13:35:32 sean-k-mooney that would be more expesive then the current validation
13:38:07 mriedem lyarwood: can you hit this queens backport https://review.opendev.org/#/c/659247/ and then we can release queens
13:38:34 alex_xu efried: dansmith, good morning, I updated the vpmem spec https://review.opendev.org/675024
13:39:23 efried noted
13:39:53 sean-k-mooney oh disabling limit for affinity. i remember talking about that at the ptg
13:40:22 lyarwood mriedem: ack done
13:42:00 sean-k-mooney lyarwood: actully we had a customer issue related to no valid host with anti-affinity that coudl be releated too that? although have said that i dont think we set a limmit so the defualt would be 1000 and then had like 50 host so proably not
13:42:38 sean-k-mooney that would be good for larger deployment in anycase.
13:43:11 lyarwood sean-k-mooney: I can't recall it if we did
13:43:58 sean-k-mooney dhill was handeling it but i tink we concluded they were just running out of space.
13:44:30 sean-k-mooney e.g. the only host that still had enough capsaity were the host the anti afinity filter elminated
13:45:31 sean-k-mooney i dont think there was actully something broken in the end.
13:52:50 openstackgerrit Eric Fried proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
13:54:48 efried stephenfin and/or johnthetubaguy, That ^ is pretty much a "rebase" if you want to reapprove.
14:00:31 stephenfin efried: Sure thing
14:01:21 efried thanks
14:06:28 openstackgerrit Stephen Finucane proposed openstack/nova master: DRY get_flavor in flavor manage tests https://review.opendev.org/668281
14:16:05 efried stephenfin, johnthetubaguy: If y'all are still in a reviewy mood, this series has my +2 all the way up and its runway slot expires today: https://review.opendev.org/#/q/topic:bp/placement-req-filter-forbidden-aggregates+(status:open+OR+status:merged)
14:16:42 efried for whatever reason, I think it's a pretty cool feature
14:17:20 efried mriedem: Wanna move cross-cell resize into the runway?
14:18:50 mriedem sure
14:20:03 openstackgerrit Filippo Inzaghi proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908
14:21:36 stephenfin mriedem, efried: Dumb question, but the semaphore here means literally every other kind of operation (delete, (live) migrate, resize, etc.) on that instances is prevented until this eventually, returns, yeah? https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1867-L1868
14:21:50 stephenfin Assuming those operations are all wrapped with the same semaphore
14:22:13 mriedem stephenfin: you can't live migrate/resize an instance that's being built
14:22:31 mriedem delete yes https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2801
14:23:54 stephenfin Okay, cool. I'm trying to invent reproducers for both https://review.opendev.org/#/c/663382/ and https://review.opendev.org/#/c/667294/
14:24:14 stephenfin Something that doesn't involve Heat, that is
14:25:06 stephenfin and trying to grok what could be stomping on what. Fun times :)
14:28:53 tssurya efried, mriedem: whenever you have time could you circle back to https://review.opendev.org/#/c/645611/ ? I think you were mostly ok on it, but just want to confirm if there is anything more to do there before I go on vacation

Earlier   Later