| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-25 | |||
| 18:39:43 | mriedem | i'm not saying i like it | |
| 18:39:52 | mriedem | but i also don't like redoing the whole thing per se | |
| 18:39:56 | mriedem | when there are maybe other ways | |
| 18:40:05 | melwitt | I'm +1 on the real integration testing, that's fine by me. but I just thought it would make the fixture a lot simpler and less big hiding to remove that bit about "last targeted db" | |
| 18:40:12 | mriedem | it's like touching the old quotas code - i can, but don't want to if i can help it | |
| 18:40:40 | mriedem | w/o looking deep into your change idk | |
| 18:40:45 | mriedem | i wouldn't abandon it, | |
| 18:40:50 | mriedem | but i wouldn't block the other thing on it either | |
| 18:40:57 | mriedem | i'd get the integration testing in nova-next working | |
| 18:41:09 | melwitt | that's fair. it's less like redoing and more like "delete all the self._last_ctxt_mgr" but yeah, when you get around to it, take a look and see if you hate it | |
| 18:41:09 | mriedem | which should be like, 1 line | |
| 18:42:22 | melwitt | don't get me wrong, I'm totally fine with that. as long as it gets tested, I'm happy. I was honed in on trying to make the func test work 100% | |
| 18:43:50 | melwitt | and thought people might be happy to see all the _last_ctxt_mgr stuff deleted from the fixture, no more global state changing, much simpler | |
| 18:45:06 | melwitt | I'll rebase the multi-cell archive patch on top of a different change to add --all-cells to nova-next | |
| 19:04:30 | mriedem | efried: ha http://lists.openstack.org/pipermail/openstack-discuss/2019-July/008037.html | |
| 19:25:29 | openstackgerrit | Merged openstack/nova master: api-ref: touch up the os-services docs https://review.opendev.org/672571 | |
| 19:33:45 | artom | That actually went pretty well. | |
| 19:45:30 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.opendev.org/612949 | |
| 19:45:39 | mriedem | i cleaned this up ^ it's pretty straight-forward | |
| 20:02:28 | efried | mriedem: approved that. Seems like an easy win. | |
| 20:03:19 | mriedem | ack, i'm cleaning up https://review.opendev.org/#/c/667894/ now | |
| 20:04:55 | efried | mriedem: make all the names match up too if you please | |
| 20:05:40 | efried | mriedem: the bp is at https://blueprints.launchpad.net/nova/+spec/add-user-id-field-to-the-migrations-table | |
| 20:06:48 | efried | (so the path at the top of the spec is right, but the file path, commit message, and topic are wrong) | |
| 20:09:42 | openstackgerrit | Merged openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.opendev.org/612949 | |
| 20:10:25 | efried | sean-k-mooney, stephenfin: Did we ever figure out whether/how you could tell from within a guest which / how many CPUs are pinned? Was that going to be via "metadata"? | |
| 20:10:46 | sean-k-mooney | efried: that is what the latest spec say yes | |
| 20:11:24 | efried | okay, I was about to dig into it. Unfortunately, I don't see me being competent to update it such as to get it approved today. | |
| 20:12:02 | sean-k-mooney | https://review.opendev.org/#/c/668656/5/specs/train/approved/use-pcpu-vcpu-in-one-instance.rst@173 | |
| 20:12:19 | sean-k-mooney | The metadata API will be extended to dedicated cpu info with new version. | |
| 20:12:21 | sean-k-mooney | The new field will be added to the `meta_data.json`:: | |
| 20:12:23 | sean-k-mooney | dedicated_cpu=<cpuset string> | |
| 20:12:25 | sean-k-mooney | The ``cpuset string`` indicated the instance cpus which are running on | |
| 20:12:27 | efried | ah nice | |
| 20:12:27 | sean-k-mooney | dedicated pCPU. | |
| 20:13:32 | sean-k-mooney | you could alos use that new numa toploty api if we approved that i guess | |
| 20:13:45 | sean-k-mooney | although that is not really from within the guest | |
| 20:14:45 | efried | I would want stephenfin to be a +2 on that spec anyway, so I guess we'll see if alex_xu et al can polish it up and request sfe, since we seem to have general agreement with caveats as noted. | |
| 20:15:16 | efried | I'll sent a note on sfe process (which apparently I'll be making up) either tomorrow or Monday. | |
| 20:15:21 | sean-k-mooney | does the timeline i set out make sesne to you | |
| 20:15:28 | efried | oh, totally. | |
| 20:28:47 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add user_id to the migrations https://review.opendev.org/667894 | |
| 20:29:28 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add user_id to the migrations https://review.opendev.org/667894 | |
| 20:29:39 | mriedem | first is the diff, second is the file rename | |
| 20:31:23 | mriedem | only open question on ^ is if we should add user_id/project_id as request filter params to GET /os-migrations | |
| 20:31:33 | mriedem | i think we might as well | |
| 20:35:22 | efried | sean-k-mooney: please vet that I represented you correctly in the whiteboard https://blueprints.launchpad.net/nova/+spec/use-pcpu-and-vcpu-in-one-instance | |
| 20:37:01 | sean-k-mooney | sure | |
| 20:38:03 | sean-k-mooney | yep | |
| 20:38:14 | efried | thx | |
| 20:38:23 | sean-k-mooney | without all the typos in my original comment :) | |
| 20:38:26 | gmann | efried: melwitt sean-k-mooney ack I will check the spec. it was in my list but did not get time to review. | |
| 20:38:43 | efried | thanks gmann | |
| 20:39:11 | melwitt | cool gmann | |
| 20:41:45 | efried | mriedem: where are request filter params for GET /os-migrations documented in the api-ref? | |
| 20:42:26 | efried | oh, are they the top-level fields hidden, host, instance_uuid etc? | |
| 20:42:28 | efried | uck | |
| 20:43:26 | efried | mriedem: but yeah, I think it makes sense to add this in there. | |
| 20:43:46 | mriedem | yeah | |
| 20:44:26 | mriedem | i frequently filter on migration_type and instance_uuid in functional tests since GET /servers/{server_id}/migrations is hard-coded to only be in-progress live migrations | |
| 20:54:56 | efried | mriedem: chuck that filter field in there and I'm +2 | |
| 20:55:09 | mriedem | alright then | |
| 20:55:13 | efried | not sure if you're still comfortable being the other +2 | |
| 20:55:21 | mriedem | o | |
| 20:55:28 | mriedem | *i'm like a 1.5 | |
| 20:56:08 | efried | sean-k-mooney: want to throw a +1 on there to push us over the edge? | |
| 20:56:13 | efried | ...once mriedem has updated | |
| 20:56:23 | sean-k-mooney | efried: link? | |
| 20:56:31 | efried | https://review.opendev.org/#/c/667894/ -- stand by for PS4 | |
| 20:57:06 | sean-k-mooney | oh i have looked at that before sure ill re review | |
| 21:05:12 | mriedem | build specs docs takes awhile | |
| 21:05:26 | mriedem | *building | |
| 21:05:47 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim() https://review.opendev.org/635669 | |
| 21:05:47 | sean-k-mooney | im reviewing v3 in the mean time and then ill revew the delta | |
| 21:05:47 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | |
| 21:05:48 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828 | |
| 21:05:48 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | |
| 21:05:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605 | |
| 21:05:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |
| 21:05:50 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | |
| 21:05:50 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Functional test for NUMA live migration https://review.opendev.org/672595 | |
| 21:06:16 | efried | mriedem: I use this: http://paste.openstack.org/raw/754874/ | |
| 21:08:39 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add user_id to the migrations https://review.opendev.org/667894 | |
| 21:10:40 | efried | oh, I retract my 'uck' from earlier. Didn't pick up that these were in the querystring. That's dandy. | |
| 21:11:55 | sean-k-mooney | ya that is how we normally do filtering | |
| 21:12:22 | mriedem | yeah i wasn't sure why you were ucking | |
| 21:12:50 | sean-k-mooney | efried: has intel not given you server with 70 billion cores to run cirros vms on yet | |
| 21:13:09 | efried | pshht, what do you think? | |
| 21:13:10 | sean-k-mooney | they are greate for builing docs or running unit tests | |
| 21:13:47 | sean-k-mooney | i had 3 racks woth of severs in my name when i left so yes? | |
| 21:13:59 | efried | even if I had 70 billion cores, I would still want to build only the spec I modified. | |
| 21:14:35 | sean-k-mooney | you could add that script to the tools directly and add it as a tox target | |
| 21:14:37 | mriedem | eric is in HMC withdrawals | |
| 21:14:41 | sean-k-mooney | like fast8 | |
| 21:15:07 | efried | that's a good idea. | |
| 21:16:50 | efried | where do those tools live? | |
| 21:17:17 | mriedem | they are just scripts in the repo | |
| 21:17:22 | sean-k-mooney | here https://github.com/openstack/nova-specs/tree/master/tools | |
| 21:17:24 | mriedem | the tox target calls them and passes through the args | |
| 21:17:32 | efried | oh, I thought there was a central repo | |