Posted	Nick	Remark
#openstack-nova - 2019-07-25
13:02:38	aspiers	bah
13:02:53	aspiers	I guess London deserves the wrath of satan more than the rest of the country
13:02:56	cdent	yes
13:03:08	aspiers	s/guess/know/
13:23:32	openstackgerrit	Adam Spiers proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities() https://review.opendev.org/670189
13:24:39	efried	stephenfin: I'm not sure what cores are able to review --^ but I thought you might be one of them?
13:24:43	efried	I know it's not me :(
13:25:22	aspiers	sean-k-mooney, kashyap: new version up ^^^
13:29:28	openstackgerrit	Adam Spiers proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities() https://review.opendev.org/670189
13:29:29	aspiers	kashyap: ah, just saw your nits - addressed
13:30:42	mriedem	efried: fyi i'll be running my kid to a class thing during the meeting so won't be around
13:31:38	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: Revert "[libvirt] Filter hypervisor_type by virt_type" https://review.opendev.org/672723
13:35:37	kashyap	aspiers: Thanks :-)
13:35:45	efried	meeting, right, meeting.
13:42:43	stephenfin	efried: It's on my list. Got to get to the combined VCPU/PCPU instances spec first though
13:43:39	openstackgerrit	Merged openstack/nova master: Remove super old unnecessary TODO from API start() method https://review.opendev.org/672330
13:43:47	openstackgerrit	Merged openstack/nova master: Completely remove fake_libvirt_utils. https://review.opendev.org/643897
13:43:55	openstackgerrit	Merged openstack/nova master: Remove usused umask argument to virt.libvirt.utils.write_to_file https://review.opendev.org/645086
13:53:44	efried	thanks stephenfin, specs are much more important rn.
13:58:51	sean-k-mooney	efried: cob today is spec freeze right
13:59:11	efried	sean-k-mooney: Yes. http://lists.openstack.org/pipermail/openstack-discuss/2019-July/008019.html
14:00:06	sean-k-mooney	yep read that yesterday but its been a busy few days
14:00:20	dansmith	sean-k-mooney: it's been a few days since yesterday?
14:00:49	efried	nova meeting now in -meeting
14:01:06	openstackgerrit	Merged openstack/nova master: Revert "[libvirt] Filter hypervisor_type by virt_type" https://review.opendev.org/672559
14:01:13	sean-k-mooney	no just ingeneral i was traviling form cashel to shannon after spending a few days at my mothers since her car broke down
14:01:14	openstackgerrit	Merged openstack/nova master: Consts for need_healing https://review.opendev.org/672284
14:01:22	openstackgerrit	Merged openstack/nova master: Fix cleaning up console tokens https://review.opendev.org/637716
14:01:29	openstackgerrit	Merged openstack/nova master: Disambiguate logs in delete_allocation_for_instance https://review.opendev.org/671869
14:01:37	openstackgerrit	Merged openstack/nova master: Remove old TODO about forced_host policy check https://review.opendev.org/669474
14:01:43	dansmith	sean-k-mooney: heh, it was just a funny mind-o highlighting the business (i.e. two days felt like three)
14:01:44	openstackgerrit	Merged openstack/nova master: Avoid logging traceback when detach device not found https://review.opendev.org/671640
14:01:50	dansmith	er, busy-ness
14:02:12	sean-k-mooney	ha ya
14:05:00	sean-k-mooney	speaking of specs i agree that https://review.opendev.org/#/c/608696/ and https://review.opendev.org/#/c/602201/ are the closest of the remaing set
14:35:09	openstackgerrit	Matt Riedemann proposed openstack/nova stable/rocky: Avoid crashing while getting libvirt capabilities with unknown arch names https://review.opendev.org/672746
14:35:09	openstackgerrit	Matt Riedemann proposed openstack/nova stable/rocky: Revert "[libvirt] Filter hypervisor_type by virt_type" https://review.opendev.org/672747
14:40:46	artom	Did something change with placement in functional tests recently? I swear my NUMA LM func test was getting to updating the XML last night, but this morning it's failing on placement not giving any allocations
14:42:51	cdent	artom you have an example of the query that's being made, that might clarify things
14:43:19	cdent	just today some cache adjustments were merged. when did things last work?
14:44:11	artom	Last night (EDT)
14:44:13	artom	27.0.0.1 "GET /placement/allocation_candidates?limit=1000&required=%21COMPUTE_STATUS_DISABLED&resources=DISK_GB%3A20%2CMEMORY_MB%3A2048%2CVCPU%3A3" status: 200 len: 53 microversion: 1.31
14:44:27	artom	Got no allocation candidates from the Placement API. This could be due to insufficient resources or a temporary occurrence as compute nodes start up.
14:45:53	artom	(Which I guess makes even less sense - if it was the same as before, what changed?)
14:47:52	cdent	artom: got a patch up so I can play with it myself?
14:48:47	cdent	when did compute status disabled support merge in nova?
14:48:53	artom	cdent, https://review.opendev.org/#/c/672595, but I had to rebase it locally, so hang on
14:48:58	cdent	aye aye
14:49:01	mriedem	cdent: last week i think
14:49:04	mriedem	or 2 weeks ago
14:51:42	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim() https://review.opendev.org/635669
14:51:43	openstackgerrit	Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
14:51:43	openstackgerrit	Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828
14:51:44	openstackgerrit	Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229
14:51:44	openstackgerrit	Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605
14:51:45	openstackgerrit	Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
14:51:45	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
14:51:46	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [WIP] Functional tests for NUMA live migration https://review.opendev.org/672595
14:51:54	artom	^^ There, fixed the merge conflicts
14:52:08	artom	For all I know it's not even placement...
14:52:08	cdent	thanks artom will try it from my side of the world
14:52:16	artom	cdent, appreciated, much thanks :)
14:55:12	efried	artom: https://review.opendev.org/#/c/668752/
14:55:30	efried	~2w ago
14:57:30	mriedem	i'm pretty sure required=%21COMPUTE_STATUS_DISABLED is saying !disabled
14:57:35	mriedem	i.e. forbidden trait
14:57:40	cdent	yes
14:57:56	artom	Yeah, that's !
14:59:40	sean-k-mooney	mriedem: yep it is
15:00:46	sean-k-mooney	althouhg ! does not technically have to be url encoded
15:00:56	sean-k-mooney	but %21 is the encodeing for !
15:28:28	efried	sean-k-mooney: A requirement for cycle-with-intermediary projects is a m-2 release. os-vif qualifies.
15:28:28	efried	It looks like there have been half a dozen or so commits since the last release, of which only one looks like it has any meat (https://review.opendev.org/#/c/658786/)
15:28:28	efried	Can we do a release now?
15:28:48	efried	jangutter: ^
15:33:21	sean-k-mooney	efried: actully we just need to have 1 release we dont need one at each milestone
15:33:30	sean-k-mooney	that was cycles-with-milestones
15:33:37	sean-k-mooney	but ill check and get back to you later
15:33:43	sean-k-mooney	just on a meeting
15:34:44	stephenfin	efried, mriedem: Can I have pre-commit? Pretty please? https://review.opendev.org/#/c/665518/
15:35:13	stephenfin	I've to respin ~8 patches because I forgot to run pep8 :'( https://review.opendev.org/#/c/671797/
15:35:33	stephenfin	Not that I'm going to bother yet. I'll fix it when I need to respin
15:37:42	jangutter	efried: regarding the meat, I'm happy for it to get barbecued into a release. note that there has been some follow-on stuff (unmerged) that happened afterwards too.
15:39:09	jangutter	efried: specifically https://review.opendev.org/#/c/665965/
15:40:07	cdent	artom: I responded on your thing. I can see where things go wrong, but not why
15:40:28	cdent	what I mean is I can answer the "why" but not the "why of the why"
15:40:43	jangutter	efried: my view (stated in the os-vif review) is that I don't think the follow-on is necessary, but I don't feel strongly enough to oppose it.
15:41:09	artom	cdent, aha, that's already very helpful
15:41:46	cdent	artom: good. i'll be curious to here what the missing piece is
15:41:53	cdent	and hear too
15:41:54	artom	I know some stuff changed recently around fakelibvirt
15:42:08	artom	Maybe a side effect of that was changing the default flavor and/or compute disk size?
15:42:17	mriedem	stephenfin: i'll defer your pre-commit request to dansmith
15:42:22	cdent	sounds likekly
15:42:25	artom	I shall dig, right after this meeting
15:42:36	artom	Which is done, thank god
15:42:37	stephenfin	ugh, but he's the worst
15:42:46	mriedem	i'm an old bugbear so i don't care about pre-commit
15:42:47	stephenfin	Um, I mean...the best <3
15:42:53	mriedem	and will bitch to no end if it makes me do extra things

Earlier   Later