| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-19 | |||
| 16:07:52 | sean-k-mooney | efried: do you know if aspires is still working on openstack? | |
| 16:08:08 | sean-k-mooney | i have not seen them involded in the sev work lately | |
| 16:08:09 | efried | I haven't seen him in quite a while, but I hope so. | |
| 16:08:14 | efried | yeah | |
| 16:08:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: libvirt: move checking CONF.my_ip to init_host() https://review.opendev.org/671471 | |
| 16:08:52 | sean-k-mooney | maybe i should add Boris Bobrov to the review too since they seam to have taken over the sev stuff | |
| 16:11:33 | efried | artom: That rev wfm. Just one other thing: do functional tests have the possibility of hitting netifaces now? | |
| 16:12:03 | artom | OK, this isn't a rabbit whole anywhere, it's the pit of hell | |
| 16:12:18 | artom | *hole | |
| 16:12:26 | artom | efried, but yeah, they do, good thought | |
| 16:12:56 | artom | Maybe right up in nova/test.py? | |
| 16:13:09 | efried | artom: do any func tests use the real libvirt driver? | |
| 16:13:14 | efried | if they use fake, this is n/a | |
| 16:13:30 | efried | no, I don't want a libvirt-specific fixture in nova/test.py | |
| 16:13:33 | artom | They use the fake libvirt API, but real driver IIRC, no? | |
| 16:13:53 | efried | (don't tell me if there are already libvirt-isms dirtying up the base class) | |
| 16:14:09 | efried | artom: I don't know, I'm still pretty green on all this libvirt stuff. | |
| 16:14:11 | sean-k-mooney | artom: i dont think so | |
| 16:14:40 | sean-k-mooney | the unit test in generall dont use the drivers at all | |
| 16:14:48 | sean-k-mooney | the functional test defualt to the fake dirver | |
| 16:14:58 | sean-k-mooney | execpt the function test under the libvirt folder | |
| 16:15:10 | sean-k-mooney | which do as you said | |
| 16:15:22 | sean-k-mooney | e.g. fake libvirt api + real libvirt driver | |
| 16:16:00 | sean-k-mooney | you could add a test in here somewhare https://github.com/openstack/nova/tree/master/nova/tests/functional/libvirt | |
| 16:16:01 | artom | efried, well, wait a second, we had that before, no? | |
| 16:16:20 | efried | had what before? | |
| 16:16:26 | artom | Any migration test that didn't mock out get_host_ip_addr | |
| 16:16:33 | artom | It ended up calling down to netifaces eventually | |
| 16:16:43 | efried | seems likely, yeah | |
| 16:16:43 | sean-k-mooney | we only have 2 migration tests i think | |
| 16:16:44 | artom | Same for functional tests | |
| 16:17:27 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/compute/test_live_migration.py | |
| 16:18:07 | artom | I don't think live migration hit that | |
| 16:18:14 | efried | let's settle this... | |
| 16:18:14 | efried | I'm going to write a DNM with a poison fixture that will blow up any test that hits netifaces.interfaces() | |
| 16:18:14 | efried | and let the gate tell me which tests are affected. | |
| 16:19:06 | efried | which is almost, but not quite, unrelated to your patch. | |
| 16:19:19 | efried | since you've expanded the number of code paths in which it could be getting called | |
| 16:19:31 | artom | I'd be OK waiting for that to report before proceeding | |
| 16:19:39 | artom | Even rebasing on top | |
| 16:19:48 | efried | Well | |
| 16:19:55 | efried | I'm not sure I want to *keep* the poison fixture | |
| 16:20:00 | efried | although I guess that wouldn't be an awful thing. | |
| 16:20:19 | artom | Well, we're either OK with listing the host interfaces, or we're not :) | |
| 16:20:33 | artom | If we're not, which seems the case, don't even bother DNM'ing it | |
| 16:20:37 | efried | yeah, that's a fair point. | |
| 16:20:42 | efried | okay, stand by | |
| 16:38:11 | openstackgerrit | Eric Fried proposed openstack/nova master: Poison netifaces.interfaces() in tests https://review.opendev.org/671773 | |
| 16:38:14 | efried | artom: ^ | |
| 16:40:20 | openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: move checking CONF.my_ip to init_host() https://review.opendev.org/671471 | |
| 16:40:26 | efried | artom: rebased yours on top ^ | |
| 16:40:37 | efried | we'll see if either/both explode :) | |
| 16:40:44 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | |
| 16:41:57 | sean-k-mooney | gibi_off: ill fix the failing tests in ^ on monday so you can ignore it for now | |
| 16:43:02 | sean-k-mooney | GenericPoisonFixture i like the name :) | |
| 16:46:00 | artom | ericyoung, ack, thanks. Don't we already have a DB poison fixture somewhere? If you're making a generic one, should it gobble that up? | |
| 16:46:10 | artom | Whoops, efried ^^ | |
| 16:46:49 | efried | artom: There are two other poison fixtures that I could conceivably roll into this one, but their messages are much more specific and they do more specific things, so I left them alone for now. | |
| 16:49:25 | artom | *snerk* I understand you mean method | |
| 16:49:34 | artom | But... maybe not have the name of a hard drug in our code? ;) | |
| 16:52:43 | efried | artom: Heh, yeah, I just didn't want to shadow variable names. It makes my IDE mildly upset, and confuses me. | |
| 16:53:04 | artom | func | |
| 16:53:05 | artom | ? | |
| 16:53:40 | efried | I should point out http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-07-15.log.html#t2019-07-15T20:49:08 | |
| 16:54:20 | efried | (You thought nobody was listening) | |
| 16:54:22 | artom | efried, what I looking at? 1836595? | |
| 16:54:57 | artom | Oh, yeah, thank you zhufl ^_^ | |
| 16:56:31 | efried | dansmith: will you be able to get back to (and hopefully close) https://review.opendev.org/612497 (providers.yaml) today? | |
| 16:56:55 | dansmith | hopefully | |
| 17:51:28 | dansmith | efried: you wanna fix at least my typo nit and I'll +2+W? No long test run required for these, so a quick bump for a typo seems fine | |
| 17:52:54 | efried | dansmith: okay, you want me to smash in the fup while I'm at it? | |
| 17:54:41 | dansmith | oh I didn't see the fup, yeah might as well and gibi is +2 there, so ... easy | |
| 17:55:51 | efried | dansmith: Do you want me to say "exactly one" identification mechanism, or is "at least one" good? | |
| 17:56:26 | dansmith | efried: the point of my comment is "exactly one" is important.. if you say "at least one" you need to define what happens if they put name and uuid and they don't match | |
| 17:56:51 | efried | right, that would be an error. | |
| 17:57:05 | efried | "exactly one" would restrict us in the future if we wanted to do some kind of pattern matching | |
| 17:57:23 | efried | name_matches: /pattern/ | |
| 17:57:23 | efried | has_trait: CUSTOM_FOO | |
| 17:57:25 | efried | kind of thing | |
| 17:57:54 | efried | but I'm fine either way. | |
| 17:58:38 | dansmith | sure, but as it is today, I would think "exactly one" gets you a crisper definition.. then when you add a match you can say "zero or one of name/uuid and one or more filters" or something like that.. but I don't care whether you go loose or tight, just define the edges if you go loose | |
| 17:59:17 | dansmith | if you want to put this in your fup for bikeshedding I can just +W the bottom one | |
| 17:59:49 | efried | dansmith: so tbc you're okay if I leave it defined as is but add "error if you specify both and they don't match"? | |
| 18:00:52 | dansmith | I think "at least one" is better than "either" because I'm not sure whether either means "one but not both", but yes, if you want "at least one" and define the edges, that's fine | |
| 18:01:16 | dansmith | but, what happens if I do $COMPUTE_NODE and name and there's no match? Is that an error because I won't ever do anything, or is that a 'well no match but that's what you asked for' ? | |
| 18:02:07 | dansmith | and, that might be right at startup, but not after a reshuffle, | |
| 18:02:23 | dansmith | and in the zero hour case with ironic, the compute starts up with no nodes at first | |
| 18:02:48 | dansmith | not trying to complicate this, which is why I thought "exactly one" makes this easier for the moment :) | |
| 18:02:54 | efried | okay okay | |
| 18:04:51 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | |
| 18:05:06 | efried | dansmith: smashed and done ^ | |
| 18:06:37 | efried | \o/ | |
| 18:06:38 | efried | thanks dansmith | |
| 18:17:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414 | |
| 18:17:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789 | |
| 18:17:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790 | |
| 18:17:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791 | |
| 18:17:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | |
| 18:17:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | |
| 18:17:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'pcpus' to the resource tracker https://review.opendev.org/671794 | |