| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-18 | |||
| 17:44:53 | sean-k-mooney | so it was causing helping to cause the subunit parser explotion | |
| 17:45:00 | sean-k-mooney | in our downstream functional job | |
| 17:45:21 | sean-k-mooney | that was not enought to fix the job donwstream but was one of the noiser things | |
| 17:45:30 | efried | I confirm that sqla l-c in stein is above 0.8.0, so procedurally there's no reason not to do it. | |
| 17:45:40 | efried | https://opendev.org/openstack/nova/src/branch/stable/stein/lower-constraints.txt#L150 | |
| 17:45:49 | efried | so sure, if it helps ya, I don't object. | |
| 17:45:52 | efried | But again, I can't +2 it. | |
| 17:46:13 | sean-k-mooney | sure but you are ptl so its still good to check with you. | |
| 17:46:21 | efried | :) thank you | |
| 17:47:01 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: Replace joinedload_all with joinedload https://review.opendev.org/671532 | |
| 17:47:17 | sean-k-mooney | ill leave it up to the stable cores to weight in ^ | |
| 17:47:25 | sean-k-mooney | i can always abandon it | |
| 17:48:23 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: take over instances from down compute services https://review.opendev.org/671534 | |
| 17:48:35 | sean-k-mooney | currently im hoping adding --suppress-attachments to our downstream tox job will fix the sub unit issue at least for now | |
| 17:49:12 | sean-k-mooney | that will skip the stdout and stderror for succesfful tests which grealy reduces the test output | |
| 17:49:22 | sean-k-mooney | but still give you all the output if a test fails | |
| 17:49:51 | sean-k-mooney | btu we dont know if that will be enough so suppressing deprecation warnings also helps | |
| 18:45:26 | efried | dansmith: does ironic hash ring reshuffle require compute restart? | |
| 18:45:32 | dansmith | efried: no | |
| 18:45:45 | efried | I guess that still works, though, since you've already parsed the file. | |
| 18:45:47 | efried | thx | |
| 18:45:52 | dansmith | yeah | |
| 18:46:02 | efried | but means we can't rely on the 'startup' arg | |
| 19:00:03 | efried | except | |
| 19:00:41 | efried | if one of the new ironic nodes has inventory in a RC we've been happily adding on at the behest of the providers.yaml | |
| 19:00:47 | efried | then we'll blow up the compute service. | |
| 19:01:18 | dansmith | meaning if someone provides CUSTOM_IRONIC_GOLD in providers.yaml? | |
| 19:01:32 | efried | yeah | |
| 19:01:49 | efried | well, isn't that a trait? Not worried about traits | |
| 19:01:57 | efried | RC is what we blow up on | |
| 19:01:59 | dansmith | yeah, that's going to be a hard case to reason about I guess, because ironic is re-using customs | |
| 19:02:01 | dansmith | no, it's an RC | |
| 19:02:01 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Replace "integrated-gate-py3" template with new "integrated-gate-storage" https://review.opendev.org/671551 | |
| 19:02:04 | efried | okay | |
| 19:02:05 | dansmith | that's the whole point | |
| 19:02:09 | dansmith | so what about this: | |
| 19:02:38 | dansmith | if we're on init=true, we set any providers inventory that isn't already in the tree, and explode otherwise | |
| 19:02:43 | efried | I think I can swing the "don't error if identical" thing, it's just going to be a bit tricky because I have to ignore fields (like min_unit) that weren't in the config. | |
| 19:02:50 | dansmith | if we're init=false, we set any inventory that isn't already in the tree, but ignore/warn otherwise | |
| 19:03:12 | efried | that seems safer, anyway. | |
| 19:03:25 | efried | could do that regardless | |
| 20:13:13 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | |
| 20:13:26 | efried | dansmith, sean-k-mooney: ^ | |
| 20:27:31 | efried | artom: that took me a while, but reviewed (CONF.my_ip warning) | |
| 20:28:50 | artom | efried, aha, thanks! | |
| 20:30:56 | artom | I did feel a bit weird about taking out a warning, I mean, it was added for a reason, right? | |
| 20:31:50 | efried | artom: I linked the reason | |
| 20:31:58 | efried | which looks like it was a legit reason... when it was an exception. | |
| 20:32:06 | artom | Exactly | |
| 20:32:08 | efried | But as a warning, not sure if it's really worthwhile or not. | |
| 20:32:17 | artom | When it turned into a warning, is it really useful? | |
| 20:32:26 | efried | I'm not sure | |
| 20:32:34 | efried | it depends how the cold migration failure manifests | |
| 20:32:54 | efried | if it's one of those things where it's really hard to figure out why it happened, unless you have this warning, then we might want to keep it around. | |
| 20:33:27 | efried | then again, are you really going to notice this warning waaay back in the logs while you're investigating your cold mig failure. | |
| 20:36:17 | artom | To set migration.dest_host | |
| 20:36:27 | artom | (Which AFAICT isn't actually used for anything) | |
| 20:36:56 | artom | Ah, no, it's passed to migrate_disk_and_power_off | |
| 20:38:49 | artom | And then is used in the actual cleanup catch-all Exception handler | |
| 20:38:51 | artom | So yeah, problems | |
| 20:56:51 | efried | nova meeting in 4 minutes in #openstack-meeting | |
| 21:49:38 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | |
| 21:49:53 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | |
| 21:50:15 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | |
| 21:50:36 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | |
| 21:50:50 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | |
| 21:51:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | |
| 21:51:20 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | |
| 21:51:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | |
| 21:52:08 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | |
| 21:52:38 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | |
| 21:54:00 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | |
| 21:54:20 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200 | |
| 21:54:37 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.opendev.org/637716 | |
| 22:36:18 | dustinc_OSCON | Anyone use any tools for reviewing local diffs before pushing other than ‘git diff’? | |
| 23:17:37 | efried | dustinc_OSCON: I have in the past, don't really anymore. Long ago I used one called beyond compare. But I don't remember whether it worked with diffs (à la git) or with two actual copies of the file, probably the latter. | |
| 23:18:04 | efried | If I'm really having trouble seeing what I want to see via git diff, I'll actually just push the change to gerrit and review it there. | |
| #openstack-nova - 2019-07-19 | |||
| 00:05:06 | openstackgerrit | melanie witt proposed openstack/nova master: Avoid logging traceback when detach device not found https://review.opendev.org/671640 | |
| 01:07:08 | alex_xu | kashyap: I replied you on the maillist, looks like ceilometer still using the perf meters, include some of meter isn't just about cmt. | |
| 02:38:42 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.opendev.org/637716 | |
| 03:09:47 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Replace "integrated-gate-py3" template with new "integrated-gate-compute" https://review.opendev.org/671551 | |
| 05:29:39 | openstackgerrit | Alex Xu proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | |
| 05:37:59 | openstackgerrit | Alex Xu proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | |
| 07:58:39 | kashyap | alex_xu: Will check; thank you | |
| 08:01:27 | alex_xu | kashyap: not sure how ceilometer enable those meters https://github.com/openstack/ceilometer/blob/master/ceilometer/compute/virt/libvirt/inspector.py#L218, since nova doesn't pass those parameter to libvirt | |
| 08:01:54 | kashyap | Yeah, was wondering the same; thanks for the code pointer | |
| 08:04:07 | cdent | alex_xu, kashyap : I seem to recall that at some point ceilometer made their own compute node agent rather than listening to nova, because nova didn't want to give all the information that ceilo wanted to get | |
| 08:04:30 | cdent | I may be remembering wrong though. Also I have zero context here so I may be butting in with info that you've already got. | |
| 08:04:57 | kashyap | cdent: No, I didn't know what you said; that's useful to know | |
| 08:05:14 | cdent | kashyap: you'll definitely want to check me on that. It's a vague memory | |
| 08:05:17 | kashyap | cdent: The context is this patch: https://review.opendev.org/#/c/669129/ | |
| 08:05:50 | kashyap | cdent: Linux kernel has removed the underlying infrastructure for Intel "CMT" | |
| 08:06:05 | cdent | seems like it's a done deal then, yeah? | |
| 08:06:10 | kashyap | Right | |
| 08:06:29 | kashyap | We already today warn if any anyone specifies the "CMT" 'performance' events via Nova's config attributes | |
| 08:06:43 | cdent | kill it! kill it with fire! | |
| 08:06:51 | kashyap | Hehe, yeah. | |
| 08:07:31 | kashyap | However there are *other* 'perf' events besides the CMT variants. So I asked on the mailing list if anyone is using them at all. | |
| 08:07:54 | kashyap | [While bearing in mind -discuss list audience does not represent all users ever :D] | |
| 08:13:47 | alex_xu | kashyap: we can write other event than cmt https://github.com/openstack/nova/blob/master/nova/conf/libvirt.py#L785 | |