| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-18 | |||
| 11:08:20 | sean-k-mooney | kashyap: even if it was stephenfin wrote it so we shoul dnot have a redhat core +2+w without someone else looking at it | |
| 11:08:58 | kashyap | Well, not that asinine reason again. There are sensible exceptions | |
| 11:09:10 | sean-k-mooney | kashyap: yep this is not one of them | |
| 11:09:22 | kashyap | On that point, see my extended point here: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006080.html | |
| 11:09:28 | kashyap | sean-k-mooney: Okay. | |
| 11:09:49 | kashyap | I don't care about this change particularly, BTW. Just the simplicity of it is what prompted me to say it. | |
| 11:18:29 | cdent | kashyap++ and *hugs* | |
| 11:18:47 | kashyap | :-) | |
| 11:22:05 | kashyap | sean-k-mooney: For argument's sake, why is this not one of them? Precise is even EOL | |
| 11:22:34 | kashyap | This is definitely one of those dead-simple changes that doesn't require an completely unhinged process to interfere | |
| 11:22:43 | kashyap | Anyway, not my circus, not my clowns. | |
| 11:23:31 | kashyap | s/"an completely"/"a completely"/ | |
| 11:27:55 | sean-k-mooney | ignoring the same company aspect. one out of curtusy to other disto maintainer we shoudl not fast merge thing related to our competitor distro without any external reveiew, second we only use singel +2 in very limited cases like when you would have been the second +2 but you fix a minor nit in someone esle pathc or rebased a patch that went int merge confcit and you are proxing a previous +2 from a | |
| 11:27:57 | sean-k-mooney | core, third its not urgent, i.e. there is no bug associated wthi this stepen jsut noticed it and its not blocking the gate. put that to gether with the same company core thing and even though its trivial and it looks correct i dont think this has a stong case for bypassing our standard policy | |
| 11:29:35 | kashyap | Sure, it is not about "urgency", but needless, grinding processes coming in the way. Also on courtesy, who says it is being incourteous? Assume good intent. | |
| 11:30:00 | kashyap | gibi: :-) I was just "thinking (or arguing) out loud". | |
| 11:31:02 | sean-k-mooney | i am assuming good intent but i would assume you would like to see change to fedora requirement before they merged if i was droping support for a fedora version | |
| 11:31:18 | kashyap | For an EOL release? I don't give a damn | |
| 11:31:48 | sean-k-mooney | anyway thanks gibi :) | |
| 11:32:18 | gibi | we an always revert such patches :) | |
| 11:32:23 | gibi | we can | |
| 11:32:26 | kashyap | Yes, exactly. | |
| 11:32:34 | kashyap | The "revert" hammer is always near by :D | |
| 11:32:49 | sean-k-mooney | keep it away from artom for a while | |
| 11:32:55 | kashyap | Haha | |
| 11:38:36 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.75: Add 'power-update' external event https://review.opendev.org/645611 | |
| 11:39:29 | artom | What am I reverting? | |
| 11:40:05 | sean-k-mooney | hehe nothing i was just saying lets not hit you with the revert hammer for a while. | |
| 11:40:20 | sean-k-mooney | i think you have had enough heartache form it in the last week or two | |
| 11:40:38 | artom | Ugh | |
| 11:41:05 | kashyap | He was teasing you :D | |
| 11:41:32 | sean-k-mooney | more his bad luck | |
| 11:41:55 | artom | I know, the "ugh" was about the reverts, not the tease | |
| 11:48:46 | kashyap | Nod, figured as much. | |
| 12:26:02 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: migrations: libvirt: remove get_machine_ips() https://review.opendev.org/671471 | |
| 12:26:06 | artom | sean-k-mooney, ^^ | |
| 12:26:23 | artom | stephenfin, ^^ you might like the code removal aspect too :) | |
| 12:26:29 | artom | Not sure if I need a bug for that... | |
| 12:27:31 | sean-k-mooney | ya we proably should have a bug and mention the downstream one | |
| 12:27:53 | sean-k-mooney | :) +0,-55 | |
| 12:31:34 | sean-k-mooney | artom: actully we want to backport it so it need a bug | |
| 12:34:06 | stephenfin | artom: Makes sense. Do you want to backport it? | |
| 12:34:29 | sean-k-mooney | stephenfin: we need this on newton downstream | |
| 12:34:34 | sean-k-mooney | so yes | |
| 12:34:35 | stephenfin | I assume so, given your comment in the bug. If so, what sean-k-mooney said | |
| 12:34:36 | stephenfin | ack | |
| 12:34:36 | artom | stephenfin, it's for an internal escalation, so yeah | |
| 12:35:01 | artom | Busy with household'y stuff, will file bug | |
| 12:35:05 | artom | In a few | |
| 12:35:12 | stephenfin | That's going to be an ugly backport. You've been warned | |
| 12:35:29 | artom | I... I can't tell if you're being serious | |
| 12:35:34 | stephenfin | (look at the "Conflicts With" for an idea of the amount of _unmerged_ patches this touches) | |
| 12:35:45 | stephenfin | Oh, I'm always very serious | |
| 12:35:46 | sean-k-mooney | really? why | |
| 12:35:53 | stephenfin | Serious Steve, I've been called | |
| 12:36:03 | sean-k-mooney | i think that is likely jsut change to the module import in most cases | |
| 12:36:08 | artom | I would think most of those are just whitespace-type things | |
| 12:36:28 | artom | Ie, the excision itself is clean, but git is having trouble because what's around it changed | |
| 12:36:32 | stephenfin | Quite possibly. I didn't check. It doesn't matter much either. If it's got to be done, it's got to be done. | |
| 12:36:56 | sean-k-mooney | stephenfin: also if artom going to be the one doing it ... :) | |
| 12:37:10 | artom | Sheesh guys, team spirit and all that | |
| 12:37:34 | sean-k-mooney | we will review it for you down stream too :P | |
| 12:38:01 | stephenfin | Go team? | |
| 12:38:10 | artom | And I'm sure it'll be done most professionally | |
| 12:38:22 | stephenfin | And that's all the team spirit I have for one day. | |
| 12:40:02 | sean-k-mooney | stephenfin: maybe an infution of teen sprit will help https://www.youtube.com/watch?v=hTWKbfoikeg | |
| 12:45:38 | artom | sean-k-mooney, *fist bump* | |
| 12:45:47 | artom | Noice. | |
| 12:58:11 | kashyap | alex_xu: When you're awake: Mind giving an opinion on the Intel CMT thing? -- https://review.opendev.org/#/c/669129/ | |
| 13:19:29 | alex_xu | kashyap: thanks, I will check that | |
| 13:23:28 | kashyap | Thanks! | |
| 13:35:37 | alex_xu | kashyap: I will send an email double check with team, the last time(after the dublin ptg) I check with team, it said ok to remove it. so just wait few more sec, I will get that back to you. | |
| 13:36:04 | kashyap | alex_xu: Sure, no rush. By "remove it", are you suggesting to remove entire support for it, yeah? | |
| 13:36:44 | alex_xu | kashyap: the entire perf feature, right? I didn't heard any requirement from intel for it now. | |
| 13:36:52 | kashyap | Right, indeed | |
| 13:37:03 | kashyap | As we know, the kernel itself has completely nuked it | |
| 13:42:17 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-next: Deploy noVNC from source https://review.opendev.org/671490 | |
| 13:42:38 | lyarwood | melwitt: ^ as discussed, hopefully that's enough to make this work. | |
| 14:04:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 14:13:37 | stephenfin | dansmith: Off the top of your head, any idea what would cause this? http://paste.openstack.org/show/754546/ | |
| 14:14:09 | dansmith | yes? | |
| 14:14:21 | dansmith | you named the things different in the model and the migration | |
| 14:14:29 | dansmith | pcpus vs pcpus_used apparently | |
| 14:14:43 | efried | kashyap: I use git-restack regularly to manage series | |
| 14:14:48 | dansmith | stephenfin: ^ | |
| 14:15:17 | stephenfin | dansmith: I don't see how though http://paste.openstack.org/show/754547/ | |
| 14:16:49 | dansmith | hmm, so it must be claiming that both of those are missing from one or the other | |
| 14:17:23 | dansmith | oh | |
| 14:17:32 | dansmith | stephenfin: aren't you creat5ing them as nullable=True, | |
| 14:17:39 | dansmith | but they're =false in the model | |
| 14:17:47 | stephenfin | god damn it, yup | |
| 14:18:04 | dansmith | that output from the test looks different than I remember for some reason, but .. yeah | |
| 14:18:20 | stephenfin | Thanks. I've been looking at that for at least 30 minutes 😅 | |
| 14:18:34 | dansmith | np, blinders.. it's a thing | |
| 14:21:54 | kashyap | efried: Good to know. Thanks for the view | |
| 14:22:46 | efried | kashyap: in fact, if you're trying to convince people that gerrit is awesomer than other things, how do other things manage series? Cause gerrit does it awesomely. | |
| 14:24:47 | efried | kashyap: I wrote a tutorial, which might be handy: https://docs.openstack.org/contributors/de/code-and-documentation/patch-series-tutorial.html | |
| 14:25:04 | efried | https://docs.openstack.org/contributors/code-and-documentation/patch-series-tutorial.html | |
| 14:30:00 | kashyap | Excellent; I saw that before! | |
| 14:30:27 | kashyap | efried: I don't think this group might consider Gerrit. I wanted to present where Gerrit shines | |