Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-07-10
20:26:53 efried ight
21:01:03 openstackgerrit sean mooney proposed openstack/nova master: DNM demonstrate that get_domain_capabilities is broken. https://review.opendev.org/670189
21:02:21 sean-k-mooney efried: aspiers ^ im going rework get_domain_capabilities function so that it does not explode at runtime
21:15:43 efried neat
21:23:24 sean-k-mooney the test case is a bit contrived as i would otherwise be assert that if i trow an excpetion that it thing explode
21:23:51 sean-k-mooney but hopefully its clear that there reason it was passing wa we were hardcoding stuff
21:24:01 sean-k-mooney and we dont call it
21:26:54 openstackgerrit Merged openstack/nova master: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164
21:28:14 sean-k-mooney im going to change the api of _get_domain_capabilities to match libvirt which allows all args to be set to none so we dont need to invent a default if we dont have one and can just use libvirts instead
21:36:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job https://review.opendev.org/670196
21:44:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job https://review.opendev.org/670196
22:48:57 openstackgerrit Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664
22:48:57 openstackgerrit Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023
22:58:26 openstackgerrit Merged openstack/nova master: nova-lvm: Disable [validation]/run_validation in tempest.conf https://review.opendev.org/662176
23:17:05 openstackgerrit sean mooney proposed openstack/nova master: libvirt: harden get_domain_capabilities https://review.opendev.org/670189
23:43:09 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
23:43:10 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list https://review.opendev.org/656027
23:43:10 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node https://review.opendev.org/656028
23:43:11 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id https://review.opendev.org/659690
23:43:11 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691
23:43:12 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for getting network metadata from node https://review.opendev.org/670213
#openstack-nova - 2019-07-11
00:00:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job https://review.opendev.org/670196
00:31:48 openstackgerrit Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177
00:31:48 openstackgerrit Artom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631
00:31:49 openstackgerrit Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442
03:05:25 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.opendev.org/580336
04:03:37 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/670225
04:05:32 openstackgerrit Takashi NATSUME proposed openstack/nova stable/queens: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/670226
06:57:50 openstackgerrit huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016
07:41:15 openstackgerrit huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016
08:55:37 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates https://review.opendev.org/667952
09:03:29 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
09:37:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955
10:32:16 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Propose ACCELERATOR_{FPGA|GPU} resource classes https://review.opendev.org/657464
10:39:09 openstackgerrit Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765
10:58:23 ralonsoh hi folks, can I have your attention to https://review.opendev.org/#/c/641670/?
10:58:31 ralonsoh thank you in advance!
11:27:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move consts from neutronv2/api to constants module https://review.opendev.org/668945
11:28:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: Translatable output strings in heal allocation https://review.opendev.org/668925
11:39:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use neutron contants in cmd/manage.py https://review.opendev.org/668946
11:39:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add 'resource_request' to neutronv2/constants https://review.opendev.org/668947
11:45:32 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use the safe get_binding_profile https://review.opendev.org/669817
12:25:27 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/670096
12:26:36 openstackgerrit Stephen Finucane proposed openstack/nova stable/rocky: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/670097
12:27:52 openstackgerrit Stephen Finucane proposed openstack/nova stable/queens: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/670100
12:33:50 shilpasd efried: dansmith: requesting to further review https://review.opendev.org/#/c/667952/7
12:39:18 alex_xu efried: after review the vpmem, I want to point the Luyao to move the vpmem ns assigment inside the resource tracker. https://review.opendev.org/#/c/662702/4/nova/compute/manager.py@2200, want to hear you opionion whether it is right direction I pointed to
12:47:02 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Scrub available quotas https://review.opendev.org/670125
12:47:02 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165
12:59:53 openstackgerrit ya.wang proposed openstack/nova master: Add method 'get_all_required_traits' to scheduler utils https://review.opendev.org/670297
12:59:53 openstackgerrit ya.wang proposed openstack/nova master: vCPU mdoels selection https://review.opendev.org/670298
12:59:54 openstackgerrit ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299
12:59:54 openstackgerrit ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300
13:00:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
13:03:55 efried alex_xu: looking...
13:04:10 alex_xu efried: thanks!
13:05:40 efried alex_xu: instance_claim is a good idea, I think. Aptly named, protected by COMPUTE_RESOURCE_SEMAPHORE... but where is bauzas claiming VGPUs?
13:05:54 bauzas efried: on a meeting atm
13:05:56 efried I would have expected that to be the same as vpmems
13:06:10 efried no worries bauzas, I can look.
13:06:21 alex_xu efried: actually, I just find the vgpu allocation have race problem
13:06:31 alex_xu I talk that with bauzas yesterday
13:06:44 efried ah, okay. So it sounds like vgpu needs to be moved to instance_claim as well
13:06:58 efried do we have a bug for that yet?
13:07:54 alex_xu not yet, I can file a bug
13:10:25 efried alex_xu: hold on, isn't COMPUTE_RESOURCES_SEMAPHORE held throughout the `with instance_claim` block?
13:10:57 efried oh, no, never mind
13:11:07 efried instance_claim isn't itself a context manager; it returns one.
13:12:08 alex_xu efried: here is the bug, that help you understand the problem https://bugs.launchpad.net/nova/+bug/1836204
13:12:08 openstack Launchpad bug 1836204 in OpenStack Compute (nova) "The allocation of VGPU has race problem" [Undecided,New]
13:13:19 alex_xu efried: also the vpmem isn't quite same with vgpu in the resize case, we need to allcoate vpmem for migration the data from the src host. so we need to assign a pmem in the beginning of resize https://review.opendev.org/#/c/662709/4/nova/compute/manager.py@4359
13:14:07 efried in that case do we want to fold it into resize_claim?
13:14:38 alex_xu yes, and that doesn't sounds good we add new virt interface just for allocae a pmem.
13:14:58 alex_xu and there isn't a way to resolve the race problem just by listing libvirt domain
13:15:18 efried alex_xu: We shouldn't be putting this libvirt-specific code into the rt anyway
13:15:28 alex_xu since we assign vpmem without create libvirt domain on the dst host in the beginning of resize
13:15:38 efried a virt driver interface to say "claim the things in this allocation" would seem appropriate.
13:15:46 efried it doesn't need to be vpmem specific
13:16:02 alex_xu efried: yes, so I'm thinking we should use virt.get_available_resources reporting the vpmem to the rt, then rt will track the assignement
13:16:41 alex_xu efried: ok, I see you point
13:17:10 alex_xu another problem is we also need some code to handle the rollback like we spawn the instance failed
13:17:36 efried yup, the methods would need to be symmetrical. claim_for_instance/unclaim_for_instance
13:18:32 efried and the virt driver doesn't really need to do anything with the device other than mark it as "used" in whatever way it sees fit.
13:18:54 alex_xu efried: yea, that we can do
13:19:13 alex_xu efried: should we call that claim_for_instance inside rt.instance_claim?
13:19:19 efried totally
13:19:23 efried and resize_claim
13:19:30 alex_xu cool
13:19:35 efried but
13:19:47 efried I think we should probably create this framework outside of the vpmem series
13:19:53 efried and put the vgpu stuff into it
13:20:02 efried and then build the vpmem series on top of that
13:20:15 sean-k-mooney efried: well im not sure that is true in all cacses
13:20:15 alex_xu yea, that makes sense
13:20:17 efried Because we already know the vgpu stuff is "working" (other than the race condition"
13:20:20 efried )
13:20:23 sean-k-mooney that the virt driver does not need to do anything
13:20:32 efried sean-k-mooney: That's the point, though
13:20:39 efried the virt driver gets to decide what all it needs to do
13:20:47 efried the RT cannot (and should not need to) know that.

Earlier   Later