Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-07-08
17:09:02 sean-k-mooney so and not instance.launched_at would be false
17:09:02 mriedem yeah i see what you're saying, and instance.config_drive is only set from the API?
17:09:19 sean-k-mooney i think its set in the flavor or image
17:09:23 sean-k-mooney actully no
17:09:25 sean-k-mooney you are right
17:09:28 sean-k-mooney the api
17:09:43 sean-k-mooney so im thinking about deployment where the metadata service is not deployed
17:10:04 sean-k-mooney so you use force_config_drive=true to make cloud init work and for things like vendor data or device role tagging
17:10:14 sean-k-mooney or file injection with the v2.1 api
17:11:27 sean-k-mooney the last point is less relevent beacue that is depercated so i would be ok with that on master but im not sure we should backport that change and it might break people on upgrade that dont deploy the metadata service
17:11:54 mriedem yeah as i said i wasn't totally comfortable with backporting it
17:12:21 mriedem oh wait
17:12:25 mriedem i remember digging into this
17:12:46 mriedem https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1758
17:13:10 mriedem instance.config_drive will be set on compute if force_config_drive=True and the user doesn't specify it in the api
17:13:30 mriedem so i don't think your scenario holds
17:13:44 mriedem https://review.opendev.org/#/c/659703/4/nova/virt/configdrive.py@169
17:14:32 mriedem so tl;dr, you likely need to recreate whatever regression you think there is and report a bug if we're going to talk about reverting that change
17:14:40 mriedem and i've got a hungry kid here and need to make lunch
17:15:16 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/virt/configdrive.py#L181
17:15:35 sean-k-mooney so if we have already set instace.launched_at then it wont
17:15:58 sean-k-mooney mriedem: sure take care of lunch :)
17:16:34 mriedem on first create, if the host has force_config_drive=True, we'll set instance.config_drive=True, and on subsequent calls to update_instance we won't update it because "if not True" is False
17:16:57 mriedem anyway, like i said, this would be easier if you can actually recreate a problem and report a bug rather than both of us mostly just guessing based on code
17:17:03 mriedem but i did look into this earlier on the patch
17:17:04 sean-k-mooney i think we need to reorder 1757 and 1758 https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1758
17:17:19 sean-k-mooney mriedem: ok no worries
17:17:33 sean-k-mooney i can test this in my devstack setup and see if it causes an issue or not
17:18:17 sean-k-mooney go make food :) ill let you know if i find anything
17:21:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520
17:21:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts https://review.opendev.org/666767
17:35:58 openstackgerrit Merged openstack/nova stable/rocky: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/667355
17:40:24 sean-k-mooney ya so with master if you set force_config_drive=true, then boot a new vm and hard reboot it it will not have the config dirve on teh second boot
17:40:31 sean-k-mooney so that intoduced a new bug
17:41:02 sean-k-mooney which should be fixable by swapping instance.launched_at and configdrive.update_instace here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1758
17:41:12 sean-k-mooney which ill go test now
17:45:57 sean-k-mooney yep that fixes it
17:46:06 sean-k-mooney ill file a bug and push a patch
17:47:05 sean-k-mooney the order didnt matter befoce because required_by did not depend on the launched_at field not it does so we need to set that after
17:47:24 sean-k-mooney ill try these change teh config to diable force and see if ti does the right thing now
17:54:25 sean-k-mooney yep it works corectly after config updte too. old vms keep the config drive an new ones dont have them. and if i go back from false to true old vms dont get a config drive but new vms do
18:30:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520
18:30:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts https://review.opendev.org/666767
18:32:47 spatel sean-k-mooney: one of my vm stuck in powering-on stat so i did
18:32:48 spatel nova reset-state --active 368f2b45-c4b8-460e-9269-023ef80a69d1
18:33:18 spatel now now when i start vm it is saying - Cannot 'start' instance 368f2b45-c4b8-460e-9269-023ef80a69d1 while it is in vm_state active (HTTP 409) (Request-ID: req-29b635ac-4d8f-4139-9170-19824f019806)
18:33:39 mriedem i'm +2 on "Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520" now
18:33:50 sean-k-mooney spatel: you will need to hard reboot it
18:36:28 spatel what is the option for command line to hard-reboot?
18:36:39 spatel let me try from GUI
18:37:12 sean-k-mooney "openstack server reboot --hard" but its available in horizon too
18:42:15 openstackgerrit sean mooney proposed openstack/nova master: libvirt: make config drives sticky bug 1835822 https://review.opendev.org/669738
18:42:16 openstack bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,Confirmed] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney)
18:42:28 sean-k-mooney mriedem: ^ that is the fix for the config drive issue
18:43:26 spatel sean-k-mooney: that works :)_
18:43:34 spatel you are awesome
18:43:55 sean-k-mooney no i just have hit the same proablem
18:44:12 sean-k-mooney if you use reset-state to set it to active you need to use hard-reboot to fix it
19:26:04 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/647671
20:23:38 openstackgerrit Merged openstack/os-vif master: Sync Sphinx requirement https://review.opendev.org/666387
20:34:39 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-lvm: Disable [validation]/run_validation in tempest.conf https://review.opendev.org/662176
20:34:46 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-lvm: Disable [validation]/run_validation in tempest.conf https://review.opendev.org/662176
20:59:52 mriedem oh lyarwood
20:59:57 mriedem wrong location for that variable
21:10:59 sean-k-mooney mriedem: im going to leave it for this evening but any idea why http://paste.openstack.org/show/754180/ would fail on the last assert.
21:11:13 sean-k-mooney it kind of looks like the compute manager code is not running
21:11:30 sean-k-mooney i might move it to the fake libvirt functional tests
21:11:41 sean-k-mooney but i would have expected this to work the the fake driver
21:12:19 mriedem sean-k-mooney: you're not waiting for the server to be ACTIVE for one
21:12:30 mriedem unless this is using the CastAsCall fixtured, but i'd avoid that for new tests if possible
21:12:32 sean-k-mooney ah yes
21:12:37 mriedem you also shouldn't need more than one compute for this test
21:13:31 sean-k-mooney oh ya i know im just using a for because it was quick but i belive it just uses self.compute
21:13:37 sean-k-mooney i will change that
21:13:47 sean-k-mooney but ill try adding teh wait that is proably the issue
21:19:14 sean-k-mooney hum no that does not seam to fix it
21:23:54 sean-k-mooney oh i didnt wait correctly
21:30:24 sean-k-mooney ok ill add the rest of the test cases tommorow but adding self._wait_for_state_change(created_server, 'BUILD') solve my issue thanks
#openstack-nova - 2019-07-09
01:23:07 openstackgerrit Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.opendev.org/612626
01:26:07 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
02:23:25 openstackgerrit Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656
02:52:55 openstackgerrit Qiu Fossen proposed openstack/nova master: Add user_id field to the migrations records https://review.opendev.org/669785
05:19:11 openstackgerrit Merged openstack/nova master: libvirt: manage COMPUTE_STATUS_DISABLED for hypervisor connection https://review.opendev.org/668707
05:57:06 openstackgerrit Boxiang Zhu proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts https://review.opendev.org/666767
06:07:29 openstackgerrit Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.opendev.org/612626
06:26:30 openstackgerrit guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096
07:34:03 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
07:39:52 openstackgerrit Luyao Zhong proposed openstack/nova master: db: Add vpmems to instance_extra https://review.opendev.org/662697
07:39:53 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs https://review.opendev.org/634548
07:50:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955
07:50:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move consts from neutronv2/api to constants module https://review.opendev.org/668945
08:02:26 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates https://review.opendev.org/667952
08:04:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use neutron contants in cmd/manage.py https://review.opendev.org/668946
08:04:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add 'resource_request' to neutronv2/constants https://review.opendev.org/668947
08:04:43 openstackgerrit Balazs Gibizer proposed openstack/nova master: Translatable output strings in heal allocation https://review.opendev.org/668925
08:42:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use the safe get_binding_profile https://review.opendev.org/669817
08:59:41 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Add support for osprofiler in placement wsgi https://review.opendev.org/667832
09:55:57 openstackgerrit Matthew Booth proposed openstack/nova master: Whether to use config drive depends on instance.configdrive https://review.opendev.org/485930
11:43:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955
11:44:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move consts from neutronv2/api to constants module https://review.opendev.org/668945

Earlier   Later