Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-07-04
08:28:33 kashyap lyarwood: If it's not too much can drop it in this change already?
08:28:50 kashyap Just that I have another change built on top of it, trying to reduce rebase churn...
08:30:29 lyarwood kashyap: I'll post it and we can go from there
08:30:38 lyarwood kashyap: it might be larger than your current PS tbh
08:31:02 kashyap Okido, I'll keep an eye.
08:37:21 lyarwood oh and FWIW my change shouldn't impact your series
08:37:35 lyarwood I'll just need to rebase it when you rebase yours etc
08:37:47 lyarwood but it shouldn't cause any conflicts in yours
08:38:17 kashyap Yep, noted
09:20:14 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Stabilize unshelve notification sample tests https://review.opendev.org/669118
09:20:57 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova.virt.libvirt.compat' https://review.opendev.org/669120
09:40:38 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121
09:40:59 lyarwood kashyap / stephenfin ; ^ follow up to the MIN LUKS_VERSION removal change
09:43:24 kashyap Will look; thanks!
09:43:32 kashyap s/!//
09:44:12 openstackgerrit Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
09:45:18 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
09:48:06 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121
09:49:06 kashyap lyarwood: I think you've addressed the things you pointed out in my review in your follow-up, yeah?
09:53:54 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
09:55:40 johnthetubaguy kashyap: will take a look at your spec now ish, been away in bristol for two days
09:56:00 kashyap johnthetubaguy: Ah, I _think_ you alluded to it. Thanks a ton.
09:56:12 kashyap (Sorry for pestering.)
09:56:24 johnthetubaguy pestering is good, helps me remember
09:57:30 lyarwood kashyap: yes
10:00:12 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549
10:00:12 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.opendev.org/634551
10:00:13 openstackgerrit Luyao Zhong proposed openstack/nova master: scheduler: translate vpmems request to placement request group https://review.opendev.org/634553
10:00:14 openstackgerrit Luyao Zhong proposed openstack/nova master: compute: allocate pmem namespaces to instance https://review.opendev.org/662702
10:00:14 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.opendev.org/634555
10:00:14 openstackgerrit Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.opendev.org/634552
10:00:15 openstackgerrit Luyao Zhong proposed openstack/nova master: update migrations_context to support migration with vpmems https://review.opendev.org/662709
10:00:16 openstackgerrit Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.opendev.org/634556
10:00:53 kashyap johnthetubaguy: To help your memory, there's a list of things addressed (based on your feedforward) as note in PS-12
10:01:02 johnthetubaguy kashyap: I meant to ask you about os-info, when using cento7 as os_distro, I seem to get unsupported device errors from libvirt when trying to boot, is that a known thing?
10:01:05 kashyap [It starts with: "Overall, turned the spec a bit "upside down" to reorganize some content:"]
10:01:48 kashyap johnthetubaguy: Hmm, didn't hear that before -- got a full error somewhere?
10:02:33 johnthetubaguy kashyap: not handily, I will let you know and get that into a bug report
10:02:37 kashyap johnthetubaguy: By 'os-info', you mean `osinfo-query`?
10:02:40 johnthetubaguy yeah
10:03:19 johnthetubaguy mostly os-distro flags just have a warning message with no match found... historially bad at setting them correctly, but everything blew up when I tried to "fix" that
10:03:33 johnthetubaguy its an unknown virtio device type I think, but I will get you the details
10:03:35 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove unreachable native QEMU iSCSI initiator config code https://review.opendev.org/668750
10:04:01 lyarwood stephenfin: ^ thanks for the review, I've removed disconnect_volume and addressed the nits in the commit
10:04:33 kashyap johnthetubaguy: Sure, happy to look and check w/ the virtio folks if I don't know
10:05:15 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
10:05:22 openstackgerrit Dirk Mueller proposed openstack/nova stable/queens: Changing scheduler sync event from INFO to DEBUG https://review.opendev.org/669126
10:05:34 openstackgerrit Dirk Mueller proposed openstack/nova stable/pike: Changing scheduler sync event from INFO to DEBUG https://review.opendev.org/669127
10:06:41 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_{QEMU,LIBVIRT}_LUKS_VERSION https://review.opendev.org/668924
10:06:42 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_PERF_VERSION https://review.opendev.org/669128
10:06:42 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove support for Intel CMT `perf` events https://review.opendev.org/669129
10:14:50 openstackgerrit Merged openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.opendev.org/506720
10:15:23 kashyap johnthetubaguy: Thanks!
10:27:44 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121
10:36:10 johnthetubaguy kashyap: "Instance failed to spawn: UnsupportedHardware: Requested hardware 'virtio1.0-net' is not supported by the 'kvm' virt driver"
10:36:41 johnthetubaguy its with os_distro="centos7.0"
10:38:49 kashyap johnthetubaguy: And only with CentOS 7?
10:39:12 johnthetubaguy haven't tried many of the others right now
10:41:05 johnthetubaguy kashyap: I have written it up here for now: https://bugs.launchpad.net/nova/+bug/1835400
10:41:05 openstack Launchpad bug 1835400 in OpenStack Compute (nova) "Issues booting with os_distro=centos7.0" [Undecided,New]
10:41:26 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.opendev.org/580336
10:41:38 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.opendev.org/612949
10:42:03 openstackgerrit Lee Yarwood proposed openstack/nova master: Get rid of args to RBDDriver.__init__() https://review.opendev.org/668564
10:42:21 kashyap johnthetubaguy: I don't see what you mean by "isn't known by 'os-info'". Do you mean this:
10:42:31 kashyap Whe nyou run `osinfo-query os | grep -i centos`, you don't see CentOS listed there at all?
10:42:42 johnthetubaguy correct, only centos7.0
10:43:00 kashyap Ah, it's the exact string match
10:43:59 johnthetubaguy yeah, although we get the "correct" match in the end, thats OK
10:44:05 johnthetubaguy just when it matches it all seems to fail
10:44:26 kashyap Right
10:44:58 kashyap johnthetubaguy: I'll check and report back on the bug
10:46:04 johnthetubaguy kashyap: thanks, I suspect we are meant to just put "virtio" in there? I am not sure though
10:47:21 kashyap johnthetubaguy: So ... was talking to DanPB on #virt, he does indeed say it's a Nova bug:
10:47:48 johnthetubaguy kashyap: I saw this patch: https://github.com/virt-manager/virt-manager/commit/617b92710f50015c5df5f9db15d25de18867957d
10:47:53 johnthetubaguy I guess we could do the same
10:48:00 kashyap 12:45 < danpb1> kashyap: nova is checking is_vif_model_valid_for_virt()
10:48:00 kashyap 12:45 < danpb1> kashyap: and that method has an incomplete list of hardware models
10:48:02 johnthetubaguy I don't mind patching that, if I know what we should do :)
10:48:07 kashyap ^ See above
10:48:11 johnthetubaguy ah...
10:49:48 johnthetubaguy kashyap: do you know where the full list lives? unsure if libvirt does this check
10:51:51 kashyap johnthetubaguy: /me is unsure, too; will check post lunch and get back
10:52:05 johnthetubaguy kashyap: sweet, thank you
11:04:23 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Stabilize unshelve notification sample tests https://review.opendev.org/669118
11:14:24 kashyap johnthetubaguy: Still here?
11:14:27 johnthetubaguy yeah
11:15:35 kashyap johnthetubaguy: So Dan tells me there are two issues here.
11:16:28 kashyap 1. Nova's validation of n/w models is incomplete
11:16:51 kashyap 2. The "model names returned by libosinfo are *NOT* required to be valid libvirt network model names".
11:17:21 kashyap On point 2, there is no such "virtio-1.0-net" model name in libvirt, if we see here: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/conf/domain_conf.c#l515
11:17:29 johnthetubaguy yeah, it was (2) I was suspecting, given this: https://github.com/virt-manager/virt-manager/commit/617b92710f50015c5df5f9db15d25de18867957d
11:17:42 kashyap Apparently libosinfo is just telling us that the guest supports 'virio-1.0-net'
11:18:04 kashyap And there are two ways to provide that: https://libvirt.org/formatdomain.html#elementsVirtioTransitional
11:18:18 kashyap The "virtio-transitional" vs. "virtio-non-transitional" devices.
11:19:01 kashyap Where "virtio-transitional" provides a device that will auto-negotiate virtio 1.0 support; while "virtio-non-transitional" provoides a device that is fixed to always use virtio 1.0 support.
11:19:38 johnthetubaguy and "virtio" what does that do?
11:20:35 johnthetubaguy thinking ln520 in libvirt... I am wondering what we should do here
11:20:55 johnthetubaguy seems like (1) doesn't matter, the issue is our os-info logic seems totally bogus
11:21:03 kashyap johnthetubaguy: On 'virtio':
11:21:04 kashyap virtio

Earlier   Later