Posted	Nick	Remark
#openstack-nova - 2019-06-28
02:32:39	sean-k-mooney	we might decide that is ok but if we can sanely clean up that would be nice to do
02:38:32	yonglihe	we might need to add power_off_unknow in case admin want to keep them for investigating.
02:40:11	sean-k-mooney	yes i think that would be fine and in that case no cleanup is needed
02:47:29	yonglihe	I gonna add them both.
03:45:39	openstackgerrit	sean mooney proposed openstack/nova master: [WIP] Libvirt: report storage bus traits https://review.opendev.org/666914
03:45:40	openstackgerrit	sean mooney proposed openstack/nova master: [WIP] use domain capablites to get supported device models https://review.opendev.org/666915
03:45:40	openstackgerrit	sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
04:09:43	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Fix test_flavors to run with correct microversion https://review.opendev.org/666536
04:10:13	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add missing tests for flavor extra_specs mv 2.61 https://review.opendev.org/667600
04:10:30	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
05:39:53	openstackgerrit	Merged openstack/nova master: Fix test_flavors to run with correct microversion https://review.opendev.org/666536
06:51:10	gmann	efried: can you re-approve this. it was rebased - https://review.opendev.org/#/c/667600/4
07:03:20	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
07:49:45	kashyap	lyarwood: Morning; stable/stein has merged, if you want to ACK its stable/rocky counterpart: https://review.opendev.org/#/c/667436/1
08:00:38	lyarwood	kashyap: the same rules apply to stable as master fwiw so I can't just +2+W this, I'll recheck and leave it to others to +W.
08:01:40	kashyap	lyarwood: Okay, thought I was under the illusion that johnthetubaguy had also ACKed the stable/rocky one
08:03:02	lyarwood	kashyap: I think that was a different one no?
08:03:38	kashyap	lyarwood: Which one was it? Strangely I recall there were 2 ACKs from John on this same change
08:03:49	kashyap	Maybe he ACKed the Git/master one and I confused with it; /me goes to look
08:04:17	kashyap	(No, never mind; I'll chalk it up to poor memory)
08:06:05	kashyap	I find it dispiriting that even for multiple backports there's more burden of getting *two* "ACKs" from separate companies.
08:07:49	openstackgerrit	Kashyap Chamarthy proposed openstack/nova stable/queens: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/668111
09:07:49	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/668118
09:08:10	openstackgerrit	Lee Yarwood proposed openstack/nova stable/rocky: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/668119
09:22:29	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/668123
09:30:25	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: DNM - Test rbd unshelve fix on stable stein https://review.opendev.org/668126
09:43:48	openstackgerrit	zhufl proposed openstack/nova master: Fix invalid assertIsNone states https://review.opendev.org/668132
10:36:44	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Add flavor group https://review.opendev.org/663563
10:38:00	openstackgerrit	Merged openstack/python-novaclient stable/rocky: Use SHA256 instead of MD5 in completion cache https://review.opendev.org/664025
10:45:26	openstackgerrit	Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497
11:03:19	openstackgerrit	Lee Yarwood proposed openstack/nova stable/rocky: DNM - Test rbd unshelve fix on stable rocky https://review.opendev.org/668141
11:06:49	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: DNM - Test rbd unshelve fix on stable queens https://review.opendev.org/668142
11:21:29	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660363
11:21:30	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/668123
11:21:30	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: DNM - Test rbd unshelve fix on stable queens https://review.opendev.org/668142
12:17:09	efried	gmann: done
13:04:31	openstackgerrit	Merged openstack/nova master: Fix invalid assertIsNone states https://review.opendev.org/668132
13:26:48	kashyap	johnthetubaguy: Can you please put this stable/rocky backport through? https://review.opendev.org/#/c/667436/
13:26:58	kashyap	johnthetubaguy: You've ACKed the stable/stein one
13:27:11	kashyap	(And this, stable/rocky version, already has one +2)
13:27:31	kashyap	Or anyone else, if John is not around
13:32:13	KeithMnemonic	is there anyone here that is maintaining or familiar with https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/ds_util.py
13:33:31	kashyap	KeithMnemonic: Your best bet is GKotton (who is not here on IRC)
13:34:04	efried	mriedem, dansmith: placement agg sync is automatic now, right? No need to run nova-manage placement sync-aggregates? https://review.opendev.org/#/c/667952/1/doc/source/reference/forbidden-aggregates.rst@44
13:34:16	kashyap	KeithMnemonic: You might want to try his e-mail (gkotton@vmware.com).
13:34:36	dansmith	efried: yeah, the manage sync is for fixup and upgrades at this point I think
13:34:37	kashyap	[And of course, Cc the list, so others could learn, too.]
13:34:45	efried	thanks dansmith
13:35:32	KeithMnemonic	yes i was looking for him, we know each other so hopefully i can find him next week
13:35:43	KeithMnemonic	thanks kashyap
13:36:14	kashyap	KeithMnemonic: By "the list" I meant: openstack-discuss@lists.openstack.org
13:36:20	mriedem	efried: right what dan said,
13:36:32	mriedem	except if the api fails to remove a provider from an aggregate, sync_aggregates won't fix that
13:36:42	mriedem	sync_aggregates is only additive
13:36:53	KeithMnemonic	ok, i thought you meant wait for him to show up back here. i will send an email today
13:38:02	efried	also, mriedem, /me Remind / ping / harass re https://review.opendev.org/662881 (sdk spec)
13:39:26	mriedem	d'oh!
13:39:39	mriedem	can i hit snooze on that until after i take my kid to camp?
13:39:57	efried	of course. I can hit you up hourly
13:40:20	dansmith	cron
13:40:34	dansmith	it's they only way he'll learn.
13:46:57	openstackgerrit	Merged openstack/nova master: Add missing tests for flavor extra_specs mv 2.61 https://review.opendev.org/667600
14:08:28	efried	ugh, do we not have `openstack resource provider trait add` ?
14:24:29	mriedem	efried: https://docs.openstack.org/osc-placement/latest/cli/index.html#trait-create
14:24:46	mriedem	osc verbs are create/set/unset/delete/list
14:24:52	mriedem	and /show
14:25:06	efried	Right, I mean "add this trait to resource provider X without fing with any of its existing traits"
14:25:22	efried	so I don't have to do trait list + add to that + trait set
14:25:32	mriedem	oh, yeah we have a few gaps in ux like that in osc-placement
14:25:50	mriedem	it's annoying, especially for things like adding inventory with a new resource class to a provider or allocations
14:26:00	efried	meanwhile, how tf do I get a compute node UUID?
14:26:13	mriedem	openstack --os-compute-api-version 2.53 hypervisor list
14:26:35	efried	by name?
14:26:52	efried	got it
14:26:53	efried	phew
14:26:54	mriedem	--matching <hostname>
14:26:54	mriedem	https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/hypervisor.html#hypervisor-list
14:27:55	efried	openstack --os-compute-api-version 2.53 hypervisor show my-compute-name -f value -c id
14:27:56	efried	?
14:28:20	mriedem	to get the id, probably -c ID
14:28:46	mriedem	node_uuid=$(openstack --os-compute-api-version 2.53 hypervisor show <hostname> -f value -c ID)
14:29:03	efried	`ID` wasn't working for me, but `id` does.
14:29:06	mriedem	i'm not totally sure osc is working with 2.53 everywhere yet
14:29:09	mriedem	ah ok
14:29:19	mriedem	i've noticed some inconsistencies with ID vs id in osc
14:29:24	efried	yeah, totally
14:29:26	mriedem	for image nad server it's ID i think
14:29:37	openstackgerrit	Balazs Gibizer proposed openstack/nova master: WIP: Add rollback to heal port allocation https://review.opendev.org/668184
14:29:39	mriedem	open a story bug
14:30:28	gibi	mriedem, efried: I hacked up the rollback code for heal port allocation. https://review.opendev.org/668184 Based on the code I feel I'm just pushing the human-interaction-needed problem one level deeper, when the rollback fails
14:30:33	mriedem	efried: there is a story for the trait append thing https://storyboard.openstack.org/#!/story/2005258
14:30:40	mriedem	i knew it sounded familiar....
14:30:47	efried	thanks
14:33:30	mriedem	gibi: i left some comments,
14:34:13	mriedem	but i haven't fully thought through which is worse - the port with the binding:profile.allocation set to something when the allocation doesn't exist in neutron vs the allocation existing in neutron but the port binding profile not mapped to that provider
14:34:26	mriedem	*doesn't exist in placement
14:35:42	gibi	mriedem: if the rollback retry fails the is it OK to ask for the human to help?
14:35:57	gibi	I feel at the end we need the human anyhow
14:37:55	gibi	if we set the allocation key in neutron without having the allocation placemen then we tell neutron to use a resource that is not really allocated. But the physical bandwidth anyhow was used even before we started to heal
14:38:27	mriedem	so the risk there is over-committing the resource right?

Earlier   Later