Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-27
13:44:37 mriedem ok this has been a useful discussion before i dive in
13:44:39 mriedem thanks
13:45:06 gibi mriedem: yes, rollback is one option. I went for just printing what failed and how to update neutron manually
13:46:05 gibi mriedem: if you think rollback is better then I have to temprarly store the original allocation of the instance before the heal, and put that back if neutron update fails
13:50:05 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
13:51:14 mriedem we could also retry the port updates with a backoff loop, like 3 retries or something if it's a temporary network issue
13:51:19 mriedem could be follow ups though
13:51:35 mriedem i'll keep it in mind when i review and leave a comment
13:54:42 gibi mriedem: ack
14:02:36 mriedem nova meeting happening
14:10:21 mriedem gibi: also in the back of my mind i've been thinking of adding something to the nova-next job post_test_hook, like creating a server, deleting it's allocatoins in placement and then running heal_allocations just to make sure we have integration test coverage as well, but it's lower priority
14:11:22 gibi mriedem: I did similar manual testing for my patch in devstack and discovered bugs. So I agree that it would be useful
14:20:27 jrosser guilhermesp: this lot https://review.opendev.org/#/q/topic:fix-octavia+(status:open+OR+status:merged)
14:20:54 jrosser guilhermesp: there are some jobs running with some depends-on, but it's difficult to see whats going on
14:21:34 jrosser oops -ECHAN
14:50:10 openstackgerrit Surya Seetharaman proposed openstack/nova stable/stein: Grab fresh power state info from the driver https://review.opendev.org/667948
14:54:35 mriedem http://status.openstack.org/reviews/#nova sure is fun for abandon fodder
14:55:05 openstackgerrit Vrushali Kamde proposed openstack/nova master: Support filtering of hosts by forbidden aggregates https://review.opendev.org/667952
14:58:33 efried abandon away
15:09:07 openstackgerrit Surya Seetharaman proposed openstack/nova stable/rocky: Grab fresh power state info from the driver https://review.opendev.org/667955
15:24:55 openstackgerrit Matt Riedemann proposed openstack/nova master: RT: replace _instance_in_resize_state with _is_trackable_migration https://review.opendev.org/560467
15:25:18 mriedem efried: another rebase on that one ^
15:25:39 mriedem dansmith: can you come back on this instance.hidden patch https://review.opendev.org/#/c/631123/ ?
15:26:06 dansmith <insert hidden pun here>
15:26:13 mriedem dansmith.hidden = True
15:27:40 efried mriedem: I can't even see where the conflict was on that one.
15:28:46 efried oh, never mind
15:30:52 dansmith mriedem: is the hidden check in the api really required? aren't you filtering out hidden instances from the list query?
15:31:35 mriedem dansmith: i'd have to look again to confirm but i believe there is a window where both are not hidden
15:31:38 mriedem while swapping over
15:31:50 mriedem which,
15:31:52 dansmith mriedem: in that case, the check for hidden-ness doesn't help right?
15:32:00 mriedem arguably the api will still filter - it might pick the "wrong" one but...
15:32:13 mriedem the comment in there mentions something about that right? updated_at and such
15:32:14 dansmith right, but the check of the hidden field would be pointless in that case
15:32:56 dansmith the comment is talking about the case where they're both not hidden
15:33:10 dansmith I'm talking about the case where one is.. what's the point of checking it if instance_list doesn't return them?
15:34:14 mriedem ok so this is the point where we could have 2 copies where hidden=False https://review.opendev.org/#/c/635646/32/nova/conductor/tasks/cross_cell_migrate.py@593 so the DB API would return both from each cell while listing
15:34:37 mriedem now that DB API isn't returning hidden=True by default...
15:34:42 dansmith ...and so checking for instance.hidden in compute/api does what?
15:35:58 mriedem yeah in this case now b/c db api won't return the hidden one, "or instance.hidden" will always be false
15:36:06 dansmith right
15:36:22 mriedem the note above still applies, but the logical or doesn't
15:36:42 mriedem so are you ok with removing the or condition and leaving the comment?
15:37:02 dansmith yep, just said that in the review
15:37:33 mriedem yup, thanks
15:48:24 openstackgerrit melanie witt proposed openstack/nova master: Require at least cryptography>=2.7 https://review.opendev.org/667765
16:09:17 mriedem dansmith: i'm going to drop https://review.opendev.org/#/c/631123/34/nova/tests/unit/compute/test_compute_api.py then since it's not really valid since the db api wouldn't return a hidden=True instance
16:09:27 dansmith yeah
16:13:42 openstackgerrit Miguel Ángel Herranz Trillo proposed openstack/nova master: Add support for 'initenv' elements https://review.opendev.org/667975
16:13:42 openstackgerrit Miguel Ángel Herranz Trillo proposed openstack/nova master: Add support for cloud-init on LXC instances https://review.opendev.org/667976
16:15:40 mriedem looks like someone is trying to make libvirt+lxc work again
16:16:33 openstackgerrit Miguel Ángel Herranz Trillo proposed openstack/nova master: Add support for cloud-init on LXC instances https://review.opendev.org/667976
16:21:24 openstackgerrit Merged openstack/nova-specs master: support virtual persistent memory https://review.opendev.org/601596
16:30:48 efried mriedem: At some point recently you wrote a functional test that used a weigher to prefer host1 so that the assertion that we landed on host2 was provably valid every time (instead of just by chance). Can you put your finger on that easily?
16:31:30 mriedem efried: look for HostNameWeigher in the nova/tests/functional
16:31:32 mriedem there are several examples
16:31:39 efried thanks
16:31:54 mriedem ima push this big ass series b/c i've been rebasing it locally for weeks and want to flush it
16:33:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
16:33:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
16:33:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
16:33:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
16:33:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
16:33:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
16:33:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
16:33:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
16:33:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
16:33:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
16:33:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
16:33:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
16:33:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
16:33:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
16:33:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
16:33:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
16:33:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
16:33:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
16:33:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
16:33:40 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
17:00:02 efried Anyone know artom's status?
17:00:15 efried seemed like he was traveling recently
17:02:49 mnaser efried: i think i remember seeing his nick with some timezone appended to it
17:03:25 efried yeah, I recall that too, GMT+3 or something. But I wasn't sure where he was or whether he was going to be afk for some amount of time
17:03:28 tbachman p!spy artom
17:03:29 tbachman oops
17:03:31 tbachman lol
17:04:04 efried worst spy ever
17:04:08 tbachman lol
17:04:09 edleafe efried: https://leafe.com/timeline/%23openstack-nova/2019-06-27T08:57:05
17:04:15 tbachman purplerbot: log at http://p.anticdent.org/logs/artom
17:04:19 dansmith efried: he's on GMT+3
17:04:56 efried oh, so he's around, just out "early" (relative to me). Cool.
17:05:02 dansmith yar
17:26:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add integration testing for heal_allocations https://review.opendev.org/667994
17:35:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add integration testing for heal_allocations https://review.opendev.org/667994
17:50:13 openstackgerrit Merged openstack/nova master: Remove global state from the FakeDriver https://review.opendev.org/656709
17:50:23 openstackgerrit Merged openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552
18:43:07 openstackgerrit Merged openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886
19:47:56 openstackgerrit Merged openstack/nova master: reorder conditions in _heal_allocations_for_instance https://review.opendev.org/655458
21:33:45 openstackgerrit Merged openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.opendev.org/637954

Earlier   Later