Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-25
15:15:14 sean-k-mooney i have no issue reading "Woak up. Got dresd. Had brekfast. Spoke wif Ergates thi ant who sed itz juss been wurk wurk wurk 4 u lately master Bascule, Y dont u ½ a holiday? & I agreed & that woz how we decided we otter go 2 c Mr Zoliparia in thi I-ball ov thi gargoyle Rosbrith. "
15:19:32 efried mriedem: would you please give this a quick look for sanity https://review.opendev.org/655985 before I invest in test?
15:23:09 artom|gmtplus3 sean-k-mooney, your brain is weird, I can barely parse that
15:29:08 sean-k-mooney artom|gmtplus3: "Woke up. Got dressed. Had breakfast. spoke with Ergates the ant, who said, it's just been work work work for you lately master Bascule, why dont you have a holiday? And i aggred, an that was how we decied we ought to go to see Mr Zoliparia in the eye ball of the gargoyle Rosbrith." :)
15:29:49 artom|gmtplus3 sean-k-mooney, aha, thi = the didn't register at all
15:29:59 artom|gmtplus3 I was thinking "thy", the old English possessive
15:30:39 sean-k-mooney o/
15:34:36 mriedem efried: comments inline
15:42:52 openstackgerrit Matt Riedemann proposed openstack/nova master: (Re-)enable vnc console tests in nova-multi-cell job https://review.opendev.org/667388
15:51:11 openstackgerrit Kashyap Chamarthy proposed openstack/nova stable/stein: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/667389
16:09:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667396
16:09:30 openstack bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)
16:09:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857
16:09:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667397
16:11:03 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552
16:11:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172 https://review.opendev.org/512553
16:11:25 openstack bug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/1724172
16:12:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667396
16:12:07 openstack bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)
16:13:56 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164
16:13:56 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165
16:14:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857
16:16:31 stephenfin dansmith: Want to take another look through this? https://review.opendev.org/#/c/666629/
16:29:53 dansmith stephenfin: will in a bit
16:30:00 stephenfin no rush
16:31:00 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove no longer required "inner" methods. https://review.opendev.org/655282
16:31:00 openstackgerrit Stephen Finucane proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431
16:31:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.opendev.org/635433
16:31:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Privsep the ebtables modification code. https://review.opendev.org/635435
16:31:02 openstackgerrit Stephen Finucane proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436
16:31:02 openstackgerrit Stephen Finucane proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508
16:31:03 openstackgerrit Stephen Finucane proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280
16:31:03 openstackgerrit Stephen Finucane proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281
16:31:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282
16:31:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283
16:31:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580
16:31:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581
16:31:06 openstackgerrit Stephen Finucane proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438
16:31:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826
16:33:21 efried thanks mriedem
16:41:35 mriedem efried: how do you feel about having a mini personal goal of making https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L985-L997 obsolete for in-tree drivers so we could deprecate or remove it in Train - out of tree drivers could be hit so if we wanted to be nice we'd just log a deprecation warning in T and remove in U
16:41:47 mriedem the only in-tree drivers that would hit those paths are xenapi and hyperv,
16:41:53 mriedem the former implements get_inventory,
16:41:59 mriedem the latter implements neither get_inventory or upt
16:43:27 mriedem oh looky here the hyperv out of tree driver has upt implemented https://opendev.org/openstack/compute-hyperv/src/branch/master/compute_hyperv/nova/driver.py#L464
16:44:49 efried mriedem: I'm big in favor of this. At some point I looked into doing it myself, but it (possibly hyperv) was going to be hairier than I was ready to deal with at that time.
16:46:17 efried mriedem: by "personal" you mean me or you? :P
16:46:45 efried stephenfin: I should wait to re-look at rootwrap series, yes?
16:47:14 mriedem efried: as in something we call each other about late on a friday night to talk about yes
16:47:16 efried stephenfin: The 'done' on the ipv4 patch is still forthcoming?
16:47:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix update_provider_tree signature in reference docs https://review.opendev.org/667408
16:47:21 stephenfin efried: 2 secs
16:47:31 efried mriedem: ack, I like it.
16:48:08 stephenfin Actually, I want to test this more so I'll leave it til the morning
16:48:46 stephenfin efried: Sort of. I'm going to drop the first patch and then address the open TODOs in the remainder. If you want to take a look at any you haven't reviewed yet though, that could be helpful
16:49:38 efried something weird just happened
16:50:04 stephenfin Ohh, that's interesting
16:50:18 stephenfin I Ctrl + C'd git-review during the upload once I realized I'd more work to do
16:50:40 efried bot didn't notify, and when I look at the review it seems... corrupted.
16:51:23 efried the series isn't showing up on the right
16:51:32 stephenfin Feck it, I'll push it again just to fix that
16:51:46 openstackgerrit Stephen Finucane proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431
16:51:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.opendev.org/635433
16:51:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Privsep the ebtables modification code. https://review.opendev.org/635435
16:51:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436
16:51:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508
16:51:49 openstackgerrit Stephen Finucane proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280
16:51:49 openstackgerrit Stephen Finucane proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281
16:51:50 openstackgerrit Stephen Finucane proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282
16:51:50 openstackgerrit Stephen Finucane proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283
16:51:51 openstackgerrit Stephen Finucane proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580
16:51:51 openstackgerrit Stephen Finucane proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581
16:51:52 openstackgerrit Stephen Finucane proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438
16:51:52 openstackgerrit Stephen Finucane proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826
16:53:06 efried that seems to have worked.
16:53:10 stephenfin Indeed
16:53:12 stephenfin and with that
16:53:20 efried why did you drop the bottom patch?
16:53:21 sean-k-mooney thats strang it should not have currpted it
16:53:52 stephenfin efried: It seemed like you didn't want it https://review.opendev.org/#/c/655282/
16:54:10 efried stephenfin: just one piece of it. The rest was good.
16:54:19 efried anyway, can do it elsewhere in the series
16:54:23 stephenfin Ah, then I can come back and stick that back in higher up in the series
16:54:31 efried ++ thanks stephenfin
17:11:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement update_provider_tree https://review.opendev.org/667417
17:24:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Clean up test_virtapi https://review.opendev.org/667419
17:44:27 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP libvirt: Add rbd_connect_timeout configurable https://review.opendev.org/667421
18:05:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
18:29:29 openstackgerrit Matt Riedemann proposed openstack/nova master: xenapi: implement update_provider_tree https://review.opendev.org/667435
18:32:06 openstackgerrit Matt Riedemann proposed openstack/nova master: xenapi: implement update_provider_tree https://review.opendev.org/667435
18:39:06 openstackgerrit Kashyap Chamarthy proposed openstack/nova stable/rocky: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/667436
18:54:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate non-update_provider_tree compat code https://review.opendev.org/667442
18:55:40 mriedem efried: thoughts on only logging the warning on startup in ^ or every update_available_resource periodic?
18:55:58 mriedem the latter would be really chatty, but maybe that's the level of annoying we want
19:11:46 NewBruce evening all! mriedem have you seen this issue before mate?
19:11:46 NewBruce 2019-06-25 20:47:45.167 166805 INFO nova.compute.manager [req-bda9173a-31ed-447f-bf57-3ad85c565141 - - - - -] [instance: 5123fa51-512f-4f13-ae4b-5bbc7dd64e94] Migrating instance to cc-compute25-sto2 finished successfully.
19:11:46 NewBruce 2019-06-25 20:47:45.302 166805 WARNING nova.virt.libvirt.driver [req-bda9173a-31ed-447f-bf57-3ad85c565141 - - - - -] [instance: 5123fa51-512f-4f13-ae4b-5bbc7dd64e94] Error monitoring migration: Compute host cc-compute04-sto2 could not be found.: ComputeHostNotFound: Compute host cc-compute04-sto2 could not be found.
19:12:04 NewBruce got me stumped…. and why always me and migration issues? :)
19:12:31 NewBruce the instance is migrated, but is left in status ERROR
19:21:34 NewBruce Not sure if its related, but the source node is throwing this error… a lot

Earlier   Later