| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-21 | |||
| 10:34:52 | sean-k-mooney | for libvirt | |
| 10:34:58 | sean-k-mooney | i think its currently at 3.0.0 | |
| 10:35:10 | stephenfin | Yeah, it is. That's why I just updated the docstring for one | |
| 10:36:01 | sean-k-mooney | oh sorry you fix the todo below that | |
| 10:36:06 | stephenfin | yup | |
| 10:36:52 | sean-k-mooney | do we set the vlan in the libvirt xml | |
| 10:37:24 | sean-k-mooney | as libvirt will only do that if we do | |
| 10:38:58 | sean-k-mooney | ok i think we do | |
| 10:39:17 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L352-L354 | |
| 10:40:12 | sean-k-mooney | ya we should be setting it here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/designer.py#L116 | |
| 10:47:39 | stephenfin | okay, I really don't like using the dict lookup. I know it's slightly faster but it feel out of place in that file, given the amount of if-elses we have | |
| 10:48:00 | stephenfin | I have dragged the legacy VIFs out to their own variable though and used sets instead of tuples for 'in' lookups | |
| 10:48:15 | sean-k-mooney | ok | |
| 10:48:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630 | |
| 10:48:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631 | |
| 10:49:20 | sean-k-mooney | when we were using getattr before it was a dict lookup which is why i wanted to keep it that way | |
| 10:50:19 | stephenfin | Understandable. I think the additional clarity is worth the small cost though | |
| 10:56:32 | sean-k-mooney | stephenfin: will you get around to rebaseing https://review.opendev.org/#/c/663382/ soon or will i do it? | |
| 10:56:53 | stephenfin | oh, forgot about that. I'll do that today, yeah | |
| 10:57:50 | sean-k-mooney | ok i was talking to a partner about it yesterday so the sooner it lands upstream the sooner we can backport and the sooner they will be happy | |
| 10:58:52 | sean-k-mooney | ok im actuly goint ot go lie down now for a bit ill be back in a few hours | |
| 11:01:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Remove dead minimum libvirt checks https://review.opendev.org/666814 | |
| 11:05:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630 | |
| 11:05:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631 | |
| 11:05:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Remove dead minimum libvirt checks https://review.opendev.org/666814 | |
| 11:06:24 | openstackgerrit | Merged openstack/os-traits master: Sync Sphinx requirement https://review.opendev.org/666386 | |
| 11:13:00 | jangutter | stephenfin: coincidentally, that piece of getattr code is one of the first bits of python code that made me go "wow, you can do that, that's awesome!" | |
| 11:13:44 | jangutter | stephenfin: and also makes the code un-greppable, meaning even though it's cool code, I'm ++ in taking it out. | |
| 11:29:47 | stephenfin | jangutter: Exact same thing here, fwiw :) | |
| 11:30:01 | stephenfin | there are some other extraneous uses of getattr that I'll root out over time | |
| 11:32:00 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 11:32:01 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add |
|
| 11:32:01 | openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | |
| 11:32:02 | openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | |
| 11:37:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | |
| 11:37:25 | stephenfin | sean-k-mooney: I'm going to need a functional test for ^ | |
| 11:37:32 | stephenfin | The initial version of the fix was totally wrong /o\ | |
| 11:59:19 | tssurya | The novaclient CI seems unhappy when running the openstack-tox-docs job (http://logs.openstack.org/92/666792/1/check/openstack-tox-docs/04b52fb/job-output.txt.gz#_2019-06-21_09_04_06_646600) | |
| 11:59:50 | tssurya | is there a bug reported already or should I open one | |
| 13:36:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-guide: better explain scheduler hints. https://review.opendev.org/522106 | |
| 13:36:43 | mriedem | gibi: easy docs change that you would probably be good for ^ | |
| 13:36:49 | mriedem | i'm already +2 | |
| 13:37:14 | mriedem | note that change is from nov 2017... | |
| 13:42:02 | bauzas | mriedem: +Wipped | |
| 13:42:15 | bauzas | easy peasy enough | |
| 13:42:48 | bauzas | FWIW, still working on providing the placement audit command | |
| 13:43:18 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | |
| 13:43:19 | openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | |
| 13:43:19 | openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | |
| 13:43:45 | dansmith | bauzas: allow me to provide some english help | |
| 13:43:54 | dansmith | bauzas: something is not "easy peasy" *enough* | |
| 13:44:02 | bauzas | :) | |
| 13:44:10 | dansmith | it's either peasy or not peasy, there is no gray area or gradient of peasiness | |
| 13:45:00 | bauzas | dansmith: but but... https://context.reverso.net/traduction/anglais-francais/peasy | |
| 13:45:17 | stephenfin | mriedem: What do you think I should log here? https://review.opendev.org/#/c/666630/5/nova/network/os_vif_util.py@535 Just "something bad happened" or maybe nothing at all? | |
| 13:45:43 | stephenfin | (Asking you since you've been involved in the earlier patches for both) | |
| 13:46:42 | mriedem | bauzas: easy peasy is fine | |
| 13:46:44 | mriedem | easy enough is fine | |
| 13:46:52 | dansmith | bauzas: exactly.. all of those examples are 100% peasy, right? no fractional peasiness | |
| 13:47:02 | mriedem | but easy peasy enough is something that will cause a shared american/french tree of friendship to whither and die | |
| 13:47:02 | dansmith | ^^ this man speaks the truth | |
| 13:47:09 | dansmith | lol | |
| 13:47:11 | bauzas | lol | |
| 13:47:29 | bauzas | gotcha | |
| 13:47:43 | bauzas | so, either "easy peasy" or "peasy enough" | |
| 13:47:46 | dansmith | yes. | |
| 13:47:49 | dansmith | no | |
| 13:47:54 | dansmith | easy peasy, or easy enough | |
| 13:47:57 | dansmith | not peasy enough | |
| 13:48:00 | bauzas | haha | |
| 13:48:09 | dansmith | gah | |
| 13:48:36 | mriedem | stephenfin: it's the same thing as you'd get before for those vif types so meh | |
| 13:48:49 | bauzas | FWIW https://www.thelocal.fr/20141112/france-has-lowest-english-proficiency-in-eu | |
| 13:49:16 | bauzas | and again now actually https://www.thelocal.fr/20181108/french-ranked-worst-in-western-europe-for-speaking-english | |
| 13:49:34 | mriedem | there is also a rapper named "young jeezy" if that helps | |
| 13:52:22 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Delete resource providers for all nodes when deleting compute service https://review.opendev.org/666840 | |
| 13:53:46 | mnaser | did we get rid of the nova-network api bits? | |
| 13:54:08 | mnaser | i just had a really confused user checking their quota and asking why the security groups listed in osc didn't match horizon (it was getting the nova-network value) | |
| 13:55:24 | stephenfin | cool | |
| 13:55:25 | mnaser | https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/doc/source/admin/quotas.rst | |
| 13:55:28 | mnaser | this needs to be scrubbed i guess | |
| 13:57:18 | aspiers | stephenfin: thanks, please abandon https://review.opendev.org/#/c/662557/ too | |
| 14:00:09 | stephenfin | aspiers: done | |
| 14:00:14 | aspiers | ta! | |
| 14:00:34 | melwitt | gibi: ack, thanks! | |
| 14:29:33 | mriedem | mnaser: i believe there is a microversion that drops the nova-network related quota stuff from that api | |
| 14:29:53 | mnaser | mriedem: there is, i confirmed it that using the `nova` command did indeed not show them | |
| 14:29:54 | mriedem | if they are using the openstack cli, that defaults to 2.1 so they'd see those old values | |
| 14:30:02 | mnaser | so i guess this is the whole osc uses oldest microversion thing | |
| 14:30:05 | mnaser | ++ | |
| 14:33:00 | mriedem | mnaser: yeah https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/quota.html#quota-show mentions 2.50 for server group quota class but nothing about 2.56, or that in 2.50 the network quota class stuff was removed | |
| 14:33:05 | mriedem | it's all very confusing | |
| 14:33:56 | mriedem | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/quota.html#quota-list could probably be updated to mention that for --compute quotas, certain minimum microversions can be used to filter out no-longer-applicable proxy/network resource quotas | |
| 14:34:06 | mriedem | i don't know if that is more or less confusing for users | |
| 14:41:57 | mriedem | anyway, i added some notes for 2.36 to https://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc | |
| 14:44:30 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Delete resource providers for all nodes when deleting compute service https://review.opendev.org/666854 | |
| 14:54:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | |
| 15:06:28 | efried | Hi folks, I'm going to take the day off today. | |
| 15:09:04 | sean-k-mooney | efried_pto: enjoy o/ | |
| 15:10:26 | sean-k-mooney | stephenfin: ok ill re review https://review.opendev.org/#/c/663382/ | |