Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-21
02:34:08 sean-k-mooney i really dont mind too much either way but i just tought it might be simpler in the long run if we started with them seperate
02:34:24 sean-k-mooney but its not a point im really going to rathole on
02:35:06 yonglihe mriedem: HI.
02:42:13 sean-k-mooney yonglihe: while its less of an insane time of mriedem then me its still well after 22:40 for him so he wont be around for about 8-10 hours
02:51:49 alex_xu sean-k-mooney: ok, I see
02:54:49 alex_xu sean-k-mooney: another concern is people is asking us for a simple version for now, I'm afraid to people feel we add more in the current propsoal. actually, I don't have a preference also, happy to do the thing people like one
02:56:17 sean-k-mooney alex_xu: ya i know its frustrating that placments lack of support for numa has been holding back feature like this for 3 or 4 releases
02:57:02 sean-k-mooney we are cripleing the feature to make it simpeler because of the lack fo placmenent freature which created techdebt that need to fix next cycle
02:57:28 alex_xu sean-k-mooney: yea, agree with that
02:57:36 sean-k-mooney but doing it properly this cycle create tech debt when placement finally does support numa
02:57:37 alex_xu I understand your point
03:04:32 openstackgerrit sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
03:54:53 openstackgerrit Boxiang Zhu proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts https://review.opendev.org/666767
04:22:39 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383
04:22:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.opendev.org/637716
04:29:49 openstackgerrit karim proposed openstack/nova-specs master: Support VM memory encryption using Intel's MKTME https://review.opendev.org/666769
07:48:33 openstackgerrit huichen proposed openstack/nova stable/queens: Suppot paginaton for server groups by sql https://review.opendev.org/666782
07:57:31 openstackgerrit Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796
08:07:04 kashyap efried: Heya, fully agreed, on jroll's spec for _physical_ TPM passthrough. Maybe I misphrased...
08:11:03 openstackgerrit Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796
08:22:08 openstackgerrit Merged openstack/nova master: Delete resource providers for all nodes when deleting compute service https://review.opendev.org/657016
08:32:42 openstackgerrit Merged openstack/nova master: Avoid unnecessary joins in delete_resource_provider https://review.opendev.org/657021
08:35:59 openstackgerrit Bence Romsics proposed openstack/os-vif master: Insert osprofiler trace info as external_ids to the bridge table https://review.opendev.org/665715
08:39:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove global state from the FakeDriver https://review.opendev.org/656709
08:43:30 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.74: Add 'power-update' external event https://review.opendev.org/645611
08:46:35 gibi melwitt: commented https://review.opendev.org/#/c/631294 I don't know if my suggestion would lead to a simpler test or not. :/
08:54:43 openstackgerrit Surya Seetharaman proposed openstack/python-novaclient master: API microversion 2.74: Add 'power-update' external event https://review.opendev.org/666792
09:06:02 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
09:06:02 openstackgerrit Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555
09:06:03 openstackgerrit Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556
09:06:03 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
09:06:04 openstackgerrit Adam Spiers proposed openstack/nova master: Add and to AMD SEV guest configs https://review.opendev.org/636318
09:06:04 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
09:06:05 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
09:36:59 openstackgerrit sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
09:40:21 cdent It's interesting to read this in the context of OpenStack, especially Nova: https://techbeacon.com/app-dev-testing/forget-monoliths-vs-microservices-cognitive-load-what-matters
09:48:56 sean-k-mooney cdent: the Germane cognitive load of nova is quite high by its nature
09:49:16 cdent it didn't have to be that way, but yes
09:50:02 sean-k-mooney well its partly becasue nova is ofthen the theing that end up driving interaction with other services
09:50:41 sean-k-mooney even if you precreate teh neuton ports for exampls nova still had sto notify nova when a vm uses them
09:51:42 sean-k-mooney some of that is intrisi to being the compute service wich is the main service that consumes other services
09:51:52 sean-k-mooney but ya its an interesting read
09:53:29 cdent the nova implementation is very tightly coupled with itself in a weirdly recursive kind of way
09:56:40 sean-k-mooney well not entirly the api, conductor, compute agent and schduler more or less work as miscroservices
09:57:56 sean-k-mooney or well services they are not that small
09:59:20 cdent that's not really true
09:59:30 sean-k-mooney how so
09:59:43 cdent interactions via rpc are insufficiently hard boundaries
09:59:43 sean-k-mooney the api does not care what virt dirver you use
10:00:35 sean-k-mooney am im not sure i would agree
10:01:09 stephenfin gibi++ Thanks for hitting https://review.opendev.org/#/c/609460/ again. Much obliged :)
10:01:20 sean-k-mooney the could be more orbust in some ways but i would not consier it to less stict then something like grpc
10:02:28 sean-k-mooney its still versioned using ovo
10:02:29 stephenfin Do we have a bug to track those failing MYSQL migration unit tests? I'm used to them intermittently failing on py35 but now py27 is unhappy too http://logs.openstack.org/29/666629/1/check/openstack-tox-py27/93e40ec/testr_results.html.gz
10:03:05 sean-k-mooney stephenfin: if they are teh ones im think of yes
10:03:30 sean-k-mooney ya those fail on all paython version intermiently and there is a bug
10:03:42 stephenfin with nova or sqlalchemy?
10:03:49 sean-k-mooney nova
10:04:04 sean-k-mooney well with that error
10:04:10 sean-k-mooney so in the nova gate
10:04:21 sean-k-mooney and we have a bug in nova
10:04:30 stephenfin Damn
10:04:38 stephenfin I don't even know where to start with that
10:04:43 stephenfin It's rather irritating
10:04:58 sean-k-mooney stephenfin: gibi has a partial patch to simplfy the tests
10:05:09 sean-k-mooney to help with figuring it out
10:05:15 sean-k-mooney not sure if it has merged yet
10:05:43 sean-k-mooney stephenfin: https://review.opendev.org/#/c/662434/
10:05:54 sean-k-mooney stephenfin: and this is the bug https://bugs.launchpad.net/nova/+bug/1823251
10:05:55 openstack Launchpad bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed]
10:05:59 openstackgerrit Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630
10:05:59 openstackgerrit Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631
10:06:01 stephenfin sean-k-mooney++
10:07:43 sean-k-mooney stephenfin: instaed of doing an if else chain use a dict of vif_type -> functions
10:07:53 stephenfin I thought about that
10:08:09 stephenfin but it saved something like 4 lines
10:08:11 sean-k-mooney its faster and simpler to read
10:08:43 sean-k-mooney the dict hashse the string and finds the function O(1)
10:09:15 sean-k-mooney the if,elif,else tree you built has to do a tone of comparisons
10:09:46 stephenfin I wonder is it significant in the grand scheme of things though?
10:09:53 stephenfin The additional lookup time
10:10:12 sean-k-mooney we do this for every interface on every boot/reboot
10:10:24 sean-k-mooney but it mostly that the code is nicer to read
10:10:59 stephenfin Hmm, okay. If we're doing it elsewhere in nova I'm happy to switch
10:11:50 stephenfin Though I must say I do rather like us explicitly highlighting the VIF types we still use the legacy path for https://review.opendev.org/#/c/666630/3/nova/network/os_vif_util.py@517
10:12:09 stephenfin Is DVS even a thing still?
10:12:54 sean-k-mooney you can still do that
10:13:13 sean-k-mooney and praobly but didnt we say we were kicking them out of tree
10:13:35 sean-k-mooney we proably should jsut port these all into os-vif to be honest
10:16:47 jangutter stephenfin: if only python had a "case" statement, right :-p
10:17:04 sean-k-mooney stephenfin: oh dvs is a vmware thing
10:17:25 sean-k-mooney jangutter: switch statement unless you are channeling sql
10:17:43 jangutter sean-k-mooney: eep, was channeling Pascal of all things.
10:18:08 sean-k-mooney ha fair enough
10:18:49 sean-k-mooney you know if python had static type swe could have overload a function on teh argument type too
10:19:16 sean-k-mooney so many ways to solve this issue in other languages
10:20:36 jangutter stephenfin, sean-k-mooney: I haven't cross-checked, but how many of the VIFs in use by Neutron Stadium things are still legacy?
10:20:59 jangutter stephenfin, sean-k-mooney: I guess I'll have to go through the plugins in https://governance.openstack.org/tc/reference/projects/neutron.html
10:24:28 sean-k-mooney i dont think that many alot use ovs underneat
10:25:00 jangutter sean-k-mooney: yah, and a _lot_ of these are 'noop' plugging.

Earlier   Later