| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-17 | |||
| 11:10:31 | bhagyashris | sean-k-mooney : yeah and thats my concern | |
| 11:10:43 | sean-k-mooney | bhagyashris: we intentionlly want to allow that | |
| 11:11:04 | sean-k-mooney | bhagyashris: we need to allow it to allow inplace upgrade of nodes with running instances | |
| 11:11:04 | bhagyashris | sean-k-mooney : ok | |
| 11:14:12 | sean-k-mooney | one of the requirements for edge workload is we need to be able to do inplace upgrades without draining a host of instaces. going for Train to U we will remove the vcpu_pin_set option which means before upgrading to U you will need to updated your config to remove it. | |
| 11:15:34 | bhagyashris | sean-k-mooney : just want to clear some points 1. As we discussed above that the floating instace can float over the pinned instances is allowed for train release | |
| 11:15:56 | sean-k-mooney | its only allowed if cpu_dedicated_set is not defined | |
| 11:16:38 | bhagyashris | sean-k-mooney : if user request the both the resources:PCPU and VCPu resources in the same request then that should get rejected | |
| 11:17:16 | sean-k-mooney | if cpu_dedicated_set is defiend VCPU inventory will only be reported if cpu_shared_set is defiend. if both cpu_shared_set and cpu_dedicated_set are defiend then nova will soft pin floating cores to the cpu_shared_set cpus | |
| 11:18:03 | sean-k-mooney | bhagyashris: yes if the user request VCPUs and PCPUs in the same request it will be reject in the api as part of the boot request before we get to the schduler | |
| 11:19:54 | bhagyashris | sean-k-mooney : and if user sets only cpu_shared_set then in that case VCPU inventory will be reported right? | |
| 11:21:38 | bhagyashris | sean-k-mooney : and that will be used as shared cpu resources | |
| 11:22:37 | bhagyashris | sean-k-mooney : my concern is what will happen if inly cpu_shared_set is define | |
| 11:22:47 | bhagyashris | only* | |
| 11:22:52 | sean-k-mooney | yes if cpu_shared_set is defeind and vcpu_pin_set is not then only VCPUs will be reported | |
| 11:22:58 | sean-k-mooney | and we should soft pin to that set | |
| 11:23:43 | sean-k-mooney | if cpu_shared_set is defiend and vcpu_pin_set is defiend then we ignore cpu_shared_set for reporting to placement and do not soft pin the cpus to cpu_shared_set | |
| 11:25:06 | sean-k-mooney | bhagyashris: if they only define cpu_shared_set we soft ping floating instance to the cpu_share_set and only report VCPU for the cores enabeld in teh cpu_shared_set and dont report any PCPU inventory | |
| 11:25:48 | sean-k-mooney | so the soft pinning of floating instace will not be done if vcpu_pin_set is defiend and will be done in all other cases | |
| 11:26:29 | sean-k-mooney | we could allow it if all 3 values are defiend but i would prefer to treat that as an error | |
| 11:26:41 | sean-k-mooney | we can decided that in code reveiw | |
| 11:26:51 | bhagyashris | sean-k-mooney : ok | |
| 11:32:47 | bhagyashris | sean-k-mooney : I would just like to know about soft pinning | |
| 12:14:36 | openstackgerrit | Merged openstack/nova master: Add 'path' query parameter to console access url https://review.opendev.org/649372 | |
| 13:29:04 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | |
| 13:43:09 | stephenfin | sean-k-mooney: Not sure if you've got to them or not, but do all my replies so far match up with what you'd expected? | |
| 13:43:18 | stephenfin | RE: the cpu-resources spec? | |
| 13:47:11 | sean-k-mooney | more or less | |
| 13:47:23 | sean-k-mooney | you mean on the mailing list post right | |
| 13:47:59 | sean-k-mooney | the prefilter will default to false in the config | |
| 13:48:06 | sean-k-mooney | so on upgade it will be disabeld by default | |
| 13:48:41 | sean-k-mooney | as you are not ment to modify config as part of upgade that means that by default we will get inveoties of both VCPU and PCPU | |
| 13:49:14 | sean-k-mooney | then later we can enable the prefilter and add the dedicated_cpu_set and remove teh vcpu_pin_set | |
| 13:52:18 | sean-k-mooney | personally i had assumed that defineing the dedicated_cpu_set option is what would have done the reshape fo exisitng instances | |
| 13:53:43 | sean-k-mooney | reshape is a little impresise what i mean is modifying the allcoation for exsiting instance to consume PCPUs if needed | |
| 13:59:31 | shilpasd | Hi, can anybody help me to test live migration? i using openstack via devstack, and facing below error | |
| 13:59:33 | shilpasd | libvirtError: operation failed: Failed to connect to remote libvirt URI qemu+tcp://<vm_user>@<compute_node_name>/system: unable to connect to server at '<compute_node_name>:16509': Connection refused | |
| 14:00:08 | shilpasd | FYI: referred 'https://www.mirantis.com/blog/tutorial-openstack-live-migration-with-kvm-hypervisor-and-nfs-shared-storage/' for libvirtd.conf configuration | |
| 14:01:45 | shilpasd | after running telnet >>Unable to connect to remote host: Connection refused | |
| 14:02:07 | shilpasd | seems configuration issue, can anybody provide me any specific link for live-migration | |
| 14:05:13 | mriedem | efried: i've half a mind to revert this https://review.opendev.org/#/c/663502/ | |
| 14:05:28 | mriedem | he removed an unused method but it's a regression to not be using that method | |
| 14:05:32 | openstack | Launchpad bug 1830260 in OpenStack Compute (nova) stein "Inefficient host_status lookup when listing servers with details (regression)" [Medium,Triaged] | |
| 14:05:32 | mriedem | https://bugs.launchpad.net/nova/+bug/1830260 | |
| 14:06:20 | mriedem | but i guess it could be reverted when someone actually fixes the bug | |
| 14:06:57 | efried | mriedem: ack. in any case, I'd like to understand the path I should have taken as a reviewer to know about that bug and that using this method was a solution | |
| 14:07:38 | mriedem | it's not really your fault. i don't know, but i suspect takashi noticed it when i pointed out the regression in a recent-ish ML thread. | |
| 14:08:25 | efried | okay | |
| 14:09:41 | efried | mriedem: I guess a note in the bug mentioning the commit where it was removed so it can be reinstated? | |
| 14:09:58 | efried | ...reinstated when fixing the bug? | |
| 14:10:01 | mriedem | yeah good point | |
| 14:21:06 | shilpasd | mriedem: hi do you have few time, want to discuss @ live migration issue i am facing | |
| 14:21:30 | sean-k-mooney | so if im following correctly https://bugs.launchpad.net/nova/+bug/1830260 was really intoduced by https://review.opendev.org/#/c/584590/ when that stop calling the method that https://review.opendev.org/#/c/663502/1 removed | |
| 14:21:30 | openstack | Launchpad bug 1830260 in OpenStack Compute (nova) stein "Inefficient host_status lookup when listing servers with details (regression)" [High,Triaged] | |
| 14:23:15 | sean-k-mooney | should ^ have a stein-backport-potential tag | |
| 14:33:14 | sean-k-mooney | mriedem: by the way your cross cell resize series should be entering the runway in a day or so. i assume the reviewers guide you sent before is still pretty much accurate? ill try to start on the series again later this weeks but ill re read that in the mean time to reload the context | |
| 14:47:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove references to nova-consoleauth https://review.opendev.org/652965 | |
| 14:47:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Stop starting consoleauth in functional tests https://review.opendev.org/652966 | |
| 14:47:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens https://review.opendev.org/652967 | |
| 14:47:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: xvp: Remove use of '_LI' marker https://review.opendev.org/665425 | |
| 14:47:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check https://review.opendev.org/652968 | |
| 14:47:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969 | |
| 14:47:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970 | |
| 14:47:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework nova console diagram https://review.opendev.org/660147 | |
| 14:47:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Integrate 'sphinx.ext.imgconverter' https://review.opendev.org/665693 | |
| 14:47:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove dead file https://review.opendev.org/665694 | |
| 14:49:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove unused Visio diagram https://review.opendev.org/665694 | |
| 14:50:16 | bauzas | mriedem: thanks for having reviewed https://review.opendev.org/#/c/650963/ | |
| 14:50:27 | bauzas | mriedem: I just updated with comments, lemme know if you need more details | |
| 14:59:16 | mriedem | sean-k-mooney: yes it's as described in the bug. and yes the cross-cell resize review guide in the ML is unchanged. | |
| 14:59:20 | mriedem | shilpasd: what's up | |
| 15:13:45 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | |
| 15:14:16 | aspiers | efried, sean-k-mooney: ^^^ changes as discussed last week | |
| 15:15:14 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA affinity for vGPUs https://review.opendev.org/650963 | |
| 15:27:00 | efried | aspiers: ack | |
| 15:27:30 | aspiers | efried: I'm just adding the API-level check to it which Alex pointed out was missing | |
| 15:28:01 | ralonsoh | tonyb, hi, can you take a look at https://review.opendev.org/#/c/655694/? Thank you in advance | |
| 15:28:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Integrate 'sphinx.ext.imgconverter' https://review.opendev.org/665693 | |
| 15:28:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove unused Visio diagram https://review.opendev.org/665694 | |
| 15:35:15 | temka | sean-k-mooney, looks like you took a look at https://bugs.launchpad.net/nova/+bug/1826519 - to me that's a cloud-init problem, not a Nova one. You OK to close as Invalid? | |
| 15:35:16 | openstack | Launchpad bug 1826519 in OpenStack Compute (nova) "Ephemeral disk volume was not mounted after resizing from non-ephemeral flavor" [Undecided,New] | |
| 15:35:20 | artom | Whoops | |
| 15:49:13 | openstackgerrit | Balazs Gibizer proposed openstack/os-vif master: Insert osprofiler trace info as external_ids to the bridge table https://review.opendev.org/665715 | |
| 15:53:36 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | |
| 15:57:00 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | |
| 15:57:13 | aspiers | efried: API-level check is now in ^^^ | |
| 15:57:19 | efried | ack | |
| 15:57:35 | aspiers | This should be ready for review. Now it should be easy for me to fix the subsequent SEV guest config changes! | |
| 16:05:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def) https://review.opendev.org/651554 | |
| 16:05:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator) https://review.opendev.org/651555 | |
| 16:05:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.opendev.org/652103 | |
| 16:05:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.opendev.org/652104 | |
| 16:25:10 | mriedem | sean-k-mooney: alex_xu: i went through the pmem spec https://review.opendev.org/#/c/601596/ - lots of questions and comments | |
| 16:26:21 | openstackgerrit | Merged openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | |
| 16:27:26 | sean-k-mooney | mriedem: ok i need to finish review that spec again too. i have not done a full review since version 12 | |
| 16:28:49 | mriedem | the biggest nagging feeling i get on that spec is it sounds like these are local block devices and should be modeled as BDMs | |
| 16:29:01 | mriedem | they really sound like the libvirt lvm image backend with the zero'ing out and such | |
| 16:29:16 | sean-k-mooney | they are presended to the guest as memory DIMs however | |
| 16:29:24 | sean-k-mooney | not as block devices | |
| 16:29:32 | sean-k-mooney | but form a host level they are similar | |