Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-14
16:04:24 melwitt finucannot: I was debating about it... because yeah it's a bug but we have like zero testing for this so it would have to be a testless bug fix else you'd have to figure out how to add testing for a thing no one's using. so I dunno
16:06:40 finucannot Yeah, we have zero tests for that and can probably remove it this cycle
16:06:51 melwitt oh and I would not expect to backport
16:07:08 finucannot Okay, then I don't need to worry about opening a bug for this so
16:07:44 finucannot BobBall said on the ML some time back that they're not using it anymore
16:11:04 melwitt yeah. I'd just leave it for now and see if mriedem complains
16:11:38 melwitt he's the expert on these type of complicated matters
16:12:09 sean-k-mooney mtreinish: tonyb[m] would ye be able to take a look at these trivial test only stable backport for me on os-vif. https://review.opendev.org/#/c/665196/ and https://review.opendev.org/#/c/665195/
16:17:58 openstackgerrit Stephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens https://review.opendev.org/652967
16:17:58 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check https://review.opendev.org/652968
16:17:59 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969
16:17:59 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970
16:18:00 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rework nova console diagram https://review.opendev.org/660147
16:18:00 openstackgerrit Stephen Finucane proposed openstack/nova master: xvp: Remove use of '_LI' marker https://review.opendev.org/665425
16:36:09 finucannot argparse is broken in so many little ways that it kind of hurts :(
16:37:02 temka moar liek arseparse, amirite?
16:37:15 finucannot temka++
16:38:17 cdent temka+++
16:38:29 cdent argparse is so very very ugh
16:40:56 finucannot It tries to be too clever
16:41:01 finucannot and fails miserably
16:41:52 finucannot fwiw, click (which is A+) is based on optparse and not argparse for just that reason
16:44:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Always Set dhcp_server in network_info https://review.opendev.org/658362
16:47:23 efried finucannot: https://review.opendev.org/#/c/664396/ - missed one --?
16:48:33 finucannot my bad. On it
16:49:47 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Document how to revert, confirm a cold migration https://review.opendev.org/664396
16:49:48 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Update resize doc https://review.opendev.org/665412
16:50:03 finucannot efried: ^
16:51:18 efried finucannot: thx, +2
16:53:18 sean-k-mooney am i missing somthing
16:53:37 sean-k-mooney "openstack server migrate revert" is not a thing
16:54:03 sean-k-mooney nor is "openstack server migrate confirm"
16:54:42 sean-k-mooney you have to use openstack server resize --revert or openstack server resize --confirm
16:55:41 sean-k-mooney oh your adding them in the depnds on patch
16:56:46 openstackgerrit Stephen Finucane proposed openstack/nova master: This patch is to fix bug #1831657 https://review.opendev.org/663926
16:56:48 openstack bug 1831657 in OpenStack Compute (nova) "Instance migration/Instance resize with lvm volumes" [Medium,Triaged] https://launchpad.net/bugs/1831657 - Assigned to Dr. Clemens Hardewig (bringha1)
17:03:49 openstackgerrit Eric Fried proposed openstack/nova master: xenapi: Remove dead host_call_plugin method https://review.opendev.org/665434
17:05:45 efried finucannot: ^ totally unrelated to hacking patch IMO
17:07:35 finucannot efried: Separate patch is a-okay (though perhaps it should come first). My objection was to touching dead code in general
17:07:38 finucannot lookig
17:07:40 finucannot *looking
17:08:53 efried I definitely don't understand by looking at that code why it would be unreachable or whatever, which you clearly do at a glance (heh).
17:09:11 efried But the hacking rule seems straightforward to me, and uncontroversial, so I put the weird one after.
17:09:21 efried Could put them in parallel, but would have to resolve merge conflict then
17:12:57 mtreinish sean-k-mooney: +2
17:18:16 finucannot melwitt: Fancy sanity checking this patch https://review.opendev.org/#/c/662570/ (it's mriedem's)
17:18:40 melwitt finucannot: ah yep, meant to do that. looking
17:19:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Removing the stale parameters documented for kombu https://review.opendev.org/664153
17:25:59 openstackgerrit Eric Fried proposed openstack/nova master: Raise if flavor and image disagree on hide_hypervisor_id https://review.opendev.org/663365
17:47:40 openstackgerrit Eric Fried proposed openstack/nova master: Clarify --before help text in nova manage https://review.opendev.org/661289
18:01:33 openstackgerrit melanie witt proposed openstack/nova master: Add 'path' query parameter to console access url https://review.opendev.org/649372
18:02:32 melwitt finucannot: updated ^
18:04:05 efried melwitt: your co-authored-by email address is wrong, intentional?
18:04:47 melwitt efried: no, that's my actual email because someone else owns melwitt@
18:05:04 efried oh, no kidding, and I just noticed after all these years.
18:06:13 melwitt haha, yeah I stubbornly wanted it to look like melwitt@ from a tidiness perspective but it's resulted in some people thinking they emailed me when they really didn't (oops)
21:52:49 openstackgerrit Merged openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003
21:52:59 openstackgerrit Merged openstack/nova master: Fix invalid privsep.readpty test https://review.opendev.org/656262
21:53:08 openstackgerrit Merged openstack/nova master: Add functional recreate test for bug 1829479 and bug 1817833 https://review.opendev.org/663737
21:53:09 openstack bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,Triaged] https://launchpad.net/bugs/1829479
21:53:10 openstack bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Undecided,In progress] https://launchpad.net/bugs/1817833 - Assigned to xulei (605423512-j)
21:53:21 openstackgerrit Merged openstack/nova master: Mock time.sleep() in unit tests https://review.opendev.org/648762
21:53:33 openstackgerrit Merged openstack/nova master: Modifying install-guide to include public endpoint for identity service https://review.opendev.org/663530
22:07:52 openstackgerrit Merged openstack/nova master: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface https://review.opendev.org/650097
22:08:00 openstackgerrit Merged openstack/nova master: Hacking N363: `in (not_a_tuple)` https://review.opendev.org/664041
22:08:08 openstackgerrit Merged openstack/nova master: Update quota known issues docs https://review.opendev.org/662570
22:22:22 openstackgerrit Merged openstack/nova stable/stein: Fix double word hacking test https://review.opendev.org/665147
#openstack-nova - 2019-06-15
00:11:42 openstackgerrit Merged openstack/nova stable/stein: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663677
00:15:13 openstackgerrit Merged openstack/nova master: Document restrictions for moving servers between availability zones https://review.opendev.org/650444
09:06:16 openstackgerrit Merged openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
09:20:43 openstackgerrit Merged openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
09:21:05 openstackgerrit Merged openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
09:21:14 openstackgerrit Merged openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
09:21:24 openstackgerrit Merged openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
09:29:37 openstackgerrit Merged openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
09:37:07 openstackgerrit Merged openstack/nova master: Replace joinedload_all with joinedload https://review.opendev.org/664193
09:37:15 openstackgerrit Merged openstack/nova master: Add a test for the _joinedload_all helper https://review.opendev.org/665421
13:53:54 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface https://review.opendev.org/665513
15:39:01 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886
15:42:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
15:42:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility https://review.opendev.org/621061
15:42:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd https://review.opendev.org/664967
15:42:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception https://review.opendev.org/651315
16:19:20 openstackgerrit Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8' https://review.opendev.org/665518
16:27:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8' https://review.opendev.org/665518
16:28:31 sean-k-mooney finucannot: hehe when i mentioned that to you a while ago i though you said we would not be able to use it in nova
16:29:34 sean-k-mooney finucannot: if we can then i would like to add https://github.com/SeanMooney/gerio/blob/master/.pre-commit-config.yaml#L14-L20
16:30:21 sean-k-mooney so that we dont have to deal with tabs or windows line ending ever being commit for people that choose to instll the hook like i intend too
#openstack-nova - 2019-06-16
03:33:23 openstackgerrit Merged openstack/nova stable/stein: Reset the stored logs at each notification test steps https://review.opendev.org/662965
07:30:04 openstackgerrit Merged openstack/nova master: Summarize output of sample configuration generator https://review.opendev.org/625014
08:03:58 openstackgerrit Merged openstack/nova master: Always Set dhcp_server in network_info https://review.opendev.org/658362
14:26:09 openstackgerrit Tao Yang proposed openstack/nova master: doc:remove the RamFilter from example https://review.opendev.org/665546
14:28:17 openstackgerrit Tao Yang proposed openstack/nova master: doc:remove the RamFilter from example https://review.opendev.org/665546
15:16:22 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
16:02:04 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
16:18:25 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
22:12:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153
22:12:39 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
22:43:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020
22:43:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027

Earlier   Later