| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-12 | |||
| 14:02:18 | sean-k-mooney | i did not think we removed that when we deleted an instace provided you have not archive teh deleted instances or purged them form the db | |
| 14:02:30 | sean-k-mooney | but maybe we do not allow you to retrive the info | |
| 14:03:03 | rafaelweingartne | that is what I thought | |
| 14:03:10 | rafaelweingartne | is this implemented in Nova API? | |
| 14:03:33 | rafaelweingartne | or is it somewhere else? where I can take a look and maybe propose a method to retrieve data for deleted VMs as well | |
| 14:04:24 | sean-k-mooney | i think its hitting this endpoint https://developer.openstack.org/api-ref/compute/?expanded=list-server-usage-audits-detail | |
| 14:05:37 | sean-k-mooney | actully no that is not correct | |
| 14:06:33 | sean-k-mooney | its hitting the server action endpoint | |
| 14:06:35 | sean-k-mooney | https://developer.openstack.org/api-ref/compute/?expanded=list-server-usage-audits-detail,list-actions-for-server-detail#list-actions-for-server | |
| 14:07:51 | rafaelweingartne | cool thanks | |
| 14:08:11 | rafaelweingartne | I was looking for "/servers/{server_id}/events"... | |
| 14:08:20 | rafaelweingartne | now I know why I did not find it | |
| 14:08:42 | rafaelweingartne | What does this "Action information of deleted instances can be returned for requests starting with microversion 2.21." mean? | |
| 14:08:53 | rafaelweingartne | Nova version? | |
| 14:09:02 | rafaelweingartne | Nova-compute* | |
| 14:09:35 | sean-k-mooney | the nova api support microversion form v2.1 on | |
| 14:09:43 | sean-k-mooney | but the openstack client does not use them | |
| 14:09:47 | sean-k-mooney | it default to 2.1 | |
| 14:10:08 | sean-k-mooney | so if you want to get it to work you have to pass a a microverion of at lest 2.21 | |
| 14:10:14 | sean-k-mooney | one sec | |
| 14:11:39 | sean-k-mooney | add --os-compute-api-version 2.21 to the request | |
| 14:11:50 | sean-k-mooney | *command | |
| 14:16:03 | rafaelweingartne | something like? "openstack server event list 9b82ae8f-ac7e-47e9-819c-24105631df80 --os-compute-api-version 2.21" | |
| 14:16:39 | rafaelweingartne | I just checked the code, and aren't the instances removed from "instance_mappings" table when they get deleted? | |
| 14:29:04 | efried | sean-k-mooney: First blush, adding the allocations from placement to the Instance object sounds like a solid idea. | |
| 14:34:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix double word hacking test https://review.opendev.org/664940 | |
| 14:34:43 | stephenfin | efried: f*** me that was a rabbit hole and half ^ | |
| 14:35:08 | efried | stephenfin: no doubt. Looking... | |
| 14:35:23 | stephenfin | tl;dr: I can't decide if either the Python patch or pycodestyle is broken, but it's the edgiest of edge cases that we'd only really see in tests, so we can work around it | |
| 14:37:51 | mriedem | rafaelweingartne: no, | |
| 14:37:58 | rafaelweingartne | hmm | |
| 14:37:59 | mriedem | the instance mappings are cleaned up when you archive | |
| 14:38:07 | mriedem | nova-manage db archive_deleted_rows | |
| 14:38:35 | mriedem | rafaelweingartne: 2.21 is about instance actions / events | |
| 14:39:07 | mriedem | rafaelweingartne: https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server-event.html | |
| 14:39:08 | gibi | stephenfin: what a detective work! | |
| 14:42:46 | dansmith | mriedem: can you quickly weigh in on this? I thought you might care about the use of a sentinel value in nova-manage. Otherwise I'm good with it: https://review.opendev.org/#/c/662383/5 | |
| 14:45:40 | mriedem | ew | |
| 14:47:11 | dansmith | before you shame him, note that it was my idea :) | |
| 14:48:53 | mriedem | i'm just trying to think of alternatives, | |
| 14:49:19 | mriedem | i saw melwitt pointed out https://review.opendev.org/#/c/603998/ but i'm not sure what that change is doing, | |
| 14:49:27 | mriedem | with takashi's change, | |
| 14:50:10 | mriedem | if you specify one but not the other it's an error, | |
| 14:50:38 | mriedem | i was thinking, what if we change the logic such that if you specify one but not the other, we just don't read from the config for the other (don't set/update the other) | |
| 14:50:48 | mriedem | if you don't specify either, we use config, | |
| 14:50:54 | mriedem | if you specify both, we set/update both, | |
| 14:50:56 | dansmith | that just seems confusing to me | |
| 14:50:59 | mriedem | if you only provide one, we only use one | |
| 14:51:14 | mriedem | i think that's more in line with how osc set commands work | |
| 14:51:27 | dansmith | I was actually expecting to have a --transport_url=(keep|config|[url]) sort of thing, but.. | |
| 14:52:02 | dansmith | the confusing bit is that we do the magic config thing if we don't specify either.. if we specify one, then we do a totally different set of things | |
| 14:52:32 | mriedem | i'm assumine when this was written, we expected people were either using all of the command options or none to let config handle it | |
| 14:52:33 | mriedem | not a mix | |
| 14:52:39 | dansmith | this has tripped up more than one person who was surprised by one or the other behaviors | |
| 14:52:54 | dansmith | well, | |
| 14:53:06 | dansmith | I think it actually came from create, where that makes more sense | |
| 14:53:14 | dansmith | and we imported the same behavior for update where it does not | |
| 14:54:39 | mriedem | yeah ok i can see that, | |
| 14:54:57 | mriedem | so in that case i think it makes more sense to only update the field provided via the option if only one option is provided, and ignore the other (don't use config) | |
| 14:55:46 | dansmith | le sigh | |
| 14:57:58 | mriedem | hey, you asked me | |
| 14:58:03 | mriedem | anyway, i commented | |
| 14:58:16 | mriedem | if we need a tie breaker i vote that we ask dean to weigh in | |
| 14:58:37 | mriedem | mean dean okerlund | |
| 14:58:40 | mriedem | from WWF fame | |
| 15:07:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix double word hacking test https://review.opendev.org/664940 | |
| 15:08:43 | bauzas | sean-k-mooney: hey | |
| 15:08:54 | bauzas | sean-k-mooney: yeah I tested it and it worked | |
| 15:09:05 | bauzas | ie. stopping the instance and then restarting it | |
| 15:09:08 | stephenfin | efried: I need to rebase this series now, right? https://review.opendev.org/#/c/651311/ | |
| 15:09:19 | stephenfin | to pick up the fix to test_hacking.py | |
| 15:09:37 | sean-k-mooney | bauzas: ok looking at the code im not sure where we figureout the mdevs in that case but i also didnt look | |
| 15:09:41 | sean-k-mooney | to far | |
| 15:09:49 | bauzas | sean-k-mooney: I provided a change for that | |
| 15:09:52 | bauzas | sec | |
| 15:10:09 | sean-k-mooney | my concern was we had to hit the placmenet api to look up the allcoation again | |
| 15:10:17 | sean-k-mooney | which i dont think we shoudl have to do. | |
| 15:10:57 | efried | stephenfin: I wouldn't think you need to rebase; I think zuul automatically rebases you against tip of master before starting tests | |
| 15:11:04 | bauzas | sean-k-mooney: https://review.opendev.org/#/c/564257/ | |
| 15:11:29 | bauzas | and https://review.opendev.org/#/c/533642/ | |
| 15:11:41 | sean-k-mooney | bauzas: that wont fix it | |
| 15:12:00 | sean-k-mooney | the second on might | |
| 15:12:09 | stephenfin | efried: Yeah, I'm not sure. That said, I think I'm going to have to recheck every one of them again anyway so maybe a rebase would be the surer thing | |
| 15:12:30 | stephenfin | Yeah, they're all -2 | |
| 15:12:49 | efried | stephenfin: Yeah, that would be an easy way to get them all back in the queue. Feel free to re+W the ones that were already +A. | |
| 15:12:58 | sean-k-mooney | bauzas: quickly looking i dont think either of those will fix the edgecase i am thinking of | |
| 15:13:09 | bauzas | sean-k-mooney: mmm N | |
| 15:13:10 | bauzas | ? | |
| 15:13:39 | sean-k-mooney | bauzas: if the instance is not found on the host in libvirt you retrun {] | |
| 15:13:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | |
| 15:13:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | |
| 15:13:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | |
| 15:13:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | |
| 15:13:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | |
| 15:13:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031 | |
| 15:13:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | |
| 15:13:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | |
| 15:13:47 | sean-k-mooney | bauzas: we can talk after standup | |
| 15:18:08 | sean-k-mooney | bauzas: basically if we stop the instance then we undefine the domain so if start it when we call _get_all_assigned_mediated_devices | |
| 15:18:18 | sean-k-mooney | bauzas: we retrun {} | |