| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-11 | |||
| 08:46:27 | stephenfin | lyarwood: Question on https://review.opendev.org/#/c/664036/ | |
| 08:46:30 | kashyap | Not really; it's a death by thousand cuts | |
| 08:46:31 | lyarwood | ack looking | |
| 08:46:35 | stephenfin | other one is +W | |
| 08:48:29 | lyarwood | stephenfin: gah, why is it always so obvious when someone comments on my change | |
| 08:48:35 | lyarwood | stephenfin: I'll respin for the elif now | |
| 08:48:52 | stephenfin | It's the same for everyone else, I assure you :) | |
| 08:49:15 | stephenfin | Thoughts on the logging? Do we want to do a full run through first to catch potential issues, or just highlight them as we encounter them? | |
| 08:51:15 | lyarwood | stephenfin: just left a note, I don't think we care enough to loop through everything everytime to find invalid values. | |
| 08:51:26 | stephenfin | Cool | |
| 08:51:42 | lyarwood | stephenfin: worst case is that we can't find a mapping for our arch and find the invalid mappings that way | |
| 08:53:01 | aspiers | stephenfin: sorry, just remembered you asked me to look at a potential bug I might have caused with the machtype mapping stuff | |
| 08:53:38 | stephenfin | aspiers: I think lyarwood's patch has fixed it so we should be good | |
| 08:53:52 | aspiers | stephenfin: ah cool | |
| 08:54:13 | aspiers | stephenfin: feel free to add me to review | |
| 08:54:34 | stephenfin | aspiers: It was this comment https://review.opendev.org/#/c/663011/9/nova/virt/libvirt/utils.py@563 | |
| 08:55:23 | stephenfin | lyarwood has moved it to 'get_default_machine_type' so the potential mixup should be resolved | |
| 08:56:08 | lyarwood | on stephenfin's suggestion FWIW, thanks for that. | |
| 08:59:15 | kashyap | lyarwood: When we can't find a valid mapping, _do_ we print everything out? | |
| 08:59:35 | aspiers | lyarwood: there's still the {} default mapping bug stephenfin pointed out in https://review.opendev.org/#/c/663011/9/nova/virt/libvirt/utils.py@571 | |
| 09:01:25 | lyarwood | kashyap: no, just the invalid mappings | |
| 09:02:38 | kashyap | (Nod) | |
| 09:02:57 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | |
| 09:04:35 | kashyap | Sigh; the crappy "fup" again | |
| 09:05:35 | lyarwood | As I said above, I'm going to continue using it. | |
| 09:06:22 | kashyap | Sure, at the cost of the death by shitty commit messages | |
| 09:33:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | |
| 09:33:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | |
| 09:33:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | |
| 09:41:39 | stephenfin | lyarwood: Can you put this through? https://review.opendev.org/#/c/657844/ | |
| 09:41:45 | stephenfin | (as a stable patch) | |
| 09:48:44 | lyarwood | stephenfin: ack, I'll look now | |
| 09:48:58 | lyarwood | stephenfin: ah no sorry, I'm not actually stable-maint | |
| 09:49:07 | lyarwood | stephenfin: only nova-stable-core | |
| 09:49:13 | stephenfin | Ah, I thought you were. Np | |
| 11:46:33 | openstackgerrit | Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559 | |
| 11:46:55 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | |
| 11:55:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | |
| 11:55:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | |
| 11:55:49 | lyarwood | ^ I've rebased these as both keep failing on nova.tests.unit.test_hacking.HackingTestCase.test_check_doubled_words in check queue and gate but are passing locally. stephenfin ^ any ideas? | |
| 12:12:09 | artom | lyarwood, you've seen https://bugs.launchpad.net/nova/+bug/1804062 I assume? | |
| 12:12:11 | openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | |
| 12:12:29 | artom | (It's in the comment immediately above your failing test) | |
| 12:15:14 | aspiers | am I right in thinking use of _LE() etc. is deprecated since Pike? as per https://docs.openstack.org/oslo.i18n/latest/user/usage.html | |
| 12:21:13 | artom | aspiers, think so, yeah | |
| 12:22:31 | lyarwood | artom: no missed that thanks, however this is on 2.7 oddly enough. | |
| 12:23:36 | lyarwood | ah https://bugs.launchpad.net/nova/+bug/1804062/comments/4 | |
| 12:23:37 | openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | |
| 12:24:06 | artom | lyarwood, I didn't really read it TBH, just kinda left it for you, like a cat leaving a mouse corpse | |
| 12:24:11 | sean-k-mooney | aspiers: we nolonger translate exception or logs | |
| 12:24:39 | sean-k-mooney | aspiers: only end user facing content | |
| 12:27:11 | stephenfin | sean-k-mooney: I thought we still translated exceptions but not logs? | |
| 12:27:36 | sean-k-mooney | stephenfin: not since pike as far as i am aware | |
| 12:28:05 | aspiers | AFAICS exceptions are translated according to https://docs.openstack.org/oslo.i18n/latest/user/usage.html | |
| 12:28:21 | sean-k-mooney | https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#log-translation | |
| 12:28:44 | sean-k-mooney | aspiers: excetions retruned from the api might be | |
| 12:28:51 | aspiers | right, logs != exceptions | |
| 12:28:56 | sean-k-mooney | excptions that are logged are not | |
| 12:29:12 | aspiers | obviously :) I mean exceptions which are raised | |
| 12:29:47 | sean-k-mooney | no what i mean is if you raise an excetip and also log it then the logged version is not translated | |
| 12:30:40 | aspiers | right | |
| 12:30:51 | aspiers | anyway the page you linked answers my questions so thanks for that | |
| 12:49:24 | yaawang | johnthetubaguy: Hi, are you good with the spec after updates? https://review.opendev.org/#/c/651681/ | |
| 13:17:00 | openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | |
| 13:17:01 | openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Fix mock of built in "open" function in unit tests https://review.opendev.org/664583 | |
| 13:23:17 | sean-k-mooney | mriedem: when you have a sec i need your advice on how we should be mocking "open" in os-vif if you can comment on https://review.opendev.org/#/c/664583/1/vif_plug_ovs/tests/unit/test_linux_net.py | |
| 13:23:28 | sean-k-mooney | that would be awsome | |
| 13:28:38 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | |
| 13:28:39 | openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | |
| 13:28:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | |
| 13:28:59 | mriedem | sean-k-mooney: i just said should probably be using the mock_open stuff that's part of mock rather than directly mocking the builtin | |
| 13:29:05 | mriedem | since i think that's what you're supposed to do | |
| 13:29:41 | sean-k-mooney | mriedem: ah ok i was not sure if there was more or not | |
| 13:29:42 | aspiers | mriedem: he is using mock_open() | |
| 13:30:00 | aspiers | oh ok sorry, not in test__disable_ipv6() | |
| 13:30:08 | yonglihe | spec "show-server-numa-topology" need core reviewer, alex_xu, mriedem , hope you have time , thanks. https://review.opendev.org/#/c/658716/ | |
| 13:30:27 | yonglihe | sean-k-mooney, hi, have a good day. | |
| 13:30:31 | sean-k-mooney | i got confused by the other stuff that aspiers is andding in nova for conditional mocking which we dont need | |
| 13:31:00 | aspiers | sean-k-mooney: right, the conditional stuff isn't usually needed for unit tests, just for functional | |
| 13:31:16 | aspiers | the docstring I added for patch_open covers that in detail | |
| 13:31:20 | sean-k-mooney | yonglihe: o/ | |
| 13:31:48 | sean-k-mooney | aspiers: right but i dont want to prot that to os-vif unless we really need it for something | |
| 13:32:17 | sean-k-mooney | in the unit test we have we dont really need it | |
| 13:32:31 | sean-k-mooney | and our functional test are intended to actully create bridges and ports | |
| 13:32:37 | aspiers | sean-k-mooney: sure, I think I just said that :) | |
| 13:32:50 | aspiers | you don't need it in this case | |
| 13:32:58 | sean-k-mooney | yep | |
| 13:36:09 | yonglihe | sean-k-mooney, we kind of address the NUMA stuff concern, i hope this spec cloud get approved. wish me lucky. | |
| 13:37:46 | sean-k-mooney | yonglihe: yes i reviewd the latest version and it looked fine to me https://review.opendev.org/#/c/658716/ | |
| 13:38:46 | sean-k-mooney | yonglihe: johnthetubaguy and alex_xu are p[roably the people you need to convicne now | |
| 13:40:26 | yonglihe | sean-k-mooney, sure, only if they got spare time. | |
| 13:42:49 | yonglihe | sean-k-mooney, and i'm working on to checking the vm's signature to make sure we delete only the VM OS created. That cleanup orphan suff. | |
| 13:43:52 | stephenfin | lyarwood, artom: Do I need to rebase the whole series for this so? http://logs.openstack.org/11/651311/11/check/openstack-tox-py27/5910a90/testr_results.html.gz | |
| 13:43:59 | stephenfin | Not sure if it's even fixed yet | |
| 13:44:05 | stephenfin | Or do we need a fix? | |
| 13:44:52 | openstackgerrit | Eric Fried proposed openstack/nova master: fup: Remove unused mock in libvirt functional base https://review.opendev.org/664449 | |
| 13:45:25 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove unused mock in libvirt functional base https://review.opendev.org/664449 | |
| 13:49:00 | sean-k-mooney | yonglihe: ah ok cool yes that would be a nice saftey feature to add for the libvirt driver so im glad to hear your looking into it | |
| 13:50:11 | yonglihe | There may have some gap, if that VM no db recording and we want get the whole xml parsed i guess. | |
| 13:56:55 | artom | stephenfin, not sure what to tell you, lyarwood has more context I believe | |