Posted	Nick	Remark
#openstack-nova - 2019-06-07
01:55:10	sean-k-mooney	but i tend to shift my day to overlap with the us more
01:57:52	sean-k-mooney	i would normally end my day and go to sleep at aound 1 am but i was tired and went to bed at 8pm today but when i do that i never get more then about 4 hours and then i get up and work for a bit and typically go back to sleep around 3-4 ish
01:58:11	sean-k-mooney	or 8-9 ish if my sleeping pattern is totally messed up
03:28:23	openstackgerrit	Daniel Speichert proposed openstack/nova-specs master: Directly download and upload images to RBD https://review.opendev.org/658903
04:32:17	openstackgerrit	Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664
04:32:18	openstackgerrit	Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023
07:20:03	openstackgerrit	Brin Zhang proposed openstack/nova master: WIP:Specify availability_zone to unshelve https://review.opendev.org/663851
07:55:27	kashyap	sean-k-mooney: Yeah, I _did_ see the obscure "vm_mode" yesterday, and reading its documentation. It is a Xen-related term, but used as a general abstraction in Nova to represent any hypervisor
07:56:11	kashyap	tonyb: I wanted to do some tests on AArch64 host; got it from another dev.
07:56:44	kashyap	efried: No, that "pick guest arch" Blueprint is not for Train. (It's Tech Debt)
08:39:51	tonyb[m]	kashyap: okay have fun
09:50:49	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Fold ComputeManager._resize to its only caller https://review.opendev.org/663873
10:23:37	stephenfin	RuntimeError: On Python 3, zvm sdk supports to Python 3.6
10:23:45	stephenfin	and all I want to do is build docs
10:24:14	stephenfin	We need to find some way to move that out of requirements.txt. More hassle than it's worth.
10:37:33	openstackgerrit	Stephen Finucane proposed openstack/nova stable/rocky: docs: Don't version links to reno docs https://review.opendev.org/662178
10:37:34	openstackgerrit	Stephen Finucane proposed openstack/nova stable/rocky: tox: Use basepython of python3.5 https://review.opendev.org/663887
10:37:34	openstackgerrit	Stephen Finucane proposed openstack/nova stable/rocky: tox: Stop build *all* docs in 'docs' https://review.opendev.org/663888
11:40:18	sean-k-mooney	just an fyi but i have marked https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration as implemented/complete since the documentation update we were waiting for is now merged in neutron.
11:48:01	openstackgerrit	Theodoros Tsioutsias proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.opendev.org/648686
12:28:57	openstackgerrit	Merged openstack/nova master: Make nova-next archive using --before https://review.opendev.org/661002
12:35:47	openstackgerrit	Merged openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806
12:35:56	openstackgerrit	Merged openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904
12:50:33	openstackgerrit	Dr. Clemens Hardewig proposed openstack/nova master: Fixes instance resizing/migration when swap volume is on lvm https://review.opendev.org/618621
12:50:34	openstackgerrit	Dr. Clemens Hardewig proposed openstack/nova master: This patch is to fix bug #1831657 https://review.opendev.org/663926
12:50:35	openstack	bug 1831657 in OpenStack Compute (nova) "Instance migration/Instance resize with lvm volumes" [Undecided,New] https://launchpad.net/bugs/1831657
12:57:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'ComputeManager._reschedule' https://review.opendev.org/660774
12:57:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311
12:57:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
12:57:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
12:57:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
12:57:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
12:57:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
12:57:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
12:57:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
12:58:12	stephenfin	gibi++
12:58:21	stephenfin	Thanks for taking a look at those tests
13:28:55	mriedem	stephenfin: gibi: comments inline on https://review.opendev.org/#/c/660774/
13:29:05	mriedem	for the notification sample test weirdness
13:29:47	stephenfin	in a meeting but I'll look after
13:30:17	stephenfin	mriedem: Actually, I did try to that. It failed miserably
13:31:02	stephenfin	The issue that I pointed out previously is that I want the call to succeed in the other places it's called
13:31:08	stephenfin	And just stub out that one caller
13:31:43	gibi	stephenfin, mriedem: I can try to iterate on those tests sometime next week
13:40:33	mriedem	i can play with it, maybe 3 sets of eyes can sort it out
13:42:53	gibi	mriedem: one hint, in those resize sample tests there is only one compute (as far as I see) but still there is a successfull re-schedule attempt
13:43:40	mriedem	which is totally unrealistic but ok
13:44:11	mriedem	maybe it's not unrealistic i guess, hard to know how this flow really works
13:44:36	mriedem	it would be unrealistic to reschedule and land back on the same host
13:44:43	sean-k-mooney	gibi: a rescuderl would only work in that case if the retry filter is disabled
13:45:17	gibi	mriedem: that two test are totally unrealistic :/
13:45:18	mriedem	we don't go back through the scheduler on a reschedule
13:45:21	mriedem	since queens
13:45:40	gibi	mriedem: fault injection is hard
13:45:51	mriedem	in fact we could probably deprecate the RetryFilter
13:45:56	mriedem	i don't think it's ever used anymore
13:46:05	mriedem	anyway, bbiab
13:46:24	sean-k-mooney	that worth looking into
13:46:43	sean-k-mooney	ill file a bug so we dont forget
13:53:59	stephenfin	mriedem: Yeah, if you've ideas I'd be happy to hear them. Those tests really aren't good but I'm out of ideas at this point
14:15:45	mriedem	i'll tinker
14:21:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Deprecate RetryFilter https://review.opendev.org/663953
14:21:40	mriedem	sean-k-mooney: let's see what blows up ^
14:21:48	mriedem	edleafe: ^
14:24:13	stephenfin	mriedem: Would you be okay with the named kwargs thing if it was a separate patch? I think it's a nice readability improvement but it probably shouldn't be munged with other stuff alright
14:24:24	stephenfin	Referring to https://review.opendev.org/#/c/651311/
14:26:04	mriedem	i disagree that it's a readability improvement...
14:26:23	mriedem	by that logic we'd use named kwargs on everything
14:27:01	mriedem	stephenfin: i'm going to pull the series down and tinker with those notification tests for reschedule and if i come up with someting cleaner i can push that up and remove the kwargs in the next patch in the series while i'm at it
14:27:13	sean-k-mooney	mriedem: i have disabled the retry filter in one of my nfv job iteration and it more orless seam to be fine so i suspect it will not blow up or not blow up too badly
14:27:41	stephenfin	mriedem: Not everything. Just things that have a lot of arguments (it's subjective but I'd say > 5)
14:28:05	sean-k-mooney	im on a triage call but ill file the bug and coment on your patch when im done
14:28:13	mriedem	sean-k-mooney: bug?
14:28:31	mriedem	it's not really a bug that we forgot to deprecate the RetryFilter in Rocky
14:28:42	sean-k-mooney	ok
14:29:06	sean-k-mooney	in that case ill just keep an eye on the test results :)
14:30:48	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311
14:30:48	openstackgerrit	Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
14:30:49	openstackgerrit	Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
14:30:49	openstackgerrit	Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
14:30:50	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
14:30:50	openstackgerrit	Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
14:30:51	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
14:30:51	openstackgerrit	Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
14:30:52	openstackgerrit	Stephen Finucane proposed openstack/nova master: Use named kwargs for resize_api https://review.opendev.org/663959
14:36:32	artom	bauzas, thanks for the note on https://review.opendev.org/#/c/644881/21, will address after this call. Also need to address mriedem's commit message feedback, which I completely forgot about the first time around
14:37:31	mriedem	oh right you want to backport that....
14:37:38	mriedem	i was going to say we don't need a release note for a virt driver interface change,
14:37:42	mriedem	but if we're backporting...
14:38:17	mriedem	we did this recently for an ironic driver related fix and handled a TypeError in the backportable version and removed it in a follow up on master
14:39:04	mriedem	https://github.com/openstack/nova/blob/stable/rocky/nova/compute/manager.py#L7648
14:39:13	mriedem	given that, we may want to follow the same pattern here
14:39:29	mriedem	it is admittedly bending over backward for out of tree drivers which is being exceedingly nice
14:40:19	artom	Wait, won't that leave vm_instance unset and blow up later?
14:40:52	artom	Oh, actually no.
14:41:15	artom	vm_power_state will be unset, but it's only used in an if
14:41:35	artom	OK, I'll do something similar when I backport
14:41:39	mriedem	for your change it would mean adding a try/except TypeError around the call to finish_revert_migration and if we get a TypeError, call again without the vifs_already_plugged kwarg
14:41:51	mriedem	when you backport? if we do this, you'd do it on master,
14:41:57	mriedem	and then follow up with a patch to remove that handling

Earlier   Later