| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-06 | |||
| 16:43:08 | mriedem | kind of scatterbrained though | |
| 16:49:44 | openstackgerrit | sean mooney proposed openstack/nova master: extend libvirt video model support https://review.opendev.org/647733 | |
| 16:50:01 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: stop admin_password information leakage https://review.opendev.org/663721 | |
| 16:50:07 | sean-k-mooney | johnthetubaguy: sorry for the delay but i have added the extra testing to ^ | |
| 16:50:26 | artom | mriedem, thank you for your dump (should TYFYD become a thing?) | |
| 16:50:59 | johnthetubaguy | sean-k-mooney: I have to run now, tuba rehearsal later, putting it on the pile | |
| 16:51:11 | sean-k-mooney | no worries | |
| 16:51:37 | sean-k-mooney | am i think it more or less ready to go but we can proably drop it out of the runway at this point | |
| 16:53:53 | artom | I thought they were different operations? | |
| 16:54:19 | sean-k-mooney | they are but they share alot of the same code | |
| 16:54:33 | sean-k-mooney | the only real differens is a cold migrate does not change teh flavor | |
| 16:54:40 | sean-k-mooney | everything else is the same | |
| 16:55:24 | artom | Aha... | |
| 16:55:41 | sean-k-mooney | i think there is some special caseing for resize to the same host but again its minimal | |
| 16:56:19 | artom | mriedem, so, my first thought is, if we already have it in tempest-slow, then keep it there | |
| 16:56:32 | artom | So I'd just abandon https://review.opendev.org/#/c/653498/ entirely | |
| 16:57:11 | artom | But since I don't want to block on https://review.opendev.org/#/c/663405/1, I'd put the fix patch below it | |
| 16:57:29 | artom | So we'd get the revert test coverage with the fix | |
| 16:58:32 | mriedem | artom: cold migrate and resize are the same except for the flavor | |
| 16:58:41 | mriedem | for the intent of your bug fix, it doesn't matter which one runs | |
| 16:58:59 | artom | Conversely, skip the revert tests in tempest-slow entirely, and keep my multinode patch. Because of the -slow part | |
| 16:59:15 | mriedem | artom: i was also thinking that if i can get that cold migrate resize revert test unskipped then yeah we don't need to add new tests to the nova-live-migration job | |
| 16:59:21 | kashyap | stephenfin: mriedem: sean-k-mooney: As promised, I bring you https://blueprints.launchpad.net/nova/+spec/pick-guest-arch-based-on-host-arch-in-libvirt-driver | |
| 16:59:38 | kashyap | [Corrections, snide remarks, rotten tomatoes welcome.] | |
| 16:59:40 | mriedem | artom: i'm not sure how you'd depend on https://review.opendev.org/#/c/663405/ if you drop your job rename patch | |
| 17:00:43 | artom | mriedem, I'd "rebase" my fix below it in order to, in the top patch (aka 663405), still have a revert test with my fix | |
| 17:01:08 | sean-k-mooney | kashyap: there is a way to select host that have hardware accleration already | |
| 17:02:51 | mriedem | artom: you can't rebase a nova change "below" https://review.opendev.org/#/c/663405/ since it's in a different repo... | |
| 17:03:20 | sean-k-mooney | kashyap: you can use the vm_mode image property and specify hvm https://github.com/openstack/glance/blob/master/etc/metadefs/compute-hypervisor.json#L30-L41 | |
| 17:03:23 | artom | *facepalm* | |
| 17:03:53 | artom | mriedem, make yours depend on mine then, same effect, right? | |
| 17:04:48 | sean-k-mooney | kashyap: that said we never test that in the ci as far as im aware so no idea if it really works | |
| 17:05:44 | mriedem | artom: that's one option yeah. i'm not sure it's the right option...since unskipping that test should be possible without your change - although i guess one could argue that maybe the test isn't safe if you're using ovs hybrid plugging w/o your fix | |
| 17:06:21 | artom | mriedem, unskipping that change *is* possible without my fix (upstream gate doesn't use hybrid plug) | |
| 17:06:43 | artom | My idea was more to have integration test coverage of my code, at least in the non-hybrid-plug case | |
| 17:08:09 | mriedem | artom: i think you missed my point, | |
| 17:08:15 | mriedem | tempest can be run anywhere on any config, | |
| 17:08:16 | artom | It happens a lot | |
| 17:08:18 | mriedem | since it's just hitting APIs, | |
| 17:08:40 | artom | OOOIC | |
| 17:08:44 | mriedem | so while unskipping it could be ok in the gate b/c of how most of the devstack jobs are setup (ovs w/o hybrid plug or lb), | |
| 17:08:51 | artom | Upstream gate would be fine, but we'd break someone else who runs it with hybrid plug | |
| 17:08:54 | mriedem | that doesn't mean someone, like your downstream ci, could break on it | |
| 17:09:02 | mriedem | correct | |
| 17:09:11 | mriedem | i'm basically convincing myself on your behalf | |
| 17:09:12 | artom | Our downstream CI is permanently on fire anyways | |
| 17:09:17 | mriedem | b/c of tripleo | |
| 17:09:18 | mriedem | sure | |
| 17:09:19 | mriedem | :) | |
| 17:09:20 | artom | (Did I say that out loud? It's not true, obviously) | |
| 17:09:59 | sean-k-mooney | sure... | |
| 17:10:44 | artom | mriedem, what I selfishly *don't* want to do is have my fix depend on your tempest patch | |
| 17:11:13 | artom | Because your tempest patch might be stuck in recheck hell for a while, and I'm in a *massive* hurry ;) | |
| 17:11:40 | artom | But... I think you made the case for me that it's better the other way around anyways | |
| 17:11:48 | efried | kashyap, mriedem: https://blueprints.launchpad.net/nova/+spec/pick-guest-arch-based-on-host-arch-in-libvirt-driver for train? | |
| 17:12:12 | sean-k-mooney | efried: proably not | |
| 17:12:20 | mriedem | efried: no | |
| 17:12:25 | efried | ight, thx | |
| 17:12:31 | mriedem | imo | |
| 17:12:43 | efried | just wanted to tag series goal if so, so it shows up on dashboard things. | |
| 17:12:50 | efried | NOT tagging. | |
| 17:13:06 | sean-k-mooney | do we have a NEXT tag or somthing we can use | |
| 17:13:08 | mriedem | artom: i have a hard time knowing what your team considers a priority ever really... | |
| 17:13:10 | sean-k-mooney | e.g. after train | |
| 17:13:27 | mriedem | until the boss (mdbooth) shows up asking for reviews | |
| 17:13:49 | sean-k-mooney | mriedem: our relase folk considers it a blocker for the osp 15 beta | |
| 17:13:56 | artom | mriedem, speaking for myself I try not to push that angle too much, because what's important for upstream isn't necessarily what's important for us | |
| 17:14:07 | artom | Or vice versa | |
| 17:14:23 | mriedem | sean-k-mooney: did those people never realize this has always been broken? | |
| 17:14:29 | sean-k-mooney | but its a beta so its not going to break production deployments | |
| 17:14:36 | artom | I just feel weird saying "well this thing is super important for *us*, so dump everything else and work on my thing" | |
| 17:14:41 | mriedem | unless you guys just changed to hybrid plug | |
| 17:14:55 | artom | But if you'd rather I just be up front about it, I can do that too | |
| 17:15:01 | mriedem | btw, whatever happened with russell ovn'ing the world at rh? | |
| 17:15:03 | sean-k-mooney | mriedem: its because its showing up in the downstream ci and that makes them unhappy | |
| 17:15:11 | mriedem | sean-k-mooney: oh easy, just stop doing testing :) | |
| 17:15:17 | mriedem | then you're in the same state as before | |
| 17:15:21 | mriedem | heads in the sand and whatnot | |
| 17:16:13 | melwitt | I think we switched our default network backend to ovn recently. sean-k-mooney correct me | |
| 17:16:18 | mriedem | artom: if you're cool with dropping the nova-live-migratoin rename + resize revert stuff (i still thing the rename is good at some point, just not while hurrying for a fix) i'm ok with adding a depends-on from my unskip to your fix | |
| 17:16:25 | sean-k-mooney | hehe well for 15 we were planning to test with ovn but it has other issues | |
| 17:16:39 | mriedem | ooo the plot thickens | |
| 17:16:48 | artom | mriedem, 🤝 | |
| 17:17:01 | artom | (That's a handshake shaped like a yellow heart) | |
| 17:17:10 | mriedem | ok - yeah pidgin doesn't render those | |
| 17:17:29 | melwitt | I can see it. looks cool | |
| 17:17:35 | artom | sean-k-mooney, so what's geneve? another name for OVN? | |
| 17:17:40 | sean-k-mooney | melwitt: yes but ovn has only works when we disabel waiting for the network-evnets on live migation so i think they wanted to test ml2/ovn with iptabls as a fallback plan | |
| 17:17:45 | artom | 'cuz that's the default networking thingee in our ospd custom job | |
| 17:17:59 | sean-k-mooney | geneve is a l3 tunneling protocol like vxlan | |
| 17:18:20 | sean-k-mooney | and its the protocol ovn uses for its networking by defualt | |
| 17:19:02 | sean-k-mooney | artom: you are refering to the neutron type driver which for ovn would be geneve | |
| 17:19:16 | artom | sean-k-mooney, "Choose the network variant (default for OSP15 is 'geneve') | |
| 17:19:16 | artom | For the geneve option set the NETWORK_OVN paremeter to yes." | |
| 17:19:26 | artom | (Form the Jenkins job build page) | |
| 17:19:32 | artom | So yeah, looks like OSP15 default is OVN | |
| 17:20:13 | sean-k-mooney | mriedem: but to your point yes this has always been broken in one way or another | |
| 17:21:09 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | |
| 17:21:09 | sean-k-mooney | but we i think we only started waithing in stien so its only showing up now as they are testing Stien/osp15 | |
| 17:22:08 | artom | sean-k-mooney, I guess you can abandon https://review.opendev.org/#/c/660782/ now, since we're settling on https://review.opendev.org/#/c/663405/1 | |