Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-05
15:26:33 mriedem tssurya: what is your max_placement_results value now?
15:29:00 tssurya mriedem: 10 still
15:29:59 mriedem heh
15:46:00 openstackgerrit Eric Fried proposed openstack/nova master: Raise if flavor and image disagree on hide_hypervisor_id https://review.opendev.org/663365
15:47:01 efried mriedem: Can we +W https://review.opendev.org/#/c/579897/ now?
15:51:36 mriedem jesus look at all of the new review comments i have to parse
15:53:02 efried only since your last +2
15:53:07 efried kashyap: you still around?
15:53:27 mriedem ok i have it in a tab but in the middle of something
15:53:49 dansmith in case you're wondering,
15:53:52 dansmith I hate it.
15:53:56 efried kashyap: I'd be happy to fix up those couple of typos in https://review.opendev.org/#/c/661574/ if you like.
15:54:19 efried dansmith: necessary evil
15:54:28 dansmith not really
15:55:44 openstackgerrit Eric Fried proposed openstack/nova master: Document mitigation for Intel MDS security flaws https://review.opendev.org/661574
15:56:16 efried kashyap: +2 ^ thanks for your patience
15:59:24 openstackgerrit John Garbutt proposed openstack/nova master: WIP: add scope check, see tests catch the change https://review.opendev.org/657823
16:08:37 jaypipes mriedem: for the record, I haven't died or anything. :P
16:09:09 mriedem jaypipes: i know you're not dead, but i also assume you don't want/need to be pinged for stuff you're not going to have the time to work on
16:10:03 jaypipes mriedem: I'd chatted with Surya about that patch series in Denver and stated I'd rebase, fix merge conflicts and push them, which I did. I also stated I wouldn't have time to shepherd them through to completion and she mentioned she would do that.
16:10:45 mdbooth lyarwood: Question in your q35 patch: Any reason we can't be explicit about q35 machine type? Are there an unmanageable number of q35 machine types or something?
16:10:46 jaypipes mriedem: I'm around, but as you say, not really time to spend. I'm still friendly, though. :)
16:11:12 mriedem jaypipes: ok i didn't mean any offense
16:11:21 mriedem just trying to not distract you
16:11:29 jaypipes no offense taken at all!
16:13:51 lyarwood mdbooth: so yeah there are a few and even more downstream iirc
16:14:13 lyarwood mdbooth: $ qemu-kvm --machine help | grep q35 | wc -l
16:14:17 mdbooth lyarwood: Can you enumerate the problem?
16:14:18 lyarwood mdbooth: 11
16:14:55 mdbooth That is... quite annoying
16:15:05 lyarwood mdbooth: We should really but that's additional work outside of this bugfix IMHO
16:15:06 mdbooth Worthy of a comment?
16:15:55 lyarwood mdbooth: sure
16:18:16 edleafe jaypipes: "still" friendly? :-P
16:19:06 jaypipes edleafe: :(
16:19:23 mdbooth artom: You on top of review comments from dansmith ?
16:19:44 artom mdbooth, working on it, yeah
16:25:42 kashyap efried: Was out for a bike ride; now here for a bit more.
16:27:30 kashyap efried: Ah, you've fixed up the typos; thank you!
16:28:22 openstackgerrit Adrian Chiris proposed openstack/nova stable/queens: Move get_pci_mapping_for_migration to MigrationContext https://review.opendev.org/661571
16:28:22 openstackgerrit Adrian Chiris proposed openstack/nova stable/queens: Allow driver to properly unplug VIFs on destination on confirm resize https://review.opendev.org/661572
16:31:33 kashyap stephenfin: O Docs Aficionado, when you can, please deliver this from its misery: https://review.opendev.org/#/c/661574
16:33:29 stephenfin kashyap: Might be better let alex_xu grab it since he's taken a look a few times already
16:33:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Delete unused get_all_host_states method https://review.opendev.org/663377
16:33:50 kashyap Oh, right. I totally forgot that; #bumblebee's-memory-7-seconds
16:34:35 kashyap mdbooth: On the number of machine types -- yes, *each* QEMU release comes with a versioned machine type
16:34:46 kashyap Why versioned machine type? They preserve guest ABI.
16:35:06 openstackgerrit Sylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when resizing https://review.opendev.org/589085
16:35:48 kashyap mdbooth: And the "naked" 'q35' aliases to the latest versioned machine type.
16:41:48 sean-k-mooney kashyap: the version machine types also create vendor lock in as they are different between distro and make it hard to migrate form one to another in some cases
16:42:38 sean-k-mooney so there are pros and cons i prefer just q35 but there are reason to use the versioned form too
16:42:45 kashyap I wouldn't call it "vendor lock-in". Each distribution is *supposed* to pick machine types as they see fit.
16:42:57 kashyap It's like saying you can install DEBs on an RPM-based system.
16:43:08 sean-k-mooney it kind of is when each distro add the name of the distor into the machine type
16:43:24 sean-k-mooney kashyap: well you can
16:43:34 sean-k-mooney using alien
16:43:38 kashyap Yeah, unfortunately, given the "there are more number of Linux distros than Linux users", we have to live with it...
16:43:42 sean-k-mooney but its more complicated
16:44:33 sean-k-mooney kashyap: it would be nice if we just had a propatable set defiend by qemu or libvirt that all distos used
16:44:55 kashyap Sorry, what is a "propatable"?
16:45:01 sean-k-mooney portable
16:45:30 sean-k-mooney or interoperable
16:45:44 kashyap Aaah, I don't know how feasible that is; need to think with a fresh brain :-)
16:45:54 kashyap Alright, need to go cook make food. See ya
16:46:35 sean-k-mooney i think recent version of libvirt or qemu have got better of checking compatibliy if you use the alais e.g. "q35"
16:47:26 sean-k-mooney but i dont know if it will allow q35-centos... to migrate to q35-rhel... even if they are the same
16:48:00 sean-k-mooney i know it did not work betweeen centos and ubunut in the past but if sepcifically set them to the same machine type it did
16:50:26 aram1s Hi there! Does anyone know what the 'state' represents for hypervisors? I thought it reflected the state of nova compute service but when I disable it I still see it as up
16:50:52 aram1s how can I make it go down?
16:51:30 aram1s without explicitly setting it as down. Will it chance based on any other status?
16:51:37 aram1s change*
17:00:16 melwitt aram1s: status will also change if you for example, stop the nova compute service
17:00:43 melwitt other than that, there's the forced_down API https://developer.openstack.org/api-ref/compute/?expanded=update-forced-down-detail#update-forced-down
17:01:48 stephenfin mriedem: Could you drop your -2 from these given my comments inline? https://review.opendev.org/#/c/662501/ https://review.opendev.org/#/c/662502/
17:03:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382
17:08:08 mriedem stephenfin: of course the ec2 objects aren't used outside of nova https://review.opendev.org/#/c/662502/
17:08:22 mriedem the ec2 API shim within nova is what's going to be used by the ec2api code
17:08:28 mriedem which uses those objects
17:08:38 stephenfin It doesn't though
17:08:42 mriedem the ec2utils stuff might be different
17:09:14 stephenfin Not used anywhere outside of nova and not used inside nova either
17:09:55 stephenfin At least not once I've removed the unused functions from ec2utils
17:10:00 mriedem i'd feel a lot more comfortable with this if we could get a tempest run on the ec2api with a dependency on this series
17:10:23 stephenfin I can try figure out how to do that
17:11:03 mriedem it should be as easy as adding openstack/nova to https://github.com/openstack/ec2-api/blob/master/.zuul.yaml#L7 and adding a depends-on to your series
17:16:58 aram1s thanks melwitt!
17:17:40 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Remove unused functions from 'ec2utils' https://review.opendev.org/662501
17:17:41 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove unused ec2 objects https://review.opendev.org/662502
17:17:41 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Remove ec2.CloudController https://review.opendev.org/662503
17:17:42 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Pre-move cleanup of utils https://review.opendev.org/662504
17:17:42 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Move ec2utils functions to their callers https://review.opendev.org/662505
17:17:43 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506
17:19:32 stephenfin mriedem: Thanks for the tip. We'll see how this goes https://review.opendev.org/663386
17:34:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert HostMapping.cells to a dict https://review.opendev.org/663387
17:34:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Cache host to cell mapping in HostManager https://review.opendev.org/663388
17:38:07 artom I feel like I've messed up my method if I need to mock like 42 things when unit testing it :(
17:38:25 mriedem your method is too big
17:38:57 artom That's never been a problem before
17:50:51 edleafe artom: generally a "unit" doesn't have 42 dependencies.
17:51:46 artom 42 is obviously an exaggeration, but yeah, this bit of code is heavily coupled to a lot of things

Earlier   Later