| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-04 | |||
| 19:13:01 | mriedem | ok. in my reply i said we could build that in, so i might as well i guess, i'll move that out of alternatives. | |
| 19:31:57 | efried | melwitt: Is there a reason you're holding back from approving https://review.opendev.org/#/c/579897/ ? | |
| 19:34:06 | melwitt | efried: yeah, I hadn't reviewed deep into the change previously and don't know much about the context (the original feature). but since I had expressed a reno would be helpful, I reviewed the change and acked on that basis | |
| 19:34:44 | efried | okay, thanks. | |
| 19:34:47 | mriedem | efried: dustinc: i'm marking https://review.opendev.org/#/c/662881/ as a WIP since it's clearly a WIP | |
| 19:34:49 | efried | Not sure who we're looking for to send it | |
| 19:34:59 | efried | ack mriedem | |
| 19:35:31 | mriedem | efried: just spin the roulette wheel of nova cores | |
| 19:36:04 | efried | mriedem: Tempted to send it myself, adding my almost+2 to the testament of people who tested it live | |
| 19:36:25 | mriedem | probably shouldn't, | |
| 19:36:33 | mriedem | just wait for stephenfin or johnthetubaguy to take a look i'd say | |
| 19:36:39 | efried | I didn't touch much of it. But yeah. | |
| 19:37:09 | mriedem | https://www.youtube.com/watch?v=JGftIcp2SC0 ? | |
| 19:37:26 | dansmith | rock on | |
| 19:37:56 | melwitt | lol, a song for every occasion | |
| 19:38:36 | mriedem | bon was ahead of his time when it came to collaborative software development | |
| 19:39:42 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add regression recreate test for bug 1830747 https://review.opendev.org/663124 | |
| 19:39:43 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/663125 | |
| 19:39:44 | openstack | bug 1830747 in OpenStack Compute (nova) rocky "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | |
| 19:40:08 | sean-k-mooney | efried: for what its worth i think the hypervior hiding chance makes sense the only reservation i have is nvida or other may work around this in the future so i tond want us to have to keep addign these workaround but for this specific case i think it makes sense | |
| 19:44:13 | dustinc | mriedem: thanks, I meant to put WIP in the title | |
| 20:13:45 | efried | dustinc: In case it's not clear, if it looks like I'm answering questions in the sdk spec, me (or anyone) answering in comments isn't the end of the road - the salient points should be included in the document itself. | |
| 20:27:03 | dustinc | efried: very clear, thanks | |
| 20:40:57 | mriedem | i'm assuming i'm not alone in saying if we add support to pass an az to the unshelve api https://review.opendev.org/#/c/624689/ we should/would not support the zone:host:node format like on server create which bypasses the scheduler and forces the server onto the specified host and/or node | |
| 20:41:16 | mriedem | from earlier review on the spec i think at least alex_xu agrees with me on ^ | |
| 20:44:06 | efried | mriedem: You appear to be alone in saying that, at least right now. But I wouldn't take that as dissent. | |
| 20:44:27 | mriedem | https://review.opendev.org/#/c/624689/7/specs/train/approved/support-specifying-az-when-restore-shelved-server.rst@49 | |
| 20:46:40 | melwitt | if it's "obvious" that the only utility for zone:host:node was getting a server into a specific az, then I would agree, but I don't feel sure that's the only reason people were using it | |
| 20:46:54 | melwitt | *for unshelve | |
| 20:59:18 | mriedem | i'm not sure what that means | |
| 20:59:41 | mriedem | zone:host:node is used during server create to force the server on a specific host and/or node if you're an admin | |
| 21:00:24 | mriedem | if you're non-admin you can only specify zone | |
| 21:05:34 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Add regression recreate test for bug 1830747 https://review.opendev.org/663143 | |
| 21:05:36 | openstack | bug 1830747 in OpenStack Compute (nova) rocky "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | |
| 21:05:36 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/663144 | |
| 21:05:40 | melwitt | oh, sorry, I misunderstood what was happening in the spec. I thought that today zone:host:node is supported and that they wish to add specifying az (for non-admins) and that they were proposing removing zone:host:node as part of the change | |
| 21:06:26 | mriedem | nope, just wanting to add az to unshelve | |
| 21:06:45 | melwitt | I see now that today there is no zone:host:node support and they want to add specification of az and they're proposing doing it via zone:host:node. I agree it should not be done that way because that's more than only adding the az, that's adding scheduler bypass, as you said | |
| 21:06:58 | mriedem | yar | |
| 21:15:47 | mriedem | thanks | |
| 21:25:52 | openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: WIP: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | |
| 22:06:34 | cfriesen | when a nova-compute service is deleted in nova, is that supposed to also remove the relevent row in the resource_providers table? | |
| 22:07:37 | efried | cfriesen: If it's deleted through proper channels, I think so? | |
| 22:07:54 | efried | that would seem to be a pretty obvious miss if not | |
| 22:08:51 | efried | You're supposed to stop the service before you delete it | |
| 22:09:05 | efried | otherwise the compute will reassert its RP the next time periodics run. | |
| 22:09:07 | cfriesen | I'm debugging a situation with Pike where deleting nova-compute and then adding it back with the same name ends up not updating the resource_providers row so it points at the deleted entry in compute_nodes. | |
| 22:09:24 | efried | oh, yeah, pretty sure there's been a bug or three about that. | |
| 22:09:37 | efried | mriedem_away would be able to recite the number off the top of his head. | |
| 22:10:23 | efried | Fraid I gotta run. Good luck :) | |
| 22:10:39 | cfriesen | thanks. :) | |
| 22:12:36 | openstackgerrit | sean mooney proposed openstack/nova-specs master: add libvirt pqos spec https://review.opendev.org/662264 | |
| 22:41:32 | cfriesen | efried: FYI, pretty sure I found the missing commits. seems we weren't up-to-date with upstream stable/pike | |
| 23:16:14 | openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: WIP: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | |
| #openstack-nova - 2019-06-05 | |||
| 00:08:35 | openstackgerrit | Merged openstack/python-novaclient master: Blacklist python-cinderclient 4.0.0 https://review.opendev.org/662912 | |
| 00:26:55 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace 'is comprised of' with 'comprises' https://review.opendev.org/663175 | |
| 00:37:47 | openstackgerrit | Brin Zhang proposed openstack/nova stable/rocky: Replace the invalid index of nova-rocky releasenote https://review.opendev.org/663178 | |
| 00:59:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary setUp methods https://review.opendev.org/663179 | |
| 01:01:23 | alex_xu | The vPMEM spec is ready for review https://review.opendev.org/#/c/601596/, in case of anyone still at the day of spec review day~ | |
| 01:52:57 | openstackgerrit | ya.wang proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681 | |
| 07:20:44 | openstackgerrit | Merged openstack/nova master: Make all functional tests reusable by other projects https://review.opendev.org/657659 | |
| 08:08:13 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237 | |
| 08:08:14 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | |
| 08:14:33 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server https://review.opendev.org/624689 | |
| 08:33:27 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using q35 machine type https://review.opendev.org/663011 | |
| 08:33:28 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887 | |
| 08:54:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | |
| 08:55:07 | stephenfin | bauzas: Is this clear(er) now? https://review.opendev.org/#/c/660774/3/nova/compute/manager.py | |
| 09:01:15 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | |
| 09:20:09 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using q35 machine type https://review.opendev.org/663011 | |
| 09:20:10 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887 | |
| 09:25:29 | kashyap | lyarwood: When you respin, an Ultra-OCD nit (please don't hate me) : s/q35/'q35'/ (or Q35). | |
| 09:38:03 | mdbooth | kashyap: We should put quotes round q35? | |
| 09:38:37 | kashyap | mdbooth: Not "should", but just a literal of some kind to show that it is a tiny code fragment, if you're using lowercase | |
| 09:38:56 | mdbooth | -EPARSE | |
| 09:39:40 | mdbooth | Is this in the context of lyarwood 's specific patch, or in general? | |
| 09:40:02 | kashyap | In general. | |
| 09:40:24 | mdbooth | kashyap: I agree with you: that's an Ultra-OCD nit ;) | |
| 09:40:25 | kashyap | mdbooth: I was saying it in the commit message, not in the code -- sorry, I didn't made that clear | |
| 09:41:01 | kashyap | Yes, because consistency is better than inconsistency, harmony is better than chaos, etc :D | |
| 09:42:03 | kashyap | I mention these (but never -1!) because "you play like you practise". | |
| 09:43:15 | lyarwood | kashyap: if I respin I'll change it to Q35 | |
| 09:43:37 | kashyap | lyarwood: Merci | |
| 10:09:04 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237 | |
| 10:09:04 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | |
| 10:21:49 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | |
| 10:21:49 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887 | |
| 10:32:16 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201 | |
| 10:35:00 | mdbooth | lyarwood: FYI you can just recheck the DNM tempest change | |
| 10:35:25 | mdbooth | Err, no you can't. Thought you were using Depends-On. | |
| 10:36:16 | sean-k-mooney | hehe if its not using Depends-On currently adding it should rerun it right :) | |
| 10:36:45 | mdbooth | sean-k-mooney: Can you Depends-On another change in the same repo? It would be really convenient if you could. | |
| 10:36:46 | sean-k-mooney | oh the tempest change is no | |
| 10:36:48 | sean-k-mooney | nova | |
| 10:37:05 | mdbooth | kashyap: https://review.opendev.org/#/c/663011/6..7/nova/virt/libvirt/blockinfo.py ;) | |
| 10:37:09 | sean-k-mooney | it can if there is no merge conflict but in repo you should jsut rebase on top of the other | |
| 10:37:50 | mdbooth | sean-k-mooney: More thinking about octopus merges. | |
| 10:38:10 | kashyap | mdbooth: One moment | |
| 10:38:26 | mdbooth | sean-k-mooney: i.e. You've got several otherwise independent patches, then a change which requires all of them. | |
| 10:38:49 | sean-k-mooney | mdbooth: yep i have done that before and if there are no merge conflict it works | |