Posted	Nick	Remark
#openstack-nova - 2019-05-30
22:26:22	mriedem	zzzeek: ^
23:06:52	openstackgerrit	Eric Fried proposed openstack/nova master: Bump openstackdocstheme to 1.30.0 https://review.opendev.org/662353
23:07:50	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Bump openstackdocstheme to 1.30.0 https://review.opendev.org/662354
23:25:10	openstackgerrit	Merged openstack/nova master: Remove unused param from _fill_provider_mapping https://review.opendev.org/655107
23:42:16	openstackgerrit	Merged openstack/nova master: Remove zeromq from getting started with compute docs https://review.opendev.org/581926
#openstack-nova - 2019-05-31
00:25:56	zzzeek	mriedem_away: yep still seems like DROP is slow for millions of rows
00:56:15	openstackgerrit	Merged openstack/nova master: Keep attach_mode as top-level field in _translate_attachment_ref https://review.opendev.org/574413
01:19:23	openstackgerrit	Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716
01:54:11	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020
01:54:39	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027
01:54:50	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031
01:55:58	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299
01:56:11	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344
01:56:31	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673
01:56:54	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676
01:57:11	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689
01:57:45	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709
01:58:20	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712
05:06:49	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383
05:48:02	openstackgerrit	Guo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure https://review.opendev.org/661466
07:42:10	openstackgerrit	Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476
08:16:06	kashyap	efried: Yeah, saw it; responded. Will address. (And yes, that "soft -1" is totally justified. :-))
08:40:46	openstackgerrit	zhaixiaojun proposed openstack/nova master: Exclude broken ironicclient versions 2.7.1 https://review.opendev.org/662404
08:43:35	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Add valid compute nodes with host and/or node in api layer https://review.opendev.org/661237
08:43:36	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520
08:43:36	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Add compute_nodes_uuid field to Destination object https://review.opendev.org/661188
08:48:49	openstackgerrit	Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497
09:00:20	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
09:21:47	openstackgerrit	Balazs Gibizer proposed openstack/os-traits master: Add COMPUTE_NET_VF_PARENT_NAME_REPORTING trait https://review.opendev.org/658852
11:02:10	openstackgerrit	John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201
11:26:32	openstackgerrit	Merged openstack/nova-specs master: Cap sphinx for py2 to match global requirements https://review.opendev.org/659205
11:26:33	openstackgerrit	Merged openstack/nova-specs master: Bump openstackdocstheme to 1.30.0 https://review.opendev.org/662354
11:44:00	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Simplfy test setup for TestNovaMigrations* tests https://review.opendev.org/662434
12:05:45	openstackgerrit	Merged openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.opendev.org/642558
12:29:01	kashyap	stephenfin: or anyone: Can you put this through its misery? Already has +2 from Eric: https://review.opendev.org/#/c/639091/
12:29:10	kashyap	("libvirt: Rework 'EBUSY' (SIGKILL) error handling code path")
12:33:24	kashyap	mdbooth: When you can, can I have your your +1 back, too?
12:34:01	mdbooth	kashyap: Well I'm not sure I trust you. I need to check you haven't tried to slip anything by me.
12:34:05	aspiers	ditto for https://review.opendev.org/#/c/661782/ :)
12:34:12	aspiers	haha
12:34:20	kashyap	mdbooth: Haha, sure. Distrust away
12:34:26	aspiers	mdbooth: He's a slippery one, that kashyap ;-)
12:34:32	mdbooth	aspiers: I know!
12:34:41	mdbooth	kashyap: You've rephrased your comment!
12:34:43	mdbooth	-1
12:34:59	kashyap	mdbooth: Hehe, that was after an elaborate discussion with aspiers
12:35:00	aspiers	I mean, he once tried to slip some Perl 4 into nova
12:35:03	kashyap	For better clarity :-)
12:35:21	mdbooth	kashyap: Yeah, that reads a bit better.
12:35:42	kashyap	mdbooth: Thanks. *Clear* phrasing is bloody hard work, it never ceases to amaze me.
12:36:10	kashyap	aspiers: Hah, now, tell the truth
12:36:29	aspiers	OK OK, it's was COBOL
12:36:35	aspiers	it, even
12:37:04	kashyap	aspiers: "It's COBOL all the way down"!
12:37:10	aspiers	:)
12:37:31	aspiers	the parent company I just left (Micro Focus) actually is *the* COBOL company these days
12:37:34	kashyap	aspiers: https://increment.com/programming-languages/cobol-all-the-way-down/
12:38:09	kashyap	aspiers: I see, didn't know.
12:38:18	aspiers	oh yeah, MF mentioned in that article
12:38:37	kashyap	aspiers: I'll address Eric's nits (which you agreed with) in a couple of hours. Finishing up something else that is racing against time.
12:39:19	aspiers	sure
12:40:10	kashyap	aspiers: Unrelated: What terminal font do you use? I'm really enjoying "Liberation Mono Regular"
12:40:14	aspiers	http://www.csis.ul.ie/cobol/exercises/Exm-BestSellersRpt/BestSellers.cbl
12:40:19	aspiers	OK, now I need to wash my eyes out
12:41:33	kashyap	Hehe
12:41:54	aspiers	kashyap: https://github.com/aspiers/desktop-config/blob/master/.Xresources.d/terms.rdb#L237
12:42:38	kashyap	So whatever is the default
12:54:39	stephenfin	kashyap: Done
12:55:29	kashyap	stephenfin: Vielen Dank
13:06:46	mriedem	stephenfin: can you confirm on the todo here to drop the cell_name column https://review.opendev.org/#/c/651309/9/nova/db/sqlalchemy/models.py@343 that you're just talking about from the model and not an actual alter table drop column schema change?
13:31:04	openstackgerrit	Merged openstack/nova master: Stop handling 'InstanceUnknownCell' exception https://review.opendev.org/651307
13:31:15	mriedem	sean-k-mooney: you might want to check my comments in here https://review.opendev.org/#/c/661237/3
13:34:33	mriedem	i thought we agreed in the ML to validate the requested node using placement rather than iterating the cells, but maybe that wasn't clear
13:40:44	stephenfin	mriedem: I just wanted to indicate that the column was unused and _something_ should be done about it. If that's just a case of removing the model and keeping the actual column, I'm a-ok with it
13:40:58	stephenfin	Heck, the thing could stay there forever for all I care. It's just cleanup :)
13:41:28	stephenfin	mriedem: Do you want a follow-up to clarify the comment? If so, what would you propose it says?
13:43:24	mriedem	per those 2 other changes i linked for internal_id and scheduled_at, it looks like a follow up could just be to comment on the column with a comment saying it's still in the db schema but not used in code so it's removed from the model
13:44:23	mriedem	it looks like we actually did a drop column on scheduled_at but never did for internal_id
13:44:53	openstackgerrit	Merged openstack/nova master: Remove unnecessary wrapper https://review.opendev.org/651308
13:46:14	mriedem	stephenfin: +W
13:46:22	stephenfin	ta
13:47:14	mriedem	someone want to get in this very old test patch for dan? https://review.opendev.org/#/c/452006/
13:48:54	openstackgerrit	Merged openstack/nova stable/stein: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/662331
13:55:17	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: DRY up test_rollback_live_migration_set_migration_status https://review.opendev.org/662470
13:55:17	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: Restore connection_info after live migration rollback https://review.opendev.org/662471
13:56:30	stephenfin	gibi: Replied to https://review.opendev.org/#/c/660774/3
13:59:44	mriedem	lyarwood: i kicked out the stein release https://review.opendev.org/#/c/656304/ from the gate so we can get https://review.opendev.org/#/c/656304/ into it
14:02:05	lyarwood	mriedem: ack thanks
14:26:27	openstackgerrit	Julia Kreger proposed openstack/nova stable/stein: [ironic] Don't remove instance info twice in destroy https://review.opendev.org/662479
14:35:11	mriedem	gibi: thanks for wading into the cross-cell resize series
14:35:15	mriedem	you're brave
14:35:20	mriedem	i shall call you beowulf
14:52:55	kashyap	aspiers: Hey, FWIW, Erik Skultety from libvirt upstream was just inquiring about SEV work. I pointed to the in-progress patch series, and what's remaining. And says: "hopefully I'll find some time to go through the patches thoroughly"
14:53:16	aspiers	kashyap: thanks, the more reviews the better!
14:53:31	aspiers	kashyap: is he on IRC?
14:53:54	kashyap	aspiers: On OFTC (#virt): eskultet
14:54:25	efried	aspiers, kashyap: I'm off doing something else but it occurs to me my time right now would be well spent reviewing the os-traits and SEV stuff while y'all are around.
14:54:31	efried	is there an update since yesterday?
14:54:38	efried	esp on the os-traits side?
14:54:47	efried	cause the can't-build-shit thing is getting annoying.

Earlier   Later