Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-22
13:39:38 efried I can see I've not been on the review itself...
13:40:37 stephenfin efried: I assume you got sorted? I'm knee deep in crappy unit tests atm :)
13:40:54 efried stephenfin: Yes thanks.
13:41:06 efried got an answer anyway, if not sorted how I would like.
13:54:59 dansmith mriedem: do we still have a job that does a full archive after tempest?
13:56:37 dansmith I see mention in nova-next, but not sure where it's called
13:56:48 sean-k-mooney as in one that runs https://github.com/openstack/nova/blob/master/gate/post_test_hook.sh
13:57:09 dansmith ah yep
13:57:11 dansmith thanks
13:57:27 sean-k-mooney it looks like 3 https://github.com/openstack/nova/search?q=post_test_hook.sh&unscoped_q=post_test_hook.sh
13:58:47 mriedem nova-next is the one you're looking for
13:59:29 sean-k-mooney its done the live migration job too and the grenade version
13:59:41 mriedem not the same scripts dan is looking for
14:00:18 sean-k-mooney oh right they run a different post test hook
14:00:29 dansmith mriedem: okay the --before patch is too stale to have test output, but wanted to see what that run looks like
14:00:32 sean-k-mooney so ya nova-nextg
14:18:19 openstackgerrit Surya Seetharaman proposed openstack/python-novaclient master: Allow passing negative values for the locked search_opt in cs.servers.list https://review.opendev.org/659783
14:25:53 aarents efried: I think you where about to read this 2 days ago, but you saw that it was no more mergeable. never mind I need a core having a look on this since Matthew has "+1" do you know who can help me on this ? ( https://review.opendev.org/#/c/659054/ )
14:27:03 efried aarents: I'm reviewing it. I have some issues with the test. Working on formulating a solution...
14:28:20 aarents ok
14:28:22 aarents thanks
14:43:40 mriedem https://www.youtube.com/watch?v=SGZqDzb__bw
14:43:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
14:43:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
14:43:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
14:43:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
14:43:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
14:43:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
14:43:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
14:43:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
14:43:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
14:43:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
14:43:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
14:43:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.opendev.org/614037
14:43:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
14:43:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
14:43:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
14:43:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
14:43:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
14:43:55 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source https://review.opendev.org/637058
14:44:12 edleafe mriedem: oh, are you out of /dev/jail?
14:44:20 mriedem let's say yes
14:45:39 prometheanfire failures for the new fasteners fasteners===0.15 http://logs.openstack.org/54/660254/2/check/cross-nova-functional/a0617a9/testr_results.html.gz
14:45:59 openstackgerrit Merged openstack/nova stable/stein: Exclude fake marker instance when listing servers https://review.opendev.org/657421
14:47:07 hansmoleman wth is fasteners and what's using it?
14:47:28 openstackgerrit Boxiang Zhu proposed openstack/nova-specs master: Update "add host and hypervisor_hostname flag to create server" spec https://review.opendev.org/660560
14:49:43 hansmoleman bah oslo.concurrency http://codesearch.openstack.org/?q=import%20fasteners&i=nope&files=&repos=
14:50:02 hansmoleman prometheanfire: open a bug please
14:52:03 hansmoleman tssurya: i can address the small issues in https://review.opendev.org/#/c/659783/ if you're busy and then +2 it
14:53:29 prometheanfire hansmoleman: ok, so far only nova has had issue with it
15:07:09 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Allow passing negative values for the locked search_opt in cs.servers.list https://review.opendev.org/659783
15:15:34 tssurya hansmoleman: thanks! yea I am snowflake
15:22:10 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311
15:22:19 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
15:22:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
15:23:11 openstackgerrit Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
15:24:51 efried stephenfin: I was considering reworking https://review.opendev.org/#/c/660527/ (get rid of nova.compute.*API()) to just change most of the imports from
15:24:51 efried from nova import compute
15:24:51 efried to
15:24:51 efried from nova.compute import api as compute
15:24:51 efried so that the code itself wouldn't change at all.
15:25:13 efried Again "most of" - some other minor tweaks will be necessary, like where there was already an import of nova.compute.api as compute_api
15:25:21 efried anyway, what do you think of that idea?
15:25:58 stephenfin I must admit I kind of like it how it is atm, with the few exceptions noted
15:26:15 efried The code lines would stay kind of intuitive: compute.API() is nice and clean, clearer than api.API() and less redundant than compute_api.API()
15:26:19 efried okay.
15:26:23 stephenfin Yeah, fair point
15:26:31 efried It's less work to leave it like it is, so I'm not going to fight for this :)
15:26:44 stephenfin I'd be happy with either in that case, actually
15:26:49 stephenfin That's a good point
15:27:02 efried alas, I sense I have sold you on this idea
15:27:08 efried okay, I'll go make it so.
15:27:45 stephenfin Think I've fixed up the issues with the one non-WIP patch that was failing [1] too, so they should all be good to go now [1] https://review.opendev.org/#/c/651311/
15:28:07 stephenfin It took me too long but it should make mriedem happy (it resolves one of his todo's in the process)
15:31:50 mriedem stephenfin: hmm, you're talking about https://review.opendev.org/#/c/651311/3/nova/compute/manager.py right? would it be possible for us to do that refactor outside of the cells v1 removal series?
15:31:50 mriedem or just separately in the series?
15:33:00 stephenfin I was afraid you'd say that
15:33:13 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201
15:34:31 stephenfin bauzas: https://redhat.bluejeans.com/2519408175/
15:34:53 bauzas wrong chan, dude
15:38:00 openstackgerrit Arnaud Morin proposed openstack/nova master: Force refresh instance network info on deletion https://review.opendev.org/660761
15:42:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: libvirt: dump console log if _clean_shutdown fails https://review.opendev.org/660766
16:22:17 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311
16:22:17 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
16:22:18 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
16:22:18 openstackgerrit Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
16:22:19 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'ComputeManager._reschedule' https://review.opendev.org/660774
16:28:58 mriedem kaisers: would it be possible to remove the feature parts of this backport? https://review.opendev.org/#/c/660706/
16:31:22 mriedem kaisers: https://review.opendev.org/#/c/660705/ also mixes in stuff that should have just been master-only IMO, i.e. the privsep conversion
16:47:20 openstackgerrit sean mooney proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498
16:47:21 openstackgerrit sean mooney proposed openstack/nova master: [DNM] use iptables in nova-multinode https://review.opendev.org/660782
16:48:15 sean-k-mooney ^ is just a repoducer so you can ignore it
16:51:27 stephenfin mriedem: Split out that patch too, fwiw https://review.opendev.org/#/c/660774/
16:51:56 mriedem thanks
16:59:09 mriedem bauzas: dansmith: melwitt: can one of you hit this stein backport? https://review.opendev.org/#/c/660370/
16:59:41 dansmith jes
16:59:54 dansmith I'm probably due to go through backports
17:01:44 melwitt same
17:03:56 dansmith let me also say.. I really hate the use of partial in here, which seems to be a growing cancer lately
17:12:13 melwitt looks like it's mirroring what we were already doing with post_live_migration

Earlier   Later