Earlier  
Posted Nick Remark
#openstack-nova - 2019-05-21
20:33:02 sean-k-mooney mriedem: are you ok with the verb 'resurrect' by the way
20:34:38 mriedem from the forum session etherpad there is a note that mordred wants to talk about naming
20:34:47 mriedem https://etherpad.openstack.org/p/DEN-osc-compute-api-gaps
20:35:01 openstackgerrit Eric Fried proposed openstack/nova master: Support old & new versions of svm and avx traits https://review.opendev.org/660515
20:35:12 sean-k-mooney ill ping him and dean to review once i fix up the last few bits
20:36:55 mriedem dansmith may or may not have strong feelings about how evacuate gets named in osc
20:37:12 sean-k-mooney ill also proably submit a patch to try and swap over the nova live migration job to uses it but im not 100% certin a depens-on will work. i could add it to the requred project which should work but no sure we want to do that in general
20:37:46 mriedem you could test it with a dnm/wip patch until it's released in osc
20:38:04 sean-k-mooney ya i can try that
20:38:23 sean-k-mooney its more i dont think we want to use osc in the gate form mater in general
20:38:34 sean-k-mooney so i can juse a dnm patch that does for testing
20:38:52 sean-k-mooney then drop the source install bit after its released
20:39:55 sean-k-mooney i just dont want to adde the python-openstackclient as a required project in the final version of the gate job patch but as you siad tis fine for a dnm or wip patch
20:40:31 mriedem we already use osc in the gate
20:40:33 mriedem for devstack and grenade
20:40:52 mriedem using the things we want users to use in our testing is a good thing
20:43:13 dansmith mriedem: I dunno.. I definitely want a different name for it, but don't think we should change the API.. having it be named something different in osc seems confusing, especially since it will be a new operation that isn't one of the other three evacuates we have
20:44:34 mriedem new operation?
20:44:58 mriedem it would just be the osc version of https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-evacuate
20:46:17 sean-k-mooney mriedem: oh im not saying we shoulding use osc in the gate i was saying we proably want to stick to released versions in the gate rather then adding to reqiured porjects which get translated in to LIBS_FORM_GIT which will install it form master
20:46:37 mriedem sean-k-mooney: yes agree
20:47:27 sean-k-mooney dansmith: my current patch just delegated internall to the nova evacuate command so its the same one that we know and hate
20:48:13 sean-k-mooney dansmith: origially i was calling the osc version "openstack server recreate" but aspiers asked me to change it to "openstack server resurrect"
20:48:22 sean-k-mooney which is what the current patch uses
20:49:02 dansmith sean-k-mooney: right and I'm saying having the command name be something new may not help with the confusion
20:49:25 sean-k-mooney dansmith: that is vaild
20:49:34 dansmith because now it will be "resurrect in osc, which is evacuate in novaclient, which is not host-evacuate or host-evacuate-live"
20:49:52 sean-k-mooney at least for osc we currently dont have the host versions
20:50:30 sean-k-mooney we did talk about that in the fourm session however but bauzas is not a fan of adding them to osc and well i dont care one way or another
20:50:51 mriedem and then i had to yell at both of you, it was great fun
20:51:14 sean-k-mooney :)
20:52:00 sean-k-mooney anyway ill add the docs and a release not and fix all the spelling mistakes tomorrow then let the patch sit for a few days for peopel to think about
20:57:16 mriedem fwiw in osc the sub-command is scoped to the source which might avoid some confusion
20:57:22 mriedem i.e. nova evacuate vs openstack server evacuate
20:57:39 mriedem so that should lessen confusion over what evacuate means per resource
20:58:00 mriedem if we did a whole host evacuate in osc, it would likely be "openstack compute service evacuate"
20:58:04 mriedem since there is a 'compute service' resource
20:59:08 sean-k-mooney is ironic the only case where there is not a 1:1 correspondece between compute services and hypervisors
20:59:42 mriedem yes
20:59:43 sean-k-mooney in the ironic case you would jsut use teh server version
21:00:00 sean-k-mooney ok i was wondering if vmware worked similarly
21:00:48 mriedem it used to back before i think kilo or liberty
21:00:59 mriedem 1 nova-compute service host could manage M vcenters
21:01:16 mriedem much hilarity ensued
21:01:30 sean-k-mooney im sure cdent has fond memories
21:01:46 mriedem this was pre-cdent in nova or vmware
21:01:59 mriedem but coincidentally had dire consequences for evacuate
21:02:09 mriedem i.e. nova deleting all vms in your vcenter
21:02:15 mriedem oops!
21:02:18 sean-k-mooney i can imagine
21:04:27 dansmith mriedem: you mean the scoping actually makes "evacuate" less bad right?
21:06:02 sean-k-mooney the only thing that is unintutive about evacuate (ignoring the host versions) is the fact for ephmereal root volumes you loose the data
21:07:00 sean-k-mooney if evacuated only worked for instacnes with shared storage it actully would be a good name for what it does
21:08:31 sean-k-mooney we brefliy discussed the idea of one command that always preservs your data and a second that always recreates the vm with the same image and flavor but again that might be more confusing
21:09:48 sean-k-mooney anway night all o/
21:09:53 dansmith that is not the only thing
21:10:00 dansmith but we've been over it a hundred times
21:10:14 mriedem dansmith: yes
21:10:15 dansmith I think keeping evacuate and relying on the scoping to disambiguate is the best plan at the moment
21:18:59 sean-k-mooney ill rephase while i wait for mincraft to load. the only thing where i have gone that must be a bug is the differecne between what we do for instance on shared storage vs non shared storage
21:42:40 openstackgerrit Eric Fried proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
22:01:26 openstackgerrit Eric Fried proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
22:01:55 dansmith efried: any luck raising melwitt for that ironic power state spec?
22:03:16 efried nope
22:03:45 dansmith aight, I'm about to end my day, so I'll leave it up on my screen to check in the morning
22:03:52 efried cool beans
22:04:12 efried dansmith: FYI I'm +2 all the way on cellsv1 removal, in case you want to hit those...
22:04:32 efried ...for some loose definition of "want",
22:04:38 dansmith efried: probably should wait a few weeks until all the inactive former cellsv1 people have had a chance to look
22:06:03 efried Vek: ^
22:11:01 efried bauzas: Would you please ack https://review.opendev.org/#/c/651681/ (since you had an earlier -1 on it)?
22:53:25 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Integrating with unified limits https://review.opendev.org/615180
22:53:41 efried o/
22:53:50 prometheanfire http://logs.openstack.org/54/660254/2/check/cross-nova-functional/a0617a9/testr_results.html.gz
22:54:02 prometheanfire failures for the new fasteners fasteners===0.15
#openstack-nova - 2019-05-22
01:09:49 openstackgerrit Guo Jingyu proposed openstack/nova master: Skip existing VMs when hosts apply force_config_drive https://review.opendev.org/659703
03:05:28 openstackgerrit Merged openstack/nova-specs master: Support server power state update through external event https://review.opendev.org/636132
03:31:45 openstackgerrit Merged openstack/nova stable/stein: Fix assert methods in unit tests https://review.opendev.org/657708
05:18:07 openstackgerrit Abhishek Kekane proposed openstack/nova-specs master: Support multiple store of Glance https://review.opendev.org/641210
05:21:02 openstackgerrit Boxiang Zhu proposed openstack/nova-specs master: Update "add host and hypervisor_hostname flag to create server" spec https://review.opendev.org/660560
05:47:19 boxiang alex_xu: hi alex, if it's convenient of you, please take a look at this updated spec https://review.opendev.org/#/c/660560/1
05:47:26 boxiang you can find some comments here https://review.opendev.org/#/c/645520/19/nova/compute/api.py@981
05:47:33 boxiang thank you :)
05:48:06 boxiang if others here, welcome :)
07:19:12 openstackgerrit Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716
07:24:55 openstackgerrit zhaixiaojun proposed openstack/nova master: Update description of valid whitelist for non-admin user https://review.opendev.org/642403
08:47:02 openstackgerrit Lee Yarwood proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/572790
08:47:57 lyarwood stephenfin: ^ updated the releasenote, can't seem to build it locally but that appears to be an issue with f29
09:02:15 stephenfin lyarwood: Ta. It reads rather oddly though. Can you take one more swing at it (comments left)?
09:04:51 lyarwood stephenfin: yeah of course
09:07:16 openstackgerrit Lee Yarwood proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/572790
09:07:21 lyarwood stephenfin: words-- ^ there you go.
09:09:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/572790
09:09:17 stephenfin Thanks
09:09:38 openstackgerrit Stephen Finucane proposed openstack/nova master: Keep attach_mode as top-level field in _translate_attachment_ref https://review.opendev.org/574413
09:10:44 lyarwood haha fs, sorry
09:50:11 openstackgerrit Boxiang Zhu proposed openstack/nova-specs master: Update "add host and hypervisor_hostname flag to create server" spec https://review.opendev.org/660560
09:50:48 stephenfin bauzas: Wanna help remove nearly 13,000 lines of dead code? :) https://review.opendev.org/#/q/topic:bp/remove-cells-v1+status:open (ignore the ones in merge conflict, obviously)
10:01:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling 'InstanceUnknownCell' exception https://review.opendev.org/651307
10:01:54 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unnecessary wrapper https://review.opendev.org/651308

Earlier   Later