Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-17
18:05:11 efried heh, okay.
18:05:14 efried wfm
18:05:15 sean-k-mooney we dont use rfe bugs in nova
18:05:29 sean-k-mooney its litrally just a rfe tag on the bug
18:06:01 sean-k-mooney cool anyway really going this time o/
18:07:14 aspiers haha the number of times I've said that
18:08:39 artom aspiers, you have no chance to survive, merge your time
18:10:41 aspiers artom: somebody set up us the branch
18:11:22 artom aspiers, move TAG
18:11:54 aspiers CI was beginning
18:12:09 aspiers We get review
18:12:33 aspiers You are on the way to -2
18:12:50 aspiers What you say !!
18:13:56 artom You've gone and rewritten the story.
18:14:00 aspiers :D
18:14:06 artom Not just random puns, a coherent narrative
18:14:40 aspiers I try my best
18:16:25 artom You definitely know what you doing.
18:17:04 aspiers For great fun
18:17:41 aspiers OK, I think it's time for the weekend
18:17:44 aspiers Main screen turn off
18:31:44 openstackgerrit Adam Spiers proposed openstack/nova master: Add element to libvirt guest XML for AMD SEV https://review.opendev.org/636318
18:37:45 efried aspiers: https://review.opendev.org/#/c/638680/ reviewed, lemme know if we need to Talk.
18:41:28 aspiers efried: looking
18:41:50 aspiers totally fell into the same trap as sean-k-mooney
18:42:11 aspiers Main screen did not turn off :-/
18:46:42 openstackgerrit Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.opendev.org/633855
18:52:15 aspiers efried: thanks, makes sense to move it to u_p_t()
18:52:18 aspiers I'll do that next week
18:54:21 efried cool, thanks.
18:55:28 aspiers efried: so that would mean it's no longer called from init_host(), right?
18:57:13 openstackgerrit Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664
18:57:13 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Use OpenStack SDK for placement https://review.opendev.org/656023
18:57:48 openstackgerrit Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664
18:57:49 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Use OpenStack SDK for placement https://review.opendev.org/656023
19:00:36 aspiers ComputeManager.pre_start_hook() -> .update_available_resource() -> ._update_available_resource_for_node() -> ResourceTracker.update_available_resource() -> ._update_available_resource() -> ._update() -> ._update_to_placement() -> driver.updated_provider_tree()
19:01:28 aspiers efried: but it seems that there are many other code paths which could reach update_provider_tree(), so your previous question about locking of the region modifying _domain_caps now will have a different answer
19:02:10 efried aspiers: I don't have a problem with the call chain through init_host as you've currently got it setting *some* instance variable on the libvirt driver.
19:02:14 efried which upt can then just go read
19:02:17 aspiers although ResourceTracker._update_available_resource has a semaphore, so maybe that's OK anyway?
19:02:27 efried it just shouldn't be in the capability dict.
19:02:44 aspiers OK, just wondering where's the best place to put it
19:03:00 efried self._supports_sev
19:03:02 efried whatever
19:03:07 aspiers yeah I guess the way you suggest works
19:03:36 efried you can put a comment saying we do this during init_host for efficiency and because it doesn't change
19:03:55 aspiers right - if I put it in resource_tracker.py then it would probably get called too often (i.e. more than once)
19:04:31 efried right. And the singleton-ness you've got set up on it would partially mitigate that - but there's no reason to even have the extra call stacks in the way.
19:04:44 efried memoizing, not singleton
19:04:58 aspiers yep
19:05:28 efried how's that whole stopping-working-because-it's-eod-friday thing going for you?
19:05:44 aspiers really great, just fantastic
19:06:16 efried You got a taste for it in Denver, now you can't get enough.
19:07:24 aspiers sad but true
19:23:05 openstackgerrit Eric Fried proposed openstack/nova stable/stein: DNM: Revert "Use external placement in functional tests" https://review.opendev.org/659682
19:23:05 openstackgerrit Eric Fried proposed openstack/nova stable/stein: Skip _exclude_nested_providers() if not nested https://review.opendev.org/659206
19:25:23 aspiers efried: last question before I go, you're saying that I don't need a driver capability at all, and u_p_t() would just provide the trait directly?
19:25:37 efried aspiers: Correct
19:25:46 aspiers OK good, thought so
19:25:54 efried aspiers: From the operator's point of view:
19:26:05 efried if they want mem encryption, they request resource MEM_ENCRYPTION_CONTEXT=1
19:26:13 efried if they want SEV specifically, they request required=SEV
19:26:15 aspiers BTW the kernel module parameter file is readable non-root, so I'm assuming privsep not required
19:26:23 aspiers right
19:26:24 efried okay.
19:26:46 aspiers IIRC, what you just wrote is captured in the spec
19:26:53 aspiers I remember us going over that before
19:26:54 efried I think so, yes
19:26:59 aspiers sweet
19:27:01 efried but I guess we never talked about driver capabilities
19:27:06 aspiers right
19:27:20 aspiers OK, *really* going now :)
19:27:23 aspiers have a great w/e!
19:27:23 efried yeah, it just seems silly for PowerVM, which will never ever ever have AMD SEV support, to have to say no every time.
19:27:27 efried later o/
19:27:42 aspiers yes totally, felt wrong to have to add to powervm driver
19:27:46 aspiers cya! o/
19:32:45 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: mention default project filtering when listing servers https://review.opendev.org/659873
21:48:40 openstackgerrit Eric Fried proposed openstack/nova stable/stein: Skip _exclude_nested_providers() if not nested https://review.opendev.org/659206
21:49:52 openstackgerrit Merged openstack/nova-specs master: Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c https://review.opendev.org/659300
21:50:15 efried mriedem, melwitt: ---^ stein & rocky backports are ready for your stable eyes now.
21:50:31 melwitt ack
21:52:15 mriedem my eyeballs are currently embargoed
21:52:31 mriedem my sweet dance moves, however, are not
22:09:51 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Allow searching for hypervisors and getting back details https://review.opendev.org/659886
#openstack-nova - 2019-05-18
01:56:18 openstackgerrit Merged openstack/nova master: Use update_provider_tree in vmware virt driver https://review.opendev.org/651615
02:04:31 openstackgerrit Merged openstack/nova master: Fix target used in nova.policy.check_is_admin https://review.opendev.org/624185
03:15:12 openstackgerrit Guo Jingyu proposed openstack/nova master: Skip existing VMs when hosts apply force_config_drive https://review.opendev.org/659703
18:47:53 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Allow searching for hypervisors and getting back details https://review.opendev.org/659886
18:50:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility https://review.opendev.org/621061
18:53:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix guestfs.set_backend_settings call https://review.opendev.org/524748
18:54:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Create volume attachment during boot from volume in compute https://review.opendev.org/541420
18:54:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Migrate old style volume attachments on nova-compute startup https://review.opendev.org/549130
19:27:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove ServersTestBase.setUp() https://review.opendev.org/608780
19:28:07 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: don't log error if guest gone during interface detach https://review.opendev.org/610727
20:55:40 openstackgerrit Eric Fried proposed openstack/nova master: Remove redundant conductor from ServersTestBase.setUp() https://review.opendev.org/608780
21:22:02 openstackgerrit Merged openstack/nova stable/pike: Do not dump all instances in the scheduler https://review.opendev.org/659832
21:50:21 openstackgerrit Merged openstack/nova master: Remove redundant conductor from ServersTestBase.setUp() https://review.opendev.org/608780
22:14:20 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Do not dump all instances in the scheduler https://review.opendev.org/659833
#openstack-nova - 2019-05-19
01:15:36 openstackgerrit Guo Jingyu proposed openstack/nova master: Skip existing VMs when hosts apply force_config_drive https://review.opendev.org/659703

Earlier   Later