Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-15
20:45:49 mriedem i'm still fixing shit back in pike so yeah it's still active-ish
20:46:40 dansmith is it easier to land things in pike than master?
20:46:48 dansmith because based on master these days, I'm guessing so
20:47:48 artom What's the company cores policy on stable stuff?
20:48:09 artom So for instance, would Mel be allowed to +W https://review.opendev.org/#/c/657125/ ?
21:04:16 openstackgerrit melanie witt proposed openstack/nova master: Stop logging traceback when skipping quiesce https://review.opendev.org/659374
21:12:14 melwitt mriedem: now I know what format_message() is for ^ and also I found this, from 6 years ago https://github.com/openstack/nova/commit/86031940b313532606449c400bca64707be1797a
21:16:27 mriedem oh geez
21:16:34 melwitt yeah xD
21:16:47 mriedem if we should always be using format_message(), shouldn't we override __str__ or __repr__ or something for NovaExceptions?
21:17:50 melwitt I _think_ that the exception type for remote exceptions is actually generated dynamically by oslo.messaging,
21:18:15 melwitt *_Remote exceptions, and it overrides __str__ and __unicode__ to have the traceback in it
21:19:30 mriedem if it's not a NovaException then we can't call format_message on it can we?
21:19:57 melwitt yeah, maybe it's that NovaException is the base class it uses
21:20:29 mriedem er i guess you're talking about this https://github.com/openstack/oslo.messaging/blob/40c25c2/oslo_messaging/_drivers/common.py#L247
21:20:53 melwitt yes
21:21:05 mriedem f what a mess
21:21:15 melwitt but you're right that it must be deriving somehow from NovaException else format_message wouldn't work
21:21:18 mriedem so NovaException override __str__ won't work b/c we aren't using a NovaException?
21:21:34 mriedem python black magic
21:22:05 melwitt I think probably not, based on this https://github.com/openstack/oslo.messaging/blob/40c25c2/oslo_messaging/_drivers/common.py#L244
21:23:04 melwitt I was also looking at these tests which seem to know all about this issue :P https://github.com/openstack/nova/blob/master/nova/tests/unit/test_exception.py#L203
21:23:53 melwitt FakeNovaException_Remote is presumably simulating what oslo.messaging does
21:25:10 melwitt I'm not seeing though in oslo.messaging code how it's subclassing the original exception type though
21:25:53 mriedem i think that's https://github.com/openstack/oslo.messaging/blob/40c25c2/oslo_messaging/_drivers/common.py#L243
21:26:09 mriedem https://docs.python.org/3.6/library/functions.html#type
21:26:14 melwitt oh, I see yeah
21:26:20 mriedem the first arg is the new type _Remote, 2nd is the parent class which is the NovaException
21:26:23 melwitt the second argument is the base classes
21:26:25 mriedem python
21:26:25 mriedem black
21:26:26 mriedem magic
21:26:28 melwitt right
21:26:38 melwitt yeah, so that's fun
21:28:05 mriedem NotImplementedError doesn't have format_message()...
21:28:12 mriedem i know what we can do!
21:28:18 mriedem monkey patch oslo.messaging,
21:28:23 mriedem extend their dynamic type,
21:28:29 mriedem and override with our own __str__ that does format_message!
21:28:40 melwitt brilliant!
21:28:41 mriedem and somehow do it with eventlet
21:31:05 openstackgerrit Hamdy Khader proposed openstack/nova master: [WIP] OVS DPDK port representors support https://review.opendev.org/658785
21:50:17 openstackgerrit melanie witt proposed openstack/nova master: Stop logging traceback when skipping quiesce https://review.opendev.org/659374
21:53:55 melwitt mriedem: just did a fugly update ^ better ideas welcome
21:53:56 openstackgerrit Merged openstack/nova master: Add image type request filter https://review.opendev.org/656413
22:10:04 mriedem replied
22:18:13 melwitt thanks
22:18:22 openstackgerrit melanie witt proposed openstack/nova master: Stop logging traceback when skipping quiesce https://review.opendev.org/659374
22:18:46 openstackgerrit Merged openstack/nova master: Enable image type query support in nova-next https://review.opendev.org/656903
22:18:54 openstackgerrit Merged openstack/nova master: Add docs for image type support request filter https://review.opendev.org/657025
22:19:06 openstackgerrit Merged openstack/nova stable/queens: Fix nova-grenade-live-migration run book for opendev migration https://review.opendev.org/655800
22:36:20 mriedem dansmith: it is done https://blueprints.launchpad.net/nova/+spec/request-filter-image-types
#openstack-nova - 2019-05-16
00:42:46 openstackgerrit Brin Zhang proposed openstack/nova master: Cap sphinx for py2 to match global requirements https://review.opendev.org/659201
00:53:51 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Cap sphinx for py2 to match global requirements https://review.opendev.org/659205
00:59:44 openstackgerrit Tetsuro Nakamura proposed openstack/nova stable/stein: Skip _exclude_nested_providers() if not nested https://review.opendev.org/659206
01:51:27 openstackgerrit Tetsuro Nakamura proposed openstack/nova stable/rocky: Skip _exclude_nested_providers() if not nested https://review.opendev.org/659207
02:22:26 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix failure to boot instances with qcow2 format images https://review.opendev.org/640271
02:26:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806
02:26:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904
02:26:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012
02:26:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
02:26:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
02:26:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
02:26:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
02:26:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
02:26:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
02:26:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
02:26:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
02:26:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
02:26:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
02:26:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
02:26:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
02:26:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
02:26:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
02:26:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
02:26:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
02:26:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
02:27:00 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
02:32:48 openstackgerrit Merged openstack/nova master: Fix retry of instance_update_and_get_original https://review.opendev.org/658845
02:33:12 guilhermesp hello! I'm currently running an upgrade N -> O. There is something weird going on when I run nova-manage cell_v2 map_instances <id>. It seems that the nova_api.instance_mappings keeps stuck for a while, incrementing slowly one by one, then after a huge amount of time it starts to re-map the instance in faster way
02:33:33 guilhermesp the deployment has 160k rows in nova.instances
02:34:06 guilhermesp we currently re-mapped 80K instnaces, but sometimes the command finishes but there are still rows to remap
02:34:39 guilhermesp the active instnaces of the deployment are currently given 404, which mean they doesn't reside on the newly created cell during the deployment
02:35:33 guilhermesp we are sometimes adding to the command --max-counts like 50k, 100k and trying to track the remapping watching the rows in nova_api.instance_mappings
02:35:51 guilhermesp does anyone knows what could be the trick in that scenario
02:35:57 openstackgerrit Merged openstack/nova master: Cap sphinx for py2 to match global requirements https://review.opendev.org/659201
02:36:01 guilhermesp we have a staging env that this didn't happen
02:36:50 guilhermesp but we used to have around 1.8k rows in nova.instances
02:37:17 guilhermesp maybe the amount of records in the other env could be a possible reason?
04:47:53 bhagyashris sean-k-mooney: Hi,
07:20:41 openstackgerrit Takashi NATSUME proposed openstack/nova stable/stein: Fix assert methods in unit tests https://review.opendev.org/657708
07:21:38 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Fix assert methods in unit tests https://review.opendev.org/657709
07:21:46 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Fix assert methods in unit tests https://review.opendev.org/657709
07:24:06 openstackgerrit zhangboye proposed openstack/nova-specs master: Cap sphinx for py2 to match global requirements https://review.opendev.org/659470
07:26:05 kashyap weshay: Was asleep when you pinged.
07:37:44 kashyap weshay: I see that melwitt (thanks) has already investigated the issue and posted a patch to skip logging the trace: https://review.opendev.org/#/c/659374/
08:05:17 openstackgerrit Gorka Eguileor proposed openstack/nova master: Fix doc requirements https://review.opendev.org/659484
08:05:58 openstackgerrit Gorka Eguileor proposed openstack/nova master: Fix doc requirements https://review.opendev.org/659484
08:07:33 openstackgerrit Gorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190
09:10:08 openstackgerrit Arnaud Morin proposed openstack/nova master: Always Set dhcp_server in network_info https://review.opendev.org/658362

Earlier   Later