| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-05-14 | |||
| 16:00:11 | mriedem | stephenfin: the bottom one is so obviously copied from the bdm code it still mentions bdms in it | |
| 16:00:46 | stephenfin | mriedem: Yuuup (though the reference is obv a mistake) | |
| 16:01:30 | stephenfin | mdbooth and I discussed dragging it out into something standardized a long time back, but we figured it would be better wait for at least one more user before proceeding down the generic util path | |
| 16:04:14 | openstackgerrit | Merged openstack/python-novaclient master: [Docs] Update client docs to add reason and locked options https://review.opendev.org/659000 | |
| 16:10:33 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add code comment to _instance_update https://review.opendev.org/659112 | |
| 16:28:03 | openstackgerrit | Adrian Chiris proposed openstack/nova master: [FUP] Follow-up patch for SR-IOV live migration https://review.opendev.org/659101 | |
| 16:36:28 | logan- | hello, in OSA we've got a failure bumping our nova testing SHA (https://review.opendev.org/#/c/658208/) due to an api_db sync failure: | |
| 16:36:30 | logan- | http://logs.openstack.org/08/658208/3/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/6c21b9f/logs/ara-report/result/2b065096-d2f5-497b-a29b-2833502c0459/ | |
| 16:36:41 | logan- | "AttributeError: 'module' object has no attribute 'COMPUTE_IMAGE_TYPE_AKI'" | |
| 16:36:49 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation-extended' spec https://review.opendev.org/638734 | |
| 16:36:59 | mriedem | logan-: which version of os-traits? | |
| 16:37:45 | mriedem | you need os-traits>=0.12.0 | |
| 16:37:51 | logan- | checking | |
| 16:37:53 | logan- | ok thanks | |
| 16:38:14 | dtantsur | hey folks, we see this one rocky in ironic: http://logs.openstack.org/71/658771/4/check/ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src/fb9d0bb/logs/screen-n-cpu.txt.gz?level=INFO | |
| 16:38:36 | dtantsur | can it be https://github.com/openstack/nova/commit/35bda4ec385e4c2b3d4cee07467f5077b13b1dd9 ? | |
| 16:38:49 | mriedem | dtantsur: which thing? the StrictVersion? yes. | |
| 16:38:57 | mriedem | er wait | |
| 16:39:22 | mriedem | the StrictVersion thing has been around awhile https://bugs.launchpad.net/nova/+bug/1793766 | |
| 16:39:23 | openstack | Launchpad bug 1793766 in OpenStack Compute (nova) "An unknown error has occurred when trying to get the list of nodes from the Ironic inventory. Error: StrictVersion instance has no attribute 'version'" [Low,Confirmed] | |
| 16:39:29 | mriedem | but maybe it's hitting more now because of ^ | |
| 16:39:51 | dtantsur | I'm not sure if it's on nova or ironicclient side tbh | |
| 16:40:22 | logan- | thanks for the tip mriedem, it looks like we're pulling in 0.11.0 somehow. http://logs.openstack.org/08/658208/3/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/6c21b9f/logs/ara-report/result/7f027c76-34d4-4dfa-a06a-d91722043b58/ | |
| 16:40:36 | dtantsur | mriedem: then we end up with http://logs.openstack.org/71/658771/4/check/ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src/fb9d0bb/logs/screen-n-cpu.txt.gz#_May_14_12_21_18_271733 | |
| 16:40:45 | dtantsur | I'm not sure if the StrictVersion thingy is the cause, but looks so | |
| 16:40:57 | logan- | oh we need to bump our requirements sha | |
| 16:40:58 | logan- | heh | |
| 16:41:01 | mriedem | logan-: stale upper-constraints? | |
| 16:41:03 | mriedem | oh ok | |
| 16:41:35 | logan- | yup, that should fix it up. thanks! | |
| 16:41:45 | stephenfin | sean-k-mooney: If you're around for a while longer, you might fancy looking at https://review.opendev.org/638734 again. Think I've addressed most of your concerns (by focussing solely on flavor extra specs) | |
| 16:46:25 | sean-k-mooney | oh the validation spec sure ill take a look | |
| 16:47:42 | openstackgerrit | Merged openstack/nova stable/stein: Add functional confirm_migration_error test https://review.opendev.org/658929 | |
| 16:53:15 | tssurya | mriedem: could you have a look when you have time ? https://review.opendev.org/#/c/658110/ - thanks in advance | |
| 17:11:15 | sean-k-mooney | stephenfin: adrianc i left some comments on https://review.opendev.org/#/c/659101/2 but this actully intduces more nits then it fixes at least from my view point | |
| 17:54:06 | sean-k-mooney | stephenfin: done. i think i have a better solution that i more generic then what you proposed but still support a yaml file for operators to customise | |
| 17:55:21 | sean-k-mooney | all standard extra specs however would be validated in python and we woudl have a stevedor entry point so that cyborg, rmd,os-traits extra specs could also be validated | |
| 18:48:48 | adrianc | sean-k-mooney: Thanks, ill take a look tommorow ? | |
| 18:49:01 | adrianc | without the ? :) | |
| 18:49:08 | sean-k-mooney | adrianc: they are reltivly minor | |
| 18:49:42 | sean-k-mooney | and one comment is a presonl preference/nit | |
| 18:51:03 | adrianc | yah i gave it a quick look, thanks for providing inputs. BTW do we really need to bother ourselves with the cyborg integration on the is_sriov_port propery ? | |
| 18:51:23 | adrianc | i mean its A. a future issue , B. ive just moved the "mess" to one place | |
| 18:51:25 | sean-k-mooney | am proably not i just wanted to highlight it | |
| 18:51:41 | adrianc | ack | |
| 18:51:53 | sean-k-mooney | i mean we can always fix it when we integrate cyborg rather then now | |
| 18:59:13 | openstackgerrit | Rodrigo Barbieri proposed openstack/nova stable/rocky: Add functional confirm_migration_error test https://review.opendev.org/658834 | |
| 19:04:13 | openstackgerrit | Eric Fried proposed openstack/nova master: [Trivial doc change] Admin can overwrite the locked_reason of an owner https://review.opendev.org/659067 | |
| 19:46:20 | mriedem | dansmith: so i just realized that our 2.33 change for listing hypervisors which added limit and marker support for paging changed the previous behavior where we'd just return everything - we now default to CONF.api.max_limit if you don't specify a limit, and i can't tell if that's good or not - i suppose in terms of api load it's good to limit server-side | |
| 19:46:30 | mriedem | forces the client to page though | |
| 19:46:54 | dansmith | mriedem: you mean before that we would return all of them regardless of the amount? | |
| 19:46:58 | mriedem | right | |
| 19:46:59 | dansmith | like, 50000000000 of them? | |
| 19:47:09 | mriedem | 10K, 14K, whatever cern has yeah | |
| 19:47:19 | dansmith | clamping to max_limit does not seem like a regression to me :) | |
| 19:47:24 | mriedem | heh | |
| 19:47:58 | mriedem | yeah i'm just learning some watcher code where they build their data model for hypervisors and it's super inefficient, and lossy because of this limit thing i realize | |
| 19:48:43 | mriedem | tl;dr they (1) list all hypervisors with details (well, up to 1K), (2) for each hypervisor, get it's servers (3) for each hypervisor, get it's details (again) | |
| 19:48:54 | mriedem | all of that can be done in a single GET with 2.53 | |
| 19:49:08 | dansmith | yoza | |
| 19:49:11 | dansmith | *yowza | |
| 19:49:21 | mriedem | and i *think* this is on ever audit request | |
| 19:49:36 | mriedem | rather than like build on startup, then modify as notifications come in | |
| 19:49:42 | mriedem | *every | |
| 19:52:31 | dansmith | sweet | |
| 19:59:21 | mriedem | oy, and for every compute node, get all of its instances in separate GETs | |
| 20:03:32 | NewBruce | hey sean-k-mooney / mriedem | |
| 20:04:13 | NewBruce | saw the code updates and call for review - will get onto it asap - sorry bout that - got caught up in a couple other bug chasing efforts….. | |
| 20:04:24 | NewBruce | thanks for the work on it though :) | |
| 20:59:32 | mriedem | np | |
| 21:15:26 | mriedem | efried: comments on surya's fix here https://review.opendev.org/#/c/658110/ - if you're in agreement i'll just make the changes quick | |
| 21:18:00 | efried | mriedem: wfm. You want to fix or would you feel better if I did? | |
| 21:18:25 | mriedem | i'll do it, already got the test done | |
| 21:21:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/658110 | |
| 21:30:03 | mriedem | efried: so i addressed my nits on ^ you and alex were +2, want to just fast approve? | |
| 21:32:15 | efried | mriedem: gimme a sec. I'll mark up and then fast approve. | |
| 21:36:29 | efried | mriedem: Comments added. If you are okay with those things, say so and I'll approve. | |
| 21:36:37 | efried | or quick respin to address would be better :) | |
| 21:38:21 | mriedem | oh hmm | |
| 21:38:24 | mriedem | multiple hints aye | |
| 21:38:28 | mriedem | couldn't i just throw a fake hint in there? | |
| 21:39:44 | mriedem | i.e. are you ok with this? | |
| 21:39:44 | mriedem | fake_spec = objects.RequestSpec( | |
| 21:39:44 | mriedem | flavor=flavor, scheduler_hints={hint: [uuids.fake], | |
| 21:39:44 | mriedem | 'some-fake-hint': ['fake-value']}) | |
| 21:40:20 | efried | That would be good too, but I'd like to see >1 of the hints we're conditioning on. | |
| 21:41:32 | efried | mriedem: If it were me, I would nix ddt, put the guts of the test in a _helper, and loop over it with various permutations of hints constructed in a loop from components. | |
| 21:42:03 | efried | mriedem: if you tire of this, I can take a crack at it. | |
| 21:43:55 | mriedem | ddt is nice in that the test names have the ddt values in the test name in case one of them blows up | |
| 21:43:58 | mriedem | anyway i've got a thing | |
| 21:44:14 | mriedem | this didn't come up in the review comments on the patch before this so i figured it was fine - unless that came up in irc | |
| 21:46:29 | mriedem | i'm not going to mention something about nested providers in the commit message b/c this is going back to queens | |
| 21:46:31 | mriedem | where those weren't supported | |
| 21:46:32 | mriedem | is that ok? | |
| 21:46:45 | efried | Yeah, ignore that one, just thought to point it out. | |
| 21:47:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/658110 | |
| 21:49:44 | efried | mriedem: +A | |
| 21:49:52 | mriedem | whew | |
| 21:50:23 | efried | I know, try to do a nice thing... | |
| 22:48:30 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: TC Vision Reflection https://review.opendev.org/658932 | |