Posted	Nick	Remark
#openstack-nova - 2019-05-13
15:28:35	openstack	Launchpad bug 1533260 in OpenStack Compute (nova) "Unexpected API Error is returned, when trying to add fixed IP to an instance in ERROR state" [Medium,Confirmed]
15:28:43	mriedem	well, same set of apis
15:29:50	mriedem	https://review.opendev.org/#/c/163864/ was the super old re-write of the apis
15:30:24	mriedem	abandoned in 2016 with "does anyone use this? don't think so"
15:31:35	johnthetubaguy	yeah, although that fix looks fine, but meh.
15:32:55	mriedem	"The more I think about, maybe the existing behaviour is correct. I need to catch up with mriedem about this."
15:32:59	mriedem	july 4 2016
15:33:17	mriedem	i was knee deep in grilled meats and explosives
15:35:58	mriedem	ganso: i'll pull your rocky test down and play with it to see if i can figure out what's going on
15:36:14	ganso	mriedem: thanks Matt! =)
15:36:35	mriedem	sean-k-mooney: in case you didn't notice, i got a recreate on https://review.opendev.org/#/c/653506/ stacked above it and cleaned it up, should be good to go now
15:36:59	mriedem	also figured out what i was doing wrong in the cross-cell resize series that was hitting that, so once i got that fixed i got a clean run in the multi cell job for cross-cell cold migration
15:51:26	openstackgerrit	Balazs Gibizer proposed openstack/os-traits master: Add REPORT_PARENT_INTERFACE_NAME_FOR_SRIOV_NIC trait https://review.opendev.org/658852
16:07:46	canori01	hello, I am running nova 18.0.2 and setting disk-cachemodes to writeback
16:08:05	canori01	However, the instance xml says none. Is this intended behavior?
16:09:14	sean-k-mooney	mriedem: hi sorry was in a meeting
16:09:56	sean-k-mooney	mriedem: im just grabing lunch but ill read through comment you left thanks for looking at this in depth
16:20:34	gibi	efried: I'm going to be away til Wednesday next week so I'm wondering if I should pul the heal port allocation from the runway slot
16:45:52	openstackgerrit	Matthew Booth proposed openstack/nova master: Fix retry of instance_update_and_get_original https://review.opendev.org/658845
16:48:08	openstackgerrit	Merged openstack/os-vif master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655068
16:53:32	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: add upper_constraints support https://review.opendev.org/658780
17:23:47	openstackgerrit	Merged openstack/nova master: Cleanup update_instance cell mapping handling https://review.opendev.org/467380
17:35:15	openstackgerrit	Merged openstack/nova master: Remove cells v2 transition code from update_instance https://review.opendev.org/467382
17:35:22	openstackgerrit	Merged openstack/nova master: api-ref: 'os-hypervisors' doesn't reflect overcommit ratio https://review.opendev.org/611604
17:44:37	efried	gibi: Probably a good idea.
18:30:02	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [DNM] Testing links to inline comments, ignore https://review.opendev.org/658887
18:30:20	artom	Crap, that was supposed to go to downstream gerrit :(
18:32:36	sean-k-mooney	am it did
18:32:59	sean-k-mooney	oh you posted it upstream then downstream
18:36:49	artom	I learn from my mistakes :D
18:37:27	artom	For posterioriy, @a<line number> links to the "before"/left pane.
19:37:16	openstackgerrit	Daniel Speichert proposed openstack/nova-specs master: Directly download and upload images to RBD https://review.opendev.org/658903
19:37:17	openstackgerrit	Surya Seetharaman proposed openstack/nova master: [WIP] Add 'power-update' external event to listen to ironic https://review.opendev.org/645611
19:39:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806
19:39:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012
19:39:47	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
19:39:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
19:39:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
19:39:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
19:39:49	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
19:39:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.opendev.org/621313
19:39:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
19:39:51	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.opendev.org/627890
19:39:51	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
19:39:52	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
19:39:52	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
19:39:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
19:39:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
19:39:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
19:39:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
19:39:55	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
19:40:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
19:40:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
19:40:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
19:40:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
19:40:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904
19:41:11	mriedem	dansmith: i've hit a not-so-fun snag in pre-validating the target host wrt attached volumes in the cross-cell resize stuff and i'd like to brain dump
19:41:25	dansmith	okay
19:42:06	mriedem	so we want to try and connect the volume on the dest host to see if it will work before starting the whole process,
19:42:22	mriedem	to do that, i need to update the volume attachment with the dest host connector to get the connection_info dict that the virt driver uses,
19:42:58	mriedem	the problem is, at the point i'm doing that, the source host volume attachment still exists and cinder pukes saying you essentially can't have more than one connected attachment for the same volume at the same time
19:43:26	mriedem	which makes sense i guess, and is not something we hit in a normal move because we delete the source host attachment before finishing on the dest
19:44:02	mriedem	granted normal resize could fail the same thing today - if you can't connect the volume on the dest after we've transferred the disks and stuff
19:44:34	dansmith	cross-cell is actually easier in this case because you have two separate instances and attachments on the nova side
19:44:56	dansmith	normal resize would need to stash that in case it needs to revert right? or maybe just ask cinder again.. tbh, I dunno how that attachment stuff works really :)
19:45:28	mriedem	attachments in cinder are essentially ephemeral, we can create and delete them as needed, or that's the idea anyway
19:45:39	mriedem	so if i want to make this work,
19:46:09	openstackgerrit	Merged openstack/python-novaclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648659
19:46:09	mriedem	i'd need to do something like delete the source host attachment, update the attachment with the dest host connector so we can test the connection on the dest host,
19:46:39	mriedem	and then if something fails and we're rolling back, i'd have to create a new attachment and complete it for the source host (using the source host connector, which we don't stash away)
19:46:48	dansmith	which entity is going to give you the go/no-go on the new attachment? cinder? brick? libvirt?
19:46:52	mriedem	so not impossible, but kinda gross
19:47:38	mriedem	updating the attachment with the host connector is what creates the exports in the storage backend
19:47:45	mriedem	and gives us back the connection_info dict
19:48:09	dansmith	okay, so, cinder yeah?
19:48:23	mriedem	i'm honestly not sure if that's enough or not, i.e. if you still need the low-level connection on the host for libvirt/brick
19:48:48	mriedem	we maybe don't need that - we don't try to plug vifs on the dest host during pre-validation
19:48:52	dansmith	cinder might tell you no, or it might not know and say "sure" but then the actual attach fails I guess
19:49:13	mriedem	yeah i'm not sure, that's why i was trying to do it all
19:49:53	mriedem	either way i'm not disconnecting the guest / volume from the source host until we've pre-validated the dest
19:50:00	mriedem	and start doing the power off / snapshot stuff
19:50:21	dansmith	hmm
19:50:42	dansmith	in what case is cinder going to tell you no to the attempted attachment change?
19:51:01	dansmith	I mean... why do you think you need to do this special for cross-cell?
19:51:39	mriedem	i was thinking in case we hit a scenario where the target cell is using a different storage backend from the source cell
19:52:05	mriedem	not sure how realistic that is though
19:52:10	dansmith	but I mean,
19:52:23	dansmith	how is that different from single-cell resize?
19:52:51	sean-k-mooney	mriedem: in an edge deployment its likely not that uncommon that they would have different backends
19:52:55	mriedem	it's not really, like i said before we could hit this same thing during normal resize and we really don't try to pre-validate that (in prep_resize) or rollback from that kind of failure
19:53:25	dansmith	yeah, I'm not sure what the backend difference is that you're talking about
19:53:35	dansmith	in this case, the volume is in cinder, on a backend, but migrating won't change what *cinder* backend it's on, regardless of where you move it
19:54:52	sean-k-mooney	dansmith: that is ture but that may mean the backen is not reachale from the new host. although if we are using sharing resouce providres to model this in placement it shoudl be reachable
19:55:09	sean-k-mooney	assuming you have set up the aggreate correctly
19:55:21	mriedem	we are not using sharing providers for any of this, or anything
19:55:21	dansmith	sean-k-mooney: right, but that's what I'm saying has nothing to do with cross-cell migration
19:55:47	sean-k-mooney	dansmith: sure
19:56:06	sean-k-mooney	its not a special case that only comes up with cross cell
19:57:04	mriedem	so if this is really not any different from normal resize then i'm probably bending over backwards for no good reason
19:57:26	mriedem	but yeah i was thinking kind of like what sean said, the target host can't connect to the storage for the volume

Earlier   Later