Earlier  
Posted Nick Remark
#openstack-nova - 2019-04-25
10:48:20 stephenfin Or even remove it if no-one else is using it yet
10:48:24 sean-k-mooney *os-traits
10:48:55 sean-k-mooney stephenfin: we cant remove traits from os-traits
10:49:06 sean-k-mooney its an add only model
10:49:23 stephenfin if no one is using it anywhere though?
10:49:26 sean-k-mooney to simplfy db updates
10:49:27 stephenfin and never has
10:49:32 stephenfin Oh, there's a DB involved
10:49:33 sean-k-mooney even then
10:49:36 sean-k-mooney ya
10:49:42 aspiers stephenfin: you're repeating an earlier discussion ;-)
10:49:48 aspiers this is now mentioned in http://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html
10:49:56 aspiers I asked the exact same question a few days ago
10:50:01 sean-k-mooney yep
10:50:03 stephenfin Fair. I'd also be ok with a dead trait, tbh, but I also don't care that much
10:50:16 sean-k-mooney im fine with hte hyperthreaing one
10:50:25 aspiers I think dead traits can be hidden to the point that they're only visible in the os-traits code where hardly anyone looks
10:50:29 sean-k-mooney people use it as a generic term even if it is a threadmark
10:50:34 aspiers well I suppose they're visible via introspection too
10:50:40 stephenfin fwiw, I tried to use SMT in the documentation e.g. https://docs.openstack.org/nova/pike/admin/cpu-topologies.html
10:51:03 sean-k-mooney yes i know and you gave a talk on the topic
10:51:36 stephenfin indeed :)
10:51:59 sean-k-mooney so ya i was in the middel of reading v27
10:52:08 sean-k-mooney ill skim through v28
10:52:34 stephenfin Yeah, spotted an issue with my description of that trait, actually :)
10:52:50 stephenfin I must admit, I really don't like Gerrit for doc reviews :-\
10:53:03 sean-k-mooney why
10:53:16 stephenfin It's too hard to keep track of conversations
10:53:24 sean-k-mooney you jut have to wait a bit and collect the changes
10:53:26 aspiers stephenfin: that's because we're using an ancient Gerrit
10:53:33 aspiers Gerrit 2.16 is awesome
10:53:43 stephenfin aspiers: Oh yeah? Anything specific?
10:53:45 sean-k-mooney we are using 2.13
10:53:49 stephenfin The polymer UI?
10:53:54 aspiers stephenfin: much more than that
10:54:28 aspiers https://review.gerrithub.io/q/status:open
10:55:07 sean-k-mooney whats so different about that
10:55:10 aspiers https://youtu.be/WsPhoPGUsss?t=9m47s
10:55:32 aspiers https://youtu.be/WsPhoPGUsss?t=19m10s
10:55:37 sean-k-mooney that is just the polomer ui + a theme
10:55:40 aspiers nope
10:56:17 stephenfin aspiers: Oh, nice
10:56:19 aspiers this is just one of many specific improvements
10:56:28 aspiers I can't list them all for you
10:56:31 stephenfin Resolvable comments are indeed one of the things I'd like
10:56:38 stephenfin I like that in gdocs
10:58:06 aspiers also bear in mind those videos are 1.5 years old now
10:58:19 stephenfin yeah, so things will have moved on a lot since then
10:58:21 aspiers OpenStack really REALLY needs a Gerrit upgrade
10:58:45 stephenfin I imagine the infra folks are snowed under with the opendev migration but this sure would be a nice next step
10:58:47 sean-k-mooney aspiers: we used to have some downstream only changes
10:59:05 sean-k-mooney because we need to fix bug that had not merged upstream
10:59:07 aspiers stephenfin: yeah. it will happen
10:59:18 stephenfin big changes in 3.0 too, from the looks of things https://www.gerritcodereview.com/3.0.html
10:59:19 sean-k-mooney im not sure what is left to get upstream at this point
10:59:25 aspiers sean-k-mooney: if a patch to 2.13 hasn't landed by now, it never will
10:59:45 sean-k-mooney aspiers: yes which may mean we never update
10:59:59 aspiers sean-k-mooney: highly doubt that
11:00:20 sean-k-mooney there were one or two that we need to work at our scalse in the past the got push back which stop openstack updating
11:00:25 aspiers clarkb / corvus / fungi started working on it a long time ago
11:00:38 sean-k-mooney but i think most of that has gone upstream now
11:00:49 aspiers sean-k-mooney: yeah, we're not the biggest Gerrit user
11:01:03 aspiers there are several other huge scale installs
11:01:08 aspiers I met them all at the conference
11:01:19 sean-k-mooney i think we were 6 years ago when i started on openstack
11:01:21 aspiers and the others are all head in terms of HA too
11:01:30 aspiers ahead
11:01:38 aspiers Google is heavily investing in Gerrit
11:01:46 aspiers they have a team of 20 or so IIRC
11:02:13 aspiers stephenfin: 3.0 is more about ditching the dead stuff which everyone will have migrated off of by 2.16
11:02:25 stephenfin looks like it, yeah
11:02:37 stephenfin I'd imagine we'll be getting 2.16 first, in that case
11:03:12 aspiers for sure
11:12:37 openstackgerrit Adam Spiers proposed openstack/os-traits master: Update SEV trait docs to avoid misleading people https://review.opendev.org/655671
11:19:33 openstackgerrit Adam Spiers proposed openstack/os-traits master: Document policy of never removing traits https://review.opendev.org/655673
11:23:27 openstackgerrit Adam Spiers proposed openstack/os-traits master: Document policy of never removing traits https://review.opendev.org/655673
11:36:23 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif stable/stein: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655678
11:36:38 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.opendev.org/645814
11:36:50 kashyap efried: As promised ^^
11:38:37 jaypipes efried: morning. sorry, just saw your question from yesterday evening.
11:39:24 jaypipes efried: I'll be leaving around 1:30-2pm on the Friday. I'll just make do with side conversations etc at the summit about the various specs I'm concerned about (and continue to add reviews to said specs)
11:41:12 sean-k-mooney jaypipes: i think efried has tried to front load most of the topic that are in your usuall area. not sure they all fit
11:41:45 sean-k-mooney one thing i think will come up in the feeback session is the ptg and summit should over lap again
11:42:22 sean-k-mooney we will see but the room was pretty split at the last ptg on that topic
11:43:18 jaypipes ack
12:05:48 openstackgerrit Merged openstack/nova stable/queens: Fix regression in glance client call https://review.opendev.org/655186
12:10:29 openstackgerrit Merged openstack/nova stable/queens: libvirt: disconnect volume when encryption fails https://review.opendev.org/653033
12:23:37 fungi aspiers: stephenfin: sean-k-mooney: yes, current plan i think is going straight from 2.13 to 2.16 we just need to re-test the upgrade process on our staging server. the transition from mysql to notedb is going to be the biggest challenge as it will likely require a day-long service outage to complete
12:24:13 fungi we didn't want to conflate that work with the opendev switch for gerrit/git, but this ptg will be the time to make plans
12:24:47 sean-k-mooney is there an infra meetup at the ptg or just people will be about so it will come up
12:25:15 fungi infra is meeting thursday and friday all day (we share a room with qa)
12:25:25 sean-k-mooney ah ok
12:26:37 sean-k-mooney i kind of want to get a bit more involved with the infra side of things but on the other hand was not sure how to go about that so i was just going to say hi
12:54:05 kashyap fungi: What is "notedb"? /me looks up
12:54:42 kashyap Okay, it is this: "NoteDb is the next generation of Gerrit storage backend, which replaces the traditional SQL backend ..."
12:54:45 kashyap https://gerrit-review.googlesource.com/Documentation/note-db.html
12:55:40 fungi kashyap: yep, basically we'll be etl'ing gigabytes of data from an rdbms into git repositories
12:55:50 fungi not a speedy process
12:57:39 fungi at one point the upgrade process was necessary to be performed stepwise first moving some of the data into an h2 database and then moving it from there into git in a subsequent gerrit version, but we hear they've added the ability to migrate directly from sql to notedb now so it may go a lot more quickly, we just need to test
13:05:00 stephenfin fungi: Thanks for the context. That's all very good to hear :)

Earlier   Later