| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-19 | |||
| 13:25:59 | fried_rice | do you have a way of seeing whether it broke recently? | |
| 13:29:36 | fried_rice | mriedem: TestRPC.test_create_transport in py36 - is that the thing you were seeing yesterday? | |
| 13:29:45 | mriedem | yes | |
| 13:29:47 | mriedem | see ML | |
| 13:33:53 | fried_rice | thanks mriedem. Recheckable or 100%? | |
| 13:42:48 | mriedem | i've been rechecking | |
| 13:43:05 | mriedem | with 12 hour turnaround on ci times plus there is a gerrit maintenance scheduled today... | |
| 13:43:11 | mriedem | looks like i should just quite early | |
| 13:47:09 | fried_rice | mriedem: When I run this locally, I get 'oslo_config.cfg.NoSuchGroupError: no such group [oslo_messaging_notifications]' | |
| 13:47:58 | fried_rice | Trying to find where that group is being registered... | |
| 13:48:31 | mriedem | via oslo.messaging opts | |
| 13:48:59 | mriedem | i think in nova.rpc | |
| 13:49:09 | mnaser | mriedem: also, I had to turn down ovh-bhs1 (150 VMs) because it had networking issues | |
| 13:49:42 | mnaser | and now I'm seeing a lot of RETRY_LIMIT failing jobs, which means that another provider is having issues (I suspect the other ovh region from what I was seeing) | |
| 13:49:43 | mriedem | ah this https://github.com/openstack/nova/blob/master/nova/config.py#L50 | |
| 13:50:02 | mriedem | mnaser: yeah i saw a lot of infra failures like that | |
| 13:50:13 | mnaser | so we're pretty short on infra :\ | |
| 13:50:30 | mnaser | but 100% relate on the "lets fix our gates that are on fire instead of making code pretty" comment | |
| 13:50:38 | mriedem | mnaser: has there been something else going on all week because it's taken half a day to get a result on a change at times | |
| 13:51:25 | mnaser | mriedem: afaik ovh has been having issues where a whole job will run and then fail to collect logs, restarting that job | |
| 13:51:35 | mnaser | so in our case a 2-3h deploy job would run 3 times in a row and still fail | |
| 13:51:56 | mriedem | ah | |
| 13:52:00 | mnaser | and even then it'd re-queue after the fail so takes ages to get a node assigned again | |
| 13:52:05 | mriedem | yeah i saw the POST_FAILURES which is generally failing to collect and publish logs | |
| 13:52:14 | mnaser | because there's so many other things that are trying to also retry | |
| 13:53:03 | mriedem | fried_rice: or it might be this that registers those options https://github.com/openstack/nova/blob/master/nova/config.py#L61 | |
| 13:53:23 | mnaser | and today you're going to have an automated patch change all the references in your code to point to opendev and so | |
| 13:53:30 | mnaser | enjoy that it in advance and hopefully that doesn't break your world too | |
| 13:58:18 | mriedem | which core can i pay off to look at these 2 simple changes? https://review.openstack.org/#/q/topic:bug/1823781+(status:open+OR+status:merged) | |
| 14:00:02 | fried_rice | I'll look. But your credit score is shit with me. "The nickel is in my backpack," suuuure. | |
| 14:00:42 | fried_rice | tonyb[m]: "Now would be a good time to start brainstorming Forum topics while some of the | |
| 14:00:42 | fried_rice | PTG discussions are fresh. Just a couple months until the Summit and Forum in | |
| 14:00:42 | fried_rice | Berlin." | |
| 14:00:42 | fried_rice | You were just seeing if we were paying attention. | |
| 14:01:25 | mriedem | fried_rice: it's still in there, i just can't ever remember to give it to you in person | |
| 14:01:31 | mriedem | my offer to mail it still stands | |
| 14:02:16 | fried_rice | Then it'll be, "the nickel's in the mail." I've heard that one before too. | |
| 14:04:19 | fried_rice | I get that same NoSuchGroupError in stein and rocky. So I'm guessing there's a bug in the test setup where the test env doesn't run through the code path that registers the options if I'm just running those two tests. | |
| 14:05:55 | mriedem | https://photos.app.goo.gl/giiB1e8RD8WztkaQ8 | |
| 14:05:57 | mriedem | i've set a reminder | |
| 14:06:23 | mriedem | fried_rice: yeah i get the same: $ tox -r -e py36 -- nova.tests.unit.test_rpc --until-failure | |
| 14:07:38 | fried_rice | so that's a red herring for our gate failure :( | |
| 14:12:12 | fried_rice | If you actually pay me off, I won't be able to keep giving you crap about it. We need a different plan. | |
| 14:14:46 | mriedem | what i'd like to know is what is calling oslo.config when the death spiral starts | |
| 14:23:22 | mriedem | well i fixed that latent traceback at least :) | |
| 14:23:25 | fried_rice | Running all of py36 locally I got these: | |
| 14:23:26 | fried_rice | {2} nova.tests.unit.pci.test_utils.PciDeviceMatchTestCase.test_spec_extra_key [] ... inprogress | |
| 14:23:26 | fried_rice | {7} nova.tests.unit.objects.test_instance_group.TestInstanceGroupObject.test_get_by_hint [] ... inprogress | |
| 14:24:53 | fried_rice | oh, by the way, that ^ was on rocky | |
| 14:25:54 | fried_rice | what have we backported lately? | |
| 14:26:57 | mriedem | shrug, lots of stuff | |
| 14:27:07 | mriedem | what is getting an option with a namespace? https://github.com/openstack/oslo.config/blob/6.8.1/oslo_config/cfg.py#L2614 | |
| 14:27:12 | mriedem | wtf is a config option namespace? | |
| 14:27:15 | mriedem | stephenfin: ^? | |
| 14:27:31 | mriedem | http://logs.openstack.org/45/649345/7/check/openstack-tox-py36/ba15c17/job-output.txt.gz#_2019-04-18_18_10_53_423952 | |
| 14:27:37 | mriedem | that's where the stack overflow starts | |
| 14:28:24 | fried_rice | and why am I suddenly getting | |
| 14:28:24 | fried_rice | Error: pg_config executable not found. | |
| 14:28:24 | fried_rice | when rebuilding my venv?? | |
| 14:28:46 | mriedem | https://github.com/openstack/oslo.config/blob/6.8.1/oslo_config/cfg.py#L2183 | |
| 14:29:33 | mriedem | might be due to newer psycopg2? | |
| 14:29:42 | mriedem | are you on 18.04? | |
| 14:29:46 | mriedem | bionic i mean | |
| 14:30:38 | fried_rice | yes. Have been for three months. Apparently I suddenly needed libpq-dev | |
| 14:31:01 | fried_rice | four months | |
| 14:31:05 | fried_rice | time flies | |
| 14:31:46 | fried_rice | On master I just got | |
| 14:31:46 | fried_rice | {6} nova.tests.unit.objects.test_instance.TestRemoteInstanceObject.test_create_with_extras [] ... inprogress | |
| 14:31:46 | fried_rice | '>' not supported between instances of 'NoneType' and 'datetime.datetime' | |
| 14:31:58 | fried_rice | so it's not RPC I guess | |
| 14:32:40 | mriedem | heh i can't recreate oslo_config.cfg.NoSuchGroupError: no such group [oslo_messaging_notifications] now | |
| 14:32:51 | yan0s | So, novnc produces the error I mentioned earlier when both a key pair and a cloud-config (setting user password) are set | |
| 14:33:12 | mriedem | fried_rice: that's what i saw yesterday when looking at this | |
| 14:33:33 | mriedem | it's not in the logs everytime the stack overflow happens, but i know the cells 1 removal stuff touched some of that code | |
| 14:55:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Only set oslo_messaging_notifications.driver if using RPCFixture https://review.openstack.org/653954 | |
| 15:43:28 | kashyap | Hmm, https://review.openstack.org/ is offline | |
| 15:44:20 | dansmith | kashyap: see topic | |
| 15:45:45 | kashyap | dansmith: Yeah, noticed it. _Just_ when I was hitting send on a comment I saw it go down | |
| 15:46:10 | kashyap | dansmith: But, I trained my muscle memory to copy it into an editor; before pasting it :-) | |
| 15:46:15 | kashyap | dansmith: Shouldn't you be offline, too? | |
| 15:46:46 | dansmith | no :) | |
| 15:46:58 | dansmith | this day has no special meaning for me | |
| 15:47:17 | kashyap | Hehe, nod. | |
| 15:48:33 | edleafe | It *is* the 244th anniversary of the start of the American Revolution. Surely *that* has meaning for you? | |
| 16:00:57 | mriedem | weeeee https://bugs.launchpad.net/nova/+bug/1825537 | |
| 16:00:59 | openstack | Launchpad bug 1825537 in OpenStack Compute (nova) "finish_resize failures incorrectly revert allocations" [Medium,Triaged] | |
| 16:01:12 | mriedem | mnaser: eandersson: ^ will add to the placement allocations are wrong woes | |
| 16:01:34 | mriedem | i've got a recreate test locally which i'll push up once gerrit is back | |
| 16:11:11 | mriedem | dansmith: interested in your opinion on the options i've laid out in https://bugs.launchpad.net/nova/+bug/1825537 for fixing it - comment 2 | |
| 16:11:12 | openstack | Launchpad bug 1825537 in OpenStack Compute (nova) "finish_resize failures incorrectly revert allocations" [Medium,Triaged] | |
| 16:11:57 | dansmith | mriedem: this is getting really old | |
| 16:12:04 | dansmith | can't you do something positive to help the project? | |
| 16:12:22 | mriedem | would you like auto-formatted code style? | |
| 16:12:33 | mriedem | it will bring the new contribs | |
| 16:12:57 | dansmith | yes please! | |
| 16:13:48 | dansmith | mriedem: I'm highly allergic to changing the host/node assignment timing | |
| 16:14:08 | dansmith | not because what we do today is good or right, but just because I'm afraid of breaking tons of other things that encode those assumptuons | |
| 16:14:11 | dansmith | *assumptions | |
| 16:14:51 | mriedem | dansmith: i.e. "I think this is probably not really an option because finish_resize has never done this on failure and we don't really know what state the instance is in" | |
| 16:15:09 | dansmith | sure | |