| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-17 | |||
| 13:54:26 | mriedem | bauzas: want to hit this backport https://review.openstack.org/#/c/647911/ ? | |
| 13:54:39 | bauzas | sure | |
| 13:54:48 | mriedem | all of them actually since it's a gate race issue https://review.openstack.org/#/q/If966eb1161c842ff49aa530e4482dbca87b61a3e+status:open | |
| 13:54:50 | bauzas | looking | |
| 13:54:53 | mriedem | http://status.openstack.org/elastic-recheck/index.html#1820337 | |
| 14:08:24 | kashyap | aspiers: Hiya...seems like I need the getDomainCapabilities() API call for Secure Boot | |
| 14:08:31 | kashyap | aspiers: Wondering if you're planning to split it out: https://review.openstack.org/#/c/633855/11/nova/virt/libvirt/host.py@680 | |
| 14:09:01 | aspiers | I wasn't, as per previous conversation | |
| 14:09:13 | aspiers | but maybe that can be revisited | |
| 14:09:58 | kashyap | aspiers: Yeah, let's revisit that conversation, plese | |
| 14:10:14 | aspiers | Can you do me a favour and find the link to it? ;-) | |
| 14:10:17 | kashyap | aspiers: Because, IMHO, it is not needed to tie that to SEV at all | |
| 14:10:18 | aspiers | Maybe in that review | |
| 14:10:40 | aspiers | I remember explicitly explaining the dependency somewhere | |
| 14:11:02 | aspiers | Oh, that *is* the link | |
| 14:11:08 | kashyap | Yeah :-) | |
| 14:11:17 | aspiers | Yeah, my comment on March 19th | |
| 14:11:39 | kashyap | aspiers: Oh, I'm blind. Will read it | |
| 14:11:45 | aspiers | :) | |
| 14:11:59 | kashyap | aspiers: The reason I ask is ... just now a libvirt dev was suggesting: | |
| 14:12:19 | kashyap | "I suggest Nova queries domcapabilities first, to see if 'efi' with Secure Boot is available" | |
| 14:12:33 | kashyap | (When implementing SB support, i.e.) | |
| 14:21:55 | mriedem | so we have a RESIZE_CONFIRMING task_state enum but never use it while confirming a resize https://github.com/openstack/nova/blob/e25d59078e61fe9f925dbef53dfe88e575d34dab/nova/compute/api.py#L3535 | |
| 14:21:59 | mriedem | that seems...not good? | |
| 14:22:28 | mriedem | unlike when reverting a resize we set the task_state in the API before casting to compute https://github.com/openstack/nova/blob/e25d59078e61fe9f925dbef53dfe88e575d34dab/nova/compute/api.py#L3515 | |
| 14:26:43 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | |
| 14:28:09 | mriedem | vdrok: mdbooth: lyarwood: more comments in https://review.openstack.org/#/c/571410/9 | |
| 14:29:10 | mriedem | i'm inclined to take a more conservative incremental approach to fixing the VERIFY_RESIZE steady state issue | |
| 14:29:20 | mriedem | which we could also backport more safely i think | |
| 14:31:31 | vdrok | meaning somewhat like it was done in ps7 https://review.openstack.org/#/c/571410/7/nova/virt/libvirt/driver.py | |
| 14:31:53 | mriedem | exactly | |
| 14:33:05 | mriedem | i'm not entirely sold on the completely ignore case like in bug 1824974 where the disk on the host is garbage and we just put our heads in the sand | |
| 14:33:06 | openstack | bug 1824974 in OpenStack Compute (nova) "Nova Compute Manager (Resource update) fails if a disk is missing" [Low,In progress] https://launchpad.net/bugs/1824974 - Assigned to Vladyslav Drok (vdrok) | |
| 14:39:35 | mnaser | as far as I know RDO ships upstream code | |
| 14:40:13 | mnaser | NewBruce: I wonder if it would be a good exercise to change one of the compute nodes to log it's current highest negotiated rpc version | |
| 14:40:26 | mnaser | and then see if for some reason it's negotiating a bad number | |
| 14:41:28 | artom | mnaser, I believe you're right, RDO is straight up upstream | |
| 14:41:35 | artom | Any backports we do is OSP, not RSO | |
| 14:41:37 | artom | *RDO | |
| 14:45:52 | mnaser | yeah, so RDO is upstream, OSA is upstream | |
| 14:47:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Make libvirt expose supported image types https://review.openstack.org/653454 | |
| 14:48:47 | sean-k-mooney | mnaser: im currently updating unit test but i think http://paste.openstack.org/show/749431/ will fix NewBruce issue | |
| 14:51:05 | efried | mriedem: There's no blueprint or anything for sdk-in-nova yet because up to this point we've been experimenting to see how it would work and what we can get done. I do have it on the ptg etherpads in some form. But will also try to file a bp soon. | |
| 14:51:35 | sean-k-mooney | efried: well you can file a blueprint just as a tracker right | |
| 14:51:49 | efried | yeah, could do. | |
| 14:51:51 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | |
| 14:52:02 | mnaser | sean-k-mooney: that's fair, I do feel like that might be a bit of a workaround I guess :-p | |
| 14:52:03 | efried | dustinc: How do you feel about leading that? | |
| 14:52:08 | sean-k-mooney | efried: it does not need to have a solution atached just "sdk is a thing we should use it" | |
| 14:52:51 | mriedem | "x exists we should use it" isn't sufficient justification imo | |
| 14:52:53 | sean-k-mooney | mnaser: well i have not found the root casue so yes but i think we likely should make this chagne on master and backport and then see if we can create a reporducer | |
| 14:53:09 | efried | sean-k-mooney: Part of what we've been working on is the scope too. "Plumb SDK" is one aspect; "stop using python-${service}client" is another. | |
| 14:53:28 | sean-k-mooney | mriedem: maybe not to approve the blueprint but it enough to file it | |
| 14:53:49 | sean-k-mooney | efried: ah ok | |
| 14:53:52 | mriedem | sure, blueprints are free | |
| 14:54:23 | mriedem | fixing the bugs they introduce is not | |
| 14:54:40 | sean-k-mooney | was "stop using python-*-client" in services approved as a comunity goal by the way | |
| 14:55:06 | mriedem | https://governance.openstack.org/tc/goals/ | |
| 14:55:40 | efried | sean-k-mooney, mriedem: The reasoning would go something like: "We want to stop using python-${service}client => We could use ksa adapter stuff, which we've already set up, but then we would have to write do-a-thing wrappers around get/put/etc primitives => so let's use the sdk, which already has those wrappers" | |
| 14:55:53 | sean-k-mooney | actully i guess that is a dumb question that will be decided at the fourm/ptg in 2 weeks | |
| 14:55:55 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add ids to sections of flavors guide to allow deep-linking https://review.openstack.org/653458 | |
| 14:56:46 | mriedem | sean-k-mooney: is that even a proposed goal for train or are you just making it up? | |
| 14:56:56 | sean-k-mooney | efried: part of the scoping would be ensuring the sdk has the actual wrapper we need | |
| 14:57:13 | efried | mriedem: there was a proposed goal to stop using python-${service}client for CLIs. | |
| 14:57:25 | mriedem | yeah, that's quite a bit different | |
| 14:57:28 | efried | which is distantly related to this, but not really overlapping. | |
| 14:57:28 | efried | yeah. | |
| 14:57:44 | sean-k-mooney | ah that is proably what im mixing it up with | |
| 14:58:19 | sean-k-mooney | it was one of the tread i lost track of on the mailing list | |
| 14:58:21 | efried | mriedem: anyway, the ironic team (as an example) is strongly behind the idea of ripping ironicclient out of nova | |
| 14:58:40 | efried | so I poked at a couple of ways of doing that | |
| 14:59:27 | efried | and it's about time we did *something* to break our pattern of "set up a whole KSA adapter just to grab the endpoint out of it and send that into *client which uses it to create a whole nother Adapter to do its work" | |
| 14:59:38 | efried | which we do (in different ways!) for glance, ironic, neutron... | |
| 15:00:45 | mriedem | the ksa stuff in nova still feels new to me, but i'm slow and old | |
| 15:00:53 | mriedem | and was a big improvement over the per-service config and all that | |
| 15:01:02 | mriedem | cinder excluded since we haven't fixed that one yet | |
| 15:01:46 | gmann | mriedem: updated this with review comments. - https://review.openstack.org/#/c/603969/ | |
| 15:04:42 | efried | mriedem: It was an improvement in the sense that operators can now use same-looking conf values for talking to the services. But internally we didn't improve much: we're still doing the dance I mentioned above --^ | |
| 15:05:30 | efried | And, wasn't the ksa cutover in Queens? That's a pretty long time ago. Maybe just seems that way for me as it's pretty much when I first got involved in nova proper. | |
| 15:07:56 | mriedem | queens is still very new to me | |
| 15:08:03 | mriedem | hell pike is as well | |
| 15:08:17 | mriedem | if i'm still fixing bugs in ocata/pike etc it's new to me | |
| 15:16:52 | mriedem | vdrok: just some small updates to https://review.openstack.org/#/c/571410/ | |
| 15:24:04 | mriedem | dansmith: can you hit this backport to keep things moving https://review.openstack.org/#/c/651639/2 | |
| 15:24:27 | mriedem | and https://review.openstack.org/#/q/If966eb1161c842ff49aa530e4482dbca87b61a3e+status:open since that's a gate issue hitting stable backports | |
| 15:25:06 | mriedem | melwitt: can you hit these backports? https://review.openstack.org/#/q/topic:bug/1819963+(status:open+OR+status:merged)+branch:stable/rocky | |
| 15:25:09 | cfriesen | mriedem: thanks for triaging that resize regression issue and writing the regression test. looks like Jack and I dropped the ball there. | |
| 15:25:16 | mriedem | cfriesen: i approved the change | |
| 15:25:21 | mriedem | i probably approved all of these busted changes | |
| 15:25:46 | mriedem | cfriesen: please see my comment-to-self on the fix and drop your opinion on decoupling the grossitude | |
| 15:25:59 | dansmith | mriedem: ack | |
| 15:26:03 | cfriesen | mriedem: for sure | |
| 15:26:29 | mriedem | cfriesen: i'll also say that as much as i don't like these regressions, i'm happy there are people in your org somewhere doing real testing | |
| 15:27:17 | mriedem | lyarwood: can you hit this backport? https://review.openstack.org/#/c/647623/ | |
| 15:27:29 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | |
| 15:27:51 | mriedem | gmann: ack | |
| 15:28:26 | mriedem | vdrok: +2 thanks | |
| 15:28:45 | mriedem | would be good to get another core on ^ since that's been around a long time | |
| 15:28:47 | mriedem | and is very latent | |
| 15:28:56 | mriedem | efried: ^ | |