| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-16 | |||
| 21:56:03 | mnaser | yeah | |
| 21:56:06 | dansmith | just a feature flag sort of "I've converted all the flavors, stop asking me" | |
| 21:56:08 | dansmith | problem is, | |
| 21:56:13 | mriedem | we could also be better about following up and cleaning these things up | |
| 21:56:28 | dansmith | if you end up with some older services by accident, you create old data, and stop running the migrations afterwards with no way of cleaning them up | |
| 21:56:37 | dansmith | mriedem: yup | |
| 21:57:52 | mnaser | I guess something that could be neat is opt-in soft delete | |
| 21:57:56 | mnaser | or opt-out | |
| 21:58:32 | mnaser | that'd probably make life a lot simpler and those online data migrations won't hurt as much, as imho you probably rarely find a million (running) instance cloud, but much more likely to have million (in total) vms | |
| 21:58:33 | dansmith | opt-out from ever showing deleted would be okay, because it's equivalent (api-wise) to running archive in a tight loop in the background | |
| 21:58:54 | dansmith | but opt-out from the soft deleting at all is harder to do | |
| 21:59:19 | efried | aspiers: Sorry, I missed you again. Left comments on the SEV review. | |
| 21:59:27 | aspiers | thanks! | |
| 22:22:04 | mriedem | huh this is fun https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-create | |
| 22:22:13 | mriedem | --config-drive <config-drive-volume>|True | |
| 22:22:17 | mriedem | Use specified volume as the config drive, or ‘True’ to use an ephemeral drive | |
| 22:22:26 | mriedem | as far as i know, that's not at all how that parameter works in the API | |
| 22:24:21 | mriedem | dansmith: has nova ever supported passing a volume id for the config drive to server create? | |
| 22:24:31 | dansmith | nfi | |
| 22:24:42 | dansmith | but no, doesn't sound familiar to me | |
| 22:29:57 | mriedem | maybe some special sauce from 2012 https://review.openstack.org/#/c/3994/ | |
| 22:40:55 | imacdonn | mriedem: speaking of cleaning up after migrations .... I wonder if something should be done to handle those null security_groups rows that would have been created for anyone who has already run the migrations while instances exist ... | |
| 22:43:18 | mriedem | definitely maybe | |
| 22:43:33 | imacdonn | seems like the sort of thing that could come back to bite later :/ | |
| 22:49:59 | eandersson | Yo | |
| 22:50:01 | eandersson | https://github.com/openstack/nova/commit/35f49f403534e174578dcd1b9ab33daf6f14c3e8 | |
| 22:50:06 | eandersson | We need this in stable/rocky | |
| 22:50:28 | eandersson | ironic_url does not actually do anything in the ironicclient for Rocky | |
| 22:50:33 | eandersson | So ironic does not respect regions at all | |
| 22:50:43 | eandersson | TheJulia, ^ | |
| 22:56:14 | mriedem | eandersson: and that's due to https://review.openstack.org/#/c/359061/ in python-ironicclient in rocky? | |
| 22:57:38 | eandersson | actually it's odd | |
| 22:57:47 | eandersson | convert_keystoneauth_opts should fix that | |
| 22:58:22 | mriedem | i'm not sure how easy it is to backport that given it's dependent on ironicclient >= 2.4.0 | |
| 22:59:13 | eandersson | Yea - let me do a bit more research | |
| 23:00:47 | TheJulia | eandersson: I was just about to link tot he discussion http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2019-04-16.log.html#t2019-04-16T22:39:49 | |
| 23:00:57 | TheJulia | to the | |
| 23:14:48 | melwitt | mriedem: fyi, I got some more reviews on https://review.openstack.org/611974, even got a +1 from melissaml. should be good to go | |
| 23:17:40 | mriedem | i can't handle that at this late hour | |
| 23:17:49 | mriedem | but will star it | |
| 23:18:35 | openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | |
| 23:21:13 | openstackgerrit | melanie witt proposed openstack/nova master: Fix assert in test_libvirt_info_scsi_with_unit https://review.openstack.org/653168 | |
| 23:21:35 | melwitt | mriedem: thanks. I got antsy with some of the pike changes going to the gate | |
| 23:37:09 | aspiers | kashyap: definitely need your input on https://review.openstack.org/#/c/641994/6/specs/train/approved/amd-sev-libvirt-support.rst@123 :) | |
| #openstack-nova - 2019-04-17 | |||
| 00:01:06 | openstackgerrit | Merged openstack/nova stable/rocky: Override the 'get' method in DriverBlockDevice class https://review.openstack.org/647651 | |
| 00:06:19 | alex_xu | francoisp_: already add it my review list, will try to reach it | |
| 00:25:59 | mriedem | cfriesen: jackding: wee stein regression https://bugs.launchpad.net/nova/+bug/1825020 | |
| 00:26:00 | openstack | Launchpad bug 1825020 in OpenStack Compute (nova) "resize of instance, that was booted from volume, trigger image size check then fails resize" [Undecided,New] | |
| 01:24:37 | melwitt | aspiers: something odd for your morrow http://eavesdrop.openstack.org/irclogs/%23openstack-placement/%23openstack-placement.2019-04-17.log.html#t2019-04-17T00:13:06 | |
| 01:26:01 | melwitt | tl;dr placement rejecting a PUT of the COMPUTE_NET_ATTACH_INTERFACE trait from nova compute. I don't understand how that could be happening | |
| 01:54:12 | openstackgerrit | Merged openstack/nova stable/pike: Fix functional tests for USE_NEUTRON https://review.openstack.org/649385 | |
| 01:54:20 | openstackgerrit | Merged openstack/nova stable/pike: Add functional regression test for bug 1669054 https://review.openstack.org/649386 | |
| 01:54:22 | openstack | bug 1669054 in OpenStack Compute (nova) pike "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,In progress] https://launchpad.net/bugs/1669054 - Assigned to Matt Riedemann (mriedem) | |
| 02:06:03 | openstackgerrit | Merged openstack/nova stable/pike: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/649387 | |
| 02:32:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Exclude fake marker instance when listing servers https://review.openstack.org/653158 | |
| 02:32:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test wrinkle to list deleted servers before archive https://review.openstack.org/653131 | |
| 02:54:17 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | |
| 02:57:12 | mriedem | melwitt: regarding the change in behavior for quota usage calculations pre and post pike with counting, you might want to report a bug just to capture the change in behavior just so we can at least document it if we want outside of mailing list threads and code review comments | |
| 02:57:47 | mriedem | i was thinking something like if we fleshed out the quota docs reference page we could / should the big shift in design with counting in pike but could also list that as a known issue | |
| 02:58:21 | mriedem | https://docs.openstack.org/nova/latest/user/quotas.html | |
| 02:59:05 | mriedem | there was also https://bugs.launchpad.net/nova/+bug/1716706 | |
| 02:59:06 | openstack | Launchpad bug 1716706 in OpenStack Compute (nova) "Should count instances in build requests when check quotas" [Medium,Triaged] | |
| 03:03:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression recreate test for bug 1825020 https://review.openstack.org/653268 | |
| 03:03:56 | openstack | bug 1825020 in OpenStack Compute (nova) stein "resize of instance, that was booted from volume, trigger image size check then fails resize" [High,Triaged] https://launchpad.net/bugs/1825020 | |
| 03:28:00 | melwitt | mriedem: ack | |
| 03:29:17 | eandersson | mriedem, nvm wasn't a nova bug | |
| 03:29:17 | eandersson | https://review.openstack.org/#/c/653271/ | |
| 03:29:43 | eandersson | * https://review.openstack.org/#/c/653233/ | |
| 03:33:11 | mriedem | eandersson: ack - you should report a bug for the latter | |
| 03:33:15 | mriedem | or story or whatever | |
| 03:33:21 | eandersson | Yep | |
| 03:33:27 | eandersson | I'll deal with that tomorrow | |
| 04:02:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass root bdm to _validate_flavor_image_nostatus during resize https://review.openstack.org/653273 | |
| 04:27:10 | openstackgerrit | melanie witt proposed openstack/nova master: Add get_usages_counts_for_quota to SchedulerReportClient https://review.openstack.org/653145 | |
| 04:27:11 | openstackgerrit | melanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | |
| 04:27:11 | openstackgerrit | melanie witt proposed openstack/nova master: Set [quota]count_usage_from_placement = True in nova-next https://review.openstack.org/653146 | |
| 04:27:12 | openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | |
| 07:22:45 | kashyap | aspiers: Morning, just took a quick look. I see the topic is: machine types as 'traits'. Will respond today once I finish something | |
| 08:00:34 | openstackgerrit | Hamdy Khader proposed openstack/nova master: Do not perform port update in case of baremetal instance. https://review.openstack.org/649345 | |
| 08:33:20 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Re-propose stable device rescue for Train https://review.openstack.org/651151 | |
| 09:09:09 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object https://review.openstack.org/649534 | |
| 09:09:10 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877 | |
| 09:09:10 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878 | |
| 09:09:11 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535 | |
| 09:09:11 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: WIP: FUP on use-placement-in-tree series https://review.openstack.org/653362 | |
| 09:49:53 | stephenfin | rechecking all the things | |
| 10:26:24 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.openstack.org/506720 | |
| 10:27:50 | kashyap | sean-k-mooney: Hi, when you get a minute ^ I've wrote a summary response. And addressed a few things. | |
| 10:28:48 | kashyap | I spent a lot of time writing the summary response, please read it in full before responding. | |
| 10:45:38 | kashyap | lyarwood: gibi: If you have 15 more minutes today, appreciate another look at this: https://review.openstack.org/506720 | |
| 11:01:48 | aspiers | kashyap: cool thanks | |
| 11:02:05 | kashyap | aspiers: About to hit 'submit' with my comment | |
| 11:02:10 | aspiers | awesome | |
| 11:02:32 | kashyap | aspiers: Also if you have spare neurons, here's the UEFI SB spec: https://review.openstack.org/#/c/506720/ | |
| 11:02:48 | kashyap | I addressed as much as I can. And my eyes are weary from reading my own text. (Despite extensive editing) | |
| 11:02:53 | aspiers | if anything I have a neuron deficit, but that's my problem ;-) | |
| 11:02:58 | aspiers | Haha I know that feeling | |
| 11:04:59 | kashyap | aspiers: No problem at all. Then just say "no". :-) | |
| 11:06:09 | aspiers | I hate asking people for help and not offering some in return though :-/ | |
| 11:12:25 | sean-k-mooney | kashyap: ya most of your responce makes sense. ill re review with itopen in a secon tab | |