Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-04-15
21:38:12 mriedem dansmith: coincidentally that series is related to recent issues https://review.openstack.org/#/q/topic:okay-we-got-it+(status:open+OR+status:merged)
21:41:36 sean-k-mooney mriedem: by the way i added a memorize decorator in https://review.openstack.org/#/c/599071/3/nova/api/validation/parameter_types.py so we could just move the into the nova utils and reuse it if we want
21:59:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Make nova.compute.rpcapi.ComputeAPI.router a singleton https://review.openstack.org/649197
22:06:02 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: log when loading security group driver https://review.openstack.org/652783
23:39:17 openstackgerrit Lee Yarwood proposed openstack/nova master: Restore connection_info after live migration rollback https://review.openstack.org/551349
23:39:18 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP compute: Use source_bdms to reset attachment_ids during LM rollback https://review.openstack.org/652800
23:48:24 openstackgerrit Merged openstack/nova stable/rocky: Adding tests to demonstrate bug #1821824 https://review.openstack.org/649602
23:48:26 openstack bug 1821824 in OpenStack Compute (nova) rocky "Forbidden traits in flavor properties don't work" [High,In progress] https://launchpad.net/bugs/1821824 - Assigned to Eric Fried (efried)
23:48:31 openstackgerrit Merged openstack/nova stable/rocky: Fix bug preventing forbidden traits from working https://review.openstack.org/649603
23:48:37 openstackgerrit Merged openstack/nova stable/rocky: Add missing libvirt exception during device detach https://review.openstack.org/651637
#openstack-nova - 2019-04-16
00:02:41 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.openstack.org/652800
00:53:31 openstackgerrit zhufl proposed openstack/nova master: Remove conductor_api and _last_host_check from manager.py https://review.openstack.org/651059
01:05:49 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces the openstacksdk to nova https://review.openstack.org/643664
03:01:13 openstackgerrit Boxiang Zhu proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server https://review.openstack.org/645458
04:05:04 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.openstack.org/651969
05:23:27 openstackgerrit Merged openstack/nova master: Handle unsetting '[DEFAULT] dhcp_domain' https://review.openstack.org/652662
06:05:09 openstackgerrit Boxiang Zhu proposed openstack/nova master: [WIP] Add host and hypervisor_hostname flag to create server https://review.openstack.org/645520
06:18:05 openstackgerrit Merged openstack/nova master: Remove dead code https://review.openstack.org/650277
07:56:43 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.openstack.org/651969
08:22:37 openstackgerrit Merged openstack/nova master: Dropping the py35 testing https://review.openstack.org/643871
08:25:28 openstackgerrit Merged openstack/nova master: Bump to hacking 1.1.0 https://review.openstack.org/651553
08:25:36 openstackgerrit Merged openstack/nova master: Remove 'nova-cells' service https://review.openstack.org/651290
08:37:33 lyarwood stephenfin: https://review.openstack.org/#/c/637224/ - would you mind taking a look at this today?
08:37:52 lyarwood ^ not a spec FWIW so feel free to ignore for now
08:43:36 kashyap lyarwood: Morning, hope this answers your question: https://review.openstack.org/#/c/506720/8/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst@287
08:43:41 kashyap (Thanks for the review, so far.)
08:47:15 stephenfin lyarwood: added to the queue :)
08:52:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove '/os-cells' REST APIs https://review.openstack.org/651291
08:52:42 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling cells v1 in '/os-hypervisors' API https://review.openstack.org/651292
08:52:42 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling cells v1 in '/os-servers' API https://review.openstack.org/651293
08:52:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-manage cell' commands https://review.openstack.org/651294
08:52:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling cells v1 for console authentication https://review.openstack.org/651295
08:52:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove old-style cell v1 instance listing https://review.openstack.org/651296
08:52:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'bdm_(update_or_create|destroy)_at_top' https://review.openstack.org/651297
08:52:45 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'instance_fault_create_at_top' https://review.openstack.org/651298
08:52:45 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'instance_info_cache_update_at_top' https://review.openstack.org/651299
08:52:46 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'get_keypair_at_top' https://review.openstack.org/651300
08:52:46 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'instance_update_at_top', 'instance_destroy_at_top' https://review.openstack.org/651301
08:52:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'instance_update_from_api' https://review.openstack.org/651302
08:52:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling 'update_cells' on 'BandwidthUsage.create' https://review.openstack.org/651303
08:52:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling cells v1 for instance naming https://review.openstack.org/651304
08:52:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove cells code https://review.openstack.org/651306
08:55:25 lyarwood kashyap: ack thanks, replied. I was more suggesting we generate the file once and make copies for each instance to use after that.
08:56:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'instance_update_from_api' https://review.openstack.org/651302
08:56:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling 'update_cells' on 'BandwidthUsage.create' https://review.openstack.org/651303
08:56:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling cells v1 for instance naming https://review.openstack.org/651304
08:56:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove cells code https://review.openstack.org/651306
08:56:16 lyarwood kashyap: and that was what led me to ask about where that template/master file could be stored.
08:56:24 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop handling 'InstanceUnknownCell' exception https://review.openstack.org/651307
08:56:32 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unnecessary wrapper https://review.openstack.org/651308
08:56:39 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Remove cell APIs https://review.openstack.org/651309
08:56:53 lyarwood kashyap: generating it for each instance is expense IMHO, I'm just looking for ways to avoid that.
08:56:53 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Remove cells v1 options, group https://review.openstack.org/651310
08:57:16 kashyap lyarwood: Let me be sure I'm not misreading you:
08:57:44 kashyap lyarwood: You're saying to generate _once_ and reuse it? Or generate them ahead store them somewhere and _then_ use a unique VARS file per instance?
08:58:03 kashyap s/ahead store/ahead and store/
09:00:05 kashyap lyarwood: Okay, I see what you mean: generate a template once, make copies and use that when needed.
09:00:16 lyarwood kashyap: yup that's it
09:00:24 kashyap Let me see if there's any gotchas there. (And yeah, I'd like to avoid needless expensive creations, too)
09:06:04 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Remove cells v1 options, group https://review.openstack.org/651310
09:06:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove conductor_api and _last_host_check from manager.py https://review.openstack.org/651059
09:20:14 kashyap lyarwood: Important bit - I didn't mention this at all in the spec: there's actually a config attribute in /etc/libvirt/qemu.conf that lets you specify the master 'nvram' template ("VARS" file)
09:28:48 lyarwood kashyap: and that can already have the keys enrolled?
09:30:30 kashyap lyarwood: So currently if you peek at your /etc/libvirt/qemu.conf, it has mapping of which _CODE.fd file belongs to which _VARS.fd file
09:30:47 kashyap lyarwood: Checking with the libvirt folks for further usage
09:58:22 avolkov kashyap: hi, have a couple of questions on https://review.openstack.org/#/c/506720/. Could you take a look?
09:58:44 sean-k-mooney ... i realised i jsut spent an hour reviewing patchset 8 of kasaps spec
09:58:48 sean-k-mooney its on 10
10:02:32 kashyap sean-k-mooney: Heya
10:02:38 kashyap Thanks for the review, looking
10:02:55 kashyap A quick point top off the head: the key enrollment script should _not_ a libvirt feature
10:03:06 kashyap And we're _not_ "(Bash) shelling out" anything
10:03:25 kashyap If you read closely, I merely mentioned it to show what is going on behind the scenes.
10:03:33 sean-k-mooney the external tool is satring qemu and then executing command on the instance right
10:03:41 kashyap No.
10:04:15 kashyap As noted in an earlier response on the change, the VARS file generator script is _not_ launching any instance.
10:04:44 sean-k-mooney ok but it is printing raw bytes and stings to something
10:05:21 sean-k-mooney https://github.com/puiterwijk/qemu-ovmf-secureboot/blob/master/ovmf-vars-generator#L104
10:05:40 openstackgerrit Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215
10:05:50 kashyap sean-k-mooney: Have you ever tried Secure Boot?
10:06:04 kashyap sean-k-mooney: It is simply sending the escape char so that you can _run_ the tool
10:06:04 sean-k-mooney only on phyical machines
10:06:47 kashyap Please rephrase.
10:07:10 kashyap It can work the same in a nested env. too. The script is merely launching the ISO and enrolling the default keys
10:07:19 kashyap The standard behaviour documented for all distribution wiki pages
10:07:21 sean-k-mooney i have used secure boot but on physical machines but i have never replaced the keys
10:07:28 kashyap (Ah, okay)
10:07:36 sean-k-mooney kashyap: yes so its using qemu to launch a vm
10:07:47 sean-k-mooney it may not be the guest vm
10:07:52 kashyap No, it is launching a QEMU process. Not every QEMU process is not a "VM"
10:07:54 sean-k-mooney but its still launching a vm
10:08:05 kashyap So what?
10:08:18 kashyap It is the correct thing to do.
10:08:33 sean-k-mooney so have you considerd how this will work on a host that is configred to run guest with hugepages only
10:09:05 sean-k-mooney e.g. where the host has been tuned so that there is not a large amount of free meory or on a realtime host
10:09:08 kashyap (The process for you to try on a guest: https://wiki.ubuntu.com/UEFI/OVMF)
10:09:45 sean-k-mooney what im concened about it how much memoy this will use and can it impact other guests
10:09:51 kashyap sean-k-mooney: That is not relevant. Because you only launch the process *once* with 256MB of RAM
10:09:57 kashyap And generate the VARS file, and that's it.
10:10:06 sean-k-mooney once per vm

Earlier   Later