Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-04-12
21:22:12 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Error out migration when confirm_resize fails https://review.openstack.org/652127
21:22:13 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Delete allocations even if _confirm_resize raises https://review.openstack.org/652146
21:24:23 mriedem that's what i like to hear
21:24:48 melwitt I was thinking if it was an easy inline edit, that would be cool. but meh if you have to redo other stuff
21:25:18 mriedem i'm sure i'll never have to touch this request spec code again in these old stable branches...
21:25:30 melwitt right exactly
21:25:47 melwitt request spec is solid
21:48:45 mriedem eandersson: let me just say it's good you went to rocky rather than pike because trying to get that allocation leak fix back to pike is a huge pain in the ass, so i'm just going to not work on that for pike unless someone comes along and really needs it
22:03:19 eandersson I wish we could go to stein tbh, but we still rely on some vendor drivers
23:20:33 openstackgerrit Merged openstack/nova stable/stein: Error out migration when confirm_resize fails https://review.openstack.org/649421
23:20:39 openstackgerrit Merged openstack/nova stable/stein: Delete allocations even if _confirm_resize raises https://review.openstack.org/650437
23:20:45 openstackgerrit Merged openstack/nova stable/queens: Add functional regression test for bug 1669054 https://review.openstack.org/649362
23:20:47 openstack bug 1669054 in OpenStack Compute (nova) queens "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,In progress] https://launchpad.net/bugs/1669054 - Assigned to Matt Riedemann (mriedem)
23:20:52 openstackgerrit Merged openstack/nova stable/queens: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/649363
23:39:59 cfriesen mriedem: sorry, was having computer issues. I think that would be lowish priority. makes it a bit harder to write automated stuff if there are spurious error events.
23:59:23 openstackgerrit Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.openstack.org/639396
23:59:23 openstackgerrit Artom Lifshitz proposed openstack/nova master: [DNM: extra logs] Revert resize: wait for external events in compute manager https://review.openstack.org/644881
23:59:24 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: extra logging in neutron api for revert resize https://review.openstack.org/652174
23:59:53 artom Oh, if you want to change the subject you can't just edit them in `git rebase -i`
#openstack-nova - 2019-04-13
00:00:05 artom *shrug* it's all a big WIP/DNM mess anyways for now
00:35:22 eandersson Got a fun one
00:35:30 eandersson Nova deleted the compute, but it very much still exists
00:47:35 eandersson Restarting nova-compute removed the disk, but didn't stop the instance lol
00:50:23 openstackgerrit Merged openstack/nova master: Uncap jsonschema https://review.openstack.org/651943
00:50:46 efried dustinc: ^ you should just be able to rebase your series on master now to resolve that failure.
00:51:48 dustinc efried: great, thanks!
00:55:45 efried dustinc: While you're at it, go ahead and remove the WIP/PoC from the commit title. This patch is ready, I think. We'll need to marshal the dep through, but that's its own thing.
01:21:48 eandersson nvm on my issue - looks like bad memory
01:37:56 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP/PoC: Introduces the openstacksdk to nova https://review.openstack.org/643664
01:38:31 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces the openstacksdk to nova https://review.openstack.org/643664
01:38:51 dustinc efried: well I derped it into two commits, but it is updated
01:39:00 dustinc *patches
01:39:11 efried cool
04:50:57 openstackgerrit Merged openstack/nova stable/stein: Do not log a warning about not using compute monitors https://review.openstack.org/650929
10:53:11 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197
10:57:28 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197
11:03:07 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197
11:52:02 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197
12:18:24 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Add instance hard delete https://review.openstack.org/570202
12:18:25 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201
12:18:25 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203
12:25:24 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473
12:25:25 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585
12:46:25 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197
12:53:11 openstackgerrit Boxiang Zhu proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server https://review.openstack.org/645458
13:23:20 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197
16:56:13 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197
#openstack-nova - 2019-04-14
06:33:53 openstackgerrit Adrian Chiris proposed openstack/nova master: Do not perform port update in case of baremetal instance. https://review.openstack.org/649345
#openstack-nova - 2019-04-15
01:22:01 openstackgerrit zhufl proposed openstack/nova master: Remove conductor_api and cells_rpcapi from manager.py https://review.openstack.org/651059
01:56:07 openstackgerrit Boxiang Zhu proposed openstack/nova master: [WIP] Fix live migration break group policy simultaneously https://review.openstack.org/651969
03:01:46 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Dropping the py35 testing https://review.openstack.org/643871
03:07:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Dropping the py35 testing https://review.openstack.org/643871
03:19:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153
03:20:05 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Replace glance command with openstack command https://review.openstack.org/637060
03:20:25 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.openstack.org/637716
06:05:29 openstackgerrit Fan Zhang proposed openstack/nova master: Log disk transfer stats in live migration monitor. https://review.openstack.org/619395
08:13:19 kashyap gibi: Morning. On the Secure Boot spec, thanks for your comment :-) -- https://review.openstack.org/#/c/506720/
08:13:47 kashyap gibi: So if I refresh it with the additional answers to the questions discussed - I guess you're onboard with it.
08:14:18 kashyap (And then I can finally get down to the code :D I already have a WIP patch for some scaffolding work that's anyway required.)
08:19:00 openstackgerrit Tushar Patil proposed openstack/nova-specs master: Support filtering of allocation_candidates by forbidden aggregates https://review.openstack.org/609960
08:20:36 openstackgerrit Tushar Patil proposed openstack/nova-specs master: Allow compute nodes to use DISK_GB from shared storage RP https://review.openstack.org/650188
08:37:38 gibi kashyap: I'm OK with your spec based on your answers
08:38:36 kashyap gibi: Thank you. I'll refresh it with some tiny wording tweaks, then you can have a final look, and then can hopefully get your ACK (+2)
08:39:19 kashyap alex_xu: Hi, on the `cpu_model_list` spec, talking to the QEMU folks ... I'm not sure we should even do that (allowing a list of CPU models) at all.
08:40:13 kashyap gibi: Got an Ubuntu machine by any chance? If so can you please post the output of equivalent on Ubuntu?
08:40:30 kashyap (Err, broken copy/paste)
08:40:37 kashyap Output of: `dpkg --listfiles ovmf`
08:40:58 kashyap (Or whatever the package is called on Ubuntu)
08:41:41 kashyap gibi: Actually, disregard me, found this: https://packages.ubuntu.com/xenial/all/ovmf/filelist
08:44:55 gibi kashyap: this is from a bionic VM http://paste.openstack.org/show/749298/
08:45:19 kashyap (Yep, that's good. Thank you.)
08:45:25 gibi np
08:45:29 kashyap So Ubuntu just does what Debian does
09:03:27 openstackgerrit Boxiang Zhu proposed openstack/nova master: [WIP] Add host and hypervisor_hostname flag to create server https://review.openstack.org/645520
09:26:58 openstackgerrit Brin Zhang proposed openstack/nova master: wip: Non-admin user can filter servers by user_id https://review.openstack.org/652602
09:47:26 openstackgerrit Balazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.openstack.org/652608
10:09:13 openstackgerrit Boxiang Zhu proposed openstack/nova master: [WIP] Fix live migration break group policy simultaneously https://review.openstack.org/651969
10:22:23 aspiers sean-k-mooney, efried: hoping to have a new version of the SEV spec submitted in the next few hours
10:24:25 sean-k-mooney aspiers: cool good to know
10:24:36 sean-k-mooney aspiers: have you added it to the review day etherpad
10:24:44 sean-k-mooney i think it was there last week
10:25:07 stephenfin Can someone sanity check this and tell me how I've changed the logic? https://review.openstack.org/#/c/651554/3/nova/compute/api.py
10:25:31 stephenfin (tests are failing so I've obviously broken _something http://logs.openstack.org/54/651554/3/check/openstack-tox-py27/d5489c5/testr_results.html.gz)
10:25:32 aspiers sean-k-mooney: I am definitely intending to - I thought it wasn't really ready for more feedback yet until we address the existing concerns
10:25:44 sean-k-mooney stephenfin: looking
10:25:57 aspiers sean-k-mooney: my new patchset will be mostly just including the new info and suggestions from you / Daniel / Brijesh
10:26:59 sean-k-mooney stephenfin: im gessing the addtion of " and service_host is none"
10:27:29 stephenfin That reads to me like I'm moving the third case in the if-else to the first
10:27:31 sean-k-mooney actully no that is just the else block
10:27:34 stephenfin yeah
10:28:20 sean-k-mooney stephenfin: where do you call the new lookup_fn fucntion
10:28:37 stephenfin sean-k-mooney: line 5002 on the right
10:28:43 stephenfin maybe the 'target_cell' context manager is doing something weird? :/
10:29:24 sean-k-mooney it shouldnt
10:30:25 sean-k-mooney why are you doing this refactoring by the way. to get rid of the pep8 warning about lamdas should not be named?
10:30:46 stephenfin sean-k-mooney: Yeah. I was going to noqa that particular one but for some reason I can't do that
10:32:11 sean-k-mooney stephenfin: why are you not passing in service_id by the way
10:32:42 stephenfin where now?
10:33:04 sean-k-mooney https://review.openstack.org/#/c/651554/3/nova/compute/api.py@4989
10:34:11 stephenfin sean-k-mooney: You don't need to for nested functions. They have access to everything in their parent's

Earlier   Later