Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-04-11
14:48:21 stephenfin dansmith: The migration path we'd suggested was keeping that but limiting it to hosts with "I don't have hyperthreads" trait set
14:48:23 stephenfin I think
14:48:25 sean-k-mooney to forbined:trait=COMPUTE_SMT
14:48:36 stephenfin Wait, yeah, that ^
14:49:05 dansmith stephenfin: that's cool, it just can't like .. be removed, like sean-k-mooney was saying :)
14:49:22 sean-k-mooney removed was a bad phasing
14:49:26 stephenfin dansmith: True. We can think about deprecating it in the future though
14:49:28 sean-k-mooney its meaning would change
14:49:34 stephenfin It's that or we carry the shim forever
14:49:34 dansmith I don't
14:49:35 dansmith it's API
14:49:52 stephenfin We deprecate/remove other APIs though?
14:49:54 dansmith you can fail the boot if it's specified as anything if you want
14:50:04 dansmith stephenfin: this is unversioned
14:50:14 dansmith but I think we have to check for it basically forever
14:50:23 dansmith it's also API that's unversioned and spread between nova, glance and cinder
14:50:37 stephenfin Hmm, good point
14:50:56 dansmith I'm not saying you have to honor it well, with a shim forever,
14:50:59 sean-k-mooney ok does it help to split that bit out into another spec
14:51:02 dansmith but you can't ever just start ignoring it, IMHO
14:51:15 stephenfin ok, let's kick that can down the road
14:51:44 stephenfin for now, I quite like the idea of overallocating the PCPUs for existing instances with the 'isolate' policy
14:51:45 dansmith the only reason not to separate it is if it's a problem for your current proposal, like you can't continue to honor it as is after you make other changes
14:51:45 sean-k-mooney well its a prequisit for dedicated cpus in placmente
14:51:54 dansmith but if that's not a problem, then sure
14:52:07 sean-k-mooney well it is a proablem for the current proposal
14:52:12 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server https://review.openstack.org/645458
14:52:16 dansmith then we can't separate it completely
14:52:17 stephenfin sean-k-mooney: Yeah, I don't think we can split it out entirely
14:52:36 dansmith I've been on a call for the last hour, and have another starting soon that I actually have to pay attention to, FYI
14:52:42 stephenfin We need to figure out what happens right now, once we have PCPUs in placement
14:52:48 dansmith so don't assume my pending silence on this matter is because I have shot myself in the face
14:53:34 stephenfin What we don't need to figure out now is what we're doing even further down the road (in terms of failing the instance if the image property is set or something else)
14:53:40 mriedem bauzas: you know how we reset_forced_destinations on the request spec when moving a server?
14:53:43 stephenfin dansmith: Ack, me too
14:53:48 sean-k-mooney stephenfin: well the traits thing is mentioned here https://review.openstack.org/#/c/555081/22/specs/train/approved/cpu-resources.rst@778
14:53:51 dansmith stephenfin: yes, I think you can punt on that part
14:54:25 mriedem bauzas: if i create a server with a query scheduler hint targeted at a host or hypervisor_hostname, i can never migrate my server off the host :) same problem - but dumber
14:54:30 stephenfin sean-k-mooney: Oh, indeed it is. I just need to expand on that I guess
14:54:41 stephenfin OK, let me try and jot all this down in the spec and clean up the other issues
14:55:19 sean-k-mooney so its litrally already part of the spec. the only fuctionality that you loose with tah it you can nolonger use isolate to allow a host with hyperthreads to be shared between guests that want full coures and thost that can just have threads
14:56:03 sean-k-mooney stephenfin: the code isnt the problem with this sepc
14:56:37 sean-k-mooney stephenfin: the upgrade impact is and it think we can move forward with this spec but the current spec still has upgrade issues
14:57:31 sean-k-mooney stephenfin: i share dansmith view that we shoudl enable inplace upgrades to this new way of doing things if we can do that i will be happy with this
14:58:30 sean-k-mooney stephenfin: that requrie either paralle implementions and a config to opt in to new beahvior or no change to exising configs
15:01:14 bauzas mriedem: sec, was otp
15:02:07 mriedem bauzas: somewhat related but you might have something to add to my reply here https://review.openstack.org/#/c/649534/5/nova/objects/request_spec.py@606
15:02:08 bauzas uh, and now in meeting actually :(
15:02:18 mriedem bauzas: not high priority
15:07:31 mriedem stephenfin: can we not have a py3 unit test for https://review.openstack.org/#/c/650235/ ?
15:08:07 stephenfin mriedem: Not really, no. It's an environment thing
15:08:27 mriedem but can't we control the environment in a test?
15:09:21 mriedem btw zigo made the same change in osc https://review.openstack.org/#/c/541609/
15:09:24 stephenfin Yes? No? I honestly don't know. We'd be monkeypatching Python internals, I suspect
15:09:44 mriedem idk about that,
15:09:48 mriedem nova's tox.ini sets this:
15:10:00 mriedem LC_ALL=en_US.utf-8
15:10:36 stephenfin right, so the Python process is correctly configured in that case
15:10:59 stephenfin I think we'd have to reload the interpreter to misconfigure things
15:11:01 sean-k-mooney is this realted to the gat using the LC_ALL=C again
15:11:05 stephenfin yup
15:11:22 mriedem stephenfin: takashi also asked that something is documented about this which could probably go here https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-console-log
15:11:54 stephenfin mriedem: I don't think OSC is an issue because of the follow up patch to the one you linked https://review.openstack.org/#/c/554698/1
15:12:25 mriedem ah ok
15:12:40 stephenfin Alas, we don't use cliff in novaclient
15:12:53 stephenfin As for docs, it's on my todo list and I'll try drag something out by the end of the week
15:15:05 stephenfin mriedem: There's an alternative approach we can take that doesn't require changing environment configuration, but I don't know if we want to do it as it's a huge hack https://review.openstack.org/#/c/583535/
15:15:14 stephenfin I'd nearly rather suggest people use Python 3 if they're encountering these kinds of Unicode issues
15:18:17 mriedem i'll see if i can add a unit test in novaclient
15:30:26 melwitt mriedem: thanks, will take a look. I'm in the middle of updating everything, will be able to push the updates soon today I think
15:34:34 melwitt soon™
15:42:45 lyarwood melwitt: https://review.openstack.org/#/c/611974/ - finally got to this btw, LGTM after playing around with it locally.
15:43:08 melwitt lyarwood: just saw that, thanks so much
16:06:14 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add test for console-log and docs for bug 1746534 https://review.openstack.org/651827
16:06:16 openstack bug 1746534 in python-novaclient "encoding error when doing console-log" [High,Fix released] https://launchpad.net/bugs/1746534 - Assigned to Thomas Goirand (thomas-goirand)
16:06:20 mriedem stephenfin: see how ^ grabs you
16:06:27 mriedem i couldn't reproduce the original bug in the unit test
16:08:53 stephenfin mriedem: Yup, that looks good to me. Good find with those click docs
16:13:10 mriedem need a stable core to hit these https://review.openstack.org/#/q/topic:bug/1821824+branch:stable/stein
16:15:20 lyarwood mriedem: have the branch open to review now btw
16:54:56 openstackgerrit Merged openstack/nova master: devstack: Remove 'tempest-dsvm-tempest-xen-rc' https://review.openstack.org/650018
17:14:07 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IP proxy methods https://review.openstack.org/643115
17:14:13 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Refactor functional base test classes https://review.openstack.org/643101
17:14:33 lyarwood mriedem: https://review.openstack.org/#/q/status:open+topic:bug/1803961 - Would you mind taking a look at this again when you have time. I'm going to suggest that we land and backport this over the competing cinder fix for the time being.
17:17:47 openstackgerrit Merged openstack/nova master: trivial: Remove dead nova.db functions https://review.openstack.org/649570
17:48:46 mriedem lyarwood: couldn't get jgriffith or another cinder person to look at https://review.openstack.org/#/c/637224/ ?
17:51:53 lyarwood mriedem: I did a while ago and they pointed me towards https://review.openstack.org/#/c/638995/ but that has now stalled and I'm thinking it might just be easier to fix and backport in Nova given the cinder change is touching lots of different backends.
17:52:23 lyarwood mriedem: I can ask again to get confirmation that using migration_status is okay with them as a workaround until ^ lands.
18:22:20 mriedem melwitt: thinking out loud about quota and cross-cell resize and your placement change, when a user resizes a server today, placement will track vcpu/ram usage against both the source and dest node, but the /limits API will only show vcpu/ram usage for the new flavor since that is counted from the instance right?
18:22:57 mriedem so i think if i'm resizing from a flavor with vcpu=2 to vcpu=4, usage from placement for that project will say a total of 6, but the compute limits API would say 4
18:23:49 mriedem i'm not necessarily saying that's wrong, but is that accurate?
18:24:41 melwitt yeah, it's definitely not going to say 6, but I don't remember if it will say 2 or 4 before the resize is confirmed
18:24:57 mriedem placement would say 6
18:25:14 melwitt yeah
18:25:53 melwitt looking at the code to see when the new flavor is saved to the Instance object vcpus and memory_mb attributes
18:25:59 mriedem once the server is resized the limits api would say 4 https://github.com/openstack/nova/blob/03322bb517925a9f5a04ebdb41c3fd31e7962440/nova/objects/instance.py#L1535
18:26:07 melwitt those attributes are what's counted today
18:26:38 mriedem it's finish_resize on the dest host https://github.com/openstack/nova/blob/03322bb517925a9f5a04ebdb41c3fd31e7962440/nova/compute/manager.py#L4632
18:26:49 mriedem same method that changes the instance status to VERIFY_RESIZE
18:27:44 melwitt ah ok

Earlier   Later