Posted	Nick	Remark
#openstack-nova - 2019-04-08
20:51:18	mriedem	but apparently forgot to add them for rocky
20:51:21	mriedem	*in* stein
20:51:38	efried	I'm confused
20:51:46	efried	then why is https://review.openstack.org/#/c/650964/ in master and not in stable/stein?
20:51:58	mriedem	for example, latest cell db migration in stein is 391 https://github.com/openstack/nova/tree/stable/stein/nova/db/sqlalchemy/migrate_repo/versions so if we needed something in stable/stein, we'd have to add 392 in stable/stein and then copy that to the 392_placeholder in train
20:52:11	mriedem	it's essentially a buffer,
20:52:20	mriedem	because otherwise the first schema migration in train is 392
20:52:30	mriedem	so if we need something in stein but already used 392 in train, we're stuck
20:53:26	efried	oh, so if we hadn't done any migrations in stein, we could set up the buffer for rocky.
20:53:28	jaypipes	mriedem: instance_action_events.action_id will automatically have an index on it since it's an FK to instance_actions
20:53:29	mriedem	rocky ended at 390 and there was one cell db migration in stein, 391
20:53:33	mriedem	so if we need something on rocky we're f'ed
20:53:51	jaypipes	at least for mysql and pgsql it will.
20:54:06	mriedem	jaypipes: ah ok, thanks. i seem to remember asking about this same query a year or more ago and came to the same conclusion (or you told me the same at the time)
20:54:07	jaypipes	I think :)
20:54:35	jaypipes	might want to have mnaser do a quick SHOW TABLE instance_action_events to verify
20:54:38	mriedem	else i'm thinking action_id/deleted or something
20:55:11	jaypipes	hmm, maybe not since we don't use SQLalchemy create_tables()
20:55:14	mnaser	be back in my machine in a sec
20:56:21	jaypipes	but if the FOREIGN KEY .. REFERENCES statement/clause is executed at any time (either by SQLAlchemy's declarative_base or using sqlalchemy-migrate) then there is indeed an index created on action_id
20:56:56	jaypipes	lemme log into an ocata prod DB and check...
20:58:40	jaypipes	mriedem, mnaser: verified. there is indeed an index on (action_id)
20:59:12	mriedem	jaypipes: ok cool
20:59:15	mriedem	efried: https://review.openstack.org/#/q/project:openstack/nova+status:open+path:%255Enova/db/sqlalchemy/migrate_repo/versions/.* :)
21:02:51	openstackgerrit	Dustin Cowles proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899
21:03:35	efried	dustinc: That looks like a sane delta ^
21:03:45	efried	were you planning to push other patches on top of that at the same time?
21:03:58	dustinc	not yet, I have them local but was just pushing that one for now
21:04:06	mnaser	jaypipes: so the thing is I think it might be the deleted field
21:05:14	mnaser	the query looked a something like this: UPDATE instance_actions_events SET deleted=instance_action_events.id WHERE action_id IN (SELECT id FROM instance_actions WHERE instance_uuid IN (SELECT uuid FROM instances WHERE deleted!=0))
21:05:35	mnaser	so you grab a list of all non deleted instances, then you grab all their instance actions, then you grab all the action ids associated to them
21:05:37	mriedem	weeee https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L174
21:06:11	mriedem	mnaser: other way around - it's soft-deleting actions and events for deleted instances
21:06:16	mriedem	deleted!=0 == soft-deleted
21:06:28	mriedem	archive is the only thing that actually deletes actions/events
21:06:33	mnaser	right, yeah, so it soft deletes them because for some reason we don't soft delete them by default? yeah
21:06:45	mnaser	so if you haven't done that in a while, that can be.. a big dataset
21:06:52	mriedem	mnaser: corret https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L1832
21:06:54	mriedem	*correct
21:07:15	mnaser	oh neat
21:07:37	mriedem	could be real big if you have lots of pets
21:08:00	mnaser	or a cloud with a lot of VMs going up and down
21:08:23	mnaser	is there an index on deleted
21:10:27	mnaser	instances_host_deleted_cleaned_idx yes there is
21:23:06	mriedem	that's my fault
21:23:32	mriedem	https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cross-cell-resize
21:33:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: Delete require_instance_exists_using_uuid https://review.openstack.org/650994
21:33:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Soft delete virtual_interfaces when instance is destroyed https://review.openstack.org/650995
21:36:30	mriedem	very easy couple of changes ^
21:47:44	openstackgerrit	Matt Riedemann proposed openstack/nova master: Drop delete_build_requests_with_no_instance_uuid online migration https://review.openstack.org/651001
21:48:04	openstackgerrit	Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969
21:48:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: Drop delete_build_requests_with_no_instance_uuid online migration https://review.openstack.org/651001
21:59:36	mriedem	mordred: i added you to this nova spec https://review.openstack.org/#/c/603969/ about cleaning up old nasty cruft out of the compute API if you want to weigh in on your most hated UX stuff in the compute API
21:59:59	mriedem	my personal most hated is the OS-EXT-* prefixes
22:00:37	mriedem	i just want do do: server = GET /servers/id; host = server['host'] without looking up the API reference every time
22:10:26	openstackgerrit	melanie witt proposed openstack/nova master: Add post-release checklist items to the PTL guide https://review.openstack.org/651009
22:12:09	openstackgerrit	melanie witt proposed openstack/nova master: Add post-release checklist items to the PTL guide https://review.openstack.org/651009
22:12:21	dansmith	efried: what mriedem said
22:44:37	efried	lyarwood, jungleboyj, mdbooth: I moved "Swap volume API woes" to the (shiny new) cinder-nova xproj etherpad
22:44:40	efried	https://etherpad.openstack.org/p/ptg-train-xproj-nova-cinder
22:50:54	openstackgerrit	Eric Fried proposed openstack/nova-specs master: DNM: split me https://review.openstack.org/651020
23:11:47	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Tools & docs for backlog & abandoned spec process https://review.openstack.org/648800
23:14:29	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon flavor-classes backlog spec https://review.openstack.org/649095
23:14:38	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon same-instances-scheduling backlog spec https://review.openstack.org/649102
23:14:46	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon parallel-scheduler backlog spec https://review.openstack.org/649101
23:14:52	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon instance-tasks backlog spec https://review.openstack.org/649100
23:17:56	openstackgerrit	Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024
23:18:20	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon instance-tasks backlog spec https://review.openstack.org/649100
23:19:36	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon flavor-classes backlog spec https://review.openstack.org/649095
23:20:08	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon same-instances-scheduling backlog spec https://review.openstack.org/649102
23:20:33	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Abandon parallel-scheduler backlog spec https://review.openstack.org/649101
23:30:27	eandersson	Does anyone have a example of using the JsonFilter for the Scheduler? :D
23:40:18	eandersson	nvm found an example
23:40:47	openstackgerrit	Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024
23:47:55	openstackgerrit	Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024
23:51:35	openstackgerrit	Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024
#openstack-nova - 2019-04-09
01:31:25	jungleboyj	efried: Thanks. Is there time planned to discuss this at the ptg?
01:34:40	openstackgerrit	Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024
02:17:41	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Cleanup migrate flags https://review.openstack.org/651056
02:35:54	openstackgerrit	zhufl proposed openstack/nova master: Remove conductor_api and cells_rpcapi from manager.py https://review.openstack.org/651059
02:42:28	efried	jungleboyj: Nothing yet, swhat I was going to ask you about. We could do 11:15-lunch (with a break at 11:50 for team photo) if that works for you. Or after lunch, any time except 1400-1515.
02:44:40	jungleboyj	I don't have anything scheduled yet so I am flexible. Let's see what the team has, if anything, and talk later in the week.
02:45:10	jungleboyj	efried: on vacation this week so will have smcginnis follow up.
02:45:24	efried	sure thing, thanks jungleboyj
03:22:10	openstackgerrit	Merged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974
03:38:57	openstackgerrit	melanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement https://review.openstack.org/638073
03:38:57	openstackgerrit	melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324
03:53:11	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.openstack.org/649953
04:29:32	openstackgerrit	Merged openstack/nova master: Add placeholder migrations for Stein backports https://review.openstack.org/650964
04:44:59	openstackgerrit	Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969
04:46:08	openstackgerrit	Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969
05:10:51	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object https://review.openstack.org/649534
05:10:52	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877
05:10:52	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878
05:10:53	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535
05:28:14	eandersson	I still wish you could add your own filters and weights as plugins.
05:29:32	eandersson	Instead of having to roll your own version of nova and drop them in the appropriate folders.
05:36:44	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Use the functional test test_parallel_evacuate_with_server_group https://review.openstack.org/649963
05:53:32	openstackgerrit	Merged openstack/nova master: Remove query_client from resource_tracker https://review.openstack.org/650616
07:17:49	kashyap	efried: When you're about, I'd suggest to _not_ approve (although it was "approved" for Stein) this spec right away: https://review.openstack.org/#/c/642030/ (Re-propose the spec to allow specifying a list of CPU models)

Earlier   Later