Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-04-03
21:42:43 tonyb nova/etc/nova/nova.conf:983:#instance_build_timeout=0
21:42:43 mriedem heh i didn't know instance_build_timeout existed
21:42:48 tonyb so I guess that isn't it
21:42:49 mriedem it's a periodic
21:43:18 mriedem looks like a hack for just setting instance status to ERROR for things that were hung or we didn't properly set to ERROR state on failure
21:43:31 dansmith mriedem: okay, I guess that seems obvious to me so I'm not sure why you're bringing it up as if it's a problem or something
21:43:49 mriedem dansmith: we just haven't hard hard destroy on stuff in the cell db records, except tags i guess
21:43:54 mriedem so it seems new and scary
21:43:58 melwitt tonyb: oh yeah, hm
21:44:01 dansmith mmkay
21:44:34 mriedem luckily theodoros already has a patch to add that support for his rebuild from cell0 series https://review.openstack.org/#/c/570202/
21:44:42 mriedem which it turned out he later didn't need, but i will
21:47:14 mriedem anyway, i'll update the re-proposed spec to note it
22:06:41 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: document ordering for instance actions and events https://review.openstack.org/649748
22:09:18 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: fix description of os-server-external-events 'events' param https://review.openstack.org/649750
22:32:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove MIN_COMPUTE_MULTIATTACH conditions in API https://review.openstack.org/649757
22:51:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova-status upgrade check for minimum required cinder API version https://review.openstack.org/649759
23:01:14 efried mriedem: where does grenade source live?
23:03:32 mriedem http://git.openstack.org/cgit/openstack-dev/grenade/
#openstack-nova - 2019-04-04
00:32:54 openstackgerrit Merged openstack/nova master: Don't warn on network-vif-unplugged event during live migration https://review.openstack.org/642877
00:37:24 mriedem this uh, seems not so necessary https://github.com/openstack/nova/commit/70c7ba7324cf47179d978b4073545e3837d4fd24#diff-12951ec32bc2b8cae6ea1933599a3dbcR334
00:41:32 mriedem and potentially a security issue
00:43:22 mriedem efried: melwitt: ^ is new in stein so if it's something we shouldn't be exposing in the notifications we should probably think about that for rc2
00:47:12 sean-k-mooney wait we send the db connection field in the cellmapping notifcation?
00:47:29 mriedem apparently
00:47:31 mriedem and transport_url
00:47:32 sean-k-mooney is that now the templated url?
00:47:33 openstackgerrit Merged openstack/nova master: Drop migrate_keypairs_to_api_db data migration https://review.openstack.org/649648
00:47:40 openstackgerrit Merged openstack/nova master: Add functional test for the JsonFilter https://review.openstack.org/647811
00:47:48 openstackgerrit Merged openstack/nova master: api-ref: document ordering for instance actions and events https://review.openstack.org/649748
00:47:57 openstackgerrit Merged openstack/nova master: api-ref: fix description of os-server-external-events 'events' param https://review.openstack.org/649750
00:48:08 openstackgerrit Merged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113
00:48:40 sean-k-mooney hehe a lot of nova patches were in the last job run
00:49:16 sean-k-mooney anyway if its the tempalted url its may not be an issue but ya if its the actully connetion sting that is bad
00:50:38 mriedem it does not need to be templated
00:50:58 mriedem https://docs.openstack.org/nova/latest/user/cells.html#template-urls-in-cell-mappings
00:51:52 mriedem even if it was templated, it would be the full url when pulled out of the CellMapping object attribute
00:52:06 sean-k-mooney :(
00:52:30 sean-k-mooney the patch mentioned it was transfroming the notificaiton to the versioned form
00:52:46 sean-k-mooney was this previouly sent via the unversioned endpoint
00:53:05 mriedem i doubt it
00:53:35 sean-k-mooney ok so it is a regression in stien and i agree it a security concern too.
00:53:59 sean-k-mooney how did you come across it
00:54:00 mriedem the unversioned notification sent RequestSpec.to_legacy_request_spec_dict()
00:54:18 mriedem tssurya -1ed a change of mine saying i should add more stuff to that notification since i added a new field to the Destination object
00:55:06 mriedem https://review.openstack.org/#/c/614035/
00:55:08 sean-k-mooney mriedem: ah ok i similarly modifed a field in one of my patches and it ended up changin the image metadata notificaion
00:55:23 sean-k-mooney which i undersand in a way but i also was confused by
00:55:43 sean-k-mooney it seams that we not have to version some object when field in an objec support new values
00:56:00 sean-k-mooney previousl we did not version bump object for compostion
00:56:10 sean-k-mooney only when fields were added or removed
00:56:38 mriedem gibi_off: stephenfin: https://review.openstack.org/#/c/508506/28/nova/notifications/objects/request_spec.py@334 - if we don't need those i don't tihnk we should be sending them out of nova on the notification bus
01:02:16 sean-k-mooney mriedem: do we want to even include the cell here https://review.openstack.org/#/c/508506/28/nova/notifications/objects/request_spec.py@284
01:02:55 mriedem idk, the legacy notification for select_destinations didn't send all of this stuff
01:02:58 mriedem so i don't know why it was all added
01:03:13 mriedem the legacy notification sent a legacy more minimal view of the request spec
01:03:23 mriedem this version is everything
01:03:57 mriedem sending the name/uuid of the cell is meh to me
01:04:18 mriedem sending the URLs with credentials to connect to the cell...that's a bad idea
01:04:20 sean-k-mooney ya i was just looking at what the to_legacy_request_spec_dict function did
01:04:59 sean-k-mooney i would proably change 'cell': fields.ObjectField('CellMappingPayload', nullable=True),
01:05:01 mriedem well i threw this on the RC2 etherpad so i guess can wait for others to look and provide an opinion
01:05:14 sean-k-mooney to 'cell': fields.UUIDFiled(nullable=True),
01:05:45 sean-k-mooney and then drop the CellMappingPayload object entirely
01:06:32 sean-k-mooney i think we require the host to be unique across all cells anyway though so the cell is uudi is not really needed
01:09:24 mriedem i'm dropping off
01:09:32 sean-k-mooney o/
01:45:18 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Pass node uuid to new Destination.node_uuid https://review.openstack.org/649533
01:45:18 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object https://review.openstack.org/649534
01:45:19 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: node_uuid from RequestSpec to ResourceRequest https://review.openstack.org/649535
02:20:19 ileixe Hi forks.
02:20:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Obfuscate CellMappingPayload database_connection and transport_url https://review.openstack.org/649775
02:20:27 ileixe Is this bp https://review.openstack.org/#/c/599598/ abonded at all?
02:20:36 ileixe abandoned*
02:21:04 ileixe We need this functionality a lot, so I wonder about it.
02:22:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Obfuscate CellMappingPayload database_connection and transport_url https://review.openstack.org/649775
02:24:13 mriedem melwitt: added you and others https://review.openstack.org/#/c/649775/
02:24:18 mriedem wip until people chew on the alternatives
02:27:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove MIN_COMPUTE_MULTIATTACH conditions in API https://review.openstack.org/649757
02:27:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova-status upgrade check for minimum required cinder API version https://review.openstack.org/649759
02:27:40 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Drop pre-cinder 3.44 version compatibility https://review.openstack.org/621061
02:31:51 openstackgerrit zhufl proposed openstack/nova master: Remove reading xvpconf_template in xvp.py https://review.openstack.org/649777
02:36:29 openstackgerrit Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.openstack.org/612626
02:37:23 openstackgerrit Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969
02:44:02 openstackgerrit Takashi NATSUME proposed openstack/nova master: Change a log level for overwriting allocation https://review.openstack.org/649788
03:26:43 openstackgerrit Alex Xu proposed openstack/nova master: [DNM] debug the LM test https://review.openstack.org/649807
04:31:37 openstackgerrit Jake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows https://review.openstack.org/556751
06:07:33 openstackgerrit Huqiang Wang proposed openstack/nova-specs master: Separate the vCPUs into different pools based on priority https://review.openstack.org/649882
07:31:10 openstackgerrit Huqiang Wang proposed openstack/nova-specs master: Separate the vCPUs into different pools based on priority https://review.openstack.org/649882
08:30:12 openstackgerrit zhaixiaojun proposed openstack/nova master: Update description of valid whitelist https://review.openstack.org/642403
08:33:02 openstackgerrit zhaixiaojun proposed openstack/nova master: Update description of valid whitelist https://review.openstack.org/642403
08:34:38 kashyap Is there some 'tox' shortcut to build _just_ one releases's specs?
08:34:47 kashyap `tox -e docs train` or something like that
08:44:52 openstackgerrit Michael Still proposed openstack/nova master: Hacking N362: Don't abbrev/alias privsep import https://review.openstack.org/649190
08:44:53 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601
08:44:53 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602
08:44:54 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603
08:44:54 openstackgerrit Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.libvirt. https://review.openstack.org/648616
08:44:55 openstackgerrit Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.qemu. https://review.openstack.org/649191
08:44:55 openstackgerrit Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431

Earlier   Later