Posted	Nick	Remark
#openstack-nova - 2019-04-01
20:25:49	melwitt	yeah, shouldn't need path= right
20:25:58	melwitt	default value of what?
20:27:45	mnaser	The nova configuration value
20:27:51	mnaser	The one pointing at vnc_lite or whatever
20:28:19	mnaser	To not longer suggest ?token=foo is the way but ?path=?token=foo
20:28:39	melwitt	I thought earlier you told me including path= wasn't as clean :P
20:28:51	mnaser	Yeah it’s just BLAH
20:28:57	mnaser	why people gotta rip code out
20:29:14	melwitt	I guess, I thought the token plugin would let us use the old default url
20:29:19	mnaser	Same.
20:29:34	mnaser	But once it was done I realized the web socket thing was only checking it at the web socket stage
20:29:37	melwitt	because if we include path in the default, we could fix this without the token plugin, I think, as I mentioned earlier
20:29:55	mnaser	Yeah then we won’t be falling back to cookies every time
20:30:02	melwitt	right
20:31:38	mnaser	I guess we can propose a revert and then I’ll just pin on the old commit :/
20:31:50	mriedem	efried: you're talking about get_or_set_cached_cell_and_set_connections right?
20:32:13	efried	mriedem: yeah
20:32:23	efried	I didn't go back and look whether that's "normal".
20:32:25	mriedem	i think that's nova.compute.api.API being constructed per controller per worker
20:32:30	efried	k
20:32:35	mriedem	which is a lot since it's not a singleton
20:33:02	efried	Last week I noticed pretty frequent failures sprayed across the long-running jobs. Never more than one per patch, and never the same one twice in a row.
20:33:08	efried	but I didn't dig into any of them.
20:33:10	mriedem	i assume the get_or_set_cached_cell_and_set_connections target_cell is due to a query on the services table when constructing the compute RPCAPI with [upgrade_levels]/compute=auto
20:33:39	mriedem	https://bugs.launchpad.net/nova/+bug/1815697
20:33:40	openstack	Launchpad bug 1815697 in OpenStack Compute (nova) "[upgrade_levels]compute=auto grinds the API response times when a cell is down" [Medium,Confirmed]
20:33:40	mnaser	I honestly don’t have that much time to dig more into this. I can report a bug and add a known issue (if needed) but I don’t have time to deal with getting this merged into novnc :/
20:33:58	mriedem	efried: also https://bugs.launchpad.net/nova/+bug/1815692
20:34:00	openstack	Launchpad bug 1815692 in OpenStack Compute (nova) "minimum nova-compute service version is not cached in nova-api when running under wsgi" [Low,Triaged]
20:34:58	melwitt	mnaser: or we could change our default nova conf value? or do you think asking for a revert is a better route?
20:35:25	mnaser	melwitt: I think the amount of downstream stuff that will break (because everyone configures this in their compute nodes) is gonna be .. a lot
20:35:37	mnaser	cause now tripleo/osa/etc all have to change our paths
20:35:47	mnaser	to something sketchy none the less :P
20:35:58	melwitt	mnaser: yeah, I see. ok
20:36:06	mnaser	I wouldn't revert it all
20:36:11	mnaser	maybe just the small part to set the cookie
20:36:12	melwitt	yeah
20:41:34	mriedem	efried: i guess bug 1815692 won't help because we don't cache the minimum compute service version until we get one, meaning until a nova-compute starts up, which in devstack is after the api
20:41:36	openstack	bug 1815692 in OpenStack Compute (nova) "minimum nova-compute service version is not cached in nova-api when running under wsgi" [Low,Triaged] https://launchpad.net/bugs/1815692
20:42:12	efried	is making the thing a singleton an option?
20:42:12	mriedem	making nova.compute.api.API or nova.compute.rpcapi.ComputeAPI a singleton might help
20:42:27	efried	Is there any evidence that that's actually a problem though?
20:42:31	mnaser	melwitt: https://bugs.launchpad.net/nova/+bug/1822676
20:42:32	openstack	Launchpad bug 1822676 in OpenStack Compute (nova) "novnc no longer sets token inside cookie" [Undecided,New]
20:42:38	melwitt	mnaser: you know, while I was looking at the websockify source, I was thinking maybe in code we could append to our self.path earlier in the call path. I can try something out
20:42:42	efried	the devstack log just says n-api doesn't start.
20:42:51	efried	I guess that means "within a certain amount of time"
20:42:53	melwitt	mnaser: thanks for the bug report
20:42:55	mriedem	efried: it's a timeout
20:42:58	mnaser	melwitt: all yours :) I don't think I can take more time on this :X
20:43:04	mnaser	I will "work-around" it in osa
20:43:12	melwitt	mnaser: yeah, I'll try this out and let you know
20:43:36	mriedem	efried: the non-singleton nature with locks can definitely cause slowness ala https://review.openstack.org/#/c/623246/
20:43:56	melwitt	mnaser: if what I'm thinking doesn't end up working, I can ask the novnc folks if they can revert the nova part
21:00:49	openstackgerrit	Eric Fried proposed openstack/nova master: Hacking N362: Don't abbrev/alias privsep import https://review.openstack.org/649188
21:02:59	efried	this f'in thing is never going to merge. Now it's failed py37
21:15:11	mriedem	dansmith: you know how on nova-api startup we check for the minimum nova-compute service version in order to set the rpc pin if [upgrade_levels]/compute=auto https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L408 ?
21:16:09	mriedem	the comment above that says we don't cache it because "we will get a better answer next time." - but next time would have to be on restart of the service right? because we only call _determine_version_cap once in order to construct the ClientRouter
21:18:11	openstackgerrit	Michael Still proposed openstack/nova master: Style corrections for privsep usage. https://review.openstack.org/648615
21:18:12	openstackgerrit	Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601
21:18:12	openstackgerrit	Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602
21:18:13	openstackgerrit	Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603
21:18:13	openstackgerrit	Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.libvirt. https://review.openstack.org/648616
21:18:14	openstackgerrit	Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
21:18:14	openstackgerrit	Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433
21:18:15	openstackgerrit	Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
21:18:15	openstackgerrit	Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
21:18:16	openstackgerrit	Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508
21:18:16	openstackgerrit	Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280
21:18:17	openstackgerrit	Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281
21:18:18	openstackgerrit	Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282
21:18:18	openstackgerrit	Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283
21:18:18	openstackgerrit	Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580
21:18:19	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581
21:18:19	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
21:18:20	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826
21:47:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Make nova.compute.rpcapi.ComputeAPI.router a singleton https://review.openstack.org/649197
22:17:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179
22:17:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382
22:17:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521
22:17:09	openstack	bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem)
22:17:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792
22:17:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806
22:17:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
22:17:10	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
22:17:10	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
22:17:11	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
22:17:11	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
22:17:12	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
22:17:12	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
22:17:13	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
22:17:13	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890
22:17:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832
22:17:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605
22:17:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891
22:17:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.openstack.org/642183
22:17:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048
22:17:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268
22:17:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
22:17:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269

Earlier   Later