| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-28 | |||
| 09:54:12 | sean-k-mooney | but anyway if other nova cores are interested in nova/neutron stuff early feedback on "is this somethign we want to fix" would be good as i dont want to speed lots of time on the nova spec if its a total non starter | |
| 10:06:45 | sean-k-mooney | gibi: so looking at you https://blueprints.launchpad.net/nova/+spec/enhance-support-for-ports-having-resource-request i have some long standing wish list items for network aware schduling that might be able to tie into that | |
| 10:07:31 | sean-k-mooney | if we look back at https://etherpad.openstack.org/p/placement-nova-neutron-queens-ptg i listed some of them when i was making the case for completeing nested resouce providers | |
| 10:08:12 | gibi | sean-k-mooney: let's list your needs part of the item in https://etherpad.openstack.org/p/nova-ptg-train | |
| 10:08:57 | gibi | physnet aware placement looks interesting | |
| 10:09:24 | gibi | vswitch vif capacity also seems doable now | |
| 10:09:30 | sean-k-mooney | well see that is the thing there are not execatly needs but they are more techdebt removal that happens to also imporve sechduling | |
| 10:10:38 | sean-k-mooney | gibi: ya i think you have put most of the infrastuture in place already as part of your bandwith work to adress some of those wishlist items | |
| 10:11:03 | sean-k-mooney | numa affinity of vswitches we have done in a none placement way already too | |
| 10:11:45 | gibi | I think it worth to talk about these on the PTG. I can definitely give review support for some of this items while I work on the move operation bp | |
| 10:12:17 | gibi | sean-k-mooney: do we want to re-do numa aware vswitches based on placement? | |
| 10:12:56 | sean-k-mooney | maybe at somepoint but i have been wonderign if we should punt numa in placement to U | |
| 10:13:15 | sean-k-mooney | to try and get other lower hanging furit feature workign first | |
| 10:13:45 | sean-k-mooney | long term i still hope we can model numa in placement but it makes everything more complicated | |
| 10:15:22 | sean-k-mooney | for better or worse the numa topology filter and numa resouce tracker work well enough that i think the benifit of track pci devices or cpus in placement without numa outways the beniftis of numa in placment | |
| 10:16:40 | gibi | sean-k-mooney: I think, either we need to put big focus on the numa-in-placement feature or focus on the small improvements that already possible, but both cannot be done in the same cycle | |
| 10:17:04 | gibi | sean-k-mooney: I can get behind both effort as at the end of the they I would like to see both done | |
| 10:17:15 | gibi | just dont want to overcommit | |
| 10:17:24 | sean-k-mooney | gibi: ya that was the same conclution that i came to when talking to some of the redhat folks internally | |
| 10:17:46 | sean-k-mooney | but we also didnt know what the comunity wanted | |
| 10:18:38 | sean-k-mooney | i think this is already listed as a ptg topic but i hope we will as you said decied to either do numa or a set of other small things but not both | |
| 10:18:55 | sean-k-mooney | in this cycle | |
| 10:19:47 | sean-k-mooney | gibi: related to your move operation work i wanted to also highlight this patch form bauzas https://review.openstack.org/#/c/589085/ | |
| 10:20:40 | sean-k-mooney | gibi: one of the issue the move operation will have is the fact that resize/migrate does not have acess to allocation candiaties. bauzas started to fix it and stopped for his vGPU work | |
| 10:21:18 | sean-k-mooney | im hoping if we fix this generically we can acclearate move operation for both vGPU and bandwith based schduleing | |
| 10:22:11 | sean-k-mooney | i know there are other gaps but i think there will be a lot fo synergey between those features | |
| 10:22:22 | gibi | sean-k-mooney: thanks for the link. I need to sit down and plan the support for move operations. There I will use what bauzas discovered already | |
| 10:22:49 | bauzas | gibi: sean-k-mooney: yeah, I was planning to update the change later | |
| 10:42:20 | gibi | easy +A (efried already +2d) https://review.openstack.org/#/c/638847/ | |
| 11:05:40 | bauzas | gibi: done | |
| 11:23:52 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | |
| 11:24:58 | openstackgerrit | zhaixiaojun proposed openstack/nova master: Remove flavor id and name validation code because of jsonschema validation.The jsonschema validation was added with Ieba96718264ad2ddfba63b65425f7e5bbb8606a9. https://review.openstack.org/638150 | |
| 11:25:08 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: WIP: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | |
| 11:27:45 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IP proxy methods https://review.openstack.org/643115 | |
| 11:50:38 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: WIP: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | |
| 12:02:46 | gibi | bauzas: thanks | |
| 12:40:50 | mdbooth | stephenfin: Left a comment on https://review.openstack.org/#/c/647831/ | |
| 12:41:23 | mdbooth | stephenfin: That second line is belt and braces, which normally I'd be in favour of. | |
| 12:47:43 | mdbooth | cdent: lol | |
| 12:57:17 | dansmith | tssurya: right, but what does that matter? vs. literally every client having to change if you change the type... | |
| 13:07:25 | openstackgerrit | Merged openstack/nova master: doc: Fix openstack CLI command https://review.openstack.org/648299 | |
| 13:07:33 | openstackgerrit | Merged openstack/nova master: s,git://github.com/,https://git.openstack.org/, https://review.openstack.org/647472 | |
| 13:07:42 | openstackgerrit | Merged openstack/nova master: Speed up test_report https://review.openstack.org/643760 | |
| 13:35:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | |
| 13:35:39 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | |
| 13:37:00 | tssurya | dansmith: fine with me then :) there was also an opinion earlier on that the boolean "locked" then becomes redundant as its just determined based on locked_by being NULL or not | |
| 13:37:31 | tssurya | but I personally don't have a strong opinion on the way its revealed | |
| 13:48:22 | openstackgerrit | Merged openstack/nova master: Add retry_on_deadlock to migration_update DB API https://review.openstack.org/633075 | |
| 13:48:42 | openstackgerrit | Merged openstack/nova master: Change the TODO to NOTE about instance multi-create https://review.openstack.org/638847 | |
| 13:55:09 | openstackgerrit | Abhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance https://review.openstack.org/641210 | |
| 13:58:19 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional recreate test for bug 1819963 https://review.openstack.org/648401 | |
| 13:58:20 | openstack | bug 1819963 in OpenStack Compute (nova) rocky "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,Confirmed] https://launchpad.net/bugs/1819963 | |
| 13:58:20 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Update instance.availability_zone on revertResize https://review.openstack.org/648402 | |
| 14:01:15 | gibi | efried: how do you feel about the nova team meetings in the EU timezone? If you need help running it then let me know and I can do it. | |
| 14:02:05 | efried | gibi: I assumed I would be running all of them at this point, but I wouldn't say no if you're itching to help :) | |
| 14:02:42 | gibi | efried: it was an old reflex last week as we split this work with melwitt. But I see that you are in a better TZ to run both | |
| 14:05:01 | efried | gibi: Yes, 8 or 9am for me depending on DST. | |
| 14:05:27 | gibi | efried: I go forward with the assumption that you will run the EU meetings but you can always ask for help | |
| 14:05:37 | efried | sounds good, thanks. | |
| 14:05:45 | gibi | efried: a similar question regrading nova onboarding in Denver. Do you need help? | |
| 14:05:53 | efried | gibi: absolutely! | |
| 14:06:12 | efried | Here's where I will eagerly take all the help I can get. | |
| 14:06:34 | efried | I'm never sure what form onboarding should take | |
| 14:06:56 | efried | the audience always seems so diverse in terms of background/experience | |
| 14:07:21 | efried | I was toying with the idea of doing it as a live demo of developing a bug fix. | |
| 14:07:52 | efried | So like, look at the bug, write and upload a test case patch, write and upload the fix patch | |
| 14:08:05 | efried | which of course is your wheelhouse completely. | |
| 14:08:32 | gibi | efried: we migth be able to do that, but it needs to be a canned bug / bugfix to make sure we can really fix it | |
| 14:09:00 | gibi | in the given time | |
| 14:09:11 | efried | gibi: Yeah, I thought maybe prepare by uploading a patch that reverts a known bug fix (and its test case) and then basically redo the work on top of it. | |
| 14:09:27 | efried | So it would be a three-patch series, but we only talk about two of the patches. | |
| 14:09:34 | efried | and abandon all three at the end. | |
| 14:09:45 | gibi | efried: good idea | |
| 14:10:35 | efried | need to pick a bug that's pretty nova-y; otherwise it really just turns into a demo of "best practices for fixing a bug in the gerrit workflow" | |
| 14:10:58 | efried | focus attention on the flow of the test case and the nature of the fix. | |
| 14:11:07 | gibi | pci? bdm? live migration? :) | |
| 14:11:33 | gibi | the heavy nova stuff | |
| 14:11:56 | efried | something with a test case that's not like hundreds of lines long. | |
| 14:14:05 | gibi | efried: this might be too heavy on test side https://review.openstack.org/#/c/624444/5/nova/tests/functional/libvirt/test_pci_sriov_servers.py | |
| 14:15:20 | gibi | efried: maybe this https://review.openstack.org/#/c/640302/ | |
| 14:15:53 | gibi | small fix, on the API with API sample test | |
| 14:16:13 | efried | gibi: Well, in that pci/sriov one the delta is bigger than I would like, but if we used it for the demo, it would be just L243-88 | |
| 14:17:13 | efried | that second one doesn't really have a clear [test case] and [fix] | |
| 14:17:27 | gibi | efried: it is api sample so it is well automataed | |
| 14:18:04 | gibi | but I hear you | |
| 14:18:57 | cdent | do we still have people who actively understand and like the api sample tests? | |
| 14:19:18 | efried | I'm looking for commits whose title includes the word 'recreate' | |
| 14:19:21 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: WIP: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | |
| 14:20:47 | gibi | cdent: at least I would not be affraid to dig into it if needed | |
| 14:20:52 | gibi | efried: what about https://review.openstack.org/#/c/632904/3/nova/tests/functional/test_servers.py | |
| 14:21:06 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional recreate test for bug 1819963 https://review.openstack.org/648409 | |
| 14:21:07 | openstack | bug 1819963 in OpenStack Compute (nova) rocky "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,Confirmed] https://launchpad.net/bugs/1819963 | |
| 14:21:07 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Update instance.availability_zone on revertResize https://review.openstack.org/648410 | |
| 14:21:32 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | |
| 14:21:36 | efried | gibi: heh, what about --^ | |
| 14:22:17 | gibi | efried: could be. I feel https://review.openstack.org/#/c/632904/3/nova/tests/functional/test_servers.py is more self contained | |
| 14:23:06 | efried | gibi: I was being lazy and looking for one where the recreate was separate from the fix, but it would be easy enough to split out. | |
| 14:23:34 | efried | again with https://review.openstack.org/#/c/648409/1/nova/tests/functional/test_availability_zones.py we wouldn't have to include the refactor part in the demo, just L145-73 | |
| 14:24:39 | gibi | efried: OK. you convinced me | |
| 14:24:48 | kaisers | efried: FYI, added the requested tests/nit-corrections to https://review.openstack.org/648093 , pls check if that fits your view | |