| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-27 | |||
| 07:23:17 | openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | |
| 07:26:52 | openstackgerrit | Boxiang Zhu proposed openstack/python-novaclient master: [WIP] Add force_scheduler in boot instance https://review.openstack.org/647671 | |
| 09:00:42 | openstackgerrit | Boxiang Zhu proposed openstack/python-novaclient master: [WIP] Add force_scheduler in boot instance https://review.openstack.org/647671 | |
| 09:01:30 | openstackgerrit | Abhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance https://review.openstack.org/641210 | |
| 09:40:54 | davidepanarese_ | Hello everyone | |
| 09:44:12 | davidepanarese_ | anyone knows if automatic rescan of cinder external volume using ceph in nova will be implemented? Or better, is already exists a method to rescan virtio drives (ceph volumes) into kvm virtual machine after a live volume resize? | |
| 09:48:13 | openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | |
| 09:49:57 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug #1819460 in functional test https://review.openstack.org/642444 | |
| 09:49:58 | openstack | bug 1819460 in OpenStack Compute (nova) "instance stuck in BUILD state due to unhandled exceptions in conductor" [Low,In progress] https://launchpad.net/bugs/1819460 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 09:49:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | |
| 09:57:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug #1819460 in functional test https://review.openstack.org/642444 | |
| 09:57:33 | openstack | bug 1819460 in OpenStack Compute (nova) "instance stuck in BUILD state due to unhandled exceptions in conductor" [Low,In progress] https://launchpad.net/bugs/1819460 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 09:57:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | |
| 10:03:52 | openstackgerrit | Merged openstack/nova master: Add functional recreate test for bug 1819963 https://review.openstack.org/643151 | |
| 10:03:53 | openstack | bug 1819963 in OpenStack Compute (nova) "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,In progress] https://launchpad.net/bugs/1819963 - Assigned to Matt Riedemann (mriedem) | |
| 10:05:37 | openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | |
| 10:43:12 | frickler | davidepanarese_: there is this recent patch that iiuc should handle your use case https://review.openstack.org/613039 | |
| 11:18:22 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | |
| 11:32:35 | kaisers | mdbooth_: thanks for looking into https://review.openstack.org/#/c/554195/28 . Could you update your -1 if you're fine with the follow up as proposed? | |
| 12:04:15 | openstackgerrit | zhaixiaojun proposed openstack/nova master: Remove flavor id and name validation code because of jsonschema validation. https://review.openstack.org/638150 | |
| 12:30:44 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: [Stable Only] hardware: Handle races during pinning https://review.openstack.org/647831 | |
| 12:45:18 | mdbooth | kaisers: Sure. As I said though, the only thing I was -1 about was the comment. If you stick that in the follow-on I'll happily update, esp as you can keep the +2 from stephenfin. | |
| 12:50:26 | kaisers | mdbooth: ok, will do :) | |
| 13:30:59 | openstackgerrit | François Palin proposed openstack/nova master: WIP - nova diagnostics command is not working with all interfaces https://review.openstack.org/648123 | |
| 13:36:57 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | |
| 13:38:05 | kaisers | mdbooth: done----^ | |
| 13:43:08 | mdbooth | kaisers: Meh, my preference is for long form, but it works | |
| 13:44:28 | mdbooth | kaisers: Updated, thanks! | |
| 13:52:51 | kaisers | mdbooth: thanks for looking into this | |
| 14:27:25 | openstackgerrit | sean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering https://review.openstack.org/647578 | |
| 14:54:44 | bauzas | cores, https://review.openstack.org/#/c/647519/ is a RC potential https://etherpad.openstack.org/p/nova-stein-rc-potential | |
| 14:56:33 | openstackgerrit | Dan Smith proposed openstack/os-traits master: Add IMAGE_TYPE_SUPPORT_* traits https://review.openstack.org/648147 | |
| 15:01:56 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Refactor CONTRIBUTING.rst https://review.openstack.org/640970 | |
| 15:03:47 | efried | bauzas, dansmith: Should we be cutting an RC2 just for a doc? | |
| 15:04:02 | bauzas | efried: well, maybe not | |
| 15:04:04 | efried | I don't think there's anything else we would be including | |
| 15:04:06 | dansmith | no | |
| 15:04:15 | efried | sean-k-mooney's lower-constraints fix is on the list | |
| 15:04:16 | bauzas | we should be just merging it now for master | |
| 15:04:22 | bauzas | then I'd backport it to stein | |
| 15:04:26 | efried | ++ | |
| 15:04:32 | dansmith | after ga | |
| 15:04:37 | bauzas | but it could be not needing a RC2 | |
| 15:04:40 | efried | ...but the lower-constraints thing has been busted for a while. | |
| 15:04:47 | bauzas | so +W the stein backport after GA | |
| 15:04:57 | bauzas | unless we find other bugs | |
| 15:05:06 | bauzas | and then we could merge it with the other fixes | |
| 15:05:16 | bauzas | but yeah, not needing a RC2 just for it | |
| 15:15:28 | trident | cdent: Are you around to answer a couple of questions about the implementation of forbidden traits? | |
| 15:16:23 | cdent | trident: I am around, either here or in #openstack-placement. Not promising I'll be able to help | |
| 15:17:20 | efried | trident: Is this about https://review.openstack.org/647957 ? | |
| 15:19:01 | trident | cdent: I am working on an issue that prevents forbidden traits in flavors from being acted upon: https://review.openstack.org/#/c/647957/ While working on some tests I found that traits of the trait:CUSTOM_FOO=forbidden in image properties doesn't seem to work either. Is that expected or should they work both for flavors and images? | |
| 15:19:10 | trident | efried: Yup. | |
| 15:19:17 | efried | gibi: if you're around, you may want to join in ^ | |
| 15:20:24 | cdent | trident: is the issue that the wrong request is built and sent to placement, or that placement is behaving incorrectly with a valid request? | |
| 15:20:32 | efried | Mm, I don't remember whether we have implemented support for traits (positive or negative) coming from image props yet. | |
| 15:20:33 | gibi | efried: did we ever said that forbidden trait support is a thing in nova? in placement I know that it is a thing | |
| 15:20:38 | sean-k-mooney | efried: bauzas well my lower constraitn fix is not complete | |
| 15:21:02 | gibi | efried: similarly placement had support for nested a_c for a while but nova need a lot of adaptation to use it | |
| 15:21:05 | trident | efried: The wrong request is sent to placement. | |
| 15:21:24 | efried | sean-k-mooney: I suspect that would be a clusterf*** to backport in any case, so we may want to consider just fixing it in master and moving on. | |
| 15:21:41 | trident | This is the commit implementing it: https://github.com/openstack/nova/commit/2c51688558504f2e8ce80bac06642772be67b2a9 | |
| 15:22:29 | efried | trident: Yup, that looks like it's pulling from flavor extra_specs; do you have any evidence that we did same for image props? | |
| 15:22:40 | trident | Sorry, cdent: The wrong request is sent to placement. | |
| 15:22:51 | sean-k-mooney | efried: ya. the main thing i need to figure out is where the mocking of rabbitmq is borked so that we use the fake message bus when running the unit tests in all cases | |
| 15:23:45 | efried | sean-k-mooney: I'll ask you about it in tomorrow's meeting, but I'm expecting we won't want to try to put it in stein RC2 even if you do get it all fixed up by then. | |
| 15:24:02 | cdent | trident: that patch is only doing it for flavor extra specs | |
| 15:24:17 | gibi | trident: the linked bp https://blueprints.launchpad.net/nova/+spec/forbidden-traits-in-nova explicitly talks about flavor extra_spec so I think there was no intention to support it from image metadata | |
| 15:24:32 | sean-k-mooney | efried: ya that is fair. we can consider backporting it when i have the final fix. | |
| 15:24:50 | efried | trident: It is something we've discussed doing, for sure, but I don't think we've implemented it yet. | |
| 15:24:54 | sean-k-mooney | efried: actully one thing i might try is fixing it on the stabel branches and see if they pass | |
| 15:24:56 | trident | efried, cdent: I am a little bit of a newbie when it comes to the code base, that's why I am asking. But my understanding from following the code path is that the logic for getting forbidden traits from image props is not there. Just wanted to verify that before putting more time into it. | |
| 15:25:08 | cdent | yes, it's not there | |
| 15:25:31 | efried | We do support positive traits from image props, nah? | |
| 15:25:42 | sean-k-mooney | efried: we do | |
| 15:25:46 | trident | efried: Yes. | |
| 15:25:53 | efried | wherezat code? | |
| 15:26:13 | cdent | it's a thing that ought to exist, I think it just didn't happen yet. Perhaps because we couldn't decide precedence? I can't remember | |
| 15:26:22 | sean-k-mooney | in the schduler uitls i think one sec | |
| 15:26:32 | trident | efried: https://github.com/openstack/nova/blob/771e102654b54d257f437f16be2aeeef51fa0783/nova/scheduler/utils.py#L186 | |
| 15:27:25 | sean-k-mooney | yep ^ which is called by resources_from_request_spec | |
| 15:28:36 | sean-k-mooney | and i think but i woudl have to confim when we build the request spec we grab the image properties form a voluem in the bfv case so it should also work in that case too | |
| 15:29:52 | sean-k-mooney | there may however be the same issue. the traits are part of the unnumbered request group which is matched agaist the compute node RP but if we did nto requerst any resouces form it that would not work correctly | |
| 15:30:32 | efried | sean-k-mooney: Yup, same issue we've been thrashing in mriedem's multiattach capability patch. | |
| 15:30:58 | gibi | sean-k-mooney: we don't have to solve the empty unnumbered group issue yet. That will happen when NUMA is modelled in placement. And it requires a lot of other changes | |
| 15:31:04 | efried | I think we decided that *right now* we always request resources in the unnumbered group for the root RP. | |
| 15:31:10 | efried | so <sweep under rug> | |
| 15:31:15 | efried | <fingers in ears> | |
| 15:31:16 | sean-k-mooney | gibi: ya that true | |
| 15:31:19 | efried | <problem for future us> | |
| 15:31:24 | trident | So supporting forbidden traits in image props as well seems like a clear case of something that would make sense to implement. But out of scope of what I am working on with this bug. (had it just been a similar bug as with forbidden traits in flavors I might as well just have fixed it while I was at it). | |
| 15:31:51 | sean-k-mooney | efried: easy fix. all compute node have a inventory of instnace which match the max instance per host value that in the nova.conf | |
| 15:32:12 | sean-k-mooney | and all vms in the futre requerst one allocation of an instance resouce class | |
| 15:32:15 | efried | trident: Right. I agree it's something that makes sense to implement, though we would probably want a clear use case / demand before prioritizing the work. | |
| 15:32:31 | sean-k-mooney | efried: we could allso kill one of the filter if we did that | |
| 15:33:06 | sean-k-mooney | specifically we could kill this filter https://github.com/openstack/nova/blob/master/nova/scheduler/filters/num_instances_filter.py | |
| 15:33:09 | efried | sean-k-mooney: that would require us to tack on that "resource" to every request | |
| 15:33:19 | sean-k-mooney | efried: yes | |
| 15:33:22 | efried | because we can't expect it to be in flavors. | |
| 15:33:32 | sean-k-mooney | but i think that would be fine | |