Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-26
15:09:26 mriedem you don't get an error message on the client side?
15:09:29 brandor5 ansible returns: msg: 'BadRequestException: 400'
15:09:47 brandor5 if I remove the filter from the call it works fine
15:09:48 mriedem there is nothing else in the logs for req-f5f66dc0-8035-4c07-a631-a438fb79ba42 ?
15:10:07 mriedem so you're hitting something with this https://github.com/openstack/nova/blob/358776a303b0c5dba3c279f242c82b7a12ff5ce8/nova/api/openstack/compute/schemas/servers.py#L125
15:10:24 mriedem i want to say i've heard this reported bfore
15:10:26 mriedem *before
15:11:13 brandor5 nothing else found in the logs with that request
15:11:32 brandor5 the 400 would be coming from nova, correct?
15:11:37 brandor5 I shouldn't be looking down in ironic?
15:11:46 mriedem it's coming from nova
15:11:57 brandor5 that's what I thought
15:12:34 mdbooth Is it worth writing new code whose only consumer would be cellsv1?
15:12:52 mriedem mdbooth: nope
15:12:58 mdbooth Specifically, it looks like the only user of expected_vm_state is cellsv1
15:13:13 mdbooth i.e. instance.save(expected_vm_state=FOO)
15:13:15 mriedem probably because cells v1 was racy
15:13:26 mriedem syncing state between child and parent cell
15:13:55 mdbooth Ok. It'll look a bit odd to add new expected_task_state code without expected_vm_state code, though, so I'll add a comment
15:15:53 mriedem brandor5: i don't know what would be returning that 400 except the json schema validation code, but that query hint is just marked as a string or object, and you're passing a json string
15:16:22 mriedem the actual query hint isn't used until we hit the JsonFilter scheduler filter, which is long after you'd get that 400
15:16:43 mriedem so my guess is the request schema validation is somehow puking
15:16:54 brandor5 ok, i'll keep digging and will report back if I figure it out
15:17:08 mriedem i very much doubt we have any functional testing for JsonFilter
15:17:35 mriedem brandor5: i think the last person that had this problem just used availability_zone=nova::b23bbc4a-9a43-4ed8-b028-43d2aca3a6d7
15:17:45 mriedem the only problem with that is it bypasses the filters and forces to that node
15:17:55 brandor5 that would be okay in this case
15:18:04 mriedem https://docs.openstack.org/nova/latest/admin/availability-zones.html
15:18:05 brandor5 so I'll try that if the thing im about to test doesn't work
15:18:07 mriedem then force away
15:23:38 brandor5 mriedem: it turns out it was a bug in ansible, updating to latest and I don't see that issue now
15:26:18 mriedem huh
15:26:29 mriedem well you made me find our docs are busted at least :) https://bugs.launchpad.net/nova/+bug/1821764
15:26:30 openstack Launchpad bug 1821764 in OpenStack Compute (nova) "docs: JsonFilter query hint examples do not use valid json strings" [Medium,Triaged]
15:26:30 brandor5 yeah, weird
15:26:46 brandor5 hehe glad to be of assistance :D
15:28:55 sean-k-mooney mriedem: [">=", "$free_ram_mb", 1024] is a vlaid json array
15:29:21 mriedem sean-k-mooney: did you read the bug?
15:30:08 sean-k-mooney im just looking at it but '[">=", "$free_ram_mb", 1024]' is not the same thing as json.loads("[>=,$free_ram_mb,1024]")
15:30:57 mriedem serenity now
15:32:06 openstackgerrit Merged openstack/nova stable/pike: Fix WeighedHost logging regression https://review.openstack.org/641398
15:33:48 sean-k-mooney oh you are saying its correct in the schduler doc but not in the create server example
15:34:40 mriedem i don't see how what i wrote in the bug report is unclear
15:36:48 sean-k-mooney i was confused by the fact that it was correct in the osc command but not in the api example in the json filter doc
15:37:46 sean-k-mooney i intially looked at it and didnt see teh api example was wrong as my brain just filled in teh missing quots ared the args
15:38:53 sean-k-mooney its why im terible are prof readign my own stuff if i read two things that are almost identical and expect them to be the same i have troble seeign the difference
15:38:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix JsonFilter query hint examples in docs https://review.openstack.org/647778
15:42:44 mriedem ooo dansmith i could use the JsonFilter to schedule directly to a cell, that's fun
15:43:22 sean-k-mooney mriedem: you can you the json filter to do a lot of horribel things
15:43:57 dansmith mriedem: you can probably use it to do all kinds of things
15:45:36 sean-k-mooney as far as i rememebr it give you acess to any value contined in the hoststate object
15:46:51 mriedem correct
15:48:31 mriedem ima add a warning in the docs
15:49:09 sean-k-mooney the main usecase i was aware of was shduing based in the cpu info or hypervior type.
15:49:30 mriedem i think the ImagePropertiesFilter already handles hv type
15:49:39 mriedem and cpu info should be solved with traits
15:49:44 sean-k-mooney ya it does
15:50:48 sean-k-mooney the json filter is really a filter that we shoudl be able to remove in the near future but some peopel still use it. i think oath have an internal version too.
15:57:39 mdbooth Hmm, my grand plan to fix instance.save() is scuppered because I forgot we don't have access to the old values of fields which have changed but not saved.
16:01:40 sean-k-mooney mdbooth: can you not just always save all changed field when we call save and simply mark any filed we write to as chaged ignoring if the value is the same or not
16:02:19 mdbooth sean-k-mooney: No, because we've already lost the old value before we called save()
16:03:29 mdbooth sean-k-mooney: There will be another way.
16:06:39 melwitt mriedem: can do
16:14:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix JsonFilter query hint examples in docs https://review.openstack.org/647778
16:14:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Document a warning about using the JsonFilter https://review.openstack.org/647796
16:27:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add flavor to requested_resources in RequestSpec https://review.openstack.org/647396
16:57:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for the JsonFilter https://review.openstack.org/647811
17:22:37 openstackgerrit Stephen Finucane proposed openstack/nova stable/queens: [Stable Only] hardware: Handle races during pinning https://review.openstack.org/647831
18:14:19 openstackgerrit Eric Fried proposed openstack/nova master: PrivsepFixture so sys_admin_pctxt methods can be tested https://review.openstack.org/647849
18:20:43 openstackgerrit melanie witt proposed openstack/nova master: Add a reference PTL guide to the contributor docs https://review.openstack.org/647854
18:41:19 efried melwitt: What's an "RPC version alias"?
18:43:18 dansmith efried: the per-release aliases for whatever version was current
18:43:35 dansmith so you can say "compat=queens" when upgrading to rocky
18:43:41 dansmith instead of compat=5.2 or something
18:45:40 efried dansmith: is this a thing that's set in code, or a git tag, or...
18:45:51 dansmith efried: it's in compute/rpcapi.py
18:46:15 efried got it, thanks.
18:46:41 dansmith you want to do those as late and close to release as possible in case we had to add an rpc version for a critical rc9 bug
18:46:55 dansmith they can be changed of course, but ideally they wouldn't
19:09:35 dansmith efried: have we let this sit long enough? https://review.openstack.org/#/c/644625/
19:09:56 efried dansmith: add my sentence and I'll fast approve it.
19:10:11 dansmith sigh, okay
19:11:21 efried you think you're pissed, I just -1'd mikal's privsep series on account of missing unit tests.
19:11:44 dansmith I think I'm done reviewing his patches for a while
19:13:17 openstackgerrit Dan Smith proposed openstack/nova-specs master: Add request-filter-image-types spec https://review.openstack.org/644625
19:13:18 dansmith efried: ^
19:13:55 dansmith I added "in other words" in front of your sentence as my highly passive-aggressive "saying this again with different words" notation
19:15:03 openstackgerrit Eric Fried proposed openstack/nova-specs master: Add request-filter-image-types spec https://review.openstack.org/644625
19:16:12 efried I noticed
19:16:24 dansmith let me have it.
19:16:35 efried I did
19:16:56 efried in the literal rather than figurative sense
19:20:15 sean-k-mooney if people have dansmith's spec still in there mind https://review.openstack.org/#/c/647578/1/specs/train/approved/image-metadata-prefiltering.rst is very similar but different uscase.
19:20:27 dansmith sean-k-mooney: I have it up to look at
19:22:24 sean-k-mooney dansmith: cool the main open question i have in the spec is realy how the use would formulate the quested that triggers the feature. 3b which is my perfeence i think is basicly the same as you were proposing for the image type
19:23:23 openstackgerrit melanie witt proposed openstack/nova master: Add a reference PTL guide to the contributor docs https://review.openstack.org/647854
19:23:26 sean-k-mooney .i.e. they have to do nothing because a prefilter magicaly adds the traits for them
19:37:41 openstackgerrit Merged openstack/nova-specs master: Add request-filter-image-types spec https://review.openstack.org/644625
19:58:05 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Fix incomplete instance data returned after build failure https://review.openstack.org/647902
20:06:57 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Fix incomplete instance data returned after build failure https://review.openstack.org/647911

Earlier   Later