| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-20 | |||
| 10:59:32 | aspiers | is it just me or is tempest-full-py broken? "The error was: 'gabbi_tempest_path' is undefined\n\nThe error appears to have been in '/var/lib/zuul/builds/42292da2453549e68ae6c1e63bfca00b/untrusted/project_5/git.openstack.org/openstack/tempest/roles/setup-tempest-run-dir/tasks/main.yaml'" | |
| 11:00:10 | cdent | blargh, that sounds like it is at least partially my fault | |
| 11:00:27 | cdent | (because of gabbi in the name) but I haven't changed anything recently | |
| 11:00:32 | aspiers | cdent: failure is in https://review.openstack.org/#/c/644554/ | |
| 11:00:35 | cdent | thanks | |
| 11:03:06 | cdent | aspiers: looks like it has already been fixed | |
| 11:03:11 | aspiers | oh nice | |
| 11:03:34 | cdent | https://review.openstack.org/#/c/644699/ | |
| 11:04:27 | cdent | hmm, actually I think that may have broken it | |
| 11:04:33 | aspiers | haha | |
| 11:06:40 | cdent | aspiers: it is a fix, the reason it wasn't happening before is because it didn't tickle a problem until ansible 2.7 was the default | |
| 11:06:52 | aspiers | ah ok | |
| 11:06:54 | aspiers | thanks! | |
| 11:06:58 | aspiers | is it just me or does the browser not cache these horrendously long job-output.txt.gz files? | |
| 11:07:20 | cdent | I think it does not | |
| 11:07:35 | aspiers | I see my Chrome sending Cache-Control: no-cache with the request - wtf? | |
| 11:07:43 | aspiers | Why would it do that? | |
| 11:08:19 | cdent | I think it is because the server is not sending good headers | |
| 11:08:34 | cdent | there's no last-modified or other cache-related header in the headers of the response | |
| 11:08:44 | aspiers | I see Cache-Control in the response | |
| 11:09:04 | aspiers | but surely it's the Apache index page which should control how the client sends a request for the actual file | |
| 11:09:13 | aspiers | http://logs.openstack.org/54/644554/2/check/tempest-full-py3/42292da/ <- this one | |
| 11:09:23 | sean-k-mooney | aspiers: do you have the developer console open | |
| 11:09:32 | aspiers | sean-k-mooney: ohhhh, good point | |
| 11:09:33 | cdent | if I do a raw curl of the log file you linked to above and the headers are very limited | |
| 11:09:39 | sean-k-mooney | aspiers: there is a tick box to disable cache | |
| 11:09:47 | aspiers | sean-k-mooney: thanks for the reminder! | |
| 11:12:07 | aspiers | ok so unticking "Disable cache" gets rid of no-cache headers, but it's still re-downloading the full file each time | |
| 11:12:29 | cdent | because of what I said: the server isn't providing enough info to allow useful caching | |
| 11:13:07 | aspiers | so it's missing an Expires: header? | |
| 11:13:15 | aspiers | or Last-Modified | |
| 11:13:19 | aspiers | or Date | |
| 11:13:20 | cdent | or a last-modified, or a cache-control, or an etag or lots of thing | |
| 11:13:32 | cdent | Date is the server date, not the date of the content | |
| 11:13:43 | mdbooth | cdent stephenfin: Docs loads oslo policies from nova.api.openstack.placement.policies because it's defined in setup.cfg and I guess it's not unreasonable to document those things. Problem is I moved the monkey patching point to nova/api/openstack/__init__.py, so now that pulls in monkey patching. | |
| 11:14:12 | cdent | yeah, fine, I tried to delete that code ! :) | |
| 11:14:12 | sean-k-mooney | aspiers: that just an issue with the apache config for the instance thats is fronting logs.openstack.org | |
| 11:14:21 | mdbooth | cdent: Yeah, if you could move that out of the way... | |
| 11:14:28 | aspiers | sean-k-mooney: yeah, I'm gonna ask infra about that | |
| 11:14:32 | aspiers | https://httpd.apache.org/docs/2.4/caching.html | |
| 11:14:57 | sean-k-mooney | well in generaly what is the point of allowing cdns to cache logs.openstack.org | |
| 11:15:18 | sean-k-mooney | the browser sure but i dont hink we can do one without the other | |
| 11:15:23 | sean-k-mooney | maybe we can | |
| 11:15:34 | cdent | mdbooth: i'll do it on saturday, with a tps repoert | |
| 11:16:21 | sean-k-mooney | aspiers: actully its proably fine to cache it so if they want to update it it proably wont have any negitive impact | |
| 11:16:35 | aspiers | right, because the paths are unique | |
| 11:16:36 | sean-k-mooney | most logs on logs.openstack.org never get read anyway | |
| 11:16:50 | cdent | they could relatively easily have a last-modified header | |
| 11:16:57 | cdent | which would at least allow a conditional get | |
| 11:17:16 | sean-k-mooney | yep each run is a new file even for the same patch so you will never get cached old data where the content on the server has changed | |
| 11:20:41 | kashyap | mdbooth: Want to give your final ACK/NACK on this: https://review.openstack.org/#/c/641981/ | |
| 11:22:30 | mdbooth | kashyap: "This improves performance without compromising data integrity". You could stick that in a politician's stump speech alongside mom and apple pie. | |
| 11:22:47 | kashyap | LOL | |
| 11:23:02 | kashyap | mdbooth: If you prefer a different phrasing, I'm open to critique | |
| 11:23:22 | mdbooth | kashyap: Absolutely not. It's straight to the point. | |
| 11:23:24 | kashyap | aspiers: (Thanks for your remark on that trade-off of: readability vs. indirection. I've bookmarked the talk :-)) | |
| 11:23:44 | kashyap | mdbooth: Okay, I get lunch then. Thanks for looking! Appreciate your time. | |
| 11:24:17 | kashyap | aspiers: (I'm largely with you on it, as I was also feeling uneasy that method becoming longer and longer.) | |
| 11:24:23 | aspiers | kashyap: :) | |
| 12:02:25 | openstackgerrit | Merged openstack/os-resource-classes master: Update master for stable/stein https://review.openstack.org/644030 | |
| 12:05:01 | openstackgerrit | Merged openstack/os-traits master: Update master for stable/stein https://review.openstack.org/644033 | |
| 12:29:23 | openstackgerrit | Merged openstack/os-resource-classes stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644028 | |
| 12:30:20 | openstackgerrit | Merged openstack/os-traits stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644031 | |
| 12:30:40 | openstackgerrit | Merged openstack/os-resource-classes stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644029 | |
| 12:36:52 | openstackgerrit | Merged openstack/os-traits stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644032 | |
| 12:46:02 | kashyap | mdbooth: You are right. That whole documentation mess needs fixing. I'll hold my nose and get that going. | |
| 12:46:39 | kashyap | mdbooth: And on that fated IBM article from the past ... look, I apparently "debunked" it as far as 2014: https://www.redhat.com/archives/libvirt-users/2014-August/msg00060.html ("Behavior of disk caching with qcow2 disks") | |
| 13:21:30 | openstackgerrit | Merged openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | |
| 13:25:33 | bauzas | efried: FWIW, I'd have loved to have time for reviewing https://review.openstack.org/#/c/644412/ but fortunately, it's not merged yet | |
| 13:29:11 | efried | bauzas: I knew it was going to hang on in the queue for a while, but we're also a bit tight for time so I didn't want it not to merge because we forgot to +W it. | |
| 13:29:37 | efried | I didn't mean to cut anyone out, sorry. | |
| 13:29:42 | bauzas | no worries | |
| 13:30:06 | bauzas | just for the next release, we open the prelude change 2 days before and we leave it there at least some time | |
| 13:30:14 | efried | noted, thank you. | |
| 13:39:08 | aspiers | kashyap: https://review.openstack.org/#/c/644554/ is ready for review | |
| 13:39:41 | aspiers | efried: anyone else I should add to review for that? ^^ | |
| 13:39:46 | openstackgerrit | Matthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible https://review.openstack.org/626952 | |
| 13:43:14 | mdbooth | It's going to be revised in a second ;) | |
| 13:43:35 | mdbooth | Line length violations after I indented everything and forgot to rerun pep8 | |
| 13:45:02 | efried | aspiers: Dunno. Maybe bauzas would like to look :) | |
| 13:45:30 | bauzas | I can | |
| 13:45:49 | efried | thanks bauzas. Should be an easy one, just a refactor (and an extra log) | |
| 13:46:01 | aspiers | and extra tests!! \o/ | |
| 13:46:40 | openstackgerrit | Matthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible https://review.openstack.org/626952 | |
| 13:46:43 | mdbooth | Ok, ^^^ is the one. Really. | |
| 13:46:59 | mdbooth | stephenfin: How do you feel about the sphinx bodge in ^^^ ? | |
| 13:47:30 | stephenfin | mdbooth: It's necessarily awful | |
| 13:47:42 | mdbooth | stephenfin: Why thank you | |
| 13:47:48 | stephenfin | :) | |
| 13:47:57 | kashyap | aspiers: Looks good to me. | |
| 13:48:08 | aspiers | kashyap: thanks | |
| 13:48:57 | mdbooth | If there's any other way which doesn't involve moving entry points, and therefore impacting deployment tooling, I'd do that instead. | |
| 13:49:15 | mdbooth | It's kinda icky, but it's the best I can think of. | |
| 13:50:32 | stephenfin | mdbooth: It'll do for 6 months, I imagine | |
| 13:50:41 | stephenfin | at which point we should be aiming to rip that all out | |
| 13:51:13 | mdbooth | stephenfin: Yarp. | |
| 13:51:20 | efried | that's a new one on me, thanks mdbooth | |
| 13:51:27 | mdbooth | efried: dirty hack that works | |
| 13:51:42 | mdbooth | efried: Code I'm not proud of | |
| 13:51:44 | sean-k-mooney | mdbooth: is the bodge hardcoding OS_NOVA_DISABLE_EVENTLET_PATCHING in the conf.py | |