Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-15
19:07:55 fried_rice ack (and confirmed btw). Will twiddle and retry to make sure it still works :)
19:08:34 mordred cool! I left a comment on the review for posterity
19:09:20 fried_rice ...also works fwiw
19:09:29 mordred \o/
19:09:45 fried_rice I guess I would need to do something nonstandard with adapter-only settings to make sure it's actually excercising the code, but for now...
19:09:59 mordred or just put ina print statement :)
19:10:13 mordred but yeah - I thnk for now that's fine
19:10:17 fried_rice No, I mean *exercising*
19:10:40 fried_rice like, I should remove the public interface from my service catalog and set my conf to private
19:10:42 fried_rice or something.
19:10:46 mordred yeah. totally
19:13:22 mordred fried_rice: if it's ok with you - I'll start updating that with docs
19:13:52 fried_rice mordred: It's all yours. I'll buzz you if I need to diddle with it any further for local testing purposes, but I think I'm done for now.
19:17:37 fried_rice mordred: What happens if I pass kwargs like microversion and headers into primitives like .get?
19:18:03 fried_rice I think what I'm asking is, do I have to go around and remove all that shit from my placement client to make it go, or can I do that cleanup later?
19:18:06 mordred it works exactly like keystoneauth adaptr (it is a subclass of a ksa adapter)
19:18:17 fried_rice okay, so probably redundant, but harmless
19:18:34 mordred nah - I think you should totally pass those thigns in
19:19:18 mordred conn.placement.get() is pure passthrough ksa.Adapter. it doesn't do anything special with microverions for you - other than doing major version discovery
19:19:45 mordred the higher order methods for other services, like ironic, are where the sdk will be handling microversions and headesr for you
19:19:56 mordred but for placement - just a one-to-one swap should be totally fine
19:21:55 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement https://review.openstack.org/643664
19:22:05 fried_rice mordred: ^
19:22:12 fried_rice expect that to fail unit/functional but pass tempest etc.
19:22:21 fried_rice assuming Depends-On chain works here...
19:22:32 mordred probably because unit tests mock ksa somehow?
19:22:40 fried_rice yes
19:22:44 fried_rice um
19:22:45 mordred I mean - to be fair - mocking ksa should still work
19:22:47 fried_rice maybe
19:22:57 mordred since it's still basically ksa
19:22:57 fried_rice yeah, I suppose it's possible most of the unit/functional will still pass.
19:23:09 fried_rice Just the ones that actually mock the get_ksa_adapter utils
19:23:15 fried_rice will fail
19:23:16 mordred yeah
19:23:22 fried_rice we'll see
19:23:30 fried_rice maybe the whole thing will blow up because I effed something.
19:23:41 fried_rice But I'm generally super pleased with how simple this is turning out to be to get off the ground.
19:24:55 mordred fried_rice: yeah - being pleased is almost always the wrong choice :)
19:25:06 mordred fried_rice: but yeah -s ince you already jinxed it - I'm also super pleased :)
19:25:18 fried_rice hah!
19:25:26 fried_rice Drinks tonight. Mourning next week.
19:48:48 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement https://review.openstack.org/643664
19:48:57 fried_rice d'oh ^
20:05:45 sean-k-mooney fried_rice: are you going to pivot your ironic clinet patch to similarly use the openstack sdk?
20:06:29 fried_rice sean-k-mooney: yes, was just about to make a start on that, if I can figure out how the baremetal sdk thingies work.
20:06:43 sean-k-mooney cool
20:07:36 sean-k-mooney the openstacksdk has some gaps compared to the python-*client module but converting what can be converted makes sense
20:47:39 cfriesen sean-k-mooney: https://review.openstack.org/#/c/631363/ and https://review.openstack.org/#/c/639934 seem to be working for me, I would appreciate some eyes on them.
20:52:59 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899
20:53:11 fried_rice sean-k-mooney, dtantsur|afk, needssleep, mordred: ^
20:53:45 fried_rice It seems like the Node object from the SDK has different fields than that of the ironicclient. Like, there's no uuid field!
20:54:10 fried_rice which made that delta rather more of a pain than I wanted it to be. And will need it vetted by someone like dtantsur|afk
20:55:09 mordred fried_rice: woot! and yeah ... there are a few areas where the sdk strives for internal consistency over consistency with actual external resource. id is one of them
20:55:59 mordred so sorry about the patch size there
20:58:26 mordred fried_rice: but it looks completely reasonable that converting that whole file won't be super terrible
20:59:21 needssleep well, it was the lift that would have been the tests with how they are written that pretty much stopped me
21:02:40 mordred needssleep: :)
21:02:45 mordred I know that feeling
21:14:48 fried_rice needssleep: You mean you don't trust the CI to have complete coverage? :P
21:20:08 mordred BLASPHEMY
21:22:42 openstackgerrit Eric Fried proposed openstack/nova master: Remove [ironic]api_endpoint option https://review.openstack.org/643483
21:22:47 fried_rice srsly ^
21:29:48 mordred fried_rice: \o/
21:59:04 mnaser yes please kill more endpoint config options :--)
22:13:42 mordred mnaser: did you see the other fun from fried_rice above?
22:32:14 openstackgerrit Merged openstack/nova stable/rocky: Fix resetting non-persistent fields when saving obj https://review.openstack.org/643215
23:52:38 openstackgerrit Merged openstack/nova stable/queens: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/637827
23:52:44 openstackgerrit Merged openstack/nova stable/pike: Handle missing marker during online data migration https://review.openstack.org/611343
#openstack-nova - 2019-03-16
14:51:26 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899
21:12:18 Haunted330 This channel is closed. You are going to have to leave.
#openstack-nova - 2019-03-17
16:39:32 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899
18:04:35 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP block_device: Optionally recreate attachments when refreshing connection_info https://review.openstack.org/579004
19:56:14 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement https://review.openstack.org/643664
19:56:15 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899
20:04:32 openstackgerrit Eric Fried proposed openstack/nova master: Speed up test_report https://review.openstack.org/643760
20:19:08 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Poison sleep() in tests https://review.openstack.org/643763
#openstack-nova - 2019-03-18
00:06:46 openstackgerrit Jake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows https://review.openstack.org/556751
00:06:47 openstackgerrit Jake Yip proposed openstack/nova master: refactor nova-manage archive_deleted_rows https://review.openstack.org/643779
01:52:22 openstackgerrit yuanliu proposed openstack/nova master: Fix query method for nova compute services by compute_driver types https://review.openstack.org/637083
02:38:00 openstackgerrit yuanliu proposed openstack/nova master: Fix query method for nova compute services by compute_driver types https://review.openstack.org/637083
05:15:38 ravirjn Can anyone please help me regarding, how to migrate instances from compute host (ephemeral disk) to cinder volume without any changes in IP addresses? I have one running Newton trippleo cluster.
05:32:23 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Extract compute API _create_image to compute.utils https://review.openstack.org/643852
05:32:23 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
05:44:52 openstackgerrit Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592
05:44:52 openstackgerrit Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
05:44:53 openstackgerrit Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433
05:44:53 openstackgerrit Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
05:44:54 openstackgerrit Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
05:44:55 openstackgerrit Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508
05:44:55 openstackgerrit Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280
05:44:55 openstackgerrit Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281
05:44:56 openstackgerrit Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282
05:44:57 openstackgerrit Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283
05:44:57 openstackgerrit Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580
05:44:58 openstackgerrit Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581
05:44:58 openstackgerrit Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
05:44:59 openstackgerrit Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826
06:11:29 openstackgerrit Brin Zhang proposed openstack/nova master: Remove the string check of the flavor attribute 'swap' https://review.openstack.org/639012
07:25:57 openstackgerrit zhangyangyang proposed openstack/nova master: Drop py35 tests https://review.openstack.org/643868

Earlier   Later