Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-14
17:44:39 dansmith because you changed things to run at import time, it's maybe a little more obscure, but really the fix here is detaching the monkeypatch from the utils module (or anything else that has a bunch of stuff in it)
17:45:40 mdbooth Yeah. I don't think there's any way to avoid running anything at import time, tbh, because that's the fundamental underlying issue
17:45:50 mdbooth you need to run monkey_patch() before importing stuff
17:46:29 dansmith no, I know.. I get that part
17:47:18 mdbooth Yes. The purpose of the monkey_patch module is to do monkey patching with minimal dependencies.
17:55:33 mdbooth dansmith: Thanks
17:55:41 dansmith aye
17:56:49 kashyap dansmith: If you want some fresh change of scenery, a simple catch: https://review.openstack.org/#/q/topic:bug/1818847+(status:open+OR+status:merged)
17:57:08 dansmith I really don't
17:57:11 kashyap Hehe
17:58:18 kashyap dansmith: It brings 15 times faster performance for image conversion :D -- https://review.openstack.org/#/c/640781/
17:58:51 kashyap I ran it through the QEMU Block Layer maintainer, who also reviewed the patches over e-mail. And gave their: "Looks-good-to-me'd-by", FWIW
18:46:05 mriedem someone want to approve these for gate goodness? https://review.openstack.org/#/q/topic:bug/1819944+(status:open+OR+status:merged)+project:openstack/nova
18:46:17 mriedem gets the ceph portion of our live migration (+grenade) jobs running again
18:46:55 mriedem efried: maybe you want to hit https://review.openstack.org/#/c/643150/ and melwitt can get the one below
18:47:47 efried mriedem: is that reverting something?
18:47:56 mriedem yeah in part
18:47:58 mriedem revert + fix
18:48:09 mriedem it's reverting this https://review.openstack.org/#/c/643122/
18:48:29 efried k, Ima update commit message accordingly
18:48:58 openstackgerrit Eric Fried proposed openstack/nova master: Re-enable Ceph in live migration testing https://review.openstack.org/643150
18:50:07 efried mriedem: done
18:52:34 mriedem thanks
19:01:47 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get https://review.openstack.org/642899
19:36:58 edleafe python
19:37:03 edleafe doh!
19:59:18 mriedem your secret is out
20:00:11 martinkennelly Hey all, I just inherited an openstack deployment that I do not think is consuming the whole node. It is a single node deployment of OS. How can I help it consume the whole node?
20:01:36 mriedem drop reserved host config values for cpu/ram/disk, create finer grained flavors
20:01:42 mriedem really pack it tight
20:02:09 mriedem and then not be able to resize anything....
20:23:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.openstack.org/636253
20:23:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for cross-cell migrate with target host https://review.openstack.org/642591
20:23:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.openstack.org/642592
20:23:40 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source https://review.openstack.org/637058
20:23:41 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.openstack.org/637070
20:23:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.openstack.org/637075
20:23:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.openstack.org/637316
20:23:42 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add revert_snapshot_based_resize_at_dest compute method https://review.openstack.org/637630
20:23:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.openstack.org/639453
20:23:43 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.openstack.org/637647
20:23:44 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.openstack.org/638046
20:23:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.openstack.org/638047
20:23:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048
20:23:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268
20:23:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
20:23:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269
20:23:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.openstack.org/643450
20:23:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.openstack.org/643451
20:30:34 mriedem sob, time to rebase
20:30:37 mriedem 44 changes
20:34:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521
20:34:33 openstack bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem)
20:34:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792
20:34:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806
20:34:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179
20:34:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382
20:34:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
20:34:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
20:34:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
20:34:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
20:34:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
20:34:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
20:34:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
20:34:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
20:34:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890
20:34:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832
20:34:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605
20:34:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891
20:34:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.openstack.org/642183
20:34:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.openstack.org/639453
20:34:53 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.openstack.org/637647
20:34:53 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.openstack.org/638046
20:34:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.openstack.org/638047
20:34:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048
20:34:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268
20:34:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
20:34:57 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269
20:37:45 mgoddard hi nova. Hitting an issue on ubuntu bionic where libvirt has a guest arch (armv6l) unknown to nova, causing nova-compute to error
20:38:02 mgoddard InvalidArchitectureName: Architecture name 'armv6l' is not recognised
20:38:11 mgoddard http://logs.openstack.org/08/643308/4/check/kolla-ansible-ubuntu-source/eee856d/primary/logs/kolla/nova/nova-compute.txt.gz#_2019-03-14_19_11_31_709
20:38:27 mgoddard Is this a known issue?
20:42:03 mgoddard qemu 2.11.1
20:42:21 mgoddard libvirt 4.0.0
20:43:40 melwitt looks like it, if the arch isn't in this list, calls to canonicalize() will raise that exception https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L102
20:44:49 mgoddard melwitt: better hope no one invents any new arches after a nova release then :)
20:45:00 melwitt haha, yeah
20:45:14 melwitt I don't know the story behind it, dansmith or someone might know
20:45:28 dansmith the story behind why we have enums?
20:45:39 mgoddard melwitt: I'll push a patch for armv6l, but maybe an item for the nova team TODO list to make it a bit more resilient to the unknown?
20:46:04 melwitt dansmith: yeah, why it's a limited set that has to be added to when new arch arrive
20:46:15 dansmith melwitt: kindof the definition of an enum right?
20:46:32 melwitt dansmith: well, ok, then yes, why we have enum. you know what I mean
20:46:38 dansmith we have enums for known image properties so one we don't support doesn't sneak into place, and we have enums for virt drivers for ...
20:47:18 dansmith I mean, everything on the wire could just be strings and dicts, but, the whole point of this stuff was to nail it down so we could tell when something changed
20:47:37 melwitt mgoddard: in what way, a better error maybe? like ArchitectureUnknown?
20:47:57 mgoddard the problem here is that a new arch in libvirt capabilities causes nova-compute to fail
20:48:22 mgoddard it doesn't have to support the arch, but it shouldn't break everything else
20:49:15 dansmith sure, so the driver maybe should catch the failure to set the enum, log an error and exit on startup
20:50:21 mgoddard exit?

Earlier   Later