| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-06 | |||
| 19:08:56 | melwitt | mriedem: ok, on it | |
| 19:09:45 | openstackgerrit | Dan Smith proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593 | |
| 19:09:45 | openstackgerrit | Dan Smith proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594 | |
| 19:09:46 | openstackgerrit | Dan Smith proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432 | |
| 19:09:46 | openstackgerrit | Dan Smith proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434 | |
| 19:09:47 | openstackgerrit | Dan Smith proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | |
| 19:09:47 | openstackgerrit | Dan Smith proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | |
| 19:09:48 | openstackgerrit | Dan Smith proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433 | |
| 19:09:48 | openstackgerrit | Dan Smith proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | |
| 19:09:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | |
| 19:09:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | |
| 19:09:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | |
| 19:09:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | |
| 19:09:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | |
| 19:09:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | |
| 19:09:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | |
| 19:09:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | |
| 19:09:53 | openstackgerrit | Dan Smith proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | |
| 19:09:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | |
| 19:10:00 | mriedem | makes you feel like a BIG MAN | |
| 19:10:31 | sean-k-mooney | :) | |
| 19:11:05 | melwitt | lol. | |
| 19:12:07 | sean-k-mooney | efried: do you want the good news or the bad news | |
| 19:12:39 | dansmith | I have some draft comments on one of melwitt's in that stack too, I need to go find and finish that | |
| 19:12:39 | mriedem | i got you a puppy on the way home from work, | |
| 19:12:43 | mriedem | but then i got hungry and ate it | |
| 19:13:12 | dansmith | melwitt: okay bottom four of that privsep set are +W | |
| 19:13:23 | dansmith | assuming I didn't break anything.. the rebases were not bad, but not trivial | |
| 19:13:38 | melwitt | dansmith: cool, thanks for doing that | |
| 19:13:52 | dansmith | aye | |
| 19:13:52 | melwitt | I made a comment on the old bottom patch to explain | |
| 19:13:57 | dansmith | oh okay | |
| 19:14:07 | sean-k-mooney | efried: the good news is your change passed the fucntional job that runs the ironic api test and and python-ironclinet was installed from git | |
| 19:14:48 | sean-k-mooney | efried: the bad news is the tempest job that ran teh senario tests failed with this error http://logs.openstack.org/21/641421/2/check/nova-ironic-client-tempest/8faf490/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Mar_06_18_04_20_985307 | |
| 19:17:27 | sean-k-mooney | efried: anyway you should be able to use that to test your chagnes looks like your just need to set the ironic api version | |
| 19:24:09 | openstackgerrit | Chris Friesen proposed openstack/nova master: Split up _is_storage_shared_with() in libvirt driver https://review.openstack.org/639933 | |
| 19:24:09 | openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | |
| 19:24:29 | cfriesen | ignore these, debugging something that fails in zuul but works locally. ^ | |
| 19:26:32 | mriedem | melwitt: ok i think dansmith and i are both up through the instance mapping user_id data migration patch, so you can probably start addressing stuff and pushing | |
| 19:27:08 | melwitt | mriedem: ack, reading through | |
| 19:29:18 | cfriesen | mriedem: just wanted to say thanks for all the reviews in the past week. you're a machine. | |
| 19:31:53 | mriedem | cfriesen: yw | |
| 19:32:08 | mriedem | i'm also having a hard time not making an inappropriate machine-related comment here | |
| 19:32:12 | mriedem | feels like a trap | |
| 19:32:13 | dansmith | haha | |
| 19:32:17 | dansmith | I've been thinking | |
| 19:32:28 | dansmith | all I came up with that was appropriate was "that's why his hugs are so cold" | |
| 19:32:45 | mriedem | but i'd have to hug for anyone to know that | |
| 19:32:53 | dansmith | I can tell from a distance | |
| 19:34:01 | melwitt | pff lol | |
| 19:35:36 | mriedem | we'll also need to think about what we do about counting for instance mappings that have queued_for_delete=None (not yet migrated) | |
| 19:35:55 | mriedem | i think i would tend to count those since we do'nt know if the instance is deleted, so it's safer to be conservative | |
| 19:36:03 | melwitt | yeah, was just reading through that | |
| 19:36:08 | dansmith | I haven't gotten to any of the actual counting stuff | |
| 19:36:19 | dansmith | I figure best case, | |
| 19:36:28 | dansmith | we merge the data model and migration stuff | |
| 19:36:42 | dansmith | so we can get the things migrated in stein and then we're looking at train for the actual counting stuff | |
| 19:36:52 | dansmith | as I haven't looked over any of that other than to go answer one question for myself | |
| 19:37:00 | melwitt | +1 my initial thought is to be conservative and count the queued_for_delete=None ones | |
| 19:37:53 | mriedem | yeah i haven't gotten into the api changes that actually use the new counting stuff, and at this rate it's too late for me to be comfortable with that, | |
| 19:38:00 | mriedem | so i'd be happy to get the data model change and migration in stein | |
| 19:38:05 | mriedem | so there is less to migrate in train | |
| 19:38:32 | dansmith | yeah, having it migrated in stein before makes that stuff a lot better | |
| 19:38:39 | melwitt | I can't argue with that. it's a bummer, but I take responsibility for not having this all ready for review earlier in the cycle | |
| 19:39:36 | melwitt | I appreciate the review you're doing now and glad to be able to land some of it because of it | |
| 19:40:24 | melwitt | s/some of it/the migration stuff/ | |
| 19:44:38 | melwitt | I don't know why, but the whole unset non-nullable ovo field thing really confuses me :x | |
| 19:45:19 | dansmith | I don't know why either :) | |
| 19:45:40 | melwitt | :P | |
| 19:50:00 | mriedem | melwitt: i'm +2 on the rbd extend volume change now https://review.openstack.org/#/c/613039/ | |
| 19:51:22 | melwitt | +W | |
| 19:56:08 | dansmith | melwitt: comment for you on the base patch.. I dare not -1 against that raft of positive votes, but.. genuine question | |
| 19:58:04 | melwitt | dansmith: good question -- I think probably so. we added indexes for the quotas re-work in pike | |
| 19:58:21 | dansmith | YES | |
| 19:58:34 | dansmith | oh sweet sweet -1 vote | |
| 19:58:41 | melwitt | hah | |
| 19:58:53 | melwitt | I'd ask jaypipes to confirm but he's not around atm | |
| 19:59:38 | dansmith | it should be free to add since it's defaulted to null at add time, so .. I can't really imagine we don't want one | |
| 20:01:22 | melwitt | yeah...I'll see what the indexes look like for the current counting stuff we have and model after that. I don't know that much about database stuff | |
| 20:04:00 | dansmith | should be fairly straightforward..nothing really to configure afaik | |
| 20:06:18 | openstackgerrit | Merged openstack/nova master: Test live migration with config drive https://review.openstack.org/567860 | |
| 20:06:33 | melwitt | dansmith: IIUC, we would need two right? one on project_id and one that is on project_id and user_id? | |
| 20:07:33 | dansmith | I'm not sure you need both, but maybe.. I guess I would think one on each is as good as one on (a) and one on (a,b) but not positive | |
| 20:08:24 | dansmith | I was focused on the userid bit, but since I haven't really looked at how this is used, I wasn't thinking about it being queried as (a,b) | |
| 20:08:33 | dansmith | so yeah maybe.. Guess we do need some expertise | |
| 20:08:38 | melwitt | I think I'm thinking that because of what jaypipes recommended to be done on the consumers table: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L646-L648 | |
| 20:09:01 | melwitt | if the queries are going to be project_id and project_id + user_id | |
| 20:09:30 | dansmith | right, but there isn't a bare one on project there, just composite ones | |
| 20:09:42 | dansmith | but yeah I dunno | |
| 20:09:47 | melwitt | yeah, true | |
| 20:10:50 | melwitt | I'm not sure there's another example. but yeah the pattern is going to be (a) and (a,b) | |
| 20:16:20 | efried | mriedem: done | |
| 20:16:55 | efried | sean-k-mooney: not at all surprised it failed, good deal that it's hitting the changes. Thanks again. | |
| 20:18:40 | sean-k-mooney | efried: it looks like the functional job that runs the ironic api tempest test dose not help so you could drop that job | |
| 20:19:17 | efried | sean-k-mooney: I guess it "proves" (or at least suggests) that I didn't f up backward compatibility | |
| 20:19:27 | efried | assuming of course that the func tests actually exercise the paths I dorked with. | |
| 20:19:56 | sean-k-mooney | ya i guess. | |
| 20:21:02 | sean-k-mooney | im just going to go grab some gorceries. ill be back online a bit later | |
| 20:22:00 | efried | wow, grocery stores are open after 6pm? Things have changed since I lived over there:) | |
| 20:22:28 | cdent | efried: the best part is that the sign says "open 24 hours" | |