Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-05
20:32:57 mriedem we're waiting for the event before starting the guest transfer
20:33:09 mriedem because if the dest plug fails or something, we don't want to start transferring the guest
20:33:57 mriedem dansmith: check my comments on takashin's fix here https://review.openstack.org/#/c/636271/ - should i just not care about a functional test for live migration or stack it up on top myself if i care?
20:34:06 mriedem i'm probably reaching
20:34:27 mriedem jaypipes: see my comment on https://review.openstack.org/#/c/638680/
20:35:05 dansmith mriedem: I dunno, the real change is in that object loader, which seems pretty well covered by two operations, so .. seemed like enough to me
20:35:21 artom mriedem, ah, got it, I think. Sorry, am slow.
20:35:28 dansmith I pulled it down and poked at it too, both fail in the expected way...
20:35:33 mriedem dansmith: yeah ok, i just don't like being told it's not an issue for live migration :)
20:36:04 dansmith well, I don't think stacking one on top is a problem if it makes you feel better
20:36:33 mriedem it won't fill the hole inside
20:36:44 dansmith hah
20:36:59 artom mriedem, oh, ODL *doesn't* send events for binding host changes
20:37:27 mriedem WRONG
20:37:35 artom DAMMIT
20:37:41 mriedem it *only* sends events in that case
20:37:42 dansmith ARGH
20:37:55 artom That note is damn confusing, I'm not backing down from that >_<
20:38:14 mriedem is it time for a truth table in that config option note?
20:38:27 mriedem if x and y but not z = False?!
20:38:38 artom ...
20:39:17 artom OK, sorry, it's fine.
20:39:23 artom I misread mriedem's line here.
20:39:51 artom I mean, mostly fine, it could be worded better.
20:40:57 dansmith but, the note is for an operator,
20:41:04 dansmith and all they need to know is ODL is not okay
20:41:16 dansmith it's not meant to explain the inner workings of both services, like you want it to, right?
20:41:21 artom Yeah
20:41:50 artom I just think explicitly saying what "OK" (or "will not currently work") would have been better
20:42:33 artom I need to be off anyways
20:42:41 openstackgerrit Merged openstack/nova master: Fix an error when generating a host ID https://review.openstack.org/639936
20:43:31 mriedem for those that *need* to know the inner details, the bug report is linked
20:44:12 openstackgerrit Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855
20:46:32 openstackgerrit Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855
20:55:24 sean-k-mooney mriedem: :) i was having dinner but i see ye were dicussing how odl breaks all the things when it comes to vif-plugged events
20:57:54 sean-k-mooney artom: by the way i straed on https://review.openstack.org/#/c/635083/ to recored which ml2 driver bound a port so we can use it in nova for thing and i intend to add another feature that report when each ml2 driver sends events. e.g. on portbinding vs when the backend wires it up
21:04:50 mriedem easy bug fix here https://review.openstack.org/#/c/638821/
21:04:53 sean-k-mooney artom: what im hpoing we can do in train is take all the guess work out of when the event will be sent and have neutron tell us but i need to bring this up with the neutron folks and work with them to create a spec.
21:08:25 sean-k-mooney i know we made the DriverBlockDevice inherit from dict to make tanstioning to it simpler but at some point it would be better to bit the bullet and just make it a reall nova object/ovo
21:45:04 openstackgerrit Chris Friesen proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131
21:45:38 cfriesen mriedem: ^
21:46:07 openstackgerrit Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680
21:49:24 mriedem cfriesen: comments inline
21:50:15 cfriesen mriedem: wasn't sure whether to copy the other docstring or refer to it. :)
21:51:07 cfriesen will update based on other comments...do you think I should test that pci is not validated by default?
21:51:47 mriedem well, if you changed validate_pci=True, i'm guessing some existing tests for create/rebuild would fail b/c they haven't mocked something out?
21:52:03 mriedem if so, then you probably don't need an explicit test for that
21:52:19 cfriesen works
21:59:09 openstackgerrit Matt Riedemann proposed openstack/nova master: De-cruftify the finish_resize methods https://review.openstack.org/635349
21:59:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Delete the obj_as_admin context manager https://review.openstack.org/635351
21:59:10 openstackgerrit Matt Riedemann proposed openstack/nova master: neutron: make migrate_instance_finish call setup_instance_network_on_host https://review.openstack.org/635343
21:59:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Temporarily mutate migration object in finish_revert_resize https://review.openstack.org/641137
21:59:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Use errors_out_migration decorator on finish_resize https://review.openstack.org/641138
22:05:45 mriedem dansmith: you might want to gander at https://bugs.launchpad.net/nova/+bug/1818239
22:05:46 openstack Launchpad bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged]
22:18:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix WeighedHost logging regression https://review.openstack.org/641143
22:18:50 mriedem super easy regression fix that i've now seen in 2 reported bugs ^
22:29:45 mriedem someone want to send the bw provider microversion change to it's watery grave? https://review.openstack.org/#/c/636360/
22:30:16 dansmith mriedem: I think I give up
22:30:46 mriedem on that build failure weigher? heh i know
22:30:55 mriedem "this seems bad if you have build failures...."
22:31:29 mriedem coreycb: maybe you and/or jamespage want to talk with us about bug 1818239
22:31:30 openstack bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged] https://launchpad.net/bugs/1818239
22:31:34 dansmith it also seems to assume that you can deploy with the completely standard config and expect everything to be fine, regardless of size or the bits of config you want to tweak
22:31:48 dansmith totally cool with charms defaulting it off
22:32:05 dansmith I tried to make the rationale for the default weight completely sane based on other default weighers and such
22:32:29 dansmith but I dunno what else to do, other than engineer the periodic de-de-prioritizing in the compute manager we discussed
22:35:10 dansmith the latter of course will demand some config option to allow tweaking the bleed rate
22:35:12 openstackgerrit Chris Friesen proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131
22:35:20 mriedem i tried to summarize https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1818239/comments/16
22:35:21 openstack Launchpad bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged]
22:35:57 openstackgerrit Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller. https://review.openstack.org/624229
22:35:57 openstackgerrit Michael Still proposed openstack/nova master: Move DHCP releasing to privsep. https://review.openstack.org/624230
22:35:58 openstackgerrit Michael Still proposed openstack/nova master: Convert additional IP management calls to privsep. https://review.openstack.org/624231
22:35:58 openstackgerrit Michael Still proposed openstack/nova master: Move route management to privsep. https://review.openstack.org/624232
22:35:59 openstackgerrit Michael Still proposed openstack/nova master: Move additional IP address management to privsep. https://review.openstack.org/624591
22:35:59 openstackgerrit Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592
22:36:00 openstackgerrit Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593
22:36:00 openstackgerrit Michael Still proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594
22:36:01 openstackgerrit Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
22:36:01 openstackgerrit Michael Still proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432
22:36:02 openstackgerrit Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433
22:36:02 openstackgerrit Michael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434
22:36:03 openstackgerrit Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
22:36:03 openstackgerrit Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
22:36:04 openstackgerrit Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508
22:36:04 openstackgerrit Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280
22:36:05 openstackgerrit Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281
22:36:05 openstackgerrit Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282
22:36:08 dansmith mriedem: ack thanks
22:37:01 mriedem no one puts mikal in a corner
22:39:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131
22:40:22 cfriesen mriedem: gah...thanks for the fixup
22:58:41 efried Do we allow backports of fixes to client libs, and corresponding requirements bumps in nova??
22:59:52 mriedem yes on the former, no on the latter
23:00:21 efried swhat I thought, thanks.
23:00:35 efried mriedem: fyi https://review.openstack.org/#/c/640879/2/nova/virt/ironic/client_wrapper.py@106
23:01:39 efried mriedem: I guess deployers wanting the bug fix can pull in the updated client lib version, even though it exceeds upper constraints for that release?
23:01:52 efried or do we bump upper constraints for the release? /me confused.
23:02:05 mriedem we can bump upper-constraints in stalbe

Earlier   Later