| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-05 | |||
| 13:01:54 | sean-k-mooney | i can double check if we prevented that when we added direct_physical but i doubt it as it would have been a breaking api change | |
| 13:02:20 | gibi | sean-k-mooney: OK. in this case the first boot will get the whole PF, and the second such boot will fail the pci claim as there is no pci device left | |
| 13:02:29 | sean-k-mooney | yep | |
| 13:03:06 | sean-k-mooney | so it wont break anything but it would be nice to tell placment that the rest of the inventory is reserved/unsuable | |
| 13:03:10 | gibi | sean-k-mooney: so the problem is that placement doesn't track PF inventory to signal that the PF is consumed | |
| 13:03:22 | sean-k-mooney | basically yes | |
| 13:03:46 | sean-k-mooney | ideally we would be asing for two things. 1 pf/vf resouce + x bandwith | |
| 13:04:21 | sean-k-mooney | since we dont track PFs/VFs in placment yet we only ask for the bandwith | |
| 13:04:25 | gibi | sean-k-mooney: OK. as far as I understand the admin needs to configur such PF specially (whitelsit the PF but not the VFs) so we can also ask the admin not to configure bandwidth for that PF as that PF will be consumed in a single piece | |
| 13:04:35 | sean-k-mooney | so this will get fix in train hopefully | |
| 13:05:24 | sean-k-mooney | ya they have to expclity whitelist the pf and that would be resonable intally at least | |
| 13:05:28 | gibi | sean-k-mooney: It will be fun moving the VF inventory to placement | |
| 13:05:45 | gibi | sean-k-mooney: OK then we will handle this case in the documentation for Stein | |
| 13:05:57 | sean-k-mooney | the downside is we wont be able to sue the min bandwith request to select pf with at least X bandwith | |
| 13:05:58 | artom | ~o~ | |
| 13:06:24 | sean-k-mooney | e.g. ask for a 10G pf vs a 1G or 40G or 100G pf | |
| 13:06:52 | sean-k-mooney | gibi: and yes moving vfs/pfs to placement will be "fun" | |
| 13:07:34 | gibi | sean-k-mooney: yeah in a mixed environment it will be a limitation | |
| 13:07:55 | sean-k-mooney | its not somthing they could do before so i think its fine | |
| 13:08:12 | gibi | yeah I feel the same | |
| 13:08:13 | sean-k-mooney | it would just be a nice bonus if we could enable that usecase in the future | |
| 13:08:43 | sean-k-mooney | but to do that we need to get a few other things in place | |
| 13:08:57 | mdbooth | lyarwood: You there? Still looking at your cinder tempest failure. | |
| 13:09:12 | mdbooth | It's pretty weird. Have you had any insight? | |
| 13:09:20 | gibi | sean-k-mooney: totally agree | |
| 13:10:58 | sean-k-mooney | anyway i responded to your replys on patchset 39 and im now going through patchset 40 but honestly i think future change can likely be done in followup patches as part fo train. | |
| 13:13:23 | gibi | sean-k-mooney: and now I've responded in your responses in PS 39 :) | |
| 13:19:21 | lyarwood | mdbooth: no, are you looking at the latest failures? | |
| 13:19:30 | lyarwood | mdbooth: I was waiting for CI to report back before taking another look | |
| 13:20:48 | mdbooth | lyarwood: I've been looking into the failures from yesterday or the day before? | |
| 13:21:13 | mdbooth | I'm currently suspecting a cinder race, tbh. | |
| 13:21:21 | mdbooth | Rather than a tempest race, that is. | |
| 13:23:02 | lyarwood | mdbooth: ack, I updated both changes this morning and they appear to be failing in the check queue. Once they report back I'll take a look to see if it's the same issue. | |
| 13:26:30 | mdbooth | lyarwood: I'll have a look at the new ones. I know what I'm looking for, now. | |
| 13:27:52 | mdbooth | lyarwood: In the one I've been looking into, we can see in both the tempest and c-api logs that cinder returns a 404 for the volume, then fails to delete the type because it still has a volume. | |
| 13:28:54 | mdbooth | I couldn't see any other volume in the logs, so my guess is that the cinder REST api is returning a 404 before updating whatever triggers the failure to delete the type. | |
| 13:29:11 | sean-k-mooney | gibi: oh i didnt know rodolfo had revied the minium bandwith work for ovs. it was merged in the past and then reverted as we found edgecase that did not work. i guess he has figured out how to work aroudn them good to know | |
| 13:29:27 | mdbooth | We can see in the c-vol logs that the volume deletion actually completes *after* the type deletion starts, so c-api is returning a 404 *before* the deletion completes. | |
| 13:29:32 | bauzas | gibi: ack, will review it later | |
| 13:34:45 | gibi | sean-k-mooney: yeah it is good that rodolfo managed to do that | |
| 13:34:47 | gibi | bauzas: thanks | |
| 13:35:51 | sean-k-mooney | it looks like tunneled netowrk support is still pendign but that was one of the things that did not work last time that ended up with the feature beign reverted | |
| 13:36:50 | sean-k-mooney | anyway having it work for flat and vlan networks i still a good step forward | |
| 13:38:02 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 13:40:40 | mdbooth | lyarwood: It has failed again. Investigating. | |
| 13:43:43 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | |
| 13:43:56 | lyarwood | mdbooth: ack thanks | |
| 13:47:41 | mdbooth | It seems to be the py3 version which fails | |
| 14:08:37 | cdent | mriedem: the openstack-dev archives are still there, but not longer reachable by the usual paths: http://lists.openstack.org/pipermail/openstack-dev/ | |
| 14:10:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle templated cell mappings in nova-status https://review.openstack.org/641021 | |
| 14:10:03 | mriedem | lyarwood: try throwing that as a dependency in your tripleo change ^; dansmith fyi ^ | |
| 14:10:11 | mriedem | cdent: google failed me | |
| 14:10:28 | cdent | aye, it often does | |
| 14:13:26 | lyarwood | mriedem: ack thanks | |
| 14:18:20 | yonglihe | mriedem: what can i do for https://review.openstack.org/#/c/621476/39 | |
| 14:27:04 | dansmith | mriedem: ah, dangit | |
| 14:27:26 | openstackgerrit | Tim Rozet proposed openstack/nova stable/rocky: Fixes race condition with privsep utime https://review.openstack.org/641023 | |
| 14:29:22 | HD|Laptop | hey | |
| 14:29:42 | HD|Laptop | yesterday I asked if it was possible for nova to use cinder as backing storage for images/instances... now I had an idea | |
| 14:29:58 | HD|Laptop | can I just go ahead and mount /var/lib/nova/instances as a NFS directory? | |
| 14:30:08 | HD|Laptop | that would serve the same purpose | |
| 14:30:45 | HD|Laptop | even better would be if I could share instances/_base, but I guess that this could lead to locking issues if e.g. two compute nodes try to convert the same vmdk image to qcow2? | |
| 14:30:58 | openstackgerrit | Merged openstack/nova master: libvirt: Omit needless check on 'CONF.serial_console' https://review.openstack.org/637578 | |
| 14:39:10 | mriedem | HD|Laptop: yes you can put the instances_path config on shared storage, many people do | |
| 14:39:15 | mriedem | note that has it's own perils, like https://review.openstack.org/641023 | |
| 14:39:41 | mriedem | and https://review.openstack.org/#/c/633042/ | |
| 14:40:07 | mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#workarounds.ensure_libvirt_rbd_instance_dir_cleanup | |
| 14:40:55 | efried | mriedem: Review the "stop using PlacementDirect" changes with whitespace ignores on in gerrit | |
| 14:41:01 | efried | mriedem, cdent, sean-k-mooney: but let me rebase it first... | |
| 14:41:20 | mriedem | what if i don't want to? | |
| 14:41:59 | efried | mriedem: Then it's a bigger review that will make you sad | |
| 14:42:15 | efried | oh, what if you don't want to wait until I've rebased? Sure, then you can +2 it now, I don't mind. | |
| 14:42:28 | mriedem | strike 2 | |
| 14:45:47 | openstackgerrit | Eric Fried proposed openstack/nova master: Stop using PlacementDirect https://review.openstack.org/640887 | |
| 14:45:55 | efried | cdent, mriedem, sean-k-mooney: ^ | |
| 14:46:06 | cdent | one moment please caller | |
| 14:46:23 | HD|Laptop | mriedem: thanks. I'll just give every instance its own nfs base directory then, that should keep me safe from that shit | |
| 14:46:56 | openstackgerrit | Eric Fried proposed openstack/nova master: Stop using PlacementDirect https://review.openstack.org/640887 | |
| 14:47:09 | efried | ^ fix whitespace | |
| 14:48:37 | efried | cdent, sean-k-mooney: for a change, the 1..3 diff is actually empty, because the patch removes the whole class that was conflicting. | |
| 14:49:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | |
| 14:49:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | |
| 14:49:51 | gibi | bauzas: I've fixed up your comments ^^ | |
| 14:50:16 | sean-k-mooney | efried: right cdent change modified one line in schdulerReportClientTEstBase and you are deleteing it out right | |
| 14:52:35 | cdent | efried: other than me continuing to think it is keen and worth doing soon than later, you after anything in particular? | |
| 14:52:39 | efried | sean-k-mooney: three or four lines, but yeah. | |
| 14:53:31 | efried | cdent: no, just letting you know it needed a rebase and that's done now. I agree there's no reason to wait for Train. And I don't want reviewers intimidated by it because it's really like a 20LOC change. | |
| 14:53:47 | gibi | stephenfin: you were +2 before on https://review.openstack.org/623543 bauzas put +2 on the previous PS. Can you meet on PS 41 and combine your votes? :) | |
| 14:54:45 | cdent | efried: I suppose if you wanted to make it really obvious you could do it in two steps: extracted the indented chunks to their own methods in 1, remove placement direct in 2, but personally I think that's overkill, the diff is readable enough as is | |
| 14:55:06 | bauzas | gibi: I was about +2ing it | |
| 14:55:36 | efried | cdent: Yeah, when I was developing the change, I started off by creating a null _interceptor context manager. I didn't want to go to the effort of removing and outdenting if I wasn't going to be able to get it to work. | |
| 14:56:45 | lyarwood | mriedem: your nova-status cell_mappings change works on a local env btw | |
| 14:57:23 | lyarwood | mriedem: thanks for turning that around so quickly! | |
| 14:57:37 | mriedem | anything for you lee | |
| 15:03:01 | gibi | bauzas: thanks a lot | |
| 15:06:49 | mriedem | mdbooth: fyi that https://review.openstack.org/#/c/625741/ just merged on master | |
| 15:06:53 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 15:07:17 | mdbooth | mriedem: Oh, dear. | |
| 15:07:24 | mdbooth | mriedem: Didn't spot that was a backport. | |
| 15:07:35 | sean-k-mooney | efried: i assume you rebased the patch due to a merge confilt with cdents patch? | |